Hey all, it appears that we’re not ready to do speculative branches yet, so
I’ll proceed with the next chunk of Stellar separation work in my private
branch, currently in https://github.com/mattf-horton/metron/tree/stellar-mod4
There is of course nothing “private” about it; anyone is most
And another way suggested by Jon’s statement, is to not squash the commit, but
leave at least one of each committer’s contributions intact. That might not be
too hard to add to the prepare-commit script, it’s just an invocation of
interactive rebase/squash.
On 7/5/17, 10:32 AM, "Matt Foley"
Yeah, this is part of why we need the guide
On July 5, 2017 at 09:23:03, zeo...@gmail.com (zeo...@gmail.com) wrote:
That all sounds pretty reasonable to me. My biggest concern would be
attribution during step 5 - we would need to make sure it isn't squash
merged like we typically do (assuming
Jon, good point. I was thinking we would just use the commit message to share
attribution.
It would be nicer to do something that would be picked up by github’s commit
attribution, but unfortunately there is only one “author” field in a git commit
metadata. There are discussions online
quest for Consensus Approval] dev branch for Stellar additional
work
Just want to say, we will need updated versions of the commuter’s guide for
doing commits and reviews to branches like this.
The current scripts we use will need to be updated ( as we go ), the we should
at least have a
That all sounds pretty reasonable to me. My biggest concern would be
attribution during step 5 - we would need to make sure it isn't squash
merged like we typically do (assuming we do properly squash merge into
the speculative
branch). Not a big issue though, I guess, just need to make sure it
Just want to say, we will need updated versions of the commuter’s guide for
doing commits and reviews to branches like this.
The current scripts we use will need to be updated ( as we go ), the we
should at least have a plan to provide these guides before the first pr.
On July 5, 2017 at
Now that METRON-877 is in, I would like to proceed with Steps 3-6 of the
remaining work to separate out Stellar functionality as an independent module.
A couple people have suggested that this further development should be done in
a Metron “dev branch”, where:
a) changes are more visible than
