Re: Checkstyle - have we run it?

2018-01-17 Thread Justin Leet
I would expect so. Honestly, it's probably more just getting PRs out on it, and adjusting if it ends up causing problems. Given that we just did a release, this is probably the best time to at least do a couple modules, see if any problems are caused, and clean it up afterwards. On Wed, Jan 17,

Re: Checkstyle - have we run it?

2018-01-17 Thread Otto Fowler
Thanks, I have check style up and integrated, and I have been running it on *new* files etc. But now when I work in existing, I obviously see the issues. I *think* in the end module by module is the only feasible way is it not? On January 17, 2018 at 12:15:33, Justin Leet

Re: Checkstyle - have we run it?

2018-01-17 Thread Justin Leet
It exists, we have a style that can be imported and setup in IntelliJ with the Checkstyle plugin Reformatting can also be done in IntelliJ (which will help a lot, but not all issues). This can be done on a file mask basis (e.g. just do "*.java" files to avoid reformatting other things), and could

Checkstyle - have we run it?

2018-01-17 Thread Otto Fowler
Where are we with the check style integration? How are we handling check style in existing modules? I seem to remember talk of a script or something to reformat? It would be nice to get some of the warnings out of the builds, how should we go about it? ottO