Github user cestella commented on the issue:
https://github.com/apache/metron/pull/652
@jjmeyer0 I don't have a problem with it, but can you cite any previous
work (i.e. another language) that works that way? The question I would have
is, should each arg be exploded as separate args
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/641
I just want to chime in and say thanks for the contribution @jjmeyer0 !. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/654
+1 by inspection. This is a big miss when I added writer disabling, so
thanks for the cleanup @merrimanr . As a follow-up, we might consider turning
acking on by default in the indexing topology
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/620#discussion_r127928099
--- Diff:
metron-interface/metron-alerts/src/app/service/elasticsearch-localstorage-impl.ts
---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the
Github user jjmeyer0 commented on the issue:
https://github.com/apache/metron/pull/652
@cestella I will create a Jira for it and reference the above link. I agree
that this ticket isn't the best place to implement this.
---
If your project is set up for it, you can reply to this
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/656
METRON-1050 Improve Docs of 'profile.period.duration'
It is a common mistake for new user's of the Profiler, to alter the
Profiler's `profiler.period.duration` property, but not alter the
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/656
@MohanDV Please take a look and let me know what you think. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/653#discussion_r128009919
--- Diff: metron-analytics/metron-profiler/README.md ---
@@ -69,7 +142,7 @@ More information on configuring and using the client can
be found
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/599
I saw this same test failure yesterday on another PR. I opened a
[METRON-1048](https://issues.apache.org/jira/browse/METRON-1048) for it.
---
If your project is set up for it, you can reply
GitHub user nickwallen reopened a pull request:
https://github.com/apache/metron/pull/656
METRON-1050 Improve Docs of 'profile.period.duration'
It is a common mistake for new user's of the Profiler, to alter the
Profiler's `profiler.period.duration` property, but not alter the
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/656
Running into METRON-1048
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user nickwallen closed the pull request at:
https://github.com/apache/metron/pull/656
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dlyle65535 commented on the issue:
https://github.com/apache/metron/pull/481
@mattf-horton - sorry about the hurry up and wait. I'll run this up
tomorrow. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/635#discussion_r128051835
--- Diff:
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchIndexingIntegrationTest.java
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/657
Another issue with this test that complicates things a bit more is that
these are static calls which require more than vanilla Mockito. @jjmeyer0 might
be right here. Do we really need these tests?
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/657
One problem I see with this test is that it sets up the mock in a
BeforeClass annotated init. That's generally frowned upon for mock tests that
use verify() because expectations for the number of
Github user jjmeyer0 commented on the issue:
https://github.com/apache/metron/pull/657
@nickwallen out of curiosity, what do you think about just deleting these
tests? I think the logging they are testing is great, but I don't think these
are really needed.
---
If your project is
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/657
Found this useful for duplicating the problem locally.
```
# build everything depended on by metron-parsers
cd metron
mvn clean install -pl metron-platform/metron-parsers -am
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/656#discussion_r128136238
--- Diff: metron-analytics/metron-profiler/README.md ---
@@ -277,25 +282,103 @@ The values can be changed on disk and then the
Profiler topology must be
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/614
Any other additions, comments, questions, concerns on this? I will close
this out tomorrow unless I hear otherwise.
---
If your project is set up for it, you can reply to this email and have your
20 matches
Mail list logo
