Windows full-dev

[Laurens Vets]

Hey list,

Has anyone gotten full-dev automatically set up on Windows by any chance 
or are we all using Linux & macOS?

[GitHub] metron issue #944: METRON-1463: Adjust the groupings and shuffles in enrichm...

[nickwallen]

Github user nickwallen commented on the issue:

https://github.com/apache/metron/pull/944
  
+1 These corrections should greatly improve performance. 


---

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

[mmiklavc]

Github user mmiklavc commented on the issue:

https://github.com/apache/metron/pull/853
  
@merrimanr this looks much better. I'm +1 via inspection pending any 
further feedback from @ottobackwards.


---

[GitHub] metron pull request #853: METRON-1337: List of facets should not be hardcode...

[mmiklavc]

Github user mmiklavc commented on a diff in the pull request:

https://github.com/apache/metron/pull/853#discussion_r171015228
  
--- Diff: 
metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/search/SearchRequest.java
 ---
@@ -101,16 +99,16 @@ public void setSort(List sort) {
 this.sort = sort;
   }
 
-  public Optional getFields() {
-return fields == null || fields.size() == 0 ? Optional.empty() : 
Optional.of(fields);
+  public List getFields() {
+return fields;
   }
 
   public void setFields(List fields) {
 this.fields = fields;
   }
 
-  public Optional getFacetFields() {
-return facetFields == null || facetFields.size() == 0 ? 
Optional.empty() : Optional.of(facetFields);
+  public List getFacetFields() {
+return facetFields;
--- End diff --

Ok, sounds reasonable


---

[GitHub] metron pull request #938: METRON-1457: Move ASF links to main page in the Me...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/metron/pull/938


---

[GitHub] metron issue #936: METRON-1450:Added documentation for random access and bat...

[JonZeolla]

Github user JonZeolla commented on the issue:

https://github.com/apache/metron/pull/936
  
The PR title here doesn't match the 
[JIRA](https://issues.apache.org/jira/projects/METRON/issues/METRON-1450?filter=allopenissues)
 but as long as we account for that during merging, I'm a +1 on this.  Thanks 
@MohanDV


---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

[anandsubbu]

Github user anandsubbu commented on the issue:

https://github.com/apache/metron/pull/938
  
Thanks all.


---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

[mmiklavc]

Github user mmiklavc commented on the issue:

https://github.com/apache/metron/pull/938
  
+1 from me as well, thanks @anandsubbu!


---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

[cestella]

Github user cestella commented on the issue:

https://github.com/apache/metron/pull/938
  
+1 as well, looks great



---

[GitHub] metron issue #940: METRON-1460: Create a complementary non-split-join enrich...

[nickwallen]

Github user nickwallen commented on the issue:

https://github.com/apache/metron/pull/940
  
I'd hold on merging this until we can get this tested at some decent scale. 
 Unless it already has been?  Otherwise, I don't see a need to merge this until 
we know it actually addresses a problem.


---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

[justinleet]

Github user justinleet commented on the issue:

https://github.com/apache/metron/pull/938
  
+1, pending Travis. I think any look complaints after this are follow-on, 
given that this addresses the main issues we wanted and has the updated mark.


---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

[anandsubbu]

Github user anandsubbu commented on the issue:

https://github.com/apache/metron/pull/938
  
Roger that. Here's the new look. Let me know if this looks ok @justinleet 
and @cestella .


![image](https://user-images.githubusercontent.com/20395490/36736657-323cff0a-1bff-11e8-8d13-b47a47193fa4.png)



---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

[justinleet]

Github user justinleet commented on the issue:

https://github.com/apache/metron/pull/938
  
Yeah, I thought that was more third party thing.  Admittedly, this seems at 
(high) risk of becoming a bikeshed.  I'd probably rather just use the main mark 
(https://www.apache.org/foundation/press/kit/asf_logo.png), even if it's 
suboptimal looking but noncontroversial in terms of branding, and just fix it 
later if we want.


---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

[cestella]

Github user cestella commented on the issue:

https://github.com/apache/metron/pull/938
  
Where is that powered by apache logo from?  Are we sure it doesn't mean 
that the apache web server serves it up?


---

[GitHub] metron pull request #944: METRON-1463: Adjust the groupings and shuffles in ...

[cestella]

GitHub user cestella opened a pull request:

https://github.com/apache/metron/pull/944

METRON-1463: Adjust the groupings and shuffles in enrichment to be more 
efficient

## Contributor Comments
Currently there are some deficiencies in our grouping approach in the 
enrichment topology:

* We have field grouping by key in places where we need LOCAL_OR_SHUFFLE 
groupings
* We have shuffle groupings in places where we need LOCAL_OR_SHUFFLE 
groupings
* We have field groupings by key in places where we need field grouping by 
message (specifically in the connections from the splitter to the enrichments).
  * Field grouping by key, as we had before, ensured that we had fewer 
cache hits as opposed to field grouping by message.

To test this, just run things up in full-dev and ensure that data continues 
to flow.


## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
  ```
  mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
  ```

- [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cestella/incubator-metron 
better_grouping_in_splitjoin

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/944.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #944


commit dd8821af912071e357c42c852361292c7c2c655c
Author: cstella 
Date:   2018-02-27T14:28:00Z

Adjusted groupings to be local or shuffle




---

[GitHub] metron issue #936: METRON-1450:Added documentation for random access and bat...

[nickwallen]

Github user nickwallen commented on the issue:

https://github.com/apache/metron/pull/936
  
+1 Thanks for correcting this @MohanDV.  This looks good.  

Let's give @JonZeolla a chance to respond before we merge this.


---

[GitHub] metron issue #936: METRON-1450:Added documentation for random access and bat...

[MohanDV]

Github user MohanDV commented on the issue:

https://github.com/apache/metron/pull/936
  
Bump. Can anyone offer a binding +1 ? I Would like to get this in.


---