Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/870
How can we test this?
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/874#discussion_r157605768
--- Diff: build_utils/release-utils/validate-jira-for-release ---
@@ -0,0 +1,197 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/874
+1 worked great
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/873
The last commit adds in the ability to tag timings, and to filter on those
tags in the shell when calling %timing.
LambdaExpressions are now timed as well. When Lambdas are used with
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/873
If there are any ideas on improving the tags implementation I would love to
here them
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/873#discussion_r157730269
--- Diff: metron-stellar/stellar-common/README.md ---
@@ -1352,6 +1352,61 @@ IS_EMAIL
[Stellar]>>>
```
+###
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/873#discussion_r157731077
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/common/timing/StackWatchTest.java
---
@@ -0,0 +1,168
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/876
METRON-1374 Script Metron Release Validation
This PR introduces a script that automats the documented process for
validation of metron releases.
It will:
Download the files
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/876
I thought the same thing once I saw your script. I will definitely do
that, I just wanted to get some eyes on it before I started mucking with it.
Would you mind if it were a follow on?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/876
I was thinking about a shared config file when you land the others...
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
It did not seem appropriate to me for this to be a stellar function, and
%magic is the other way to execute things from the shell. At the time at least.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
In other words, a stellar function that called the stellar compilation
stuff, did not seem correct.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/876
@nickwallen https://issues.apache.org/jira/browse/METRON-1376
---
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/877
METRON-1376 metron-rc-check script should have named params
This PR adds named parameter support to the metron-rc-check script
```bash
-> % bash ./metron-rc-check
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/877
@nickwallen
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
Do you feel strongly that this should be a Function? @cestella ? I'm not
opposed to changing it if you are. I would like to here some more feedback
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/864
Ran up in full dev, works as described.
Nice Job.
+1
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/875
Ran up through
```bash
mvn clean && time mvn -q -T 2C -DskipTests install && time mvn -q -T 2C
surefire:test@unit-tests && time mvn -q surefire:test@integratio
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
Ok, I'll change it. Feels a little crossing the streams, but we'll see
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
I don't think it should be in management necessarily though.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
@nickwallen I have refactored to a function.
see updated PR description
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/881
+1, although this makes me wonder again about apache lic. in MD
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/338
Re-reading this, I think it is dead, unless there is an update triggered by
this.
I *think* I have the resolution to the update issue.
Post `777` and parser extensions
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/883
+1
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r158588194
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationProvider.java
---
@@ -0,0 +1,144
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r158588342
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationProvider.java
---
@@ -0,0 +1,144
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r158588357
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationProvider.java
---
@@ -0,0 +1,144
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r158588377
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationProvider.java
---
@@ -0,0 +1,144
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r158588382
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationProvider.java
---
@@ -0,0 +1,144
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r158588419
--- Diff: metron-platform/metron-management/README.md ---
@@ -276,6 +278,13 @@ The functions are split roughly into a few sections
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r158588519
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/validation/StellarConfiguredStatementContainer.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r158588556
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/validation/StellarZookeeperBasedValidator.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r158588686
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/validation/StellarZookeeperBasedValidator.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r158588712
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/validation/annotations/StellarExpressionMap.java
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
Refactored based on feedback for some things, based on making what I was
trying for more correct in others.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/526
What is the status of this pr? Can it be closed? I has no updates since
August and it is conflicted.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/879
I think the need is to 'pre-create' complex objects, and re-use them across
multiple stellar rule executions, with the bloom-filter being the example.
Is that close?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/868
I'll run this up.
I am concerned that there is no documentation about having to maintain this
as well as the rpms now. Also, you should change the scripts we have the
build the rp
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/868
I don't know if there is such documentation. Right now, it is understood
that the rpms are nec. for full dev and ambari.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/868
Works as describe, do not have a machine to test with.
Can we have some disclaimer about this not being supported until the follow
ons are complete? Until there is full dev equiv. that is.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/868
+1, thanks @nickwallen
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/868
we can update the scripts when it is 'official'
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/869
Can we have a section on `How dow I build everything with docker` with
instructions for the ansible docker container?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/883
I'm +1
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/869
The ansible-docker image can be used for this.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/869
https://github.com/apache/metron/tree/master/metron-deployment/packaging/docker/ansible-docker
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/869
+1 Thanks
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/884
This is quite a bit to go over can I trade you a similarly large review
task?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/873
This has been submitted to Commons Lang :
https://github.com/apache/commons-lang/pull/311
The version there is refactored and also java 7 comparable ( so I had to
lose Optional and Lambdas
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/884#discussion_r159919435
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/shell/DefaultStellarShellExecutor.java
---
@@ -0,0 +1,413
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/884#discussion_r159920062
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/shell/StellarExecutionListeners.java
---
@@ -0,0 +1,51
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/884#discussion_r159920465
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/shell/StellarResult.java
---
@@ -0,0 +1,185
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/884#discussion_r159921114
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/shell/StellarResult.java
---
@@ -0,0 +1,185
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/884#discussion_r159922114
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/shell/StellarShellExecutor.java
---
@@ -0,0 +1,79
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/884
I would not, and am not -1 a pr for non-technical reasons. I'm not ready
to +1 this, since I have outstanding comments and actually have to try it out
beyond scanning the diffs.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/884
When I say I would like a readme or outline document, here is where I'm
coming from: As someone who does do stellar and stellar shell work, I would
like to understand the high level vi
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r160001387
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/validation/StellarZookeeperBasedValidator.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/884#discussion_r160026564
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/shell/StellarExecutionListeners.java
---
@@ -0,0 +1,51
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r160026668
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/validation/StellarZookeeperBasedValidator.java
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/687
Reviewer Note: Would a default method on the interface be better for
update()?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/884
I don't thin a full design doc is what we need, just an overview. It
should be in the top level of common.shell.
..
Stellar can be hosted in two shell like environ
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r160042250
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/validation/StellarZookeeperBasedValidator.java
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/884
Is there a 'supported' or tested version of zeppelin?
I have 0.7.3 installed locally.
I am getting exceptions starting the stellar i
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/884
Another question:
Even through it is consistent with the other interpreters, I am not sure
that we should not have Apache Stellar, or Apache Metron Stellar and not just
stellar as the name
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/831
So, all of these parameters with the more generic names will be uniformly
applicable to all possible backends?
We will never have more than one of a given type at any time? ( s3/hdfs
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/873
Timing is integrated into the stellar execution, so it is taken before we
execute named functions and lambdas.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/873
see the changes to LambdaExpression and StellarCompiler
---
GitHub user ottobackwards reopened a pull request:
https://github.com/apache/metron/pull/865
METRON-1212 The bundle System and Maven Plugin (Feature Branch)
This PR contains the Bundle system and Maven Plugin.
The bundle system and the plugin are adapted from the Apache
Github user ottobackwards closed the pull request at:
https://github.com/apache/metron/pull/865
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/884
1. When I type something in the notebook and hit run. At least I think
that is when I get the error. It may happen when selecting the interpreter for
the notebook.
2. Yes
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/884
I think creating the /interpreters/stellar/x.json creates the entry?
I just tried again, ( new mvn install , new site file ) and I checked the
interpreter log:
INFO [2018-01
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r160529767
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/validation/StellarZookeeperBasedValidator.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r160530273
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/validation/StellarZookeeperBasedValidator.java
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/884
Can you run the check style against the interpreter class?
Also, do we want to use `@Override`?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/884
@nickwallen I'm not sure what to do to get this going. The jar is in
maven. I tried to path directly to it as well. I can attach my site and
interpreter json files, and screensh
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/884
I'm going to try a clean zeppelin install I guess.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/884
ok, starting over
1. First difference, is on first start ( new install ) the stellar
interpreter / group is already created in zeppelin when I go to configure the
stellar interpreter
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/884
Is the plan to deploy the jar file in the interpreter directory like the
other interpreters?
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r161239454
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/validation/StellarZookeeperBasedValidator.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/888#discussion_r161240092
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_master.py
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/865
__**BUMP**__
@nickwallen , @mmiklavc , @cestella : leaving a breadcrumb so you can
follow the PR to here. This is now a feature branch and is broken up as you
requested, so it is the
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/884
Do we have jiras for the next steps on this yet? I would be good if we
recored our intent, and who knows, maybe someone will want to work on it.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/884
This is really good work @nickwallen. I am +1 on this, but would like to
see jiras on the next steps entered if possible as a side note.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/879
I'm not getting in front of the train on this.
I am neutral on this other than my comments to help the conversation and
attempt to focus things.
I don't know how to en
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/879
+0
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/888#discussion_r161746734
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_master.py
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/858
@merrimanr I am +1 on getting this down to the feature branch and moving on.
Due to the way the feature branch works, I think it is OK to do so if
@cestella doesn't get back in time.
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/899#discussion_r161817448
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java
---
@@ -220,4 +219,156 @@ public
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/899#discussion_r161821411
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java
---
@@ -220,4 +219,156 @@ public
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/785
well then.
In a world where 777 didn't exist I would be a +1.
In world where 777 does exist, i'm a +0, since I feel the effort would have
been better spent reviewing 777,
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/899
This tests fails, I think something is wrong.
```java
@Test
public void
boyerMoore_calculates_plurality_from_list_of_mixed_objects_o() throws Exception
{
List items
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/899#discussion_r161919259
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java
---
@@ -220,4 +219,156 @@ public
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/899
Just in case: Note that that test is modified from your test ( _o )
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/888#discussion_r162029895
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_master.py
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/899#discussion_r162134157
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java
---
@@ -220,4 +219,156 @@ public
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/899
@Test
public void boyerMoore_calculates_plurality_from_list_of_values_o()
throws Exception {
List items = Arrays.asList(1, 1, 1,1, 2,2,3,3,4,4,4);
BoyerMooreState state
Github user ottobackwards commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/5
I believe the linking *is* working. Maybe it is just lagged.
As far as Jira rights, I'm looking into it, but I cannot as of this moment
execute that
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/687
I just removed the conflicts and changed StellarAssignment to account for
this
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/687
The question for me @cestella is the resolvers, and the consequences of
having them support updating etc. I left it so that they *don't* by default
because I didn't understa
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/687
@cestella also: := is in the shell not the language. The mechanics of
what is LANG and what is MACHINE is part of the issue.
---
201 - 300 of 1314 matches
Mail list logo
