[GitHub] metron pull request #961: METRON-1487 Define Performance Benchmarks for Enri...

2018-03-14 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/961#discussion_r174654407 --- Diff: metron-platform/metron-enrichment/Performance.md --- @@ -0,0 +1,527 @@ + + +# Enrichment Performance + +This guide defines a

[GitHub] metron pull request #961: METRON-1487 Define Performance Benchmarks for Enri...

2018-03-14 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/961#discussion_r174652376 --- Diff: metron-platform/Performance-tuning-guide.md --- @@ -422,10 +422,12 @@ modifying the options outlined above, increasing the poll timeout, or both

[GitHub] metron pull request #961: METRON-1487 Define Performance Benchmarks for Enri...

2018-03-14 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/961#discussion_r174653285 --- Diff: metron-platform/metron-enrichment/Performance.md --- @@ -0,0 +1,527 @@ + + +# Enrichment Performance + +This guide defines a

[GitHub] metron pull request #961: METRON-1487 Define Performance Benchmarks for Enri...

2018-03-14 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/961#discussion_r174653386 --- Diff: metron-platform/metron-enrichment/Performance.md --- @@ -0,0 +1,527 @@ + + +# Enrichment Performance + +This guide defines a

[GitHub] metron pull request #961: METRON-1487 Define Performance Benchmarks for Enri...

2018-03-14 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/961#discussion_r174653589 --- Diff: metron-platform/metron-enrichment/Performance.md --- @@ -0,0 +1,527 @@ + + +# Enrichment Performance + +This guide defines a

[GitHub] metron pull request #961: METRON-1487 Define Performance Benchmarks for Enri...

2018-03-14 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/961#discussion_r174653490 --- Diff: metron-platform/metron-enrichment/Performance.md --- @@ -0,0 +1,527 @@ + + +# Enrichment Performance + +This guide defines a

[GitHub] metron pull request #961: METRON-1487 Define Performance Benchmarks for Enri...

2018-03-14 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/961#discussion_r174652892 --- Diff: metron-platform/metron-enrichment/Performance.md --- @@ -0,0 +1,527 @@ + + +# Enrichment Performance + +This guide defines a

[GitHub] metron-bro-plugin-kafka issue #6: METRON-1469: Kafka Plugin for Bro - Config...

2018-03-13 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/6 I'm +1 on this. @nickwallen anything outstanding on your end? ---

[GitHub] metron pull request #959: METRON-1485 Upgrade vagrant for dev environments

2018-03-09 Thread JonZeolla
GitHub user JonZeolla opened a pull request: https://github.com/apache/metron/pull/959 METRON-1485 Upgrade vagrant for dev environments ## Contributor Comments It looks like we are going to be forced into upgrading vagrant based on some HashiCorp deprecation activities. See

[GitHub] metron issue #948: METRON-1468: Add support for apache/metron-bro-plugin-kaf...

2018-03-06 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/948 I agree, updated the script and readme. ---

[GitHub] metron-bro-plugin-kafka issue #7: METRON-1324: Increment metron-bro-plugin-k...

2018-03-05 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/7 # Testing ## Build and install manually Some guideline commands to test: ``` mkdir tmp cd tmp git clone https://github.com/bro/bro cd bro git

[GitHub] metron pull request #948: METRON-1468: Add support for apache/metron-bro-plu...

2018-03-05 Thread JonZeolla
GitHub user JonZeolla opened a pull request: https://github.com/apache/metron/pull/948 METRON-1468: Add support for apache/metron-bro-plugin-kafka to prepare-commit ## Contributor Comments This updates the prepare-commit script to work with `apache/metron-bro-plugin-kafka

[GitHub] metron-bro-plugin-kafka issue #6: Configurable JSON timestamps and default a...

2018-03-05 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/6 It's a part of the `apache/metron` project (of which this is considered a component) and uses the open apache JIRA that I linked above. In order to accept PRs we need to h

[GitHub] metron-bro-plugin-kafka pull request #7: METRON-1324: Increment metron-bro-p...

2018-03-05 Thread JonZeolla
GitHub user JonZeolla opened a pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/7 METRON-1324: Increment metron-bro-plugin-kafka version We have some changes staged to upgrade the plugin, so we should increment the version. You can merge this pull request into

[GitHub] metron-bro-plugin-kafka issue #6: Configurable JSON timestamps and default a...

2018-03-05 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/6 This is really coming together. Is there a [JIRA](https://issues.apache.org/jira/browse/METRON-1325?filter=-5&jql=project%20%3D%20METRON%20AND%20resolution%20%3D%20Unreso

[GitHub] metron issue #936: METRON-1450:Added documentation for random access and bat...

2018-02-27 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/936 The PR title here doesn't match the [JIRA](https://issues.apache.org/jira/projects/METRON/issues/METRON-1450?filter=allopenissues) but as long as we account for that during merging, I'

[GitHub] metron-bro-plugin-kafka issue #6: Configurable JSON timestamps and default a...

2018-02-24 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/6 Okay great, thanks. I will add to my todo list this week to get this and #5 tested and in. Then we can look at merging #2 and maybe the bool option to send all logs. ---

[GitHub] metron-bro-plugin-kafka issue #6: Configurable JSON timestamps and default a...

2018-02-24 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/6 Would you mind removing the send all logs by default portion of this? I would love to get this reviewed and in but I feel like that approach could be problematic and is better

[GitHub] metron-bro-plugin-kafka issue #6: Configurable JSON timestamps and default a...

2018-02-24 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/6 Thanks @dcode I'll need to review this more specifically but I don't recall using any of your contributions for my other work. I modeled it after other plugins in t

[GitHub] metron issue #936: METRON-1450:Added documentation for random access and bat...

2018-02-16 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/936 I don't see a PR for METRON-1458, did you mean you opened a [JIRA](https://issues.apache.org/jira/projects/METRON/issues/METRON-1458)? In the JIRA for [METRON-1450](https://issues.apach

[GitHub] metron issue #936: METRON-1450:Added documentation for random access and bat...

2018-02-16 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/936 I'm specifically referring to [this](https://github.com/MohanDV/metron/blob/4cb99e7186c408159cb41b0e5e8761fdcbfe74d2/metron-platform/metron-indexing/README.md#indexing-architecture) which

[GitHub] metron issue #936: METRON-1450:Added documentation for random access and bat...

2018-02-14 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/936 Yes ---

[GitHub] metron issue #936: METRON-1450:Added documentation for random access and bat...

2018-02-13 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/936 Would you also mind updating the main README? ---

[GitHub] metron pull request #930: METRON-1318 updated MacOS instructions and explain...

2018-02-07 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/930#discussion_r166752581 --- Diff: metron-deployment/amazon-ec2/README.md --- @@ -41,11 +50,13 @@ Any platform that supports these tools is suitable, but the following instructio

[GitHub] metron pull request #930: METRON-1318 updated MacOS instructions and explain...

2018-02-07 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/930#discussion_r166751584 --- Diff: metron-deployment/amazon-ec2/README.md --- @@ -41,11 +50,13 @@ Any platform that supports these tools is suitable, but the following instructio

[GitHub] metron issue #812: METRON-1273: Website documentation link should point to t...

2018-02-07 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/812 Thanks @mmiklavc this totally fell off my plate ---

[GitHub] metron pull request #929: METRON-1448: Update SolrWriter to conform to new c...

2018-02-07 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/929#discussion_r166680167 --- Diff: metron-platform/metron-solr/src/main/java/org/apache/metron/solr/writer/SolrWriter.java --- @@ -33,17 +39,19 @@ import

[GitHub] metron issue #865: METRON-1212 The bundle System and Maven Plugin (Feature B...

2018-02-01 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/865 Ping ---

[GitHub] metron pull request #918: METRON-1436: Manually Install Solr Cloud in Full D...

2018-01-30 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/918#discussion_r164925885 --- Diff: metron-platform/metron-solr/src/main/scripts/install_solr.sh --- @@ -0,0 +1,62 @@ +#!/bin/bash +# +# Licensed to the Apache Software

[GitHub] metron pull request #918: METRON-1436: Manually Install Solr Cloud in Full D...

2018-01-30 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/918#discussion_r164925950 --- Diff: metron-platform/metron-solr/src/main/scripts/install_solr.sh --- @@ -0,0 +1,62 @@ +#!/bin/bash +# +# Licensed to the Apache Software

[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone

2018-01-30 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/690 Perfect, ty. ---

[GitHub] metron pull request #690: METRON-1091 Package STELLAR shell as stand alone

2018-01-30 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/690#discussion_r164805799 --- Diff: metron-stellar/stellar-common/README.md --- @@ -1413,6 +1413,46 @@ Please note that functions are loading lazily in the background and will be

[GitHub] metron pull request #690: METRON-1091 Package STELLAR shell as stand alone

2018-01-30 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/690#discussion_r164805617 --- Diff: metron-stellar/stellar-common/README.md --- @@ -1346,6 +1346,46 @@ Please note that functions are loading lazily in the background and will be

[GitHub] metron pull request #690: METRON-1091 Package STELLAR shell as stand alone

2018-01-30 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/690#discussion_r164805812 --- Diff: metron-stellar/stellar-common/README.md --- @@ -1413,6 +1413,46 @@ Please note that functions are loading lazily in the background and will be

[GitHub] metron issue #903: METRON-1370 Create Full Dev Equivalent for Ubuntu

2018-01-26 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/903 +1 to that latest round of naming ---

[GitHub] metron issue #903: METRON-1370 Create Full Dev Equivalent for Ubuntu

2018-01-25 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/903 @lvets trusty is 14.04. As far as I'm aware the only newer LTS is 16.04, with a new one expected in April. https://wiki.ubuntu.com/Releases ---

[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool

2018-01-22 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/902 I'm game to merge the `prepare-commit` and `checkout-pr` logic into one script; I'm even fine with pushing that to be a follow-on. Regarding the HTML-encoded JIRA description

[GitHub] metron pull request #902: METRON-1413 Add Metron Commit Tool

2018-01-19 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/902#discussion_r162688528 --- Diff: metron-dev-support/committer-utils/README.md --- @@ -0,0 +1,96 @@ +# Committer Tools + +This project contains tools to assist Apache

[GitHub] metron-bro-plugin-kafka issue #5: METRON-1407: Metron-Bro-Kafka plugin unabl...

2018-01-18 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/5 +1 ---

[GitHub] metron-bro-plugin-kafka issue #5: METRON-1407: Metron-Bro-Kafka plugin unabl...

2018-01-17 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/5 There we go, yeah that was significantly more delayed than normal. @z0r0 Would you mind sending an email to the dev list to get you added as a contributor on Jira so we

[GitHub] metron-bro-plugin-kafka issue #5: METRON-1407: Metron-Bro-Kafka plugin unabl...

2018-01-17 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/5 Great catch, thanks @z0r0 I will check this out soon. Not sure why this isn't auto linking to https://issues.apache.org/jira/browse/METRON-1407 though... I can

[GitHub] metron issue #896: METRON-1396: Fix .gitignore files to not ignore themselve...

2018-01-11 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/896 +1 by inspection ---

[GitHub] metron issue #883: METRON-1381: Add Apache license to MD files and remove th...

2017-12-30 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/883 Did you mean to tag @nickwallen in that last comment? I took a quick look and it all looks good to me but didn't do any verification that you got all of the md files (depending on Travis)

[GitHub] metron issue #881: METRON-1071: Create CONTRIBUTING.md

2017-12-23 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/881 Yup, looks good ---

[GitHub] metron pull request #881: METRON-1071: Create CONTRIBUTING.md

2017-12-22 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/881#discussion_r158477376 --- Diff: CONTRIBUTING.md --- @@ -0,0 +1,27 @@ +# How To Contribute +As an open source project, Metron welcomes contributions of all forms. There

[GitHub] metron pull request #881: METRON-1071: Create CONTRIBUTING.md

2017-12-22 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/881#discussion_r158477818 --- Diff: CONTRIBUTING.md --- @@ -0,0 +1,27 @@ +# How To Contribute +As an open source project, Metron welcomes contributions of all forms. There

[GitHub] metron pull request #873: METRON-1367 Stellar should have some instrumentati...

2017-12-19 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/873#discussion_r157717084 --- Diff: metron-stellar/stellar-common/README.md --- @@ -1352,6 +1352,61 @@ IS_EMAIL [Stellar]>>> ``` + %timing +

[GitHub] metron pull request #873: METRON-1367 Stellar should have some instrumentati...

2017-12-19 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/873#discussion_r157718871 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/common/timing/StackWatchTest.java --- @@ -0,0 +1,168

[GitHub] metron pull request #873: METRON-1367 Stellar should have some instrumentati...

2017-12-17 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/873#discussion_r157385625 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/shell/StellarExecutor.java --- @@ -289,7 +293,25 @@ public Object

[GitHub] metron pull request #873: METRON-1367 Stellar should have some instrumentati...

2017-12-17 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/873#discussion_r157376617 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/shell/StellarShell.java --- @@ -346,6 +348,18 @@ private void

[GitHub] metron pull request #873: METRON-1367 Stellar should have some instrumentati...

2017-12-17 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/873#discussion_r157376611 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/shell/StellarExecutor.java --- @@ -289,7 +293,25 @@ public Object

[GitHub] metron pull request #865: METRON-1212 The bundle System and Maven Plugin (Fe...

2017-12-15 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/865#discussion_r157303681 --- Diff: bundles-maven-plugin/README.md --- @@ -20,7 +20,9 @@ Apache Metron Bundles Maven Plugin helps to build Bundles Archives to support th

[GitHub] metron pull request #865: METRON-1212 The bundle System and Maven Plugin (Fe...

2017-12-15 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/865#discussion_r157196243 --- Diff: bundles-maven-plugin/README.md --- @@ -0,0 +1,230 @@ + +# Apache Metron Bundle Maven Plugin + +Apache Metron Bundles Maven Plugin

[GitHub] metron pull request #865: METRON-1212 The bundle System and Maven Plugin (Fe...

2017-12-15 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/865#discussion_r157196009 --- Diff: metron-bundles/bundles-lib/src/main/java/org/apache/metron/bundles/VfsBundleClassLoaderResource.java --- @@ -0,0 +1,110

[GitHub] metron pull request #865: METRON-1212 The bundle System and Maven Plugin (Fe...

2017-12-15 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/865#discussion_r157196275 --- Diff: bundles-maven-plugin/README.md --- @@ -0,0 +1,230 @@ + +# Apache Metron Bundle Maven Plugin + +Apache Metron Bundles Maven Plugin

[GitHub] metron pull request #865: METRON-1212 The bundle System and Maven Plugin (Fe...

2017-12-15 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/865#discussion_r157195764 --- Diff: metron-bundles/bundles-lib/README.md --- @@ -0,0 +1,213 @@ +# Apache Metron Bundles + +Apache Metron Bundles and this documentation

[GitHub] metron pull request #865: METRON-1212 The bundle System and Maven Plugin (Fe...

2017-12-15 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/865#discussion_r157196122 --- Diff: bundles-maven-plugin/NOTICE --- @@ -0,0 +1,8 @@ +Apache NiFi +Copyright 2014-2017 The Apache Software Foundation + +Apache Metron

[GitHub] metron pull request #865: METRON-1212 The bundle System and Maven Plugin (Fe...

2017-12-15 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/865#discussion_r157196527 --- Diff: metron-bundles/bundles-lib/pom.xml --- @@ -0,0 +1,185 @@ + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://

[GitHub] metron pull request #865: METRON-1212 The bundle System and Maven Plugin (Fe...

2017-12-15 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/865#discussion_r157196342 --- Diff: bundles-maven-plugin/pom.xml --- @@ -0,0 +1,328 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] metron pull request #865: METRON-1212 The bundle System and Maven Plugin (Fe...

2017-12-15 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/865#discussion_r157197191 --- Diff: bundles-maven-plugin/README.md --- @@ -0,0 +1,230 @@ + +# Apache Metron Bundle Maven Plugin + +Apache Metron Bundles Maven Plugin

[GitHub] metron pull request #865: METRON-1212 The bundle System and Maven Plugin (Fe...

2017-12-15 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/865#discussion_r157196478 --- Diff: bundles-maven-plugin/pom.xml --- @@ -0,0 +1,328 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] metron pull request #865: METRON-1212 The bundle System and Maven Plugin (Fe...

2017-12-15 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/865#discussion_r157196378 --- Diff: bundles-maven-plugin/pom.xml --- @@ -0,0 +1,328 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] metron pull request #865: METRON-1212 The bundle System and Maven Plugin (Fe...

2017-12-15 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/865#discussion_r157194648 --- Diff: bundles-maven-plugin/README.md --- @@ -0,0 +1,230 @@ + +# Apache Metron Bundle Maven Plugin + +Apache Metron Bundles Maven Plugin

[GitHub] metron issue #812: METRON-1273: Website documentation link should point to t...

2017-12-07 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/812 Sorry, I'm not at a computer right now but if anybody wants to push this before our release candidate is cut feel free ---

[GitHub] metron issue #847: METRON-1313: Update metron-deployment to use bro-pkg to i...

2017-12-07 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/847 Looks like we're [all sorted out](https://lists.apache.org/thread.html/3aecbadbf3353e98c03ca4b680fcd998d0cd2bf5a4319238dd85ae75@%3Cdev.metron.apache.org%3E) now. Updated per my prior com

[GitHub] metron issue #836: METRON-1308: Fix Metron Documentation

2017-12-05 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/836 Merged master, ran tests successfully, built site-books and did some clicking around. Going to merge. ---

[GitHub] metron issue #849: METRON-1334 Add C++11 Compliance Check to 'platform-info....

2017-12-01 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/849 +1 great stuff @nickwallen ---

[GitHub] metron issue #849: METRON-1334 Add C++11 Compliance Check to 'platform-info....

2017-11-28 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/849 Instead of trying to explaining my position, I threw together a quick PR to illustrate my thoughts. Feel free to take another approach. I tested it with `g++` configured, unconfigured, and not

[GitHub] metron issue #847: METRON-1313: Update metron-deployment to use bro-pkg to i...

2017-11-28 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/847 Thanks Otto. Leaving this one open for now, until things get sorted on the mailing list. ---

[GitHub] metron-bro-plugin-kafka issue #4: METRON-1329: Simplify metron-bro-plugin-ka...

2017-11-28 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/4 Thanks Otto. Leaving this one open for now, until things get sorted on the mailing list. ---

[GitHub] metron issue #848: METRON-1333 Ensure that ansible-docker can be used to bui...

2017-11-28 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/848 Ahh sorry, missed that was in the docs as well. Ok, looks good ---

[GitHub] metron issue #848: METRON-1333 Ensure that ansible-docker can be used to bui...

2017-11-28 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/848 +1, this is awesome work thanks Otto. Tested via ``` cd metron-deployment/packaging/docker/ansible-docker/ docker build -t ansible-docker:2.0.0.2 . docker run -it -v /Users/jzeolla

[GitHub] metron issue #836: METRON-1308: Fix Metron Documentation

2017-11-27 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/836 @cestella I know you were out recently, just wanted to bring this one to the top of your inbox. Would like to have this in the upcoming release, but also want to get your input. ---

[GitHub] metron issue #848: METRON-1333 Ensure that ansible-docker can be used to bui...

2017-11-27 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/848 Tested via ``` cd /Users/jzeolla/metron-pr848 docker run -it -v /Users/jzeolla/metron-pr848:/root/metron ansible-docker:2.0.0.2 bash cd /root/metron mvn clean package

[GitHub] metron issue #849: METRON-1334 Add C++11 Compliance Check to 'platform-info....

2017-11-27 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/849 Ran on a purposefully misconfigured macOS system. Is this the expected output? ``` -- g++ xcrun: error: invalid active developer path (/Library/Developer/CommandLineTools

[GitHub] metron pull request #848: METRON-1333 Ensure that ansible-docker can be used...

2017-11-27 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/848#discussion_r153327669 --- Diff: metron-deployment/packaging/docker/ansible-docker/README.md --- @@ -1,17 +1,34 @@ # Overview -The Metron ansible-docker container is

[GitHub] metron pull request #848: METRON-1333 Ensure that ansible-docker can be used...

2017-11-27 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/848#discussion_r153326885 --- Diff: metron-deployment/packaging/docker/ansible-docker/Dockerfile --- @@ -14,13 +14,18 @@ # See the License for the specific language governing

[GitHub] metron pull request #848: METRON-1333 Ensure that ansible-docker can be used...

2017-11-27 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/848#discussion_r153326917 --- Diff: metron-deployment/packaging/docker/ansible-docker/Dockerfile --- @@ -33,18 +38,28 @@ RUN tar xvf setuptools-11.3.tar.gz WORKDIR /usr/src

[GitHub] metron-bro-plugin-kafka pull request #2: DO NOT MERGE METRON-1304: Allow met...

2017-11-23 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r152850661 --- Diff: scripts/Bro/Kafka/logs-to-kafka.bro --- @@ -14,32 +14,37 @@ # See the License for the specific language governing

[GitHub] metron pull request #847: METRON-1313: Update metron-deployment to use bro-p...

2017-11-22 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/847#discussion_r152715716 --- Diff: metron-deployment/roles/bro/tasks/metron-bro-plugin-kafka.yml --- @@ -15,36 +15,34 @@ # limitations under the License

[GitHub] metron pull request #847: METRON-1313: Update metron-deployment to use bro-p...

2017-11-22 Thread JonZeolla
GitHub user JonZeolla opened a pull request: https://github.com/apache/metron/pull/847 METRON-1313: Update metron-deployment to use bro-pkg to install the kafka plugin ## Contributor Comments This PR requires #844. For testing, this PR currently references my fork of

[GitHub] metron-bro-plugin-kafka pull request #4: METRON-1329: Simplify metron-bro-pl...

2017-11-22 Thread JonZeolla
GitHub user JonZeolla opened a pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/4 METRON-1329: Simplify metron-bro-plugin-kafka package loading This is a very simple change that normalizes the process of loading this package in an existing bro system

[GitHub] metron-bro-plugin-kafka pull request #2: DO NOT MERGE METRON-1304: Allow met...

2017-11-22 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r152674806 --- Diff: scripts/Bro/Kafka/logs-to-kafka.bro --- @@ -14,32 +14,37 @@ # See the License for the specific language governing

[GitHub] metron issue #846: METRON-1328: Enhance platform-info.sh script to check if ...

2017-11-22 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/846 +1 tested on my mac with and without the daemon running. ---

[GitHub] metron issue #844: METRON-1088: Upgrade bro to 2.5.2

2017-11-20 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/844 Okay, so I spun up master, pushed my template via `curl`, and then ran the above commands to confirm backward compatibility with the template on bro 2.4.x. The only change to my steps that I had

[GitHub] metron issue #844: METRON-1088: Upgrade bro to 2.5.2

2017-11-20 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/844 Leaving this open a bit longer so @nickwallen has time to comment, if interested. ---

[GitHub] metron-bro-plugin-kafka pull request #2: DO NOT MERGE METRON-1304: Allow met...

2017-11-20 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r152085762 --- Diff: scripts/Bro/Kafka/logs-to-kafka.bro --- @@ -14,32 +14,37 @@ # See the License for the specific language governing

[GitHub] metron issue #844: METRON-1088: Upgrade bro to 2.5.2

2017-11-20 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/844 [METRON-1322](https://issues.apache.org/jira/browse/METRON-1322) for your PCAP feature request. Also, I totally agree with your documentation notes. Cleaning this up has been on my to-do

[GitHub] metron-bro-plugin-kafka pull request #2: DO NOT MERGE METRON-1304: Allow met...

2017-11-20 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r152075056 --- Diff: scripts/Bro/Kafka/logs-to-kafka.bro --- @@ -14,32 +14,37 @@ # See the License for the specific language governing

[GitHub] metron issue #844: METRON-1088: Upgrade bro to 2.5.2

2017-11-20 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/844 Thanks @ottobackwards While I feel like the ES template documentation is good enough for now, I really want to investigate something cleaner, probably via 777 but also potentially by

[GitHub] metron pull request #844: METRON-1088: Upgrade bro to 2.5.2

2017-11-20 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/844#discussion_r152067166 --- Diff: metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/bro/BasicBroParserTest.java --- @@ -1133,6 +1133,233 @@ public void

[GitHub] metron issue #844: METRON-1088: Upgrade bro to 2.5.2

2017-11-20 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/844 There is no requirement to upgrade bro with this change. All old fields and logs are still supported, this simply adds support for the new fields in existing logs or new logs altogether to be

[GitHub] metron issue #844: METRON-1088: Upgrade bro to 2.5.2

2017-11-20 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/844 I'm going to see if I can find some time today to fix the tests, but this is ready for review otherwise. Full-dev worked as expected for me. ---

[GitHub] metron pull request #844: METRON-1088: Upgrade bro to 2.5.2

2017-11-19 Thread JonZeolla
GitHub user JonZeolla opened a pull request: https://github.com/apache/metron/pull/844 METRON-1088: Upgrade bro to 2.5.2 ## Contributor Comments This upgrades bro to 2.5.2, and natively provides support for many of the fields from a default bro 2.5.2 install. Specifically

[GitHub] metron-bro-plugin-kafka pull request #2: DO NOT MERGE METRON-1304: Allow met...

2017-11-17 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r151825744 --- Diff: scripts/init.bro --- @@ -18,11 +18,20 @@ module Kafka; export { - const topic_name: string = "bro&qu

[GitHub] metron issue #836: METRON-1308: Fix Metron Documentation

2017-11-17 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/836 Since we have a release coming up, I won't have time to do any additional documentation review past what I've already done. @cestella have you had a chance to review? ---

[GitHub] metron issue #827: METRON-1294: IP addresses are not formatted correctly in ...

2017-11-16 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/827 I didn't get myself intimately familiar with this PR, but I wanted to mention that assuming two fields with the same name but different types between indexes are not the same may not always

[GitHub] metron-bro-plugin-kafka pull request #3: METRON-813: Migrate metron-bro-plug...

2017-11-15 Thread JonZeolla
GitHub user JonZeolla opened a pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/3 METRON-813: Migrate metron-bro-plugin-kafka to be a bro package This should turn this repo into a bro package containing a bro plugin. # Testing The below testing plan

[GitHub] metron pull request #837: METRON-1309: Change metron-deployment to pull the ...

2017-11-09 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/837#discussion_r150056693 --- Diff: metron-deployment/other-examples/manual-install/Manual_Install_CentOS6.md --- @@ -638,15 +638,15 @@ Edit crontab with `# crontab -e` and add

[GitHub] metron issue #837: METRON-1309: Change metron-deployment to pull the plugin ...

2017-11-09 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/837 This is ready for review. ---

  1   2   3   >