Github user dbist commented on the issue:
https://github.com/apache/metron/pull/664
I have a failure locally, will re-do the commit.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/664
just another bump to deconflict this so we can land it
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/664
Please resolve conflicts in this PR, then we should be on track to commit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/664
+1 Thanks for the contribution
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dbist commented on the issue:
https://github.com/apache/metron/pull/664
@nickwallen @ottobackwards separated by new line and placed them in
separated blocks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/664
I agree with you @ottobackwards . We typically have a block of imports,
then a blank line then a block of static imports with no wildcards.
Our current development guidelines say to
Github user dbist commented on the issue:
https://github.com/apache/metron/pull/664
I would agree it would be better for readability, let me know and I'll
generate another commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/664
That is better. I would just like some confirmation from someone else (
@cestella, @nickwallen ). I *think* that we want the static imports separate,
and after the other imports. That is
Github user dbist commented on the issue:
https://github.com/apache/metron/pull/664
@ottobackwards organized the imports, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/664
Thanks for the contribution! While we are looking at the imports can we
order them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
10 matches
Mail list logo
