[GitHub] metron issue #734: METRON-1158: Build backend for grouping alerts into meta ...

2017-09-12 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/734 @merrimanr Are you still +1 after the most recent changes before I commit this? ---

[GitHub] metron issue #734: METRON-1158: Build backend for grouping alerts into meta ...

2017-09-11 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/734 @merrimanr I added in one fix for some typing on meta alert updates and also merged in master and the group stuff ---

[GitHub] metron issue #734: METRON-1158: Build backend for grouping alerts into meta ...

2017-09-11 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/734 Tested this again in full dev and now the default sort is working as expected (due to timestamp being added). +1 from me. Nice job. ---

[GitHub] metron issue #734: METRON-1158: Build backend for grouping alerts into meta ...

2017-09-11 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/734 @merrimanr I added the timestamp field in the meta alert create with current timestamp. Should take care of it lining up with the other sources. ---

[GitHub] metron issue #734: METRON-1158: Build backend for grouping alerts into meta ...

2017-09-08 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/734 Great job on this. I spent a lot of time testing and had trouble finding anything wrong. The one thing I did notice was that the "timestamp" field was missing from documents in the metaalerts

[GitHub] metron issue #734: METRON-1158: Build backend for grouping alerts into meta ...

2017-09-06 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/734 ## Create Meta Alert The first thing to do is to build and deploy full dev with this PR. Afterwards, we're going to set up a bit of base data. Retrieve the current list of