Github user james-sirota commented on the issue:
https://github.com/apache/metron/pull/796
+1
---
Github user james-sirota commented on the issue:
https://github.com/apache/metron/pull/796
+ 1. Gret job. all pass
login to application
â should display error message for invalid credentials
â should login for valid credentials
â should logout
Github user james-sirota commented on the issue:
https://github.com/apache/metron/pull/796
login to application
â should display error message for invalid credentials
â should login for valid credentials
â should logout
metron-alerts App
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/796
I think the test coverage looks pretty good. I'm +1 conditional on the e2e
tests passing.
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/796
@merrimanr I have added e2e tests as suggested and merged your PR too. Plz,
let me know if I missed anything. I had to omit assertions for a couple of
quick ranges as they can cause trouble when
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/796
This issue is still not fixed:
- The first is related to time-range selections that include 'Now' as part
of the range (Last 7 days, Last 5 minutes, Today so far, etc). This should be a
Github user james-sirota commented on the issue:
https://github.com/apache/metron/pull/796
@iraghumitra looks like everything has been addressed. I am +1 on my side,
but lets have @merrimanr chime in
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/796
@merrimanr @james-sirota There was a bug in handling the recent searches
that were in old format can you check it now. Sorry for the trouble
---
Github user james-sirota commented on the issue:
https://github.com/apache/metron/pull/796
A few things didn't work for me. First, when I select a time range of (t-x
minutes) the start and end time does not fill in per screen shot below.
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/796
@merrimanr can you clear browser cache and try? There is a change in save
query model my bad I missed mentioning it.
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/796
@merrimanr plz find my replies
- when I open the date/time range picker why does it say "now/d"? I would
expect just "now" or "Now" - Changed to now
- when I first navigate to the Alerts
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/796
I definitely like the testing section @merrimanr I'd like to see the test
in existence in the PR split into the test cases that you suggest. Testing
those time range quicklinks turn into sensible
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/796
I tested this as well. First a couple things I'm curious about:
- when I open the date/time range picker why does it say "now/d"? I would
expect just "now" or "Now"
- when I first
Github user james-sirota commented on the issue:
https://github.com/apache/metron/pull/796
I tested the PR. The only issue I see is that when I paste the timestamp
or manually type it into the boxes it overwrites it with the calendar entries.
So essentially the only way to get the
Github user james-sirota commented on the issue:
https://github.com/apache/metron/pull/796
@ottobackwards @iraghumitra i already filed a feature request on that:
https://issues.apache.org/jira/browse/METRON-1248
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/796
@ottobackwards that's a good suggestion can you create a ticket with some
more details about new quick filters and any design that you have in mind. I
would be happy to pick it up as a follow-on
16 matches
Mail list logo
