[GitHub] metron issue #829: METRON-1296 Full Dev Fails to Deploy Index Templates

2017-11-07 Thread anandsubbu
Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/829 @nickwallen , for the record full dev spun up fine with the fix. Thank you! ---

[GitHub] metron issue #829: METRON-1296 Full Dev Fails to Deploy Index Templates

2017-11-07 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/829 @anandsubbu agreed with your comments on the exception ---

[GitHub] metron issue #829: METRON-1296 Full Dev Fails to Deploy Index Templates

2017-11-07 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/829 +1. I agree with Casey that this should fail instead of WARN. If templates are not installed it puts us in a bad state and requires manual intervention that may not be obvious. ---

[GitHub] metron issue #829: METRON-1296 Full Dev Fails to Deploy Index Templates

2017-11-07 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/829 I'm +1 on the PR, but I strongly agree with Anand, this should not be a warn. We should throw an exception here and fail the build. That being said, despite it being in the vicinity of this PR,

[GitHub] metron issue #829: METRON-1296 Full Dev Fails to Deploy Index Templates

2017-11-07 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/829 > However, given that the indexing templates are a must have for the alerts UI to work properly, should we remove the try/expect block and allow the install to fail in the event it was not

[GitHub] metron issue #829: METRON-1296 Full Dev Fails to Deploy Index Templates

2017-11-07 Thread anandsubbu
Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/829 Hi @nickwallen , thank you for the fix. It is my bad, I should have added the line `commands = IndexingCommands(params)` before the `try` block in my previous fix :(. I am under way

[GitHub] metron issue #829: METRON-1296 Full Dev Fails to Deploy Index Templates

2017-11-03 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/829 Worked for me when I ran it up in Full Dev. I am able to see the templates and use the Alerts UI. ``` 2017-11-03 22:22:41,294 - File['/var/lib/ambari-agent/tmp/bro_index.template']