Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/832
Thanks for all the reviews, guys. Going to commit now.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/832
+1 worked as advertised. Thanks @nickwallen!
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/832
+1 by inspection. Looks great!
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/832
Spun this up on full dev, and saw that sorting worked as expected in the
UI. This worked both when no groupings were selected and also when drilling
down (e.g. grouping by ip_dst_addr and
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/832
I merged with the latest changed from #824
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/832
@nickwallen really liked the way you annotated the PR with your comments.
You made it really easy to understand and saved a lot of time for me. As you
rightly pointed out I will wait till all
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/832
I want to get all of @merrimanr 's fixes in (#824, #825 #827 ) before we
consider merging this one. There will be some merge conflicts and I can take
care of sorting through those.
---
