[GitHub] metron issue #846: METRON-1328: Enhance platform-info.sh script to check if ...

[JonZeolla]

Github user JonZeolla commented on the issue:

https://github.com/apache/metron/pull/846
  
+1 tested on my mac with and without the daemon running.


---

[GitHub] metron issue #846: METRON-1328: Enhance platform-info.sh script to check if ...

[ottobackwards]

Github user ottobackwards commented on the issue:

https://github.com/apache/metron/pull/846
  
I would prefer it always say docker is running or not, but this will work.  
+1


---

[GitHub] metron issue #846: METRON-1328: Enhance platform-info.sh script to check if ...

[nickwallen]

Github user nickwallen commented on the issue:

https://github.com/apache/metron/pull/846
  
+1 Thanks, Anand.  I tested with Docker daemon running, not running and not 
installed.  Worked as advertised.


---

[GitHub] metron issue #846: METRON-1328: Enhance platform-info.sh script to check if ...

[anandsubbu]

Github user anandsubbu commented on the issue:

https://github.com/apache/metron/pull/846
  
Hi @ottobackwards , thanks for your review.

I prefixed a 'WARNING' to the message text so it would catch the eye of the 
user. Also, I removed the else bit for docker running scenario, since this will 
fail for the case where docker is not installed at all. If I retain the else 
block, it would report saying 'Docker daemon is running'. 

So, in summary here are the cases:

1. Docker installed and running would print:
```bash
Docker version 1.12.1, build 23cf638, experimental
```
2. Docker installed, but not running would print:
```bash
Docker version 1.12.1, build 23cf638, experimental
WARNING: Docker daemon is not running
```
3. Docker not installed would print:
```bash
-bash: docker: command not found
```
Let me know if this looks okay.


---

[GitHub] metron issue #846: METRON-1328: Enhance platform-info.sh script to check if ...

[ottobackwards]

Github user ottobackwards commented on the issue:

https://github.com/apache/metron/pull/846
  
Thanks for the contribution!  This is a great idea.  If I may, I think this 
may be more clear:

```bash
if docker info 2>&1  | grep -q 'Cannot connect to the Docker daemon'
then
echo "Docker daemon is not running"
else
echo "Docker daemon is running"
 fi

```


---