[GitHub] incubator-metron pull request #401: METRON-637: Add a STATS_BIN function to ...

Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/401#discussion_r93573955 --- Diff: metron-analytics/metron-statistics/src/main/java/org/apache/metron/statistics/MathFunctions.java --- @@ -59,4 +60,49 @@ public

[GitHub] incubator-metron pull request #401: METRON-637: Add a STATS_BIN function to ...

Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/401#discussion_r93574334 --- Diff: metron-analytics/metron-statistics/src/main/java/org/apache/metron/statistics/StellarStatisticsFunctions.java --- @@ -425,4 +428,61

[GitHub] incubator-metron pull request #401: METRON-637: Add a STATS_BIN function to ...

Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/401#discussion_r93573772 --- Diff: metron-analytics/metron-statistics/src/main/java/org/apache/metron/statistics/MathFunctions.java --- @@ -59,4 +60,49 @@ public

[GitHub] incubator-metron pull request #401: METRON-637: Add a STATS_BIN function to ...

Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/401#discussion_r93575237 --- Diff: metron-analytics/metron-statistics/src/test/java/org/apache/metron/statistics/StellarStatisticsFunctionsTest.java --- @@ -373,15

[GitHub] incubator-metron issue #401: METRON-637: Add a STATS_BIN function to Stellar...

Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/401 Thanks for the feedback, @mattf-horton! I went ahead and incorporated your changes. For posterity and so this gets replicated to the JIRA, I added a `BIN` function that just takes a

[GitHub] incubator-metron pull request #402: METRON-639: The Network Stellar function...

GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/402 METRON-639: The Network Stellar functions need to have better unit testing We have very little unit test coverage around the Networking functions in Stellar at the edge level. When

[GitHub] incubator-metron pull request #401: METRON-637: Add a STATS_BIN function to ...

Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/401#discussion_r93537026 --- Diff: metron-analytics/metron-statistics/src/test/java/org/apache/metron/statistics/StellarStatisticsFunctionsTest.java --- @@ -356,6 +357,44

[GitHub] incubator-metron pull request #401: METRON-637: Add a STATS_BIN function to ...

Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/401#discussion_r93536290 --- Diff: metron-analytics/metron-statistics/src/test/java/org/apache/metron/statistics/StellarStatisticsFunctionsTest.java --- @@ -356,6

[GitHub] incubator-metron pull request #401: METRON-637: Add a STATS_BIN function to ...

Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/401#discussion_r93535574 --- Diff: metron-analytics/metron-statistics/src/test/java/org/apache/metron/statistics/StellarStatisticsFunctionsTest.java --- @@ -356,6 +357,44

[GitHub] incubator-metron pull request #401: METRON-637: Add a STATS_BIN function to ...

Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/401#discussion_r93528090 --- Diff: metron-analytics/metron-statistics/README.md --- @@ -112,6 +112,13 @@ functions can be used from everywhere where Stellar is used.

[GitHub] incubator-metron pull request #401: METRON-637: Add a STATS_BIN function to ...

Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/401#discussion_r93530871 --- Diff: metron-analytics/metron-statistics/src/test/java/org/apache/metron/statistics/StellarStatisticsFunctionsTest.java --- @@ -356,6

[GitHub] incubator-metron pull request #397: METRON-627: Add HyperLogLogPlus implemen...

Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/397#discussion_r93529216 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/utils/HyperLogLogPlus.java --- @@ -0,0 +1,102 @@ +/** + *

[GitHub] incubator-metron pull request #401: METRON-637: Add a STATS_BIN function to ...

Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/401#discussion_r93524927 --- Diff: metron-analytics/metron-statistics/README.md --- @@ -112,6 +112,13 @@ functions can be used from everywhere where Stellar is used.

[GitHub] incubator-metron pull request #401: METRON-637: Add a STATS_BIN function to ...

Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/401#discussion_r93520475 --- Diff: metron-analytics/metron-statistics/src/main/java/org/apache/metron/statistics/StellarStatisticsFunctions.java --- @@ -425,4 +428,74

[GitHub] incubator-metron pull request #401: METRON-637: Add a STATS_BIN function to ...

Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/401#discussion_r93524020 --- Diff: metron-analytics/metron-statistics/src/main/java/org/apache/metron/statistics/StellarStatisticsFunctions.java --- @@ -425,4 +428,74 @@

[GitHub] incubator-metron pull request #401: METRON-637: Add a STATS_BIN function to ...

Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/401#discussion_r93523895 --- Diff: metron-analytics/metron-statistics/src/main/java/org/apache/metron/statistics/StellarStatisticsFunctions.java --- @@ -425,4 +428,74 @@

[GitHub] incubator-metron pull request #401: METRON-637: Add a STATS_BIN function to ...

Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/401#discussion_r93523813 --- Diff: metron-analytics/metron-statistics/README.md --- @@ -112,6 +112,13 @@ functions can be used from everywhere where Stellar is used.

[GitHub] incubator-metron pull request #401: METRON-637: Add a STATS_BIN function to ...

Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/401#discussion_r93520478 --- Diff: metron-analytics/metron-statistics/src/main/java/org/apache/metron/statistics/StellarStatisticsFunctions.java --- @@ -425,4 +428,74

Re: Apache Lic on README.md files?

Looks like they use XML escapes On December 21, 2016 at 15:48:07, Casey Stella (ceste...@gmail.com) wrote: We should do this. I was not aware that Markdown took comments. Every file which is capable of handling comments should have an apache license, IIRC. On Wed, Dec 21, 2016 at 3:45 PM,

Re: Apache Lic on README.md files?

We should do this. I was not aware that Markdown took comments. Every file which is capable of handling comments should have an apache license, IIRC. On Wed, Dec 21, 2016 at 3:45 PM, Otto Fowler wrote: > I was just looking at the NiFi source, and noticed that they

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/393 Thanks for the explanation @merrimanr. I totally agree on the need for the local IDE to have access to the containerized services. It's an easy enough fix for me to manipulate

Re: [DISCUSS] Coding Guidelines

+1 On December 21, 2016 at 14:56:06, Michael Miklavcic ( michael.miklav...@gmail.com) wrote: Works for me also. On Wed, Dec 21, 2016 at 12:38 PM, Matt Foley wrote: > Works for me, thanks. > > On 12/21/16, 11:21 AM, "Casey Stella" wrote: > > Sure, how

[GitHub] incubator-metron pull request #401: METRON-637: Add a STATS_BIN function to ...

GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/401 METRON-637: Add a STATS_BIN function to Stellar. When passing parameters to models, it's often useful to pass the binned representation of a variable based on an empirical statistical

Re: [DISCUSS] Coding Guidelines

Works for me also. On Wed, Dec 21, 2016 at 12:38 PM, Matt Foley wrote: > Works for me, thanks. > > On 12/21/16, 11:21 AM, "Casey Stella" wrote: > > Sure, how about making it generic to "a deployed cluster"? > > On Wed, Dec 21, 2016 at 2:20 PM, Matt

[GitHub] incubator-metron issue #395: METRON-590 Enable Use of Event Time in Profiler

Github user merrimanr commented on the issue: https://github.com/apache/incubator-metron/pull/395 Here is the Jira: https://issues.apache.org/jira/browse/METRON-638 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-metron issue #395: METRON-590 Enable Use of Event Time in Profiler

Github user merrimanr commented on the issue: https://github.com/apache/incubator-metron/pull/395 No problem @nickwallen, I agree you shouldn't have to tackle all of this on your own. I will volunteer for the ConfiguredBolt refactor task. Let me create a Jira and we can start

[GitHub] incubator-metron issue #395: METRON-590 Enable Use of Event Time in Profiler

Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/395 Recording here for posterity, in case anyone is interested: I asked on the storm user list: ``` I’ve been unable to find this in the Storm documentation: How does the

Re: [DISCUSS] Coding Guidelines

Works for me, thanks. On 12/21/16, 11:21 AM, "Casey Stella" wrote: Sure, how about making it generic to "a deployed cluster"? On Wed, Dec 21, 2016 at 2:20 PM, Matt Foley wrote: > +1 on Casey’s first edit. However, wrt the second, can

[GitHub] incubator-metron issue #395: METRON-590 Enable Use of Event Time in Profiler

Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/395 @nickwallen , totally understand, and I respect your efforts to keep things as simple as possible in the original scope. But I'm much happier with this scoping :-) --- If your

[GitHub] incubator-metron issue #395: METRON-590 Enable Use of Event Time in Profiler

Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/395 Ok, gotcha @mattf-horton. Understand now. To be fair, in this PR, I wasn't trying to replace `ConfiguredBolt` so what I have in `ZkConfigurationManager` was the easiest way I

Re: [DISCUSS] Coding Guidelines

Sure, how about making it generic to "a deployed cluster"? On Wed, Dec 21, 2016 at 2:20 PM, Matt Foley wrote: > +1 on Casey’s first edit. However, wrt the second, can we please not > require vagrant? Any of our single-node test deployments, including > vagrant, ansible,

Re: [DISCUSS] Coding Guidelines

+1 on Casey’s first edit. However, wrt the second, can we please not require vagrant? Any of our single-node test deployments, including vagrant, ansible, mpack, or (soon :-) docker, should be acceptable. Thanks, --Matt (who can’t run vagrant workably on the systems available to me) On

[GitHub] incubator-metron issue #395: METRON-590 Enable Use of Event Time in Profiler

Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/395 Thanks, @merrimanr for expressing that better than I did. @nickwallen , one of the principles of reliable refactoring[1] is to methodically do only and precisely the changes needed

[GitHub] incubator-metron pull request #395: METRON-590 Enable Use of Event Time in P...

Github user nickwallen closed the pull request at: https://github.com/apache/incubator-metron/pull/395 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-metron issue #395: METRON-590 Enable Use of Event Time in Profiler

Github user merrimanr commented on the issue: https://github.com/apache/incubator-metron/pull/395 I agree with @mattf-horton. ConfiguredBolt should be improved/refactored instead of completely starting over. Keep in mind this was developed over many iterations with input from

[GitHub] incubator-metron issue #395: METRON-590 Enable Use of Event Time in Profiler

Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/395 I don't understand what your proposal is @mattf-horton . Please clarify --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] incubator-metron issue #395: METRON-590 Enable Use of Event Time in Profiler

Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/395 @nickwallen and @cestella, I'm fine with this conclusion, but from a design perspective, the ZkConfigurationManager effort should not be viewed as bringing the current file to parity

Re: [DISCUSS] Coding Guidelines

Agreed on Casey's addition to 2.5. What do you think about saying the plan should be stated on the PR, since that will be replicated to Jira automatically? On Wed, Dec 21, 2016 at 7:49 AM, Casey Stella wrote: > Oh, one more, I propose the following addition to 2.5: > > > >

Re: [DISCUSS] Coding Guidelines

Oh, one more, I propose the following addition to 2.5: > > JIRAs will have a description of how to exercise the functionality in a > step-by-step manner on a Quickdev vagrant instance to aid review and > validation. When Mike, Otto and I moved the system to the current version of Storm, we

[GitHub] incubator-metron issue #395: METRON-590 Enable Use of Event Time in Profiler

Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/395 @nickwallen Your suggestion is fine by me. I hate to put the onus on you like this, but I think I like your suggestion best of all because it will result in smaller and more targeted

Re: [DISCUSS] Coding Guidelines

We have been having a lively discussion on METRON-590 (see https://github.com/apache/incubator-metron/pull/395) around creating multiple abstractions to do the same (or very nearly the same) thing. I'd like to propose an addition to section 2.3 which reads: > Contributions which provide

[GitHub] incubator-metron issue #395: METRON-590 Enable Use of Event Time in Profiler

Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/395 As to @mattf-horton suggestion, I had looked at the possibility of not using the BaseWindowedBolt and implementing that myself. But that seems like worse technical debt to me. I'd be

[GitHub] incubator-metron issue #395: METRON-590 Enable Use of Event Time in Profiler

Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/395 I also wanted to mention one of the reasons I am particularly sensitive to having multiple components that do *very nearly* the same thing. I made this mistake early on in the project

[GitHub] incubator-metron issue #395: METRON-590 Enable Use of Event Time in Profiler

Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/395 @mattf-horton @mmiklavc First off, thanks for the perspective, both of you. While I think we should investigate your suggestion, @mattf-horton , it appears on the face of it quite

[GitHub] incubator-metron issue #395: METRON-590 Enable Use of Event Time in Profiler

Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/395 Regarding ZkConfigurationManager and the above discussion thread: This is a complex situation, but my best advice is as follows: 1. It is definitely worthwhile to refactor

[GitHub] incubator-metron pull request #395: METRON-590 Enable Use of Event Time in P...

Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/395#discussion_r93426555 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/manager/ZkConfigurationManager.java --- @@ -0,0

[GitHub] incubator-metron pull request #400: METRON-636: Capture memory and cpu detai...

GitHub user anandsubbu opened a pull request: https://github.com/apache/incubator-metron/pull/400 METRON-636: Capture memory and cpu details as a part of platform-info… … script Added top commands for Linux and Mac to be captured as a part of the platform-info.sh