GitHub user cestella opened a pull request:
https://github.com/apache/incubator-metron/pull/402
METRON-639: The Network Stellar functions need to have better unit testing
We have very little unit test coverage around the Networking functions in
Stellar at the edge level. When diving a bit deeper on real data, I found a
number of bugs around:
* Domains with TLDs that are not part of the proper set of TLDs
* URIs with schemes that Java doesn't know about.
* N_SUBNET takes multiple CIDRs, but only evaluates the first one.
* Generally calling validate on these methods can be unsafe because they do
not handle null arguments correctly.
This just shores up the functions and provides more explicit and detailed
unit testing. If I missed a test case or two, let me know and I'll add it in.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron NetworkFunctionBug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/402.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #402
----
commit 16720acf00f5f9a62bbacfbba959baf0db97fc47
Author: cstella <[email protected]>
Date: 2016-12-21T23:00:57Z
Added more rigorous tests to look at edge cases for network stellar
functions.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
