[GitHub] incubator-metron pull request: Initial code for a website

2015-12-15 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/1#issuecomment-164833748 Everyone should have the ability to comment or submit a JIRA. On Tue, Dec 15, 2015 at 11:03 AM, ddutta <notificati...@github.com> wrote:

[GitHub] incubator-metron pull request #143: METRON-197: Validation should be the las...

2016-06-02 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/143 METRON-197: Validation should be the last step in the ParserBolt Right now we are doing the validation prior to the messageFilter. We should only validate the parsed messages which

[GitHub] incubator-metron pull request #146: METRON-203 General best practice and bug...

2016-06-08 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/146#discussion_r66321208 --- Diff: metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/nonbulk/taxii/TaxiiHandler.java --- @@ -61,346 +63,334

[GitHub] incubator-metron pull request #148: METRON-215: Fixing an NPE in the Message...

2016-06-09 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/148 METRON-215: Fixing an NPE in the MessageParser Optional.of does not accept nulls. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-metron pull request #147: METRON-208 Add Google Analytics tags to ...

2016-06-09 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/147#discussion_r66463687 --- Diff: site/diff --- @@ -0,0 +1,186 @@ +diff --git a/site/_includes/footer.html b/site/_includes/footer.html --- End diff

[GitHub] incubator-metron pull request #149: METRON-217: Found a grabbag of bugs

2016-06-10 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/149 METRON-217: Found a grabbag of bugs Doing some scale testing, I found a grabbag of bugs: * The elasticsearch writer should allow multiple ES hosts to be passed in via a List

[GitHub] incubator-metron pull request: METRON-186: Create a fieldMapping f...

2016-05-25 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/136 METRON-186: Create a fieldMapping functionality which allows for parsed fields to be transformed Currently the parsers take care of transforming raw data to the parsed JSON

[GitHub] incubator-metron pull request: METRON-174 Storm consumption of hba...

2016-05-25 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/127#discussion_r64669063 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/bolt/ParserBolt.java --- @@ -60,7 +93,25 @@ public void prepare

[GitHub] incubator-metron issue #150: METRON-222: Address ConcurrentModificationExcep...

2016-06-14 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/150 I don't see a difference in the clone method vs the method currently implemented. I think we should evaluate in a follow-on JIRA whether any of the clones are needed. It seems that none

[GitHub] incubator-metron pull request #151: METRON-223: Invalid and Erroneous messag...

2016-06-14 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/151 METRON-223: Invalid and Erroneous messages should go to kafka for further analysis in the Parser Topology Right now we send error messages and invalid messages to separate streams

[GitHub] incubator-metron issue #142: METRON-204: Field Transformation Domain Specifi...

2016-06-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/142 So, I think the main disadvantage of using groovy or any of the scripting engine integrations is speed and expressibility. Having a targeted domain specific language is going

[GitHub] incubator-metron issue #144: METRON-211 Enable creation of new Kafka topics ...

2016-06-14 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/144 +1 this looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron issue #145: METRON-212: Allow additional Elasticsearch temp...

2016-06-14 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/145 +1 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-metron pull request #142: METRON-204: Field Transformation Domain ...

2016-06-13 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/142#discussion_r66876932 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/query/generated/PredicateLexer.java --- @@ -114,59 +118,74

[GitHub] incubator-metron pull request #142: METRON-204: Field Transformation Domain ...

2016-06-13 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/142#discussion_r66877352 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/aggregator/Aggregators.java --- @@ -18,18 +18,21

[GitHub] incubator-metron issue #146: METRON-203 General best practice and bug fixes

2016-06-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/146 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-metron pull request #150: METRON-222: Address ConcurrentModificati...

2016-06-13 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/150 METRON-222: Address ConcurrentModificationException in BulkMessageWriter You can merge this pull request into a Git repository by running: $ git pull https://github.com/cestella

[GitHub] incubator-metron issue #142: METRON-204: Field Transformation Domain Specifi...

2016-06-03 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/142 Also, it seems like a big PR, but honestly it's deceptive. There was a lot of file moving and the generated Antlr code inflates the size. --- If your project is set up for it, you can

[GitHub] incubator-metron pull request: METRON-190: Make start_parser_topol...

2016-05-28 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/139#issuecomment-222313782 @james-sirota Right you are! Just updated exposing the numTasks for the spout and the parser bolt. ``` -pnt,--parser_num_tasksParser Num

[GitHub] incubator-metron pull request: METRON-174 Storm consumption of hba...

2016-05-31 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/127#issuecomment-222638653 You sure Kafka is still up? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-metron pull request: METRON-190: Make start_parser_topol...

2016-05-27 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/139 METRON-190: Make start_parser_topology.sh more adaptable regarding storm topology configuration Add the ability to specify the message timeout, the max task parallelism, the number

[GitHub] incubator-metron pull request: METRON-190: Make start_parser_topol...

2016-05-27 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/139#issuecomment-53339 Ok, I verified this on full dev vagrant. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-metron pull request: METRON-186: Create a fieldMapping f...

2016-05-26 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/136#issuecomment-221862988 Yeah, I was thinking about that too. I think transformation is a more descriptive term. You're the 2nd person (in addition to myself) who has made

[GitHub] incubator-metron pull request: METRON-100 GeoIP errors out silentl...

2016-05-26 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/134#discussion_r64742580 --- Diff: metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/adapters/jdbc/JdbcAdapter.java --- @@ -38,6 +39,27

[GitHub] incubator-metron pull request: METRON-174 Storm consumption of hba...

2016-05-30 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/127#issuecomment-222534318 Looks like it can't find the writerClassname field. Are you sure you ran a build from this branch before the deploy? On Mon, May 30, 2016 at 13:48

[GitHub] incubator-metron pull request: METRON-183 Allow the simple hbase e...

2016-05-29 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/131#issuecomment-222363251 The way to validate this is to * Create a second column family on the enrichment HBase table, say `cf1` * Push some enrichment data into the table

[GitHub] incubator-metron pull request: METRON-190: Make start_parser_topol...

2016-05-29 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/139#issuecomment-222363512 good catch, I'll make those changes now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-metron pull request: METRON-174 Storm consumption of hba...

2016-05-29 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/127#issuecomment-222364875 In order to validate this, you can do the following: * Configure a new parser, in this example I'll call it a `user` parser and we'll parse some CSV data

[GitHub] incubator-metron pull request: METRON-183 Allow the simple hbase e...

2016-05-29 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/131#issuecomment-222363326 As it stands, we have the docs for the configs with where the configurations live. I think you are absolutely right that we need to move them closer

[GitHub] incubator-metron pull request: METRON-189: Add the ability to do g...

2016-05-29 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/138#issuecomment-222363626 Yeah, the documentation situation is a bit incorrect. Documentation for configuration started to be placed where the configuration objects existed, rather

[GitHub] incubator-metron issue #167: METRON-246 metron_streaming role needs to expli...

2016-06-22 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/167 +1, looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron pull request #152: METRON-228: Fixing NPE when enrichment c...

2016-06-15 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/152 METRON-228: Fixing NPE when enrichment config does not exist. Because we are pulling the batch size from the enrichment sensor config, if it does not exist then it will throw a NPE. You

[GitHub] incubator-metron pull request #155: METRON-231: Snort parser should throw ex...

2016-06-16 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/155 METRON-231: Snort parser should throw exception Snort parser returns null when we should be throwing an exception in the event of an improperly formatted message. An exception

[GitHub] incubator-metron pull request #154: METRON-230: Bro parser should throw exce...

2016-06-16 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/154 METRON-230: Bro parser should throw exception Right now, if an invalid message comes to the bro parser, it returns null, which is interpreted as no messages from the parser. INstead, we

[GitHub] incubator-metron pull request #156: METRON-235 Expose filtering capability f...

2016-06-16 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/156#discussion_r67419245 --- Diff: metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/pcap/query/CliParser.java --- @@ -0,0 +1,83

[GitHub] incubator-metron pull request #156: METRON-235 Expose filtering capability f...

2016-06-16 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/156#discussion_r67420354 --- Diff: metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/pcap/query/QueryCliParser.java --- @@ -0,0 +1,57

[GitHub] incubator-metron pull request #156: METRON-235 Expose filtering capability f...

2016-06-16 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/156#discussion_r67420651 --- Diff: metron-platform/metron-pcap-backend/src/main/scripts/pcap_query.sh --- @@ -0,0 +1,34 @@ +#!/bin/bash +# +# Licensed

[GitHub] incubator-metron pull request #156: METRON-235 Expose filtering capability f...

2016-06-16 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/156#discussion_r67421199 --- Diff: metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/pcap/query/PcapCli.java --- @@ -0,0 +1,168

[GitHub] incubator-metron pull request #156: METRON-235 Expose filtering capability f...

2016-06-16 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/156#discussion_r67421145 --- Diff: metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/pcap/query/PcapCli.java --- @@ -0,0 +1,168

[GitHub] incubator-metron pull request #156: METRON-235 Expose filtering capability f...

2016-06-16 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/156#discussion_r67422356 --- Diff: metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/pcap/query/PcapCli.java --- @@ -0,0 +1,168

[GitHub] incubator-metron pull request #156: METRON-235 Expose filtering capability f...

2016-06-16 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/156#discussion_r67420022 --- Diff: metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/pcap/query/PcapCli.java --- @@ -0,0 +1,168

[GitHub] incubator-metron pull request #156: METRON-235 Expose filtering capability f...

2016-06-16 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/156#discussion_r67420179 --- Diff: metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/pcap/query/PcapCli.java --- @@ -0,0 +1,168

[GitHub] incubator-metron pull request #156: METRON-235 Expose filtering capability f...

2016-06-16 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/156#discussion_r67421802 --- Diff: metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/pcap/query/CliParser.java --- @@ -0,0 +1,83

[GitHub] incubator-metron pull request #156: METRON-235 Expose filtering capability f...

2016-06-16 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/156#discussion_r67424320 --- Diff: metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/pcap/query/FixedCliParser.java --- @@ -0,0 +1,66

[GitHub] incubator-metron pull request #156: METRON-235 Expose filtering capability f...

2016-06-16 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/156#discussion_r67422117 --- Diff: metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/pcap/query/CliParser.java --- @@ -0,0 +1,83

[GitHub] incubator-metron issue #159: METRON-237 Remove metron-ui from the code base

2016-06-17 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/159 If we're going to remove metron-ui, which I completely support btw, we are going to need to trim down the sections in the LICENSE around metron-ui components. --- If your project

[GitHub] incubator-metron pull request #156: METRON-235 Expose filtering capability f...

2016-06-17 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/156#discussion_r67512583 --- Diff: metron-platform/metron-pcap-backend/src/test/java/org/apache/metron/pcap/query/PcapCliTest.java --- @@ -0,0 +1,275

[GitHub] incubator-metron pull request #160: METRON-233: Expose Kafka producer and co...

2016-06-17 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/160 METRON-233: Expose Kafka producer and consumer configs for parser topologies We need the ability to tune KafkaSpout and KafkaWriter properties in a more granular way. Currently we do

[GitHub] incubator-metron pull request #162: METRON-239: NOOP Bulk Message Writer

2016-06-20 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/162 METRON-239: NOOP Bulk Message Writer We should have a NOOP Writer that will sleep at random. This will help differentiate write slowdowns between index misconfiguration and storm/kafka

[GitHub] incubator-metron issue #164: METRON-244 Added Documentation

2016-06-21 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/164 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-metron issue #156: METRON-235 Expose filtering capability for PCAP...

2016-06-17 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/156 +1 from me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-metron pull request #170: METRON-253: Reloading parser configurati...

2016-06-22 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/170 METRON-253: Reloading parser configurations from zookeeper doesn't call init() This results in a NPE if you do not specify an output column (this output column gets inferred as part

[GitHub] incubator-metron issue #161: Develop

2016-06-20 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/161 So, a couple of things. Please refactor this into separate PRs associated with JIRAs. As of now, it's just impossible to review and we don't really know what we're getting. It looks

[GitHub] incubator-metron issue #158: METRON-219 Create Default Metron Dashboard for ...

2016-06-20 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/158 got my +1 after that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron issue #163: METRON-241: Update revision from 0.1BETA to 0.2...

2016-06-20 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/163 This worked on `quick-dev-platform`. Data from the default sensors made it to the new kibana dashboard. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-metron issue #142: METRON-204: Field Transformation Domain Specifi...

2016-06-16 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/142 I have modified the squid parser to use the MTL transformer to extract the subdomain-less hostname rather than using grok. So, in order to test this, you should be able to * create

[GitHub] incubator-metron pull request #172: METRON-255: Expose the IPProtocolTransfo...

2016-06-23 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/172 METRON-255: Expose the IPProtocolTransformer as a function in the Stellar query language We have a TransformationFunction to map IANA protocol numbers to normalized strings. This should

[GitHub] incubator-metron issue #169: METRON-252 Metron Dashboard Can Be Broken By Ad...

2016-06-23 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/169 +1, spun up in vagrant --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron issue #175: METRON-243 Ensure templates are installed on al...

2016-06-24 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/175 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-metron pull request #173: METRON-256: Make the PCap values returne...

2016-06-23 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/173 METRON-256: Make the PCap values returned ordered by timestamp Right now we are not specifying the partitioner for the MR job to filter PCaps as part of PCap retrieval, so we are getting

[GitHub] incubator-metron issue #159: METRON-237 Remove metron-ui from the code base

2016-06-17 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/159 +1, looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron pull request #156: METRON-235 Expose filtering capability f...

2016-06-17 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/156#discussion_r67512176 --- Diff: metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/pcap/query/PcapCli.java --- @@ -0,0 +1,168

[GitHub] incubator-metron pull request #171: METRON-254 pcap inspector emits fields t...

2016-06-23 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/171 METRON-254 pcap inspector emits fields that are named based on the enum, rather than the standardized field names PcapInspector utility prints field names that are enum names (i.e

[GitHub] incubator-metron pull request: [METRON-25] Create Bro Plugin to Se...

2016-02-04 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/17#issuecomment-180045345 I like the bro plugin solution. The one comment I have is for bro-plugin-kafka/scripts/init.bro Is there a way to pull the kafka broker list and topic name

[GitHub] incubator-metron pull request: METRON-35 Implement threat intellig...

2016-02-13 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/22#issuecomment-183747542 Of course, I have attached a design doc to the [JIRA](https://issues.apache.org/jira/browse/METRON-35) . This is really a single feature as leaving

[GitHub] incubator-metron pull request: METRON-35 Implement threat intellig...

2016-02-12 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/22#issuecomment-183613907 I want to point out a couple of other things this PR provides that aren't strictly associated with the feature above, but are general cleanup tasks

[GitHub] incubator-metron pull request: METRON-35 Implement threat intellig...

2016-02-12 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/22 METRON-35 Implement threat intelligence message enrichment Create the infrastructure to * Bulk ingest threat intelligence feeds from CSV and Stix data sources into HBase * Enrich

[GitHub] incubator-metron pull request: Metron 22 Adding back the HBase bol...

2016-02-01 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/16 Metron 22 Adding back the HBase bolt to the pcap topology In addition to adding the hbase bolt back into the pcap topology, the beginnings of an integration test framework was created

[GitHub] incubator-metron pull request: METRON-50 Ingest threat intel data ...

2016-02-24 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/29 METRON-50 Ingest threat intel data from Taxii feeds Ingest Taxii threat intel feeds via a polling service that will write into HBase as an companion to the BulkLoadThreatIntel job. You

[GitHub] incubator-metron pull request: Configure Cobertura plugin to produ...

2016-02-16 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/21#issuecomment-184820606 This looks good. Can you create a JIRA for it and I'll merge it. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-metron pull request: METRON-37: Configure Cobertura Plug...

2016-02-16 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/23#issuecomment-184857855 As promised, +1 to this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-metron pull request: METRON-59 Automated Deployment of M...

2016-03-09 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/41#issuecomment-194475475 Ok +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron pull request: Metron 98 - Travis does not fail a ...

2016-04-07 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/69#issuecomment-206891621 +1 and I'm itching to get travis back and in working order. Just for posterity, the integration tests were failing and not reporting the failure back up

[GitHub] incubator-metron pull request: METRON-95: Create data purging scri...

2016-04-08 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/70#issuecomment-207453329 I looked at it. Looks good to me. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-metron pull request: METRON-93: Generalize the HBase thr...

2016-04-06 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/66#discussion_r58729427 --- Diff: metron-streaming/Metron-Common/pom.xml --- @@ -34,8 +34,11 @@ Metron Kraken Repository https

[GitHub] incubator-metron pull request: METRON-108 Created fast packet capt...

2016-04-11 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/73#issuecomment-208532061 It's unfortunate that we are unable to get this to work with singlenode vagrant. In lieu of that, can we have at least a utility and some sample data

[GitHub] incubator-metron pull request: METRON-108 Created fast packet capt...

2016-04-11 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/73#issuecomment-208544467 So, since this touches the ansible stuff, could we please get someone else to verify that singlenode vagrant isn't broken in a too-subtle-for-me-to-detect way

[GitHub] incubator-metron pull request: METRON-108 Created fast packet capt...

2016-04-11 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/73#issuecomment-208532922 Got it, makes sense. This looks great, btw. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-metron pull request: METRON-70 Create service wrapper fo...

2016-03-19 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/47#issuecomment-197539298 This looks good to me, but I'm going to defer to @merrimanr to give it a second glance since he's in that code right now. --- If your project is set up

[GitHub] incubator-metron pull request: METRON-57 Added Snort Community rul...

2016-03-08 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/34#issuecomment-193823068 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-metron pull request: METRON-60 Created service managemen...

2016-03-08 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/37#issuecomment-193815074 Looks like deployment/roles/snort/files/snortrules-snapshot-2962.tar.gz is giving an apache-rat license violation. Can you fix and update? --- If your

[GitHub] incubator-metron pull request: METRON-62 Add writing to enriched d...

2016-03-08 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/39 METRON-62 Add writing to enriched data back to the enrichment topology When we rearchitected the topologies to use flux, we never added back in the HDFS writing. This needs to be done

[GitHub] incubator-metron pull request: METRON-58: Remediate Deployment Int...

2016-03-07 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/36#issuecomment-193502076 Ok +1 from me :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-metron pull request: Metron-56 Create unified enrichment...

2016-03-01 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/33#issuecomment-190815542 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-metron pull request: METRON-61: Allow selection of topol...

2016-03-08 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/38#issuecomment-193971678 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-metron pull request: Metron 86 - SolrWriter

2016-04-01 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/67#discussion_r58221773 --- Diff: metron-streaming/Metron-Solr/src/main/java/org/apache/metron/writer/solr/MetronSolrClient.java --- @@ -0,0 +1,83

[GitHub] incubator-metron pull request: Metron 86 - SolrWriter

2016-04-01 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/67#discussion_r58223216 --- Diff: metron-streaming/Metron-Common/src/main/java/org/apache/metron/bolt/ConfiguredBolt.java --- @@ -77,15 +82,37 @@ public void childEvent

[GitHub] incubator-metron pull request: Metron 86 - SolrWriter

2016-04-01 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/67#discussion_r58221656 --- Diff: metron-streaming/Metron-Solr/src/main/java/org/apache/metron/writer/solr/MetronSolrClient.java --- @@ -0,0 +1,83

[GitHub] incubator-metron pull request: Metron 86 - SolrWriter

2016-04-01 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/67#discussion_r58223047 --- Diff: deployment/inventory/multinode-vagrant/group_vars/all --- @@ -49,17 +49,23 @@ snort_version: "2.9.8.0-1" snort_alert_csv_p

[GitHub] incubator-metron pull request: Metron 86 - SolrWriter

2016-04-01 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/67#discussion_r58223640 --- Diff: metron-streaming/Metron-Elasticsearch/pom.xml --- @@ -0,0 +1,202 @@ + + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi

[GitHub] incubator-metron pull request: Metron 86 - SolrWriter

2016-04-01 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/67#discussion_r58221412 --- Diff: metron-streaming/Metron-Solr/src/main/java/org/apache/metron/writer/solr/MetronSolrClient.java --- @@ -0,0 +1,83

[GitHub] incubator-metron pull request: METRON-93: Generalize the HBase thr...

2016-04-04 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/66#discussion_r58375098 --- Diff: metron-streaming/Metron-Common/src/test/java/org/apache/metron/enrichment/EnrichmentConfigTest.java --- @@ -0,0 +1,253 @@ +package

[GitHub] incubator-metron pull request: METRON-95: Create data purging scri...

2016-04-04 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/68#discussion_r58473310 --- Diff: deployment/roles/metron_streaming/defaults/main.yml --- @@ -34,3 +39,6 @@ storm_topologies: - "{{ metron_directory }}/c

[GitHub] incubator-metron pull request: Updating missing licenses from metr...

2016-03-30 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/64#issuecomment-203428699 * Removed extraneous LICENSE files and COPYING files * Fixed the verbiage for the cisco contribution in the LICENSE file * Added link to the license

[GitHub] incubator-metron pull request: METRON-93: Generalize the HBase thr...

2016-04-04 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/66#discussion_r58468314 --- Diff: metron-streaming/Metron-Common/src/test/java/org/apache/metron/enrichment/EnrichmentConfigTest.java --- @@ -0,0 +1,253 @@ +package

[GitHub] incubator-metron pull request: METRON-95: Create data purging scri...

2016-04-04 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/68#discussion_r58468994 --- Diff: deployment/roles/metron_streaming/defaults/main.yml --- @@ -34,3 +39,6 @@ storm_topologies: - "{{ metron_directory }}/c

[GitHub] incubator-metron pull request: METRON-95: Create data purging scri...

2016-04-04 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/68#discussion_r58469110 --- Diff: metron-streaming/Metron-DataLoads/pom.xml --- @@ -149,7 +149,12 @@ ${project.parent.version} test

[GitHub] incubator-metron pull request: Updating missing licenses from metr...

2016-03-29 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/64 Updating missing licenses from metron-ui. This is required for the apache release You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-metron pull request: METRON-119 Move PCAP infrastructure...

2016-04-29 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/93#issuecomment-215694256 @dlyle65535 Definitely agreed, I'll submit a change this morning to remove the warnings. --- If your project is set up for it, you can reply to this email

[GitHub] incubator-metron pull request: METRON-119 Move PCAP infrastructure...

2016-04-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/93#discussion_r61566951 --- Diff: metron-deployment/roles/metron_streaming/tasks/metron_topology.yml --- @@ -16,18 +16,14 @@ # --- - name: Submit Metron

  1   2   3   4   5   6   7   8   9   10   >