[GitHub] incubator-metron pull request #418: METRON-666 Fix javadoc doclint errors

2017-01-17 Thread mattf-horton
GitHub user mattf-horton opened a pull request: https://github.com/apache/incubator-metron/pull/418 METRON-666 Fix javadoc doclint errors Fixes for Java 8 javadocs automatic doclint problems: - replaced many uses of `` and `` with simple uses of `` - wrapped uses of `<`

[GitHub] incubator-metron pull request #418: METRON-666 Fix javadoc doclint errors

2017-01-17 Thread mattf-horton
Github user mattf-horton closed the pull request at: https://github.com/apache/incubator-metron/pull/418 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-metron pull request #418: METRON-666 Fix javadoc doclint errors

2017-01-17 Thread mattf-horton
GitHub user mattf-horton reopened a pull request: https://github.com/apache/incubator-metron/pull/418 METRON-666 Fix javadoc doclint errors Fixes for Java 8 javadocs automatic doclint problems: - replaced many uses of `` and `` with simple uses of `` - wrapped uses of `<`

[GitHub] incubator-metron issue #418: METRON-666 Fix javadoc doclint errors

2017-01-17 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/418 Kicking Travis. Bad Travis! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-metron issue #399: METRON-600: Fix Metron Website

2017-01-18 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/399 Yes, +1. I tested the links used, they work, and are in the right domains. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-metron issue #418: METRON-666 Fix javadoc doclint errors

2017-01-18 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/418 Travis is back to normal. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-metron issue #408: METRON-608 Mpack to install a single-node test ...

2017-01-23 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/408 @JonZeolla , I'm not sure I follow the doc statement, since the issue is not installing two MySQL instances on the same server, but rather sharing the same MySQL instance betwee

[GitHub] incubator-metron issue #408: METRON-608 Mpack to install a single-node test ...

2017-01-24 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/408 Hi @dlyle65535 , from a design perspective, I totally agree that we should have a single MPack that works on any size cluster, and I hope to replace both the 4(+)-node and single-node

[GitHub] incubator-metron issue #408: METRON-608 Mpack to install a single-node test ...

2017-01-25 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/408 @JonZeolla , I removed the obsolete comments about MySQL installation in Mpack. Thanks for the suggestion. --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-metron issue #418: METRON-666 Fix javadoc doclint errors

2017-01-25 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/418 Do we need any changes, to commit these modest fixes to javadoc comments? I'd like to experiment with adding javadocs to the doc site. Thanks. --- If your project is set up f

[GitHub] incubator-metron issue #408: METRON-608 Mpack to install a single-node test ...

2017-01-25 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/408 @dlyle65535 , I'll be happy to share my wip. It will take me a few hours to brush it off, then I'll post it as a PR referring to [METRON-609](https://issues.apache.org/j

[GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

2017-01-25 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/405 Let's do this, but need to also fix the other three places in this file where '{}' is used with format method. --- If your project is set up for it, you can reply to

[GitHub] incubator-metron pull request #425: METRON 609 Enhance Mpack to handle singl...

2017-01-26 Thread mattf-horton
GitHub user mattf-horton opened a pull request: https://github.com/apache/incubator-metron/pull/425 METRON 609 Enhance Mpack to handle single-node and small-cluster installs of Elasticsearch This PR is not ready for prime time, but is provided for ease of access to work-in

[GitHub] incubator-metron issue #408: METRON-608 Mpack to install a single-node test ...

2017-01-26 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/408 @dlyle65535 , please see https://github.com/apache/incubator-metron/pull/425 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-metron issue #425: METRON 609 Enhance Mpack to handle single-node ...

2017-01-26 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/425 Thanks, @dlyle65535 . Couple more comments: - Also included is the small change proposed in METRON-641 to use {0} instead of {} in python format strings in kibana_master.py

[GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

2017-01-26 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/405 > I'd like @DimDroll to get the deserved credit Exactly, @DimDroll please spin a quick update. --- If your project is set up for it, you can reply to this email and h

[GitHub] incubator-metron issue #423: METRON-270: Add Zeppelin to the platform

2017-01-26 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/423 @nickwallen , glad you got it working. Just BTW, the [wiki page](https://cwiki.apache.org/confluence/display/METRON/Metron+with+HDP+2.5+bare-metal+install) recently posted by Dima

[GitHub] incubator-metron issue #425: METRON 609 Enhance Mpack to handle single-node ...

2017-01-26 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/425 @dlyle65535 , makes sense to me. METRON-671 is very important for rationalizing our install scenarios, and clearly these fixes can be pipelined as you describe. I'm super

[GitHub] incubator-metron issue #425: METRON 609 Enhance Mpack to handle single-node ...

2017-01-26 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/425 @dlyle65535 , I see that changes necessary to single-node, in slave.py and elastic_slave.py, were in my METRON-634 commit rather than the METRON-609 commit. Sorry for the oversight

[GitHub] incubator-metron pull request #429: METRON-660 [Umbrella] up-to-date version...

2017-01-29 Thread mattf-horton
GitHub user mattf-horton opened a pull request: https://github.com/apache/incubator-metron/pull/429 METRON-660 [Umbrella] up-to-date versioned documentation This has come out rather well, I think. The integration is still open to discussion. Currently it is in a stand-alone

[GitHub] incubator-metron pull request #429: METRON-660 [Umbrella] up-to-date version...

2017-01-30 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/429#discussion_r98521687 --- Diff: site-book/src/site/site.xml --- @@ -0,0 +1,124 @@ + + +http://maven.apache.org/DECORATION/1.3.0"; --- End

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-01-30 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 @justinleet and @JonZeolla , the issues you are describing with bullets and codeblocks sound like things I worked hard to fix, and they work on my system. Please see new screenshot

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-01-30 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 @JonZeolla , interesting. That would be equivalent to gawk version 3.1.5 or 3.1.6. I see now that my updated awk is from a homebrew installation. Would you be willing to

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-01-30 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 Guys, to make it easier to distinguish between tool problems vs content bugs, I've uploaded a tarball of the full site-book as built on my platform, at [site-book_0.3.0_201

[GitHub] incubator-metron pull request #429: METRON-660 [Umbrella] up-to-date version...

2017-01-30 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/429#discussion_r98531347 --- Diff: site-book/src/site/site.xml --- @@ -0,0 +1,124 @@ + + +http://maven.apache.org/DECORATION/1.3.0"; --- End

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-01-30 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 @justinleet , yah, that's typical of what I called "paragraph munching". The triple-backtick delimiter is being consumed as text, then interpreted as an empty

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-01-30 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 @justinleet , hi, sorry our responses crossed. Looks like the old awk is rejecting the regex, probably the `[:blank:]` notation? So yah, need an updated awk. Is that an acceptable

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-01-30 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 @justinleet , No, the advanced awk features are heavily used. Well, I guess this is a good reason to convert to a python script after all. I'll give it whack. --- If your pr

[GitHub] incubator-metron pull request #429: METRON-660 [Umbrella] up-to-date version...

2017-01-31 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/429#discussion_r98739265 --- Diff: site-book/bin/generate-md.sh --- @@ -190,7 +190,13 @@ cd site-book/src/site/markdown # Rewrite hrefs for resource references

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-01-31 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 Okay, @JonZeolla , @justinleet , and others, the awk script has been replaced by a python script. The results of the dialect fix-up are identical to the awk script's results a

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-01-31 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 BTW, the instructions for use are unchanged, since the fix-up script is invoked from within the bin/generate-md.sh script. --- If your project is set up for it, you can reply to this

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-02-02 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 @justinleet thanks for the catch. Fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-02-03 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 Hi @JonZeolla , you have good eyes! I missed those cases, which are only visible where H1 headers have been used in the *body* of the document, AND there are TOC or other internal

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-02-03 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 @JonZeolla you pushed my perfectionist button :-) This latest push fixes the problem with anchors on H1 headers. The generated html is unchanged except for the insertion of anchor

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-02-03 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 @cestella , as Release Manager you can choose whether to accept this last commit (if @JonZeolla has time to review it) or just roll in the previous change set. I'm ok eithe

[GitHub] incubator-metron pull request #439: add stellar external functions feature (...

2017-02-04 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r99479152 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

[GitHub] incubator-metron pull request #439: add stellar external functions feature (...

2017-02-04 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r99479385 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

[GitHub] incubator-metron pull request #439: add stellar external functions feature (...

2017-02-04 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r99479325 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

[GitHub] incubator-metron pull request #439: add stellar external functions feature (...

2017-02-04 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r99479221 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

[GitHub] incubator-metron pull request #439: add stellar external functions feature (...

2017-02-04 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r99479068 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

[GitHub] incubator-metron pull request #439: add stellar external functions feature (...

2017-02-04 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r99479413 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

[GitHub] incubator-metron pull request #439: add stellar external functions feature (...

2017-02-05 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r99493097 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

[GitHub] incubator-metron pull request #442: METRON-322 Global Batching and Flushing

2017-02-05 Thread mattf-horton
GitHub user mattf-horton opened a pull request: https://github.com/apache/incubator-metron/pull/442 METRON-322 Global Batching and Flushing DO NOT INTEGRATE YET. This is a preliminary review request. This Jira Ticket is to add timeout flushing to all Writers that do batch

[GitHub] incubator-metron pull request #442: METRON-322 Global Batching and Flushing

2017-02-05 Thread mattf-horton
Github user mattf-horton closed the pull request at: https://github.com/apache/incubator-metron/pull/442 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-metron issue #442: METRON-322 Global Batching and Flushing

2017-02-05 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/442 I found a gap in my logic. Will re-open after fixing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-02-06 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 Thank you all for your efforts reviewing this. @cestella , I have rebased to master and re-validated. The only conflict was a trivial edit in one doc file. Per

[GitHub] incubator-metron issue #442: METRON-322 Global Batching and Flushing

2017-02-06 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/442 Gap fixed. (Added fix to decrease flush latency for most queues.) Please give preliminary review feedback, as requested in the PR Intro. --- If your project is set up for it

[GitHub] incubator-metron issue #443: METRON-703: Rev the version from 0.3.0 to 0.3.1

2017-02-07 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/443 Late, but: +1, verified version in site-book docs is "Version: 0.3.1" --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] incubator-metron issue #447: METRON-708: Update metron documentation

2017-02-10 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/447 +1 on the changes so far, by inspection. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron pull request #454: METRON-716 site-book README.md

2017-02-13 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/454#discussion_r100912086 --- Diff: site-book/README.md --- @@ -0,0 +1,51 @@ +# Site Book Metron documentation --- End diff -- Suggest "Metron

[GitHub] incubator-metron pull request #454: METRON-716 site-book README.md

2017-02-13 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/454#discussion_r100911935 --- Diff: site-book/README.md --- @@ -0,0 +1,51 @@ +# Site Book Metron documentation + +Metron's Site Book is an attem

[GitHub] incubator-metron pull request #454: METRON-716 site-book README.md

2017-02-13 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/454#discussion_r100910894 --- Diff: site-book/README.md --- @@ -0,0 +1,51 @@ +# Site Book Metron documentation + +Metron's Site Book is an attem

[GitHub] incubator-metron pull request #454: METRON-716 site-book README.md

2017-02-13 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/454#discussion_r100912944 --- Diff: site-book/README.md --- @@ -0,0 +1,51 @@ +# Site Book Metron documentation + +Metron's Site Book is an attem

[GitHub] incubator-metron pull request #454: METRON-716 site-book README.md

2017-02-13 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/454#discussion_r100938289 --- Diff: site-book/README.md --- @@ -0,0 +1,50 @@ +# Metron Site-Book documentation + +Metron's Site Book is an attem

[GitHub] incubator-metron pull request #451: METRON-157: Added CEF Parser

2017-02-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/451#discussion_r101203282 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/utils/DateUtils.java --- @@ -0,0 +1,78

[GitHub] incubator-metron issue #454: METRON-716 site-book README.md

2017-02-14 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/454 +1 More than okay! This is great, thanks for doing it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-metron pull request #455: METRON-720 modify generate-md.sh to re-t...

2017-02-15 Thread mattf-horton
GitHub user mattf-horton opened a pull request: https://github.com/apache/incubator-metron/pull/455 METRON-720 modify generate-md.sh to re-throw errors from within 'find' This patch also fixes, en passant: METRON-719 use of quadruple back-ticks in README.md file wh

[GitHub] incubator-metron issue #455: METRON-720 modify generate-md.sh to re-throw er...

2017-02-16 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/455 @JonZeolla , sorry traveling yesterday. Will look at it this evening. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-metron issue #455: METRON-720 modify generate-md.sh to re-throw er...

2017-02-16 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/455 @JonZeolla , thanks for the suggestions. Incorporated the SIG traps and better exit codes, as well as improvements to the 'find -exec' error catching logic. Also added &#

[GitHub] incubator-metron issue #455: METRON-720 modify generate-md.sh to re-throw er...

2017-02-17 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/455 Hi @JonZeolla , thanks for taking a look amidst the other demands on your time. I disagree with 'mv $fullpath/site.xml.bak $fullpath/site.xml' for the followi

[GitHub] incubator-metron issue #455: METRON-720 modify generate-md.sh to re-throw er...

2017-02-17 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/455 Hi @JonZeolla , @ottobackwards , @cestella , @mmiklavc , Thanks to all of you for looking at this. Taking issues in order: 1. Absolutely right, no reason to have site.xml.bak

[GitHub] incubator-metron issue #455: METRON-720 modify generate-md.sh to re-throw er...

2017-02-17 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/455 I have pushed fixes for all of the above. To fix item 3 I had to change history, so you'll need to "pull -f" to update an existing image. I tested cod

[GitHub] incubator-metron issue #455: METRON-720 modify generate-md.sh to re-throw er...

2017-02-17 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/455 I've tested it to completion on both Centos 6 and 7. It works and generates identical src and site file trees. I also tested the trap on SIGINT, which worked on all three plat

[GitHub] incubator-metron issue #455: METRON-720 modify generate-md.sh to re-throw er...

2017-02-20 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/455 I just checked, and this PR branch rebases to master without conflict, which I think means it will merge without conflict. If anyone would consider committing it, let me know if you

[GitHub] incubator-metron issue #406: METRON-642: Correted path to ES gc log file

2017-02-24 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/406 +1 This is a correct and badly needed fix. @DimDroll (Dima), thanks for progressing this. @dlyle65535 , note this is one of the fixes also suggested in PR#425, contributed for

[GitHub] incubator-metron issue #406: METRON-642: Correted path to ES gc log file

2017-02-24 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/406 @DimDroll , please note the title of this PR is different from the title of the Jira. That means comments here will *not* be correctly cc'ed to the Jira. Please edit the PR

[GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

2017-02-24 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/405 @DimDroll , here's what I did to find the answer to your question: * I went to github and found https://github.com/apache/incubator-metron/blob/master/metron-deployment/pack

[GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

2017-02-24 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/405 +1 on the fix btw. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron issue #406: METRON-642 Correct path to ES gc log file

2017-02-24 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/406 @DimDroll , yes, I just noticed in PR#405 that the comments were being correctly cc'ed to Jira even tho the title was different. Don't know. Maybe the received wisdom

[GitHub] incubator-metron issue #442: METRON-322 Global Batching and Flushing

2017-03-02 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/442 Rebased to current master -- which apparently scotches this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-metron pull request #470: METRON-752 Fix documentation typos and M...

2017-03-03 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/470#discussion_r104264703 --- Diff: metron-analytics/metron-profiler/README.md --- @@ -204,21 +204,21 @@ The Profiler runs as an independent Storm topology. The

[GitHub] incubator-metron pull request #470: METRON-752 Fix documentation typos and M...

2017-03-03 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/470#discussion_r104264231 --- Diff: metron-interface/metron-rest/README.md --- @@ -10,24 +10,24 @@ This module provides a RESTful API for interacting with Metron

[GitHub] incubator-metron pull request #470: METRON-752 Fix documentation typos and M...

2017-03-03 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/470#discussion_r104261688 --- Diff: metron-analytics/metron-profiler/README.md --- @@ -69,26 +69,27 @@ More information on configuring and using the client can be

[GitHub] incubator-metron pull request #470: METRON-752 Fix documentation typos and M...

2017-03-03 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/470#discussion_r104264200 --- Diff: metron-analytics/metron-profiler/README.md --- @@ -174,7 +175,6 @@ A required Stellar expression that results in a value that is

[GitHub] incubator-metron pull request #470: METRON-752 Fix documentation typos and M...

2017-03-03 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/470#discussion_r104264106 --- Diff: metron-interface/metron-rest/README.md --- @@ -131,11 +131,11 @@ Request and Response objects are JSON formatted. The JSON schemas

[GitHub] incubator-metron pull request #470: METRON-752 Fix documentation typos and M...

2017-03-03 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/470#discussion_r104261426 --- Diff: metron-analytics/metron-profiler/README.md --- @@ -69,26 +69,27 @@ More information on configuring and using the client can be

[GitHub] incubator-metron pull request #470: METRON-752 Fix documentation typos and M...

2017-03-03 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/470#discussion_r104275074 --- Diff: metron-interface/metron-rest/README.md --- @@ -131,11 +131,11 @@ Request and Response objects are JSON formatted. The JSON schemas

[GitHub] incubator-metron pull request #470: METRON-752 Fix documentation typos and M...

2017-03-03 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/470#discussion_r104275137 --- Diff: metron-analytics/metron-profiler/README.md --- @@ -69,26 +69,27 @@ More information on configuring and using the client can be

[GitHub] incubator-metron pull request #470: METRON-752 Fix documentation typos and M...

2017-03-03 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/470#discussion_r104275168 --- Diff: metron-analytics/metron-profiler/README.md --- @@ -174,7 +175,6 @@ A required Stellar expression that results in a value that is

[GitHub] incubator-metron pull request #470: METRON-752 Fix documentation typos and M...

2017-03-03 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/470#discussion_r104275196 --- Diff: metron-analytics/metron-profiler/README.md --- @@ -204,21 +204,21 @@ The Profiler runs as an independent Storm topology. The

[GitHub] incubator-metron issue #470: METRON-752 Fix documentation typos and MD issue...

2017-03-03 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/470 Umm, looks like your comments got duplicated into a second set. I only responded to the first set. Also, I've now sent you a PR for the link label fix-up. --- If your proje

[GitHub] incubator-metron issue #459: METRON-726: Clean up mvn site generation

2017-03-07 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/459 I've opened METRON-759 to track the need to get javadoc running nightly and integrate with the public site. Now that METRON-666 and METRON-725 are in 0.3.1, what remains to be

[GitHub] incubator-metron issue #459: METRON-726: Clean up mvn site generation

2017-03-08 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/459 @justinleet , +100 that you've added site-book and javadocs to the automated build. Having site-book in the base build is fine, it only takes seconds to build, and it will

[GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

2017-03-09 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/405 Would someone consider committing this PR? It's been open a while. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] incubator-metron pull request #476: METRON-764 DST bug in metron-profiler-cl...

2017-03-14 Thread mattf-horton
GitHub user mattf-horton opened a pull request: https://github.com/apache/incubator-metron/pull/476 METRON-764 DST bug in metron-profiler-client Unit Tests This is a Unit Test bug. Please see https://issues.apache.org/jira/browse/METRON-764 for detailed description and how to

[GitHub] incubator-metron pull request #481: METRON-322 Global Batching and Flushing

2017-03-16 Thread mattf-horton
GitHub user mattf-horton opened a pull request: https://github.com/apache/incubator-metron/pull/481 METRON-322 Global Batching and Flushing This patch starts by adding "batchTimeout" essentially every place "batchSize" is used. Since the configuration-rela

[GitHub] incubator-metron issue #482: METRON-791: Add links to website and downloads ...

2017-03-20 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/482 +1 by inspection. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron pull request #485: METRON-771 Stellar INDEXING_SET_BATCH in...

2017-03-20 Thread mattf-horton
GitHub user mattf-horton opened a pull request: https://github.com/apache/incubator-metron/pull/485 METRON-771 Stellar INDEXING_SET_BATCH incorrectly defaults batchSize to 5 Simple couple-line fix for the defaulting behavior. The only non-comment line is changing the default from

[GitHub] incubator-metron issue #481: METRON-322 Global Batching and Flushing

2017-03-21 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/481 @cestella , thanks for looking at this. The primary motivation for adding batchTimeout was to prevent tuple recycling due to "topology.message.timeout.secs". Thus,

[GitHub] incubator-metron pull request #481: METRON-322 Global Batching and Flushing

2017-03-23 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/481#discussion_r107779736 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/IndexingConfigurations.java --- @@ -73,7 +74,30

[GitHub] incubator-metron pull request #481: METRON-322 Global Batching and Flushing

2017-03-23 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/481#discussion_r107781590 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/bolt/BulkMessageWriterBolt.java --- @@ -92,22 +177,51

[GitHub] incubator-metron pull request #488: METRON-796: Mpack uses wrong group for o...

2017-03-24 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/488#discussion_r107957631 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params

[GitHub] incubator-metron issue #490: DO NOT MERGE METRON-797: Pass security.protocol...

2017-03-24 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/490 @cestella , In the Jira, please add the dependencies as blockers (at least METRON-793), and create (if it doesn't exist yet) the jira(s) for the needed follow-on work and link to

[GitHub] incubator-metron pull request #488: METRON-796: Mpack uses wrong group for o...

2017-03-24 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/488#discussion_r107964537 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params

[GitHub] incubator-metron issue #488: METRON-796: Mpack uses wrong group for owning H...

2017-03-24 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/488 Thanks. Looks okay to me now, for the intended purpose. +0 due to Simon's concerns; I'd prefer someone with more experience in Metron give you the plus one.

[GitHub] incubator-metron issue #490: DO NOT MERGE METRON-797: Pass security.protocol...

2017-03-24 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/490 Thanks, there didn't seem to be a jira for parsers, so I expanded the scope of METRON-798 and made bro it's first sub-task. --- If your project is set up for it, you ca

[GitHub] incubator-metron issue #488: METRON-796: Mpack uses wrong group for owning H...

2017-03-24 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/488 +1 then, thanks. Please expand METRON-349 to include these issues too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-metron pull request #492: Add mattf to committer list on site

2017-03-27 Thread mattf-horton
GitHub user mattf-horton opened a pull request: https://github.com/apache/incubator-metron/pull/492 Add mattf to committer list on site Trivial PR to add my name to the committer list on the site. No review needed. Thanks. You can merge this pull request into a Git repository

[GitHub] incubator-metron issue #497: METRON-804: Create a document to describe kerbe...

2017-03-29 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/497 @mmiklavc , Markdown requires you to indent a codeblock (beginning and ending triple back-ticks) if you wish it to be "under" a list item. Otherwise it interrupts the list,

[GitHub] incubator-metron pull request #502: METRON-814 minor tweaks in document form...

2017-03-31 Thread mattf-horton
GitHub user mattf-horton opened a pull request: https://github.com/apache/incubator-metron/pull/502 METRON-814 minor tweaks in document format of Kerberos-setup.md ## Contributor Comments Apparently github ate my latest comment on PR#497. Here's the fix that would have

  1   2   3   >