Re: [DISCUSS] Some SSHD refactoring before 2.0.0

2018-05-31 19:59 GMT+02:00 Lyor Goldstein : > >>> > I disagree with the characterization that they do not have a "real > concept > > behind them" they represent contracts of entities that have similar > > attributes. IMO, all the various *XxxHolder*(s) represent an entity that > > provides

Re: [DISCUSS] Some SSHD refactoring before 2.0.0

Le 01/06/2018 à 00:31, Guillaume Nodet a écrit : > But if the community want to pursue the 2.0.0 release as it is, that's fine > with me, I can restart a vote quickly, as I haven't deleted the staging > repository or tag yet. Regardless to the cancelation reasons, do you have any insight on

Re: [DISCUSS] Some SSHD refactoring before 2.0.0

I didn't really see the need to push out two releases which both contains incompatible changes in a short time frame. If people want the bug fixes that are currently on master, I think it would be better to create a 1.x support branch, backport those and release this branch quickly. And keep

Re: [DISCUSS] Some SSHD refactoring before 2.0.0

Push out the release as proposed in the cancelled vote. Then proceede to work on refactoring in a new branch. When the refactoring is completed, push another official release. This way the versions in maven will be clearly known as before and after the refactor when debugging issues. On Thu,

Re: [DISCUSS] Some SSHD refactoring before 2.0.0

You mean commit in a branch ? Not sure to understand what you mean ? 2018-05-31 23:29 GMT+02:00 Jonathan Valliere : > From a codebase stability perspective, maybe you should commit a version > number with the bug fixes. Then do the refactoring in its own version > number as to not confuse the

Re: [DISCUSS] Some SSHD refactoring before 2.0.0

>From a codebase stability perspective, maybe you should commit a version number with the bug fixes. Then do the refactoring in its own version number as to not confuse the two when trying to figure out if the refactoring broke something or if the previous bug fixes broke something? On Thu, May

REMINDER: Apache EU Roadshow 2018 in Berlin is less than 2 weeks away!

Hello Apache Supporters and Enthusiasts This is a reminder that our Apache EU Roadshow in Berlin is less than two weeks away and we need your help to spread the word. Please let your work colleagues, friends and anyone interested in any attending know about our Apache EU Roadshow event. We

Re: [DISCUSS] Some SSHD refactoring before 2.0.0

>>> > I disagree with the characterization that they do not have a "real concept > behind them" they represent contracts of entities that have similar > attributes. IMO, all the various *XxxHolder*(s) represent an entity that > provides whatever these "attribute" interfaces hold. >>> Well, I

Re: [DISCUSS] Some SSHD refactoring before 2.0.0

> >> remove a few interfaces which are not actually used, i.e. they've been > introduced because various classes have methods with similar signatures, > but there's no real concept behind > > I disagree with the characterization that they do not have a "real concept > behind them" they represent

Re: [DISCUSS] Some SSHD refactoring before 2.0.0

I have read the proposed changes and I agree in principle, although the suggested re-factoring feels a bit too extensive. >> remove a few interfaces which are not actually used, i.e. they've been introduced because various classes have methods with similar signatures, but there's no real concept

[DISCUSS] Some SSHD refactoring before 2.0.0

Following the discussion in SSHD-340 , I'd like to start refactoring a few internal things. - remove a few interfaces which are not actually used, i.e. they've been introduced because various classes have methods with similar signatures, but

Re: [CANCEL] [VOTE] Release Mina SSHD 2.0.0

I'll start a separate thread in a few minutes. 2018-05-31 16:16 GMT+02:00 Jared Armstrong : > What are you planning to refactor at this time? > > -- > Jared Armstrong > > > On Thu, May 31, 2018 at 9:46 AM, Guillaume Nodet > wrote: > > > I'm cancelling this vote. > > I'd like to do some

Re: [CANCEL] [VOTE] Release Mina SSHD 2.0.0

What are you planning to refactor at this time? -- Jared Armstrong On Thu, May 31, 2018 at 9:46 AM, Guillaume Nodet wrote: > I'm cancelling this vote. > I'd like to do some refactoring before a 2.0 is going out. > > 2018-05-28 17:12 GMT+02:00 Guillaume Nodet : > > > I've staged a release of

[CANCEL] [VOTE] Release Mina SSHD 2.0.0

I'm cancelling this vote. I'd like to do some refactoring before a 2.0 is going out. 2018-05-28 17:12 GMT+02:00 Guillaume Nodet : > I've staged a release of Mina SSHD 2.0.0 > https://repository.apache.org/content/repositories/orgapachemina-1035/ > > Changelog: > > ** Bug > * [SSHD-449] -

Re: [VOTE] Apache MINA 2.0.18

+1 2018-05-29 15:48 GMT+02:00 Emmanuel Lécharny : > Hi ! > > I'm calling for a vote of Apache MINA 2.0.18 release. There is nothing > critical in it, no big bug fixes, just a few annoying ones. Although > there is some important addition: The IoHandler interface now expose a > new method : > >