Re: Release Apache MINA SSHD 2.13.0?

2024-06-08 Thread Gary Gregory
Sounds  good to me. Gary On Sat, Jun 8, 2024, 2:56 PM Thomas Wolf wrote: > On 2024-06-08 20:48 , Thomas Wolf wrote: > > I suggest we start with a release for Apache MINA 2.13.0. > > Apache MINA SSHD, of course. > > Cheers, > >Thomas > > >

Re: [VOTE] Release Mina SSHD 2.12.1

2024-02-11 Thread Gary Gregory
STATUS PORTS > NAMES > 1d69e8b3f633 localhost/testcontainers/tx3g8n6fh63vansg:latest > "/usr/sbin/sshd -D -…" 2 seconds agoUp 2 seconds > 0.0.0.0:61124->22/tcp quizzical_lederberg > b3cfc446e8f4 testcontainers/ryuk:0.3.3 > >

Re: [VOTE] Release Mina SSHD 2.12.1

2024-02-10 Thread Gary Gregory
arting(GenericContainer.java:1066) at org.testcontainers.containers.FailureDetectingExternalResource$1.evaluate(FailureDetectingExternalResource.java:29) I must be missing some requirements. The 'docker' app is not on my PATH. Is it on yours? Can you say 'docker ps' for example? Gary On Sat, Feb

Re: [VOTE] Release Mina SSHD 2.12.1

2024-02-10 Thread Gary Gregory
Hi Emmanuel: Yes: Docker Desktop 4.27.1 (136059) Gary On Sat, Feb 10, 2024 at 11:25 AM Emmanuel Lécharny wrote: > > Hi Gary, > > I had it working on my Mac, have you docker running before launching the > test? > > On 10/02/2024 04:10, Gary Gregory wrote: > > Testing

Re: [VOTE] Release Mina SSHD 2.12.1

2024-02-09 Thread Gary Gregory
Testing src zip file. - ASC OK - Eyeballing SHA512 is OK but can't be checked with "shasum --check apache-sshd-2.12.1-src.zip.sha512" - On macOS, with Docker running, the tests can't find it or download an image, if that's what it is trying to do: [ERROR] Errors: [ERROR]

Re: [ANNOUNCE] Apache MINA SSHD 2.12.0 released

2024-01-18 Thread Gary Gregory
It usually takes 30 minutes. Gary On Thu, Jan 18, 2024, 6:08 PM Matthias Sohn wrote: > On Thu, Jan 18, 2024 at 11:21 AM Guillaume Nodet > wrote: > > > The Apache Mina PMC is proud to announce the release of Mina SSHD 2.12.0. > > > > This new minor release provides a bunch of bug enhancements

Re: [VOTE] Release Apache Mina SSHD 2.9.3

2023-10-17 Thread Gary Gregory
I think the CI should run ALL tests. It's for the developer in a hurry to disable some tests from the command line if they want to take the chance. Gary On Tue, Oct 17, 2023, 2:04 AM Guillaume Nodet wrote: > Le lun. 16 oct. 2023 à 22:02, Thomas Wolf a écrit : > > > On 16.10.23 01:04 ,

Re: [VOTE] Release Apache Mina SSHD 2.11.0

2023-10-15 Thread Gary Gregory
; https://mina.apache.org/mina-project/developer-guide.html#step-12-deploy-web-reports-javadoc-and-jxr > Am I missing something ? > > Guillaume > > Le sam. 14 oct. 2023 à 20:02, Gary Gregory a > écrit : > > > Hi Guillaume, > > > > Did you update the site gen

Re: [VOTE] Release Apache Mina SSHD 2.11.0

2023-10-14 Thread Gary Gregory
Hi Guillaume, Did you update the site generation as well? Gary On Sat, Oct 14, 2023, 12:48 PM Guillaume Nodet wrote: > Thx for pointing out the weird sha files. I've fixed them and removed the > sha256 ones. > > Guillaume > > > Le sam. 14 oct. 2023 à 17:13, Gary D. Gregory a > écrit : > >

Re: [VOTE] Apache MINA 2.2.3, 2.1.8 and 2.0.25 releases

2023-09-12 Thread Gary Gregory
I don't understand what Windows has to do with my question. What did you do to validate the release candidate before voting +1? Gary On Tue, Sep 12, 2023, 4:11 PM wrote: > I don’t use Windows. > > Jeff > > > > On Sep 12, 2023, at 10:11 AM, Gary Gregory > wrote: &g

Re: [VOTE] Apache MINA 2.2.3, 2.1.8 and 2.0.25 releases

2023-09-12 Thread Gary Gregory
You don't remember if you downloaded, built and reviewed all three src or tar files? Are you voting without reviewing? Gary On Tue, Sep 12, 2023, 9:55 AM wrote: > I don’t remember if I voted because I have been voting on a lot of stuff > lately. > > If I didn’t here is my +1 for all 3. > >

Re: [VOTE] Apache MINA 2.2.3, 2.1.8 and 2.0.25 releases

2023-09-12 Thread Gary Gregory
I only tested 2.2.3 RC 1 on Windows with Java 17. My other test runs where on macOS with Java 8. Gary On Tue, Sep 12, 2023, 4:29 AM Emmanuel Lécharny wrote: > Thanks Jeff & Gary. > > Is that for all the MINA versions? > > On 11/09/2023 16:27, Gary D. Gregory wrote: > > I can confirm a failure

Re: [VOTE] Apache MINA 2.2.3, 2.1.8 and 2.0.25 releases

2023-09-10 Thread Gary Gregory
Non-binding +1 for all three. Tested each src zip file with 'mvn clear verify' using: Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9) Maven home: /usr/local/Cellar/maven/3.9.4/libexec Java version: 1.8.0_382, vendor: Homebrew, runtime:

Re: Throwing RuntimeException is usually an anti-pattern

2023-07-04 Thread Gary Gregory
> > > And, yes, I do think we should thows some meaningful excection. > > > > On 04/07/2023 14:35, Jonathan Valliere wrote: > >> Make a PR > >> > >> On Mon, Jul 3, 2023 at 7:12 PM Gary Gregory > >> wrote: > >> > >>

Re: Throwing RuntimeException is usually an anti-pattern

2023-07-04 Thread Gary Gregory
On Tue, Jul 4, 2023 at 8:35 AM Jonathan Valliere wrote: > > Make a PR An order is not a thought. Gary > > On Mon, Jul 3, 2023 at 7:12 PM Gary Gregory wrote: >> >> Hi All, >> >> I noticed that in org.apache.ftpserver.util.EncryptUtils we explicitly >&g

Throwing RuntimeException is usually an anti-pattern

2023-07-03 Thread Gary Gregory
Hi All, I noticed that in org.apache.ftpserver.util.EncryptUtils we explicitly throw RuntimeException. This is usually an anti-pattern as IllegalArgumentException, IllegalStateException, and others are more descriptive. In the case of EncryptUtils, IllegalArgumentException seems more

Re: [FTP Server] Bumping deps

2023-07-03 Thread Gary Gregory
method to get the AUTH encrypting method (TLS or SSL), and to get the > TLS version to use. Thi was not playing well when you were setting the > getAuth() return to "TLSv1.2" for instance. I created another method for > that purpose, and that should work > > Bottom line, it's a

Branch 1.2.X does not compile?

2023-07-03 Thread Gary Gregory
Hi All: Did I check out the wrong branch or have bad tooling? Can anyone compile the 1.2.X branch? [INFO] - [ERROR] COMPILATION ERROR : [INFO] - [ERROR]

[FTP Server] Bumping deps

2023-07-03 Thread Gary Gregory
Hi All, As I was updating Apache Commons VFS' tests to use current versions of Mina libraries, I ran into an issue where FTP Server 1.2.0 is not using the current version of Mina Core (2.2.2). I have tests that use Core directly, but the FTP Server tests fail with a method missing exception. I

Re: [VOTE] Apache MINA 2.2.2, 2.1.7, 2.0.24 releases

2023-06-04 Thread Gary Gregory
Non-binding +1 on 2.2.2. SHA512, ASC OK, and 'mvn clean verify' builds OK on: pache Maven 3.9.2 (c9616018c7a021c1c39be70fb2843d6f5f9b8a1c) Maven home: /usr/local/Cellar/maven/3.9.2/libexec Java version: 1.8.0_372, vendor: Homebrew, runtime:

Re: [VOTE] Apache MINA 2.2.2, 2.1.7, 2.0.24 releases

2023-06-04 Thread Gary Gregory
Hi, In the future, it would be convenient if the VOTE email contained a URL to the project's PGP/GPG KEYS file. Gary On Thu, Jun 1, 2023 at 6:58 PM Emmanuel Lécharny wrote: > hi! > > WARNING: there are 3 votes to cast! > > > This is a vote for a triple release: > * MINA 2.2.2 > * MINA 2.1.7 >

Re: [VOTE] Apache MINA 2.2.2, 2.1.7, 2.0.24 releases

2023-06-03 Thread Gary Gregory
In the future, it seems to me like we only need sha512 files, not both 512 and 256. Less clutter IMO. Gary On Thu, Jun 1, 2023, 18:58 Emmanuel Lécharny wrote: > hi! > > WARNING: there are 3 votes to cast! > > > This is a vote for a triple release: > * MINA 2.2.2 > * MINA 2.1.7 > * MINA 2.0.24

Default branch is still master

2022-04-12 Thread Gary Gregory
Hi all, It would be nice is someone with the right karma would make 1.2.x the default branch instead of master, at least on GitHub. TY, Gary

Re: GitHub Action builds

2022-04-11 Thread Gary Gregory
Hm, if I make a BC check as part of the enforce profile, I'll have to fix Checkstyle errors. There are a lot, simple, but quite a few. Do we want that? Gary On Mon, Apr 11, 2022, 14:15 Gary Gregory wrote: > YW. As I mentioned at some point in the past, I will add support for > checking

Re: GitHub Action builds

2022-04-11 Thread Gary Gregory
: > Super, thanks Gregory ! > > On 11/04/2022 15:57, Gary Gregory wrote: > > Hi All: > > > > I enabled GitHub Actions builds which will give us quick feedback on PRs > as > > well as sanity checks for building and testing on Java LTS versions. > > >

GitHub Action builds

2022-04-11 Thread Gary Gregory
Hi All: I enabled GitHub Actions builds which will give us quick feedback on PRs as well as sanity checks for building and testing on Java LTS versions. See https://github.com/apache/mina-ftpserver/actions Gary

Re: Welcome Gary Gregory as a new MINA committer !

2022-03-24 Thread Gary Gregory
Thank you Emmanuel! Gary On Thu, Mar 24, 2022, 08:40 Emmanuel Lécharny wrote: > Hi Gary, > > we are pleased to inform you that you have been granted commit access to > the MINA project. > > FTR, Gary is a long time Apache member (back to 2008 AFAIR), and is > active on commons, loogins and

Re: [mina] 02/02: o Renamed SSLxxx classes to Sslxxx to keep an ascendant compatibility o Used meaningful variable nales o Removed useless 'this' o Removed useless 'final' o Transmitted the nexwt filt

2022-03-15 Thread Gary Gregory
this commit is moving back to the previous names, > exactly for the reason you mention... > > So I guess you will approve this comit :-) > > On 15/03/2022 14:41, Gary Gregory wrote: > > You can't rename public or protected classes/types/methods without > breaking > > existi

Re: [mina] 02/02: o Renamed SSLxxx classes to Sslxxx to keep an ascendant compatibility o Used meaningful variable nales o Removed useless 'this' o Removed useless 'final' o Transmitted the nexwt filt

2022-03-15 Thread Gary Gregory
You can't rename public or protected classes/types/methods without breaking existing applications! Gary Gary On Tue, Mar 15, 2022, 09:31 wrote: > This is an automated email from the ASF dual-hosted git repository. > > elecharny pushed a commit to branch 2.2.X > in repository

[jira] [Created] (FTPSERVER-437) NoSuchMethodError when using FtpServer 1.0.6 with SshD 0.8.0 because of dependency on different mina-core versions.

2012-10-29 Thread Gary Gregory (JIRA)
Gary Gregory created FTPSERVER-437: -- Summary: NoSuchMethodError when using FtpServer 1.0.6 with SshD 0.8.0 because of dependency on different mina-core versions. Key: FTPSERVER-437 URL: https://issues.apache.org