[GitHub] [mina-sshd] lgoldstein commented on issue #120: Increase log level to error for scp error logs

2020-04-12 Thread GitBox
lgoldstein commented on issue #120: Increase log level to error for scp error logs URL: https://github.com/apache/mina-sshd/pull/120#issuecomment-612639877 Merged - see commit [4320886b19c8385ac017945d708680fad9c46f04](https://github.com/apache/mina-sshd/commit/4320886b19c8385ac017945d7086

[GitHub] [mina-sshd] lgoldstein commented on issue #120: Increase log level to error for scp error logs

2020-04-12 Thread GitBox
lgoldstein commented on issue #120: Increase log level to error for scp error logs URL: https://github.com/apache/mina-sshd/pull/120#issuecomment-612637864 I can live with this... will merge soon This is an automated message

[GitHub] [mina-sshd] lgoldstein commented on issue #120: Increase log level to error for scp error logs

2020-04-12 Thread GitBox
lgoldstein commented on issue #120: Increase log level to error for scp error logs URL: https://github.com/apache/mina-sshd/pull/120#issuecomment-612575529 I have been considering perhaps using a dedicated logger for exceptions where in addition to logging as we currently do we also invoke

[GitHub] [mina-sshd] lgoldstein commented on issue #120: Increase log level to error for scp error logs

2020-04-12 Thread GitBox
lgoldstein commented on issue #120: Increase log level to error for scp error logs URL: https://github.com/apache/mina-sshd/pull/120#issuecomment-612574982 I am not sure I understand exactly how this would work - however, my main concern is not specifically with this code but rather our ov

[GitHub] [mina-sshd] lgoldstein commented on issue #120: Increase log level to error for scp error logs

2020-04-11 Thread GitBox
lgoldstein commented on issue #120: Increase log level to error for scp error logs URL: https://github.com/apache/mina-sshd/pull/120#issuecomment-612490266 >> There are cases where scp fails from different set of servers which is very hard to debug. And making the error log trace creates l

[GitHub] [mina-sshd] lgoldstein commented on issue #120: Increase log level to error for scp error logs

2020-04-11 Thread GitBox
lgoldstein commented on issue #120: Increase log level to error for scp error logs URL: https://github.com/apache/mina-sshd/pull/120#issuecomment-612432731 While I understand that it may solve some specific problem you are having and perhaps the advantages of such a change, this change is