Re: Black/White List in FTP Server

2010-03-18 Thread Sai Pullabhotla
Attached is the alpha release ;) for the black/white lists for your review. This patch is created from the trunk. I briefly tested this as a stand-alone server using spring config as well as programmatically configuring the server with a custom IP Filter. I updated the spring config/parser to

Re: Black/White List in FTP Server

2010-03-18 Thread Niklas Gustavsson
On Thu, Mar 18, 2010 at 7:20 PM, Sai Pullabhotla sai.pullabho...@jmethods.com wrote: Attached is the alpha release ;) for the black/white lists for your review. Create a JIRA issue and attach it there. Mailing lists strip attachments :-) /niklas

Re: Black/White List in FTP Server

2010-03-18 Thread Sai Pullabhotla
Done. Regards, Sai Pullabhotla On Thu, Mar 18, 2010 at 1:32 PM, Niklas Gustavsson nik...@protocol7.com wrote: On Thu, Mar 18, 2010 at 7:20 PM, Sai Pullabhotla sai.pullabho...@jmethods.com wrote: Attached is the alpha release ;) for the black/white lists for your review. Create a JIRA

Re: Black/White List in FTP Server

2010-03-16 Thread Niklas Gustavsson
On Tue, Mar 16, 2010 at 5:19 AM, Ashish paliwalash...@gmail.com wrote: Is this IoListener or something specific to FtpServer? AFAIK, our filters are part of chain and get applied at session level. Yes, listeners are part of the FtpServer API and basically maps 1:1 to an IoAcceptor. One

Re: Black/White List in FTP Server

2010-03-16 Thread Niklas Gustavsson
On Mon, Mar 15, 2010 at 7:27 PM, Sai Pullabhotla sai.pullabho...@jmethods.com wrote: I've been trying to implement white/black lists in FTP server and thought of running my findings/ideas with you guys. +1 to all you say. I think we should aim to land this work in MINA 3.0. /niklas

Re: Black/White List in FTP Server

2010-03-16 Thread Sai Pullabhotla
Does this mean you want to wait until Mina 3.0, or should we start working on the FTP Server right away and share relevant code with MINA? Regards, Sai Pullabhotla On Tue, Mar 16, 2010 at 1:13 AM, Niklas Gustavsson nik...@protocol7.com wrote: On Mon, Mar 15, 2010 at 7:27 PM, Sai Pullabhotla

Re: Black/White List in FTP Server

2010-03-16 Thread Niklas Gustavsson
On Tue, Mar 16, 2010 at 1:05 PM, Sai Pullabhotla sai.pullabho...@jmethods.com wrote: Does this mean you want to wait until Mina 3.0, or should we start working on the FTP Server right away and share relevant code with MINA? I think we can start right away and copy the code upstream until we

Re: Black/White List in FTP Server

2010-03-16 Thread Sai Pullabhotla
Cool, I will see what I can do. I was also looking at other ways to implement this feature and looks like one should be able to make use of an Ftplet and capture the onConnect event to determine if the connection should be allowed or not. I did some quick tests and found the following: Plain

Re: Black/White List in FTP Server

2010-03-16 Thread Niklas Gustavsson
On Tue, Mar 16, 2010 at 1:29 PM, Sai Pullabhotla sai.pullabho...@jmethods.com wrote: However, with FTPS (Implicit), the SSL negotiation is initiated prior to sending the onConnect event to the Ftplets. To be precise, the client does get the server's certificate before onConnect is called. I

Re: Black/White List in FTP Server

2010-03-16 Thread Sai Pullabhotla
I would not disagree that the IP restrictions should be handled by the filters, but at the same time. I was just looking for other ways that can be used when the filters do not provide the functionality the user wants. I do See that MINA propagates two different events - 1. session opened 2.

Re: Black/White List in FTP Server

2010-03-16 Thread Niklas Gustavsson
On Tue, Mar 16, 2010 at 2:24 PM, Sai Pullabhotla sai.pullabho...@jmethods.com wrote: Currently, we call the Ftplet.onConnect from the sessionOpened method. May be we should add yet another method to the Ftplets to indicate a sessionCreated event, in case if some one wants to use it? If I

Re: Black/White List in FTP Server

2010-03-16 Thread Niklas Gustavsson
On Tue, Mar 16, 2010 at 2:52 PM, Sai Pullabhotla sai.pullabho...@jmethods.com wrote: If a filter can make use of this event, why not an Ftplet? To me, because writing your own Ftplet should require minimal knowledge of the internals of FtpServer. Compare this to writing a Servlet and your own

Re: Black/White List in FTP Server

2010-03-16 Thread David Latorre
2010/3/16 Niklas Gustavsson nik...@protocol7.com: On Tue, Mar 16, 2010 at 2:52 PM, Sai Pullabhotla sai.pullabho...@jmethods.com wrote: If a filter can make use of this event, why not an Ftplet? To me, because writing your own Ftplet should require minimal knowledge of the internals of

Black/White List in FTP Server

2010-03-15 Thread Sai Pullabhotla
I've been trying to implement white/black lists in FTP server and thought of running my findings/ideas with you guys. Currently, each listener can have a black list. There is NO white listing capability. I've been thinking, instead of having the black list IPs/Subnets, simply have an interface

Re: Black/White List in FTP Server

2010-03-15 Thread Ashish
On Mon, Mar 15, 2010 at 11:57 PM, Sai Pullabhotla sai.pullabho...@jmethods.com wrote: I've been trying to implement white/black lists in FTP server and thought of running my findings/ideas with you guys. Currently, each listener can have a black list. There is NO white listing capability. Is