Re: svn commit: r928769

2010-04-01 Thread Sai Pullabhotla
I've imported this formatter, but this does not auto-format the Java Docs. So, if I type a long line for a method comment, and format just the method or the entire class, the comments/java docs are not affected. Is it okay to enable the formatting on Javadocs and wrap the lines at 80 just like the

Re: svn commit: r928769

2010-04-01 Thread Emmanuel Lecharny
On 4/1/10 2:37 PM, Sai Pullabhotla wrote: I've imported this formatter, but this does not auto-format the Java Docs. So, if I type a long line for a method comment, and format just the method or the entire class, the comments/java docs are not affected. Is it okay to enable the formatting on

Re: svn commit: r928769

2010-04-01 Thread Sai Pullabhotla
Wouldn't you use HTML tags/pre-formatted text for those types of docs? Regards, Sai Pullabhotla On Thu, Apr 1, 2010 at 1:47 PM, Emmanuel Lecharny elecha...@gmail.com wrote: On 4/1/10 2:37 PM, Sai Pullabhotla wrote: I've imported this formatter, but this does not auto-format the Java

Re: svn commit: r928769

2010-04-01 Thread Emmanuel Lecharny
On 4/1/10 9:20 PM, Sai Pullabhotla wrote: Wouldn't you use HTML tags/pre-formatted text for those types of docs? Yes, but I'm not sure that the formater respect the pre tags. To be double checked ... -- Regards, Cordialement, Emmanuel Lécharny www.nextury.com

Re: svn commit: r928769 - in /mina/ftpserver/trunk/core/src: main/java/org/apache/ftpserver/config/spring/ main/java/org/apache/ftpserver/ipfilter/ main/java/org/apache/ftpserver/listener/ main/java

2010-03-30 Thread David Latorre
Regarding this issue, I downloaded the common formatter for Eclipse from the website a while back and (I think!) I'm using it. I use the 'autoformat' feature all the time so I hope that's the one which should be used for FTPServer as well, is it? Otherwise I think it would be great if we defined

Re: svn commit: r928769

2010-03-30 Thread Dave Roberts
On 29/03/2010 22:35, Sai Pullabhotla wrote: Of course, a Source Code Formatter posted to the MINA web site would definitely be a plus as I do want to format and still keep the unchanged stuff as is. http://mina.apache.org/developer-guide.data/ImprovedJavaConventions.xml Or, go to the MINA

Re: svn commit: r928769

2010-03-30 Thread Sai Pullabhotla
Cool, thanks. Regards, Sai Pullabhotla On Tue, Mar 30, 2010 at 3:21 AM, Dave Roberts dave.robe...@saaconsultants.com wrote: On 29/03/2010 22:35, Sai Pullabhotla wrote: Of course, a Source Code Formatter posted to the MINA web site would definitely be a plus as I do want to format and

Re: svn commit: r928769 - in /mina/ftpserver/trunk/core/src: main/java/org/apache/ftpserver/config/spring/ main/java/org/apache/ftpserver/ipfilter/ main/java/org/apache/ftpserver/listener/ main/java

2010-03-30 Thread Niklas Gustavsson
On Mon, Mar 29, 2010 at 10:41 PM, Sai Pullabhotla sai.pullabho...@jmethods.com wrote: BTW, do you know why Hudson is complaining about the test failure on trunk? I did not get that error locally. I reran the build after it failed, but still no luck. It runs fine on my laptop as well. I think

Re: svn commit: r928769 - in /mina/ftpserver/trunk/core/src: main/java/org/apache/ftpserver/config/spring/ main/java/org/apache/ftpserver/ipfilter/ main/java/org/apache/ftpserver/listener/ main/java

2010-03-29 Thread Niklas Gustavsson
On Mon, Mar 29, 2010 at 2:31 PM, s...@apache.org wrote: Author: sai Date: Mon Mar 29 13:31:55 2010 New Revision: 928769 URL: http://svn.apache.org/viewvc?rev=928769view=rev Log: Implemented FTPSERVER-357 Seems like there was a ton of whitespace changes included in this commit. Keeping the

Re: svn commit: r928769 - in /mina/ftpserver/trunk/core/src: main/java/org/apache/ftpserver/config/spring/ main/java/org/apache/ftpserver/ipfilter/ main/java/org/apache/ftpserver/listener/ main/java

2010-03-29 Thread Emmanuel Lecharny
On 3/29/10 9:34 PM, Niklas Gustavsson wrote: On Mon, Mar 29, 2010 at 2:31 PM,s...@apache.org wrote: Author: sai Date: Mon Mar 29 13:31:55 2010 New Revision: 928769 URL: http://svn.apache.org/viewvc?rev=928769view=rev Log: Implemented FTPSERVER-357 Seems like there was a ton of

Re: svn commit: r928769 - in /mina/ftpserver/trunk/core/src: main/java/org/apache/ftpserver/config/spring/ main/java/org/apache/ftpserver/ipfilter/ main/java/org/apache/ftpserver/listener/ main/java

2010-03-29 Thread Sai Pullabhotla
I apologize for the mess up. However, I do want you to know that I tried all the possible things I could, but still was not able to figure out how Eclipse manages to screw it up. I did not format any existing sources. I even tried creating a brand new workspace, set the new lines to UNIX style,

Re: svn commit: r928769 - in /mina/ftpserver/trunk/core/src: main/java/org/apache/ftpserver/config/spring/ main/java/org/apache/ftpserver/ipfilter/ main/java/org/apache/ftpserver/listener/ main/java

2010-03-29 Thread Sai Pullabhotla
BTW, do you know why Hudson is complaining about the test failure on trunk? I did not get that error locally. Regards, Sai Pullabhotla On Mon, Mar 29, 2010 at 4:06 PM, Niklas Gustavsson nik...@protocol7.com wrote: On Mon, Mar 29, 2010 at 9:39 PM, Emmanuel Lecharny elecha...@gmail.com