[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369756#comment-16369756 ] Goldstein Lyor commented on SSHD-730: - I think I did no explain my thoughts on this issue clearly thus

[jira] [Commented] (DIRMINA-1078) OrderedThreadPoolExecutor should allow sessions to be prioritized

[ https://issues.apache.org/jira/browse/DIRMINA-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368890#comment-16368890 ] Guus der Kinderen commented on DIRMINA-1078: Thanks for the feedback guys! I initially had

[jira] [Commented] (DIRMINA-1078) OrderedThreadPoolExecutor should allow sessions to be prioritized

[ https://issues.apache.org/jira/browse/DIRMINA-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369191#comment-16369191 ] Guus der Kinderen commented on DIRMINA-1078: I'm sorry, I don't understand the request.

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369145#comment-16369145 ] Goldstein Lyor commented on SSHD-730: - There is an issue regarding what \{quote}current

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369167#comment-16369167 ] Lukas Waldmann commented on SSHD-730: - I beg to differ. We are not talking about "current directory" in

[jira] [Commented] (DIRMINA-1078) OrderedThreadPoolExecutor should allow sessions to be prioritized

[ https://issues.apache.org/jira/browse/DIRMINA-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369181#comment-16369181 ] Jonathan Valliere commented on DIRMINA-1078: Please change the name of the class and update

[jira] [Commented] (DIRMINA-1078) OrderedThreadPoolExecutor should allow sessions to be prioritized

[ https://issues.apache.org/jira/browse/DIRMINA-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369199#comment-16369199 ] Jonathan Valliere commented on DIRMINA-1078: Idk? Call the class "SortingThreadPoolExecutor"

[jira] [Commented] (DIRMINA-1078) OrderedThreadPoolExecutor should allow sessions to be prioritized

[ https://issues.apache.org/jira/browse/DIRMINA-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369225#comment-16369225 ] Jonathan Valliere commented on DIRMINA-1078: Might be a good idea to create and add a Unit

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369278#comment-16369278 ] Lukas Waldmann commented on SSHD-730: - Sure, I can give it a try > Relative symbolic links with .. is

Re: Linter / Code Formatting

Le 19/02/2018 à 16:47, Jonathan Valliere a écrit : > Any interest in adding support for a linter to automatically check for > formatting / quality issues and formatting the code to enforce consistent > style across the entire codebase? We can use Checkstyle for that purpose. And, yes, that

Re: Linter / Code Formatting

I like the idea of CheckStyle because it has an Eclipse Plugin. I can also add an Eclipse Formatter XML to the project somewhere. The default Eclipse Formatter does not comply with the Oracle Style Guide. On Mon, Feb 19, 2018 at 11:47 AM, Emmanuel Lécharny wrote: > > > Le

[jira] [Commented] (DIRMINA-1077) Threads hanging in dispose() on SSLHandshakeException

[ https://issues.apache.org/jira/browse/DIRMINA-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369316#comment-16369316 ] Christoph John commented on DIRMINA-1077: - No problem, thanks a lot. > Threads hanging in

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369233#comment-16369233 ] Guillaume Nodet commented on SSHD-730: -- [~luky] could you write a unit test in

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369386#comment-16369386 ] Goldstein Lyor commented on SSHD-730: - {quote} We are talking about traversing well defined directory

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369409#comment-16369409 ] Lukas Waldmann commented on SSHD-730: - Lyor, I really can't agree if you have directories defined as

Linter / Code Formatting

Any interest in adding support for a linter to automatically check for formatting / quality issues and formatting the code to enforce consistent style across the entire codebase?

Re: Linter / Code Formatting

Le 19/02/2018 à 16:47, Jonathan Valliere a écrit : > Any interest in adding support for a linter to automatically check for > formatting / quality issues and formatting the code to enforce consistent > style across the entire codebase? > I would add twi things : - months ago, I ran the code

[jira] [Commented] (DIRMINA-1077) Threads hanging in dispose() on SSLHandshakeException

[ https://issues.apache.org/jira/browse/DIRMINA-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369313#comment-16369313 ] Jonathan Valliere commented on DIRMINA-1077: I'm waiting to commit DIRMINA-1076 until I can

[jira] [Commented] (SSHD-730) Relative symbolic links with .. is not resolved properly by sftp readLink

[ https://issues.apache.org/jira/browse/SSHD-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369444#comment-16369444 ] Guillaume Nodet commented on SSHD-730: -- [~lgoldstein] The link should be resolved relative to the its