[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-10-18 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656269#comment-16656269 ] Goldstein Lyor commented on SSHD-849: - The code can also be checked out and tested from

Please help review and test solution for SSHD-849

2018-10-18 Thread Lyor Goldstein
Here is the issue in a nutshell - a client might open an SSH tunnel, send some data and close (normally) its side of the tunnel before the channel to the other side has been successfully established and all data transmitted. Currently a race condition may occur in such a scenario where the code

[jira] [Assigned] (SSHD-850) Add capability to retry a failed private key decryption when client is decrypting private key file(s)

2018-10-18 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Goldstein Lyor reassigned SSHD-850: --- Assignee: Goldstein Lyor > Add capability to retry a failed private key decryption when

[jira] [Work started] (SSHD-850) Add capability to retry a failed private key decryption when client is decrypting private key file(s)

2018-10-18 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on SSHD-850 started by Goldstein Lyor. --- > Add capability to retry a failed private key decryption when client is >

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-10-18 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656162#comment-16656162 ] Goldstein Lyor commented on SSHD-849: - Hi, please review the solution I posted as a PR

[jira] [Commented] (SSHD-850) Add capability to retry a failed private key decryption when client is decrypting private key file(s)

2018-10-18 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656138#comment-16656138 ] Goldstein Lyor commented on SSHD-850: - {quote} But it remains a big ugly hack in my opinion. Doing it

[jira] [Commented] (SSHD-850) Add capability to retry a failed private key decryption when client is decrypting private key file(s)

2018-10-18 Thread Thomas Wolf (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655582#comment-16655582 ] Thomas Wolf commented on SSHD-850: -- I don't quite understand that. As far as I see, KeyPairProviders are

[jira] [Commented] (SSHD-850) Add capability to retry a failed private key decryption when client is decrypting private key file(s)

2018-10-18 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655339#comment-16655339 ] Goldstein Lyor commented on SSHD-850: - One possible avenue of solution might be to override {{Iterable

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655328#comment-16655328 ] ASF GitHub Bot commented on SSHD-849: - GitHub user lgoldstein opened a pull request:

[GitHub] mina-sshd pull request #72: [SSHD-849] Using a ClientChannelPendingMessagesQ...

2018-10-18 Thread lgoldstein
GitHub user lgoldstein opened a pull request: https://github.com/apache/mina-sshd/pull/72 [SSHD-849] Using a ClientChannelPendingMessagesQueue to regulate messages order while forwarding channel is being set up You can merge this pull request into a Git repository by running:

[jira] [Resolved] (SSHD-852) Verification fails for hashed known host entry on non standard port generated by OpenSSH client

2018-10-18 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Goldstein Lyor resolved SSHD-852. - Resolution: Fixed Fix Version/s: 2.1.1 > Verification fails for hashed known host entry on

[jira] [Commented] (SSHD-852) Verification fails for hashed known host entry on non standard port generated by OpenSSH client

2018-10-18 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655162#comment-16655162 ] Goldstein Lyor commented on SSHD-852: - Many thanks for the patch - merged it in (with a few minor

[GitHub] mina-sshd pull request #71: OpenSSH client creates hash with port, mina shou...

2018-10-18 Thread lgoldstein
Github user lgoldstein closed the pull request at: https://github.com/apache/mina-sshd/pull/71 ---

[jira] [Work started] (SSHD-852) Verification fails for hashed known host entry on non standard port generated by OpenSSH client

2018-10-18 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on SSHD-852 started by Goldstein Lyor. --- > Verification fails for hashed known host entry on non standard port generated >

[jira] [Assigned] (SSHD-852) Verification fails for hashed known host entry on non standard port generated by OpenSSH client

2018-10-18 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Goldstein Lyor reassigned SSHD-852: --- Assignee: Goldstein Lyor > Verification fails for hashed known host entry on non standard

[jira] [Comment Edited] (SSHD-852) Verification fails for hashed known host entry on non standard port generated by OpenSSH client

2018-10-18 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654040#comment-16654040 ] Goldstein Lyor edited comment on SSHD-852 at 10/18/18 10:28 AM: Thanks for