[GitHub] [mina-sshd] tomaswolf commented on a diff in pull request #368: [SSHD-1259] Match key type in known_hosts lookup

2023-05-07 Thread via GitHub
tomaswolf commented on code in PR #368: URL: https://github.com/apache/mina-sshd/pull/368#discussion_r1186889041 ## sshd-core/src/main/java/org/apache/sshd/client/keyverifier/KnownHostsServerKeyVerifier.java: ## @@ -267,36 +268,55 @@ protected PublicKeyEntryResolver

[GitHub] [mina-sshd] FliegenKLATSCH commented on a diff in pull request #368: [SSHD-1259] Match key type in known_hosts lookup

2023-05-07 Thread via GitHub
FliegenKLATSCH commented on code in PR #368: URL: https://github.com/apache/mina-sshd/pull/368#discussion_r1186893876 ## sshd-core/src/main/java/org/apache/sshd/client/keyverifier/KnownHostsServerKeyVerifier.java: ## @@ -267,36 +268,55 @@ protected PublicKeyEntryResolver

[GitHub] [mina-sshd] tomaswolf commented on issue #373: jgit ssh

2023-05-17 Thread via GitHub
tomaswolf commented on issue #373: URL: https://github.com/apache/mina-sshd/issues/373#issuecomment-1552015749 Sorry, I don't understand what you mean. What is a warehouse address? Can you give a concrete example of what you are trying to do? -- This is an automated message from the

[GitHub] [mina-sshd] tomaswolf opened a new pull request, #374: [SSHD-1327] ChannelAsyncOutputStream: remove write future when done

2023-05-17 Thread via GitHub
tomaswolf opened a new pull request, #374: URL: https://github.com/apache/mina-sshd/pull/374 We keep the top-level future of the last initiated write to be able to delay closing the stream until it has been written. But once the write _has_ been done, there is no need to keep the future

[GitHub] [mina-sshd] tomaswolf commented on issue #360: Apache Mina SSHD adapt to Apache MINA 2.2.x

2023-05-17 Thread via GitHub
tomaswolf commented on issue #360: URL: https://github.com/apache/mina-sshd/issues/360#issuecomment-1552027083 Unfortunately MINA 2.0.x and 2.2.x are not source compatible. Switching might also require testing effort. (Perhaps we'd be lucky, and everything just still works. But maybe not.)

[GitHub] [mina-sshd] tomaswolf opened a new pull request, #375: GH-370: Also compare file keys in ModifiableFileWatcher

2023-05-18 Thread via GitHub
tomaswolf opened a new pull request, #375: URL: https://github.com/apache/mina-sshd/pull/375 Additionally, handle the case of files being modified very quickly, such that the last modified timestamp doesn't change, even though the file was modified. If the modification did not change the

[GitHub] [mina-sshd] tomaswolf merged pull request #374: [SSHD-1327] ChannelAsyncOutputStream: remove write future when done

2023-05-18 Thread via GitHub
tomaswolf merged PR #374: URL: https://github.com/apache/mina-sshd/pull/374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mina-sshd] tomaswolf commented on issue #356: Provide Snapshot builds of current master

2023-05-18 Thread via GitHub
tomaswolf commented on issue #356: URL: https://github.com/apache/mina-sshd/issues/356#issuecomment-1553310287 Good idea. I haven't found any proper documentation, but reading through a number of support tickets at the ASF it looks as if such credentials already exist. I have opened

[GitHub] [mina-sshd] HannesWell commented on issue #356: Provide Snapshot builds of current master

2023-05-18 Thread via GitHub
HannesWell commented on issue #356: URL: https://github.com/apache/mina-sshd/issues/356#issuecomment-1553477906 > I have opened https://issues.apache.org/jira/browse/INFRA-24609 to get some help. Not that we run off in the wrong direction :-) Great, thanks. > Of course

[GitHub] [mina-sshd] jglick commented on a diff in pull request #315: Cancellation and time-outs of futures

2023-05-18 Thread via GitHub
jglick commented on code in PR #315: URL: https://github.com/apache/mina-sshd/pull/315#discussion_r1198363609 ## sshd-common/src/main/java/org/apache/sshd/common/future/VerifiableFuture.java: ## @@ -35,45 +35,53 @@ /** * Wait {@link Long#MAX_VALUE} msec. and verify

[GitHub] [mina] elecharny commented on pull request #26: DIRMINA-1122 - added support for endpoint identification algorithm

2023-05-08 Thread via GitHub
elecharny commented on PR #26: URL: https://github.com/apache/mina/pull/26#issuecomment-1539017831 FTR, here is a part of the logs I get when running the test with Java8: ``` javax.net.ssl|FINE|0F|CLIENT|2023-05-08 22:21:32.416 CEST|SSLExtensions.java:173|Ignore unavailable

[GitHub] [mina] elecharny commented on pull request #26: DIRMINA-1122 - added support for endpoint identification algorithm

2023-05-08 Thread via GitHub
elecharny commented on PR #26: URL: https://github.com/apache/mina/pull/26#issuecomment-1539042180 Note that MINA 2.2.X don't have anymore a **PEER_ADDRESS** attribute, so we have to go through the creation of a dedicated **SslFilter** class, which extends the default **SslFilter** class.

[GitHub] [mina] the-thing commented on pull request #26: DIRMINA-1122 - added support for endpoint identification algorithm

2023-05-09 Thread via GitHub
the-thing commented on PR #26: URL: https://github.com/apache/mina/pull/26#issuecomment-1539764637 I was able to crate 2 branches based of 2.2.X and they both work (still waiting for the CI to run). 1) The old method - by providing the peer address.

[GitHub] [mina] elecharny commented on pull request #26: DIRMINA-1122 - added support for endpoint identification algorithm

2023-05-08 Thread via GitHub
elecharny commented on PR #26: URL: https://github.com/apache/mina/pull/26#issuecomment-1539039335 On the test, we use a custom SSLFilter which sets the peer: ``` protected SSLEngine createEngine(IoSession session, InetSocketAddress addr) { //Add your SNI

[GitHub] [mina] elecharny commented on pull request #26: DIRMINA-1122 - added support for endpoint identification algorithm

2023-05-08 Thread via GitHub
elecharny commented on PR #26: URL: https://github.com/apache/mina/pull/26#issuecomment-1538929098 Actually, all the handshakes are passing, which make the *shouldFailXXX* tests failing. Here is the modified test class for MINA 2.2.X: ``` package org.apache.mina.filter.ssl;

[GitHub] [mina] the-thing commented on pull request #26: DIRMINA-1122 - added support for endpoint identification algorithm

2023-05-08 Thread via GitHub
the-thing commented on PR #26: URL: https://github.com/apache/mina/pull/26#issuecomment-1539019441 I applied the changes manually to 2.2.X. The peerAddress session attribute has been removed, which was used to get the hostname for the SSL engine. 2.1.X -

[GitHub] [mina] elecharny commented on pull request #26: DIRMINA-1122 - added support for endpoint identification algorithm

2023-05-09 Thread via GitHub
elecharny commented on PR #26: URL: https://github.com/apache/mina/pull/26#issuecomment-1540100131 Hi, I confirm the first branch (_ssl_endpoint_algorithm_) works. It mimics MINA_2.1.X, using a PEER attribute. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [mina-sshd] lgoldstein commented on pull request #362: [SSHD-1324] Rooted file system can leak informations

2023-05-09 Thread via GitHub
lgoldstein commented on PR #362: URL: https://github.com/apache/mina-sshd/pull/362#issuecomment-1540575190 > I suggest we publish a 2.10.0 without this change, and do a 2.10.1 once this is ready. I second that... -- This is an automated message from the Apache Git Service. To

[GitHub] [mina-sshd] acho-bacho opened a new issue, #376: sftp client using proxyJump fails with StreamCorruptedException: Incorrect identification (line too long)

2023-05-19 Thread via GitHub
acho-bacho opened a new issue, #376: URL: https://github.com/apache/mina-sshd/issues/376 ### Version 2.10 ### Bug description Hello, we are using sfp client from Latest SSHD Release (2.10) binaries and try to connect to a sFTP server through a SQUID http proxy

[GitHub] [mina] elecharny commented on pull request #26: DIRMINA-1122 - added support for endpoint identification algorithm

2023-05-19 Thread via GitHub
elecharny commented on PR #26: URL: https://github.com/apache/mina/pull/26#issuecomment-1554469397 Will do this week-end! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [mina-sshd] beijishiqidu commented on issue #371: The timeout interval from the client SftpClient cannot be configured on the current server.

2023-05-19 Thread via GitHub
beijishiqidu commented on issue #371: URL: https://github.com/apache/mina-sshd/issues/371#issuecomment-1554346083 @tomaswolf Hello, friend. I wrote all kinds of test cases, Here's just one example ```java private static SftpClient sftpClient; private

[GitHub] [mina] tomaswolf commented on pull request #35: [DIRMINA-1169] Fix unbinding a serverSocketChannel

2023-05-20 Thread via GitHub
tomaswolf commented on PR #35: URL: https://github.com/apache/mina/pull/35#issuecomment-1555823619 > Merged in 2.2.X But not correctly. See my [comment](https://github.com/apache/mina/commit/36f4e9718d43509d0182b153277ff186148660f3#r114177942). -- This is an automated message from

[GitHub] [mina-sshd] tomaswolf commented on issue #371: The timeout interval from the client SftpClient cannot be configured on the current server.

2023-05-19 Thread via GitHub
tomaswolf commented on issue #371: URL: https://github.com/apache/mina-sshd/issues/371#issuecomment-1555293276 Maybe it would help if you closed the various client-side objects you use. An `SftpClient` is supposed to be closed when it is no longer needed. But yes, there is a problem

[GitHub] [mina-sshd] tomaswolf commented on issue #376: sftp client using proxyJump fails with StreamCorruptedException: Incorrect identification (line too long)

2023-05-19 Thread via GitHub
tomaswolf commented on issue #376: URL: https://github.com/apache/mina-sshd/issues/376#issuecomment-1555065524 `ProxyJump` is not intended to connect to HTTP or SOCKS proxies. It opens an SSH connection to the proxy and then _inside that SSH session_ connects to the target SSH server. Your

[GitHub] [mina-sshd] tomaswolf closed issue #376: sftp client using proxyJump fails with StreamCorruptedException: Incorrect identification (line too long)

2023-05-19 Thread via GitHub
tomaswolf closed issue #376: sftp client using proxyJump fails with StreamCorruptedException: Incorrect identification (line too long) URL: https://github.com/apache/mina-sshd/issues/376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [mina] elecharny commented on pull request #35: [DIRMINA-1169] Fix unbinding a serverSocketChannel

2023-05-19 Thread via GitHub
elecharny commented on PR #35: URL: https://github.com/apache/mina/pull/35#issuecomment-122769 Merged in 2.2.X -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [mina] elecharny commented on pull request #26: DIRMINA-1122 - added support for endpoint identification algorithm

2023-05-19 Thread via GitHub
elecharny commented on PR #26: URL: https://github.com/apache/mina/pull/26#issuecomment-123546 Pushed in 2.2.X -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [mina] tomaswolf opened a new pull request, #39: Fix patch application for DIRMINA-1169

2023-05-20 Thread via GitHub
tomaswolf opened a new pull request, #39: URL: https://github.com/apache/mina/pull/39 Add the most crucial bit: the actual fix. Since Java 11, unbinding may take effect only on the next select(). Thus there must be a select() between unbindings and performing new bindings. -- This is an

[GitHub] [mina-sshd] tomaswolf commented on issue #356: Provide Snapshot builds of current master

2023-05-20 Thread via GitHub
tomaswolf commented on issue #356: URL: https://github.com/apache/mina-sshd/issues/356#issuecomment-1555950777 The two secrets are named NEXUS_USER and NEXUS_PW. They have been enabled now for this repository. Apparently that is all we need, so we can go forward with this. -- This

[GitHub] [mina-sshd] tomaswolf closed issue #370: ModifiableFileWatcher should watch for changes in BasicFileAttributes.fileKey()

2023-05-20 Thread via GitHub
tomaswolf closed issue #370: ModifiableFileWatcher should watch for changes in BasicFileAttributes.fileKey() URL: https://github.com/apache/mina-sshd/issues/370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [mina-sshd] tomaswolf merged pull request #375: GH-370: Also compare file keys in ModifiableFileWatcher

2023-05-20 Thread via GitHub
tomaswolf merged PR #375: URL: https://github.com/apache/mina-sshd/pull/375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mina-sshd] tomaswolf opened a new pull request, #377: [SSHD-1310] SftpFileSystem: do not close user sessions

2023-05-20 Thread via GitHub
tomaswolf opened a new pull request, #377: URL: https://github.com/apache/mina-sshd/pull/377 A SftpFileSystem can be obtained in two ways: 1. Via FileSystems.newFileSystem() 2. Via SftpClientFactory.instance().createSftpFileSystem(ClientSession) In the first case, the

[GitHub] [mina-sshd] tomaswolf commented on issue #403: exceptionCaught(ServerSessionImpl[user@/10.x.x.x:23232])[state=Opened] IllegalStateException: Bad length (32796) for cmd=SSH_MSG_CHANNEL_DATA -

2023-08-14 Thread via GitHub
tomaswolf commented on issue #403: URL: https://github.com/apache/mina-sshd/issues/403#issuecomment-1677390541 I suppose you mean not the whole mailing list but just the thread starting at https://www.mail-archive.com/users@mina.apache.org/msg06936.html . Yes, that's the same issue.

[I] KeyExchangeMessageHandler threads pilling up [mina-sshd]

2024-01-24 Thread via GitHub
FliegenKLATSCH opened a new issue, #458: URL: https://github.com/apache/mina-sshd/issues/458 ### Version 2.11.0 ### Bug description `KeyExchangeMessageHandler:89` creates an unnamed SingleThreadExecutor, which is kept open for each session. In our use case we create

Re: [I] DefaultScpClient.upload(InputStream, ...) will always hit the exit status timeout [mina-sshd]

2024-02-08 Thread via GitHub
TerraNibble commented on issue #427: URL: https://github.com/apache/mina-sshd/issues/427#issuecomment-1934985712 This is also easily reproducible using the including unit test `ScpTest.testStreamsUploadAndDownload`. Running it you can observe the 5 second exit timeout being hit.

Re: [I] DefaultScpClient.upload(InputStream, ...) will always hit the exit status timeout [mina-sshd]

2024-02-09 Thread via GitHub
TerraNibble commented on issue #427: URL: https://github.com/apache/mina-sshd/issues/427#issuecomment-1936026984 With some further testing this appears to happen if we trigger the sending of an EOF too quickly after sending a stream. Placing a 100ms delay between these actions alleviates

Re: [I] DefaultScpClient.upload(InputStream, ...) will always hit the exit status timeout [mina-sshd]

2024-02-09 Thread via GitHub
TerraNibble commented on issue #427: URL: https://github.com/apache/mina-sshd/issues/427#issuecomment-1936151679 It appears that this is caused by an initial ACK not being processed when the initial channel is open, then the following sequence of ACKs are not processed in the correct

[I] Concurrent active mode FTP transfers fail when specifying static data-port [mina-ftpserver]

2024-02-15 Thread via GitHub
jerome651 opened a new issue, #34: URL: https://github.com/apache/mina-ftpserver/issues/34 When configuring the "local-port" element within the /res/conf/ftpd-*.xml file to a static value, then the ability to run parallel active FTP transfers is lost, and results in an immediate "425"

[I] NullPointer in ChannelSession.closeImmediately0() leading to regular warning log spam [mina-sshd]

2024-02-10 Thread via GitHub
stephen-day opened a new issue, #465: URL: https://github.com/apache/mina-sshd/issues/465 ### Version 2.11.0 ### Bug description This method regularly produces a NullPointer which it immediately catches and logs as a warning before ignoring it. Hence, this is just

[I] Consider IdentityFile from SSH Config with UserAuthPublicKey [mina-sshd]

2024-02-19 Thread via GitHub
kwin opened a new issue, #466: URL: https://github.com/apache/mina-sshd/issues/466 ### Description In order to support edge cases with SSH agents like outlined in either 1. https://keepassxc.org/docs/#faq-ssh-agent-openssh or 2.

Re: [I] Consider IdentityFile from SSH Config with UserAuthPublicKey [mina-sshd]

2024-02-19 Thread via GitHub
kwin commented on issue #466: URL: https://github.com/apache/mina-sshd/issues/466#issuecomment-1953022161 Sorry, this seems to be a downstream issue of

Re: [I] Consider IdentityFile from SSH Config with UserAuthPublicKey [mina-sshd]

2024-02-19 Thread via GitHub
kwin closed issue #466: Consider IdentityFile from SSH Config with UserAuthPublicKey URL: https://github.com/apache/mina-sshd/issues/466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Synchronize not thread safe java.security.KeyPairGenerator.generateKe… [mina-sshd]

2024-02-20 Thread via GitHub
zakharovsergey1000 opened a new pull request, #467: URL: https://github.com/apache/mina-sshd/pull/467 …yPair() method call. The keyPairGenerator object is a bouncycastle implementation of the java.security.KeyPairGenerator class. The generateKeyPair method in class

Re: [PR] Synchronize not thread safe java.security.KeyPairGenerator.generateKe… [mina-sshd]

2024-02-20 Thread via GitHub
zakharovsergey1000 commented on PR #467: URL: https://github.com/apache/mina-sshd/pull/467#issuecomment-1955997478 This change is the result of an investigation into the cause of the flaky tests in Gerrit. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Synchronize not thread safe java.security.KeyPairGenerator.generateKe… [mina-sshd]

2024-02-21 Thread via GitHub
tomaswolf commented on PR #467: URL: https://github.com/apache/mina-sshd/pull/467#issuecomment-1957898945 This commit message is more an issue description. Please open a bug issue and explain all that there. Then the commit message can focus on the change here (synchronizing access

Re: [PR] GH-455: ensure BaseCipher.update() fulfills the contract [mina-sshd]

2024-02-21 Thread via GitHub
tomaswolf merged PR #463: URL: https://github.com/apache/mina-sshd/pull/463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Mina's AbstractSessionHelper and BaseCipher are ignoring lengths returned from cipher update and deriving information from the input len rather than what has actually been processed during the

2024-02-21 Thread via GitHub
tomaswolf closed issue #455: Mina's AbstractSessionHelper and BaseCipher are ignoring lengths returned from cipher update and deriving information from the input len rather than what has actually been processed during the update URL: https://github.com/apache/mina-sshd/issues/455 -- This is

[PR] DIRMINA-1173 [mina]

2024-02-21 Thread via GitHub
jon-valliere opened a new pull request, #44: URL: https://github.com/apache/mina/pull/44 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] Question regarding the md5-hash extension [mina-sshd]

2024-02-19 Thread via GitHub
lgoldstein commented on issue #450: URL: https://github.com/apache/mina-sshd/issues/450#issuecomment-1952874876 Of course need to check that result of `client.getExtension(MD5FileExtension.class)` returns non-NULL value, thus indicating that the server supports this extension -- This is

Re: [I] How to implement SFTP resuming transfer using mina-sshd? [mina-sshd]

2024-02-19 Thread via GitHub
lgoldstein commented on issue #447: URL: https://github.com/apache/mina-sshd/issues/447#issuecomment-1952881575 Simple * Remember the last offset that you have successfully uploaded/download * Re-establish the client connection * Re-open the relevant file handle * Seek to the

[PR] GH-427: Read initial ACK on channel open prior to direct stream upload [mina-sshd]

2024-02-09 Thread via GitHub
TerraNibble opened a new pull request, #464: URL: https://github.com/apache/mina-sshd/pull/464 Fixes GH-427. - Ensures that the initial ACK sent upon creating the channel is processed prior to sending the payload stream. - Channel IO streams are first closed to trigger EOF prior

Re: [I] org.apache.sshd.client.global.OpenSshHostKeysHandler should ignore unsupported host keys [mina-sshd]

2023-12-18 Thread via GitHub
ThadHouse commented on issue #434: URL: https://github.com/apache/mina-sshd/issues/434#issuecomment-1861694352 Seeing this as well. The EdDSA provider from net.i2p.crypto:eddsa is extremely out of date, and doesn't work on newer version of Java, as it uses removed internal API's. Removing

[I] Terrapin Mitigation: "strict-kex" [mina-sshd]

2023-12-19 Thread via GitHub
ecki opened a new issue, #445: URL: https://github.com/apache/mina-sshd/issues/445 ### Description Hello, is Mina or any contributor planning to work on adding the new OpenSSH protocol extension "strict-KEX" for mitigating Terrapin attacks? Also did somebody check for

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
lgoldstein commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435252051 ## sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java: ## @@ -1741,6 +1979,143 @@ protected byte[] sendKexInit(Map proposal) throws

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
lgoldstein commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435251890 ## sshd-core/src/main/java/org/apache/sshd/common/config/SshConfigFileReader.java: ## @@ -256,6 +257,11 @@ public static M configureKeyExchanges( M

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
ecki commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435099877 ## sshd-common/src/main/java/org/apache/sshd/common/config/ConfigFileReaderSupport.java: ## @@ -89,6 +89,8 @@ public final class ConfigFileReaderSupport { public

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
lgoldstein commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435107705 ## docs/standards.md: ## @@ -29,23 +29,31 @@ above mentioned hooks for [RFC 8308](https://tools.ietf.org/html/rfc8308). * [RFC 8731 - Secure Shell (SSH) Key

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
lgoldstein commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435111276 ## docs/standards.md: ## @@ -29,23 +29,31 @@ above mentioned hooks for [RFC 8308](https://tools.ietf.org/html/rfc8308). * [RFC 8731 - Secure Shell (SSH) Key

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
lgoldstein commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435107705 ## docs/standards.md: ## @@ -29,23 +29,31 @@ above mentioned hooks for [RFC 8308](https://tools.ietf.org/html/rfc8308). * [RFC 8731 - Secure Shell (SSH) Key

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
ecki commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435255754 ## sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java: ## @@ -151,24 +156,34 @@ public abstract class AbstractSession extends

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
lgoldstein commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435105467 ## sshd-common/src/main/java/org/apache/sshd/common/config/ConfigFileReaderSupport.java: ## @@ -89,6 +89,8 @@ public final class ConfigFileReaderSupport {

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
lgoldstein commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435103523 ## CHANGES.md: ## @@ -36,13 +36,26 @@ ## Behavioral changes and enhancements +### [GH-445 - Terrapin attack

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
ecki commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435101866 ## sshd-common/src/main/java/org/apache/sshd/common/kex/extension/KexExtensions.java: ## @@ -59,6 +60,24 @@ public final class KexExtensions { public static final

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
lgoldstein commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435106411 ## CHANGES.md: ## @@ -36,14 +36,38 @@ ## Behavioral changes and enhancements +### [GH-445 - Terrapin attack

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
lgoldstein commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435247929 ## sshd-common/src/main/java/org/apache/sshd/common/kex/extension/KexExtensions.java: ## @@ -59,6 +60,24 @@ public final class KexExtensions { public static

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
ecki commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435264388 ## sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java: ## @@ -1741,6 +1979,143 @@ protected byte[] sendKexInit(Map proposal) throws Exc

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
gnodet commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435094081 ## docs/standards.md: ## @@ -29,23 +29,31 @@ above mentioned hooks for [RFC 8308](https://tools.ietf.org/html/rfc8308). * [RFC 8731 - Secure Shell (SSH) Key

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
lgoldstein commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435251528 ## sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java: ## @@ -151,24 +156,34 @@ public abstract class AbstractSession extends

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
ecki commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435258249 ## sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java: ## @@ -1741,6 +1979,143 @@ protected byte[] sendKexInit(Map proposal) throws Exc

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
lgoldstein commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435260568 ## sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java: ## @@ -1741,6 +1979,143 @@ protected byte[] sendKexInit(Map proposal) throws

Re: [I] Terrapin Mitigation: "strict-kex" [mina-sshd]

2023-12-22 Thread via GitHub
ecki commented on issue #445: URL: https://github.com/apache/mina-sshd/issues/445#issuecomment-1867726843 Lyle, let me know when you think I can have a look. We are using it heavily inside karaf, so we are happy to help. -- This is an automated message from the Apache Git Service. To

Re: [I] Terrapin Mitigation: "strict-kex" [mina-sshd]

2023-12-22 Thread via GitHub
lgoldstein commented on issue #445: URL: https://github.com/apache/mina-sshd/issues/445#issuecomment-1867740157 See https://github.com/apache/mina-sshd/pull/446 - still working on it (polishing it) but it seems promising -- This is an automated message from the Apache Git Service. To

Re: [I] Terrapin Mitigation: "strict-kex" [mina-sshd]

2023-12-22 Thread via GitHub
lgoldstein commented on issue #445: URL: https://github.com/apache/mina-sshd/issues/445#issuecomment-1867739086 Thx - will do -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
lgoldstein commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435249201 ## sshd-common/src/main/java/org/apache/sshd/common/session/helpers/SessionCountersDetails.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
ecki commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435255754 ## sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java: ## @@ -151,24 +156,34 @@ public abstract class AbstractSession extends

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
ecki commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435094783 ## CHANGES.md: ## @@ -36,13 +36,26 @@ ## Behavioral changes and enhancements +### [GH-445 - Terrapin attack

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
lgoldstein commented on PR #446: URL: https://github.com/apache/mina-sshd/pull/446#issuecomment-1867775861 I have also added unit tests (except one) - please review them as well and let me know if you think there is a use-case that is not covered by them -- This is an automated message

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
ecki commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435264388 ## sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java: ## @@ -1741,6 +1979,143 @@ protected byte[] sendKexInit(Map proposal) throws Exc

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
lgoldstein commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435249686 ## sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java: ## @@ -202,13 +213,20 @@ public abstract class AbstractSession extends

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
sberyozkin commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435360419 ## CHANGES.md: ## @@ -36,14 +36,38 @@ ## Behavioral changes and enhancements +### [GH-445 - Terrapin attack

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
ecki commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435255754 ## sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java: ## @@ -151,24 +156,34 @@ public abstract class AbstractSession extends

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-22 Thread via GitHub
sberyozkin commented on code in PR #446: URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435360419 ## CHANGES.md: ## @@ -36,14 +36,38 @@ ## Behavioral changes and enhancements +### [GH-445 - Terrapin attack

Re: [I] org.apache.sshd.client.global.OpenSshHostKeysHandler should ignore unsupported host keys [mina-sshd]

2023-12-14 Thread via GitHub
tomaswolf commented on issue #434: URL: https://github.com/apache/mina-sshd/issues/434#issuecomment-1856533066 On the client side, it should indeed ignore unknown key types (and not do anything if it cannot deal with any of the keys). On the server side, it should fail if it ever

Re: [I] use client to connect to the cluster server, and the connection will only be established to one instance. [mina-sshd]

2023-12-14 Thread via GitHub
tomaswolf commented on issue #435: URL: https://github.com/apache/mina-sshd/issues/435#issuecomment-1856496111 Yes, like plain Java HTTP, Apache MINA sshd only uses the first IP address. In part this is hard-coded in Java's `InetSocketAddress(String hostname, int port)`, which resolves the

Re: [I] Ciphers and KEX override at ClientSession level not taken into account [mina-sshd]

2023-12-12 Thread via GitHub
baiglin commented on issue #439: URL: https://github.com/apache/mina-sshd/issues/439#issuecomment-1851795133 Indeed, in my case I want to apply configuration on per-basis destination (user@IP:port), so I create many different client sessions and I would need to apply given configuration

Re: [I] Ciphers and KEX override at ClientSession level not taken into account [mina-sshd]

2023-12-12 Thread via GitHub
tomaswolf commented on issue #439: URL: https://github.com/apache/mina-sshd/issues/439#issuecomment-1851711680 The listener has access to the session, so it can do special things per session. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] Huge File transfer (>5GB) to AIX host through SSH key credentials is always getting hung and SocketTimeoutException is reported [mina-sshd]

2023-12-10 Thread via GitHub
tomaswolf commented on issue #432: URL: https://github.com/apache/mina-sshd/issues/432#issuecomment-1849071181 We do not have the resources to investigate problems with old versions. Try with Apache MINA sshd 2.11.0. There have been problems in past versions in key re-exchanges that

Re: [I] Ciphers and KEX override at ClientSession level not taken into account [mina-sshd]

2023-12-10 Thread via GitHub
tomaswolf commented on issue #439: URL: https://github.com/apache/mina-sshd/issues/439#issuecomment-1849067063 I don't understand your example code. What's `client`? Seems undefined. In any case: SEND_IMMEDIATE_KEXINIT = false delays sending the client's KEX init message until after

Re: [I] When using SSH client, the server has no output [mina-sshd]

2023-12-10 Thread via GitHub
dyw770 commented on issue #441: URL: https://github.com/apache/mina-sshd/issues/441#issuecomment-1849363662 Idea needs to add `- Editable. Java. test. console=true` options -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] When using SSH client, the server has no output [mina-sshd]

2023-12-10 Thread via GitHub
dyw770 commented on issue #441: URL: https://github.com/apache/mina-sshd/issues/441#issuecomment-1849300309 > Cannot reproduce. Using your code on OS X with two minor modifications: > > 1. Connect to my own user on localhost port 22. > 2. Use public-key authentication instead of

Re: [I] Lost window adjust packets (SSH_MSG_CHANNEL_WINDOW_ADJUST) [mina-sshd]

2023-12-10 Thread via GitHub
tomaswolf commented on issue #440: URL: https://github.com/apache/mina-sshd/issues/440#issuecomment-1849063155 > Any ideas how to debug this problem further? Not really. Never seen something like this. No other hints in the full log? I don't quite understand the filtered log excerpt

Re: [I] Add Support for Multi-Factor Authentication [mina-sshd]

2023-12-10 Thread via GitHub
tomaswolf commented on issue #433: URL: https://github.com/apache/mina-sshd/issues/433#issuecomment-1849070206 Support for PKCS11 hardware security modules is not implemented in Apache MINA sshd, but could be added via the SunPKCS11 security provider. [JGit did

Re: [I] When using SSH client, the server has no output [mina-sshd]

2023-12-10 Thread via GitHub
dyw770 closed issue #441: When using SSH client, the server has no output URL: https://github.com/apache/mina-sshd/issues/441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Ciphers and KEX override at ClientSession level not taken into account [mina-sshd]

2023-12-12 Thread via GitHub
baiglin commented on issue #439: URL: https://github.com/apache/mina-sshd/issues/439#issuecomment-1851543133 Hi @tomaswolf , thanks a lot for your reply, I corrected the code sample, sorry for that, so you confirm what I thought, I found the piece of documentation about listeners

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-27 Thread via GitHub
tomaswolf commented on PR #446: URL: https://github.com/apache/mina-sshd/pull/446#issuecomment-1870636101 I find this very hard to review. 1. That reformatting should be avoided. It indicates some problem with the configuration in your IDE or in your maven build. Please ensure that

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-28 Thread via GitHub
lgoldstein commented on PR #446: URL: https://github.com/apache/mina-sshd/pull/446#issuecomment-1871748071 > check that the receive sequence number of the peer's initial KEX_INIT is 1. If not, there were earlier messages, and they disconnect. Done > as long as initialKexDone

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-28 Thread via GitHub
lgoldstein commented on PR #446: URL: https://github.com/apache/mina-sshd/pull/446#issuecomment-1871737314 > There is completely unrelated stuff in this change. These things must not be in this change at all. Let's agree to disagree on this. My philosophy is that if, while changing a

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-28 Thread via GitHub
lgoldstein commented on PR #446: URL: https://github.com/apache/mina-sshd/pull/446#issuecomment-1871737629 > The command execution timeout looks suspicious to me. At least the timeout for running a command should by default be zero, as it was before. Well put - will fix this --

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-28 Thread via GitHub
lgoldstein commented on PR #446: URL: https://github.com/apache/mina-sshd/pull/446#issuecomment-1871744683 > It does not seem necessary to actively avoid sending IGNORE/DEBUG messages before one's own initial KEX_INIT. Normally that shouldn't happen anyway. If it is needed, it could be

Re: [PR] [GH-445] Implemented OpenSSH strict KEX protocol [mina-sshd]

2023-12-28 Thread via GitHub
lgoldstein commented on PR #446: URL: https://github.com/apache/mina-sshd/pull/446#issuecomment-1871750113 > Protocol-wise, this should be a fairly simple change. :-) not so simple ... > I would refrain from any beautification or not strictly needed refactoring; such things

<    2   3   4   5   6   7   8   9   10   11   >