[GitHub] [mina-sshd] Thrameos commented on pull request #314: Report exceptions in logs

2023-01-19 Thread GitBox
Thrameos commented on PR #314: URL: https://github.com/apache/mina-sshd/pull/314#issuecomment-1397660577 For reference here is the log with this code being exercised. ``` 2023/01/19 13:52:38,097 [sshd-SftpSubsystem-61352-thread-1] DEBUG SftpSubsystem -

[GitHub] [mina-sshd] Thrameos commented on a diff in pull request #314: Report exceptions in logs

2023-01-19 Thread GitBox
Thrameos commented on code in PR #314: URL: https://github.com/apache/mina-sshd/pull/314#discussion_r1081905234 ## sshd-sftp/src/main/java/org/apache/sshd/sftp/server/AbstractSftpSubsystemHelper.java: ## @@ -338,6 +338,9 @@ protected void process(Buffer buffer) throws

[GitHub] [mina-sshd] tomaswolf opened a new pull request, #315: Cancellation and time-outs of futures

2023-01-19 Thread GitBox
tomaswolf opened a new pull request, #315: URL: https://github.com/apache/mina-sshd/pull/315 Implement cancellation of futures such that cancelling a user-visible future also cancels the underlying internal operation. Since cancellations can be asynchronous, introduce the concept of a

[GitHub] [mina-sshd] tomaswolf merged pull request #308: GH-302: Fail writes after SSH session is closed

2023-01-19 Thread GitBox
tomaswolf merged PR #308: URL: https://github.com/apache/mina-sshd/pull/308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mina-sshd] tomaswolf closed issue #302: requestNewKeysExchange may cause KeyExchangeMessageHandler into dead lock,cpu 100%

2023-01-19 Thread GitBox
tomaswolf closed issue #302: requestNewKeysExchange may cause KeyExchangeMessageHandler into dead lock,cpu 100% URL: https://github.com/apache/mina-sshd/issues/302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [mina-sshd] tomaswolf commented on a diff in pull request #314: Report exceptions in logs

2023-01-19 Thread GitBox
tomaswolf commented on code in PR #314: URL: https://github.com/apache/mina-sshd/pull/314#discussion_r1081679988 ## sshd-sftp/src/main/java/org/apache/sshd/sftp/server/AbstractSftpSubsystemHelper.java: ## @@ -338,6 +338,9 @@ protected void process(Buffer buffer) throws

[GitHub] [mina-sshd] Thrameos commented on issue #313: SftpSubsystem eats exceptions

2023-01-19 Thread GitBox
Thrameos commented on issue #313: URL: https://github.com/apache/mina-sshd/issues/313#issuecomment-1397427750 I gave it a shot. I am not sure what information is needed to identify the source. I put the session and the id assuming that it matches the other calls. -- This is an

[GitHub] [mina-sshd] Thrameos opened a new pull request, #314: Report exceptions in logs

2023-01-19 Thread GitBox
Thrameos opened a new pull request, #314: URL: https://github.com/apache/mina-sshd/pull/314 Fixes #313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [mina-sshd] tomaswolf commented on issue #313: SftpSubsystem eats exceptions

2023-01-18 Thread GitBox
tomaswolf commented on issue #313: URL: https://github.com/apache/mina-sshd/issues/313#issuecomment-1396564724 There is debug logging in

[GitHub] [mina-sshd] MiniTaT commented on issue #312: Connect to server failed when get session:error: 在一个非套接字上尝试了一个操作

2023-01-18 Thread GitBox
MiniTaT commented on issue #312: URL: https://github.com/apache/mina-sshd/issues/312#issuecomment-1396385975 > We can't go to the customer site to check, so we'll contact the customer to try "netsh winsock reset"。 -- This is an automated message from the Apache Git Service.

[GitHub] [mina-sshd] Thrameos opened a new issue, #313: SftpSubsystem eats exceptions

2023-01-18 Thread GitBox
Thrameos opened a new issue, #313: URL: https://github.com/apache/mina-sshd/issues/313 ### Version 2.9.3 ### Bug description While trying to implement a virtual file system for SFTPD, I ran into a condition in which the connection would close but there was nothing in

[GitHub] [mina-sshd] tomaswolf commented on issue #312: Connect to server failed when get session:error: 在一个非套接字上尝试了一个操作

2023-01-18 Thread GitBox
tomaswolf commented on issue #312: URL: https://github.com/apache/mina-sshd/issues/312#issuecomment-1387539730 You could also try using a later Java version. Try Java 11 or 17, or maybe even 19. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mina-sshd] tomaswolf commented on issue #312: Connect to server failed when get session:error: 在一个非套接字上尝试了一个操作

2023-01-17 Thread GitBox
tomaswolf commented on issue #312: URL: https://github.com/apache/mina-sshd/issues/312#issuecomment-1385419758 The error message appears to indicate that this is Windows error 10038 ("An operation was attempted on something that is not a socket."). Searching the Internet for "OS 10038" or

[GitHub] [mina-sshd] MiniTaT commented on issue #312: Connect to server failed when get session:error: 在一个非套接字上尝试了一个操作

2023-01-17 Thread GitBox
MiniTaT commented on issue #312: URL: https://github.com/apache/mina-sshd/issues/312#issuecomment-1385163955 ![image](https://user-images.githubusercontent.com/122873415/212870558-88eb5c4a-671d-47c2-945d-7f4e3ceb74aa.png) -- This is an automated message from the Apache Git Service. To

[GitHub] [mina-sshd] MiniTaT opened a new issue, #312: Connect to server failed when get session:error: 在一个非套接字上尝试了一个操作

2023-01-17 Thread GitBox
MiniTaT opened a new issue, #312: URL: https://github.com/apache/mina-sshd/issues/312 ### Version 2.9.2 ### Bug description Recently, we switched from jsch to mina ssh. In some of our customers' environments, we encountered the following error when connecting to the

[GitHub] [mina-sshd] garyiscoding commented on issue #310: What will cause the failure to open the channel

2023-01-17 Thread GitBox
garyiscoding commented on issue #310: URL: https://github.com/apache/mina-sshd/issues/310#issuecomment-1385029023 long openChannelTimeout = 500L; try (ChannelExec channel = session.createExecChannel(command); ByteArrayOutputStream outputStream =

[GitHub] [mina-sshd] garyiscoding commented on issue #310: What will cause the failure to open the channel

2023-01-17 Thread GitBox
garyiscoding commented on issue #310: URL: https://github.com/apache/mina-sshd/issues/310#issuecomment-1385028394 `long openChannelTimeout = 500L; try (ChannelExec channel = session.createExecChannel(command); ByteArrayOutputStream outputStream =

[GitHub] [mina-sshd] garyiscoding commented on issue #310: What will cause the failure to open the channel

2023-01-17 Thread GitBox
garyiscoding commented on issue #310: URL: https://github.com/apache/mina-sshd/issues/310#issuecomment-1385028733 `long openChannelTimeout = 500L; try (ChannelExec channel = session.createExecChannel(command); ByteArrayOutputStream outputStream =

[GitHub] [mina-sshd] garyiscoding commented on issue #310: What will cause the failure to open the channel

2023-01-17 Thread GitBox
garyiscoding commented on issue #310: URL: https://github.com/apache/mina-sshd/issues/310#issuecomment-1385023724 When the service is first deployed, there is no error. After running for a while, this error occurs

[GitHub] [mina-sshd] tomaswolf commented on issue #310: What will cause the failure to open the channel

2023-01-16 Thread GitBox
tomaswolf commented on issue #310: URL: https://github.com/apache/mina-sshd/issues/310#issuecomment-1384481173 From looking at where this exception is created, it seems that it indicates a failure in TCP/IP port fowarding to connect to the requested external port. -- This is an automated

[GitHub] [mina-sshd] tomaswolf commented on issue #311: Issue related to CVE-2022-45047

2023-01-16 Thread GitBox
tomaswolf commented on issue #311: URL: https://github.com/apache/mina-sshd/issues/311#issuecomment-1384457928 We wrote in the [CVE announcement](https://www.mail-archive.com/users@mina.apache.org/msg06948.html), also [linked at the

[GitHub] [mina-sshd] 4devwithgit opened a new issue, #311: Issue related to CVE-2022-45047

2023-01-16 Thread GitBox
4devwithgit opened a new issue, #311: URL: https://github.com/apache/mina-sshd/issues/311 ### Version 2.7.0 ### Bug description This is in regards to the security vulnerability, https://nvd.nist.gov/vuln/detail/CVE-2022-45047 In our code implementation for

[GitHub] [mina-sshd] garyiscoding opened a new issue, #310: What will cause the failure to open the channel?

2023-01-14 Thread GitBox
garyiscoding opened a new issue, #310: URL: https://github.com/apache/mina-sshd/issues/310 Hello, may I ask what will cause the failure to open the channel? Is this the exception caught in the log org.apache.sshd.common.SshException: DefaultOpenFuture[ChannelExec[id=123,

[GitHub] [mina-sshd] garyiscoding closed issue #306: Client startup sometimes take a long time

2023-01-14 Thread GitBox
garyiscoding closed issue #306: Client startup sometimes take a long time URL: https://github.com/apache/mina-sshd/issues/306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [mina-sshd] Ingo13F commented on issue #309: Allow for the use of HTTP or SOCKS proxies

2023-01-11 Thread GitBox
Ingo13F commented on issue #309: URL: https://github.com/apache/mina-sshd/issues/309#issuecomment-1378550899 Ah, yes sure. That's more of a wording issue then. I concur: The code from jGit for proxy handling should somehow make its way into MINA SSHD and all is good. -- This is an

[GitHub] [mina-sshd] Ingo13F commented on issue #309: Allow for the use of HTTP or SOCKS proxies

2023-01-11 Thread GitBox
Ingo13F commented on issue #309: URL: https://github.com/apache/mina-sshd/issues/309#issuecomment-1378490095 If I see this correctly this would be accomplished by subclassing SshClient and overwriting the connect method as well as implementing the ProxyConnectors. In my opinion, this is

[GitHub] [mina-sshd] tomaswolf commented on issue #309: Allow for the use of HTTP or SOCKS proxies

2023-01-10 Thread GitBox
tomaswolf commented on issue #309: URL: https://github.com/apache/mina-sshd/issues/309#issuecomment-1378337756 It is possible to connect via HTTP or SOCKS proxies with Apache MINA sshd. But the library does not provide this feature out of the box; users have to write their own code.

[GitHub] [mina-sshd] Ingo13F opened a new issue, #309: Allow for the use of HTTP or SOCKS proxies

2023-01-10 Thread GitBox
Ingo13F opened a new issue, #309: URL: https://github.com/apache/mina-sshd/issues/309 ### Description I am using MINA SSHD as part of Spring Integration 6.0.1 since it replaced the JSch SSH implementation there. However I was using a HTTP proxy to connect with JSch and this seems

[GitHub] [mina-sshd] tomaswolf commented on issue #302: requestNewKeysExchange may cause KeyExchangeMessageHandler into dead lock,cpu 100%

2023-01-09 Thread GitBox
tomaswolf commented on issue #302: URL: https://github.com/apache/mina-sshd/issues/302#issuecomment-1376388012 @zmrush can you give #308 a try? I think that should avoid this endless loop. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [mina-sshd] tomaswolf opened a new pull request, #308: GH-302: Fail writes after SSH session is closed

2023-01-09 Thread GitBox
tomaswolf opened a new pull request, #308: URL: https://github.com/apache/mina-sshd/pull/308 If there is an exception during KEX that causes the SSH session to be closed, fail any further write attempts by throwing an SshException. Otherwise KeyExchangeMessageHandler.writeOrEnqueue()

[GitHub] [mina-sshd] tomaswolf closed issue #293: Performance problems in tests (NIO2 and MINA, Linux only)

2023-01-08 Thread GitBox
tomaswolf closed issue #293: Performance problems in tests (NIO2 and MINA, Linux only) URL: https://github.com/apache/mina-sshd/issues/293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [mina-sshd] tomaswolf merged pull request #307: GH-293: Handle SFTP buffer sizes > server limit better

2023-01-08 Thread GitBox
tomaswolf merged PR #307: URL: https://github.com/apache/mina-sshd/pull/307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mina-sshd] tomaswolf commented on issue #293: Performance problems in tests (NIO2 and MINA, Linux only)

2023-01-07 Thread GitBox
tomaswolf commented on issue #293: URL: https://github.com/apache/mina-sshd/issues/293#issuecomment-1374645896 The problem in SFTP is caused by excessively jumping back and forth in the file on the server side. It manifests only with NIO2 and MINA but not with Netty because timing is

[GitHub] [mina] jon-valliere closed pull request #25: DIRMINA-1124 : make NioProcessor and NioSocketAcceptor extendable by removing final from class declaration

2023-01-07 Thread GitBox
jon-valliere closed pull request #25: DIRMINA-1124 : make NioProcessor and NioSocketAcceptor extendable by removing final from class declaration URL: https://github.com/apache/mina/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [mina] jon-valliere commented on pull request #25: DIRMINA-1124 : make NioProcessor and NioSocketAcceptor extendable by removing final from class declaration

2023-01-07 Thread GitBox
jon-valliere commented on PR #25: URL: https://github.com/apache/mina/pull/25#issuecomment-1374629832 Closing because the patch was merged into main on https://gitbox.apache.org/repos/asf?p=mina.git;a=commit;h=53d96b92d4bf14fad2b87d8fdeca4ebc5019b6d8 -- This is an automated message from

[GitHub] [mina] jon-valliere merged pull request #33: Fixed small typo in `SslFilter`

2023-01-07 Thread GitBox
jon-valliere merged PR #33: URL: https://github.com/apache/mina/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

[GitHub] [mina] jon-valliere merged pull request #37: write direct buffer only once in APR

2023-01-07 Thread GitBox
jon-valliere merged PR #37: URL: https://github.com/apache/mina/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

[GitHub] [mina] jon-valliere commented on pull request #37: write direct buffer only once in APR

2023-01-07 Thread GitBox
jon-valliere commented on PR #37: URL: https://github.com/apache/mina/pull/37#issuecomment-1374624355 I take it back, since the `position()` is used when writing, it makes sense not to move the pointer. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [mina] jon-valliere commented on pull request #37: write direct buffer only once in APR

2023-01-07 Thread GitBox
jon-valliere commented on PR #37: URL: https://github.com/apache/mina/pull/37#issuecomment-1374621868 I spent the last 10 minutes trying to find the source code for `sendb`. The only thing I can find is the JNI definition for the function. Usually when a function takes in a `ByteBuffer`

[GitHub] [mina-sshd] tomaswolf opened a new pull request, #307: GH-293: Handle SFTP buffer sizes > server limit better

2023-01-07 Thread GitBox
tomaswolf opened a new pull request, #307: URL: https://github.com/apache/mina-sshd/pull/307 If a client uses an SFTP buffer size greater than the maximum amount of data the server is willing to return for an individual read request, data will be delivered with "holes". For instance, if

[GitHub] [mina] subes opened a new pull request, #37: write direct buffer only once

2023-01-07 Thread GitBox
subes opened a new pull request, #37: URL: https://github.com/apache/mina/pull/37 fixes an endless loop when writing a direct buffer in APR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [mina-sshd] tomaswolf closed issue #283: Client:Sent SSH_MSG_USERAUTH_REQUEST twice even PASSWORD_PROMPTS=1

2023-01-04 Thread GitBox
tomaswolf closed issue #283: Client:Sent SSH_MSG_USERAUTH_REQUEST twice even PASSWORD_PROMPTS=1 URL: https://github.com/apache/mina-sshd/issues/283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [mina-sshd] tomaswolf merged pull request #284: GH-283: Fix handling of CoreModuleProperties.PASSWORD_PROMPTS

2023-01-04 Thread GitBox
tomaswolf merged PR #284: URL: https://github.com/apache/mina-sshd/pull/284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mina-sshd] tomaswolf commented on issue #306: Client startup sometimes take a long time

2023-01-03 Thread GitBox
tomaswolf commented on issue #306: URL: https://github.com/apache/mina-sshd/issues/306#issuecomment-1369844383 Keeping the client open is certainly faster, but re-creating clients is also possible. JGit does so, for instance, and we never got any complaints. To find out why recreating

[GitHub] [mina-sshd] garyiscoding commented on issue #306: Client startup sometimes take a long time

2023-01-03 Thread GitBox
garyiscoding commented on issue #306: URL: https://github.com/apache/mina-sshd/issues/306#issuecomment-1369729305 > 9783ms is 9.783s, not 90s. > > It is impossible to answer this question from the information given. Might be anything, like the JVM having to load classes first, or

[GitHub] [mina-sshd] garyiscoding closed issue #306: Client startup sometimes take a long time

2023-01-03 Thread GitBox
garyiscoding closed issue #306: Client startup sometimes take a long time URL: https://github.com/apache/mina-sshd/issues/306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [mina-sshd] garyiscoding commented on issue #306: Client startup sometimes take a long time

2023-01-03 Thread GitBox
garyiscoding commented on issue #306: URL: https://github.com/apache/mina-sshd/issues/306#issuecomment-1369720307 > 9783ms is 9.783s, not 90s. > > It is impossible to answer this question from the information given. Might be anything, like the JVM having to load classes first, or

[GitHub] [mina-sshd] tomaswolf commented on issue #306: Client startup sometimes take a long time

2023-01-03 Thread GitBox
tomaswolf commented on issue #306: URL: https://github.com/apache/mina-sshd/issues/306#issuecomment-1369586061 9783ms is 9.783s, not 90s. It is impossible to answer this question from the information given. Might be anything, like the JVM having to load classes first, or garbage

[GitHub] [mina-sshd] garyiscoding opened a new issue, #306: Client startup sometimes take a long time

2023-01-03 Thread GitBox
garyiscoding opened a new issue, #306: URL: https://github.com/apache/mina-sshd/issues/306 ### Version 2.9.2 ### Bug description Sometimes the client starts quickly and sometimes slowly. long startTime = System.currentTimeMillis(); client =

[GitHub] [mina-sshd] tomaswolf commented on issue #293: Performance problems in tests (NIO2 and MINA, Linux only)

2023-01-02 Thread GitBox
tomaswolf commented on issue #293: URL: https://github.com/apache/mina-sshd/issues/293#issuecomment-1369168078 This is also reproducible for me in a CentOS 7 virtual machine running locally. From the logs I see that with NIO2 and MINA, there is a 40ms delay for getting these extra 1kB

[GitHub] [mina-sshd] tomaswolf commented on issue #283: Client:Sent SSH_MSG_USERAUTH_REQUEST twice even PASSWORD_PROMPTS=1

2023-01-02 Thread GitBox
tomaswolf commented on issue #283: URL: https://github.com/apache/mina-sshd/issues/283#issuecomment-1369166287 Absent an answer, I've pushed a fix to PR #284. It implements `CoreModuleProperties.PASSWORD_PROMPTS`as the equivalent of the OpenSSH config `NumberOfPasswordPrompts`. Only

[GitHub] [mina-sshd] tomaswolf closed issue #300: The variable sender of channelOpenConfirmation is possibly negative

2023-01-02 Thread GitBox
tomaswolf closed issue #300: The variable sender of channelOpenConfirmation is possibly negative URL: https://github.com/apache/mina-sshd/issues/300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [mina-sshd] tomaswolf merged pull request #305: GH-300: SSH_MSG_CHANNEL_OPEN_CONFIRMATION: channel ID is unsigned

2023-01-02 Thread GitBox
tomaswolf merged PR #305: URL: https://github.com/apache/mina-sshd/pull/305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mina-sshd] tomaswolf opened a new pull request, #305: GH-300: SSH_MSG_CHANNEL_OPEN_CONFIRMATION: channel ID is unsigned

2023-01-02 Thread GitBox
tomaswolf opened a new pull request, #305: URL: https://github.com/apache/mina-sshd/pull/305 Fix reading the id from the message, and add a test in which the server uses artificially high channel IDs beyond Integer.MAX_VALUE. Fixes #300. -- This is an automated message from the

[GitHub] [mina-sshd] tomaswolf closed issue #298: Server side heartbeat not working

2023-01-01 Thread GitBox
tomaswolf closed issue #298: Server side heartbeat not working URL: https://github.com/apache/mina-sshd/issues/298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [mina-sshd] tomaswolf merged pull request #303: GH-298: Start service in AbstractServerSession

2023-01-01 Thread GitBox
tomaswolf merged PR #303: URL: https://github.com/apache/mina-sshd/pull/303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mina-sshd] cl728 closed issue #304: How to disable the warning "Server at xxxx preseneted unverfied EC key"

2022-12-29 Thread GitBox
cl728 closed issue #304: How to disable the warning "Server at preseneted unverfied EC key" URL: https://github.com/apache/mina-sshd/issues/304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [mina-sshd] cl728 opened a new issue, #304: How to disable the warning "Server at xxxx preseneted unverfied EC key"

2022-12-27 Thread GitBox
cl728 opened a new issue, #304: URL: https://github.com/apache/mina-sshd/issues/304 ### Version 2.7.0 ### Bug description every time when the program connects to the remote host using apache-mina-sshd will print the WARN log like "Server at xxx presented unverfied EC

[GitHub] [mina-sshd] tomaswolf opened a new pull request, #303: GH-298: Start service in AbstractServerSession

2022-12-26 Thread GitBox
tomaswolf opened a new pull request, #303: URL: https://github.com/apache/mina-sshd/pull/303 Services need to be started. In particular, the connection service starts its heartbeat, if configured, when started. It was already noticed in commit e74e2041 that the server-side did not start

[GitHub] [mina-sshd] tomaswolf commented on issue #298: Server side heartbeat not working

2022-12-26 Thread GitBox
tomaswolf commented on issue #298: URL: https://github.com/apache/mina-sshd/issues/298#issuecomment-1365428807 Indeed; you're right. It looks like this never worked, and was not caught because there was no test for server-side heartbeats. -- This is an automated message from the

[GitHub] [mina-sshd] thevipwan commented on issue #298: Server side heartbeat not working

2022-12-25 Thread GitBox
thevipwan commented on issue #298: URL: https://github.com/apache/mina-sshd/issues/298#issuecomment-1364823374 switch to version 2.9.2 but still not work;I use debug log and Wireshark(Capture port traffic) monitor heartbeat,I'm so confused about it, can you give me correct example code?

[GitHub] [mina-sshd] tomaswolf closed issue #297: SSHD Client failing on private key file with key password

2022-12-24 Thread GitBox
tomaswolf closed issue #297: SSHD Client failing on private key file with key password URL: https://github.com/apache/mina-sshd/issues/297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [mina-sshd] tomaswolf merged pull request #299: GH-297: SshClient: auto-configure for encrypted key identities

2022-12-24 Thread GitBox
tomaswolf merged PR #299: URL: https://github.com/apache/mina-sshd/pull/299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mina-sshd] zmrush commented on issue #302: requestNewKeysExchange may cause KeyExchangeMessageHandler into dead lock,cpu 100%

2022-12-23 Thread GitBox
zmrush commented on issue #302: URL: https://github.com/apache/mina-sshd/issues/302#issuecomment-1364450878 > Not enough information. Please provide full jstack traces as text file. If you have some code that can reproduce the behavior reliably that would also be helpful. > > With

[GitHub] [mina-sshd] zmrush commented on issue #302: requestNewKeysExchange may cause KeyExchangeMessageHandler into dead lock,cpu 100%

2022-12-23 Thread GitBox
zmrush commented on issue #302: URL: https://github.com/apache/mina-sshd/issues/302#issuecomment-1364450488 it happens occasionally,not always.i guess that when we write packet, the thread is in requestNewKeysExchange,so kexDone not fulfilled and the thread goes into "block =

[GitHub] [mina-sshd] tomaswolf commented on issue #302: requestNewKeysExchange may cause KeyExchangeMessageHandler into dead lock,cpu 100%

2022-12-23 Thread GitBox
tomaswolf commented on issue #302: URL: https://github.com/apache/mina-sshd/issues/302#issuecomment-1364179109 Not enough information. Please provide full jstack traces as text file. If you have some code that can reproduce the behavior reliably that would also be helpful. With just

[GitHub] [mina-sshd] zmrush commented on issue #302: requestNewKeysExchange may cause KeyExchangeMessageHandler into dead lock,cpu 100%

2022-12-23 Thread GitBox
zmrush commented on issue #302: URL: https://github.com/apache/mina-sshd/issues/302#issuecomment-1363931090 ![4D6AACE5-968A-475E-909D-5AF7CB62853A](https://user-images.githubusercontent.com/17923600/209339710-d6aa50f8-2078-4c5f-84ba-ed77b744d1d4.png) ![Uploading

[GitHub] [mina-sshd] zmrush opened a new issue, #302: requestNewKeysExchange may cause KeyExchangeMessageHandler into dead lock,cpu 100%

2022-12-23 Thread GitBox
zmrush opened a new issue, #302: URL: https://github.com/apache/mina-sshd/issues/302 ### Version 2.9.1 ### Bug description i observed in cases, the write packet thread is always running and in the interval i saw

[GitHub] [mina-sshd] tomaswolf commented on issue #298: Server side heartbeat not working

2022-12-22 Thread GitBox
tomaswolf commented on issue #298: URL: https://github.com/apache/mina-sshd/issues/298#issuecomment-1363696280 1. I see that you are using version 2.7.0. Please try with 2.9.2, or with the master version. 2. How do you verify whether the client gets heartbeat messages? -- This is an

[GitHub] [mina-sshd] thevipwan commented on issue #298: Server side heartbeat not working

2022-12-22 Thread GitBox
thevipwan commented on issue #298: URL: https://github.com/apache/mina-sshd/issues/298#issuecomment-1363561355 > SessionHeartbeatController.HeartbeatType.IGNORE Try this, but still can't get any heartbeats -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [mina-sshd] jiang1308061292 commented on issue #300: The variable sender of channelOpenConfirmation is possibly negative

2022-12-22 Thread GitBox
jiang1308061292 commented on issue #300: URL: https://github.com/apache/mina-sshd/issues/300#issuecomment-1363531638 > Yes. Do you want to provide a PR? Yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [mina-sshd] tomaswolf commented on issue #300: The variable sender of channelOpenConfirmation is possibly negative

2022-12-22 Thread GitBox
tomaswolf commented on issue #300: URL: https://github.com/apache/mina-sshd/issues/300#issuecomment-1363404457 Yes. Do you want to provide a PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [mina-sshd] tomaswolf closed issue #301: Get sender from cmd SSH_MSG_CHANNEL_OPEN_CONFIRMATION wrong could result exception

2022-12-22 Thread GitBox
tomaswolf closed issue #301: Get sender from cmd SSH_MSG_CHANNEL_OPEN_CONFIRMATION wrong could result exception URL: https://github.com/apache/mina-sshd/issues/301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [mina-sshd] tomaswolf commented on issue #301: Get sender from cmd SSH_MSG_CHANNEL_OPEN_CONFIRMATION wrong could result exception

2022-12-22 Thread GitBox
tomaswolf commented on issue #301: URL: https://github.com/apache/mina-sshd/issues/301#issuecomment-1362858864 This is a duplicate of #300. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [mina-sshd] AricBear opened a new issue, #301: Get sender from cmd SSH_MSG_CHANNEL_OPEN_CONFIRMATION wrong could result exception

2022-12-22 Thread GitBox
AricBear opened a new issue, #301: URL: https://github.com/apache/mina-sshd/issues/301 ### Version 2.9.2 ### Bug description While opening a channel, mina deals cmd of SSH_MSG_CHANNEL_OPEN_CONFIRMATION in

[GitHub] [mina-sshd] ascertsimonm commented on issue #297: SSHD Client failing on private key file with key password

2022-12-22 Thread GitBox
ascertsimonm commented on issue #297: URL: https://github.com/apache/mina-sshd/issues/297#issuecomment-1362725809 Heya Yes, something like that but having things done automatically is better. Thanks Simon -- This is an automated message from the Apache Git Service. To

[GitHub] [mina-sshd] jiang1308061292 commented on issue #300: The variable sender of channelOpenConfirmation is possibly negative

2022-12-22 Thread GitBox
jiang1308061292 commented on issue #300: URL: https://github.com/apache/mina-sshd/issues/300#issuecomment-1362576297 public void channelOpenConfirmation(Buffer buffer) throws IOException { Channel channel = this.getChannel((byte)91, buffer); if (channel != null) {

[GitHub] [mina-sshd] jiang1308061292 opened a new issue, #300: The variable sender of channelOpenConfirmation is possibly negative

2022-12-22 Thread GitBox
jiang1308061292 opened a new issue, #300: URL: https://github.com/apache/mina-sshd/issues/300 ### Version 2.9.2 ### Bug description The remote side then decides whether it can open the channel, and responds with either SSH_MSG_CHANNEL_OPEN_CONFIRMATION or

[GitHub] [mina-sshd] tomaswolf opened a new pull request, #299: GH-297: SshClient: auto-configure for encrypted key identities

2022-12-21 Thread GitBox
tomaswolf opened a new pull request, #299: URL: https://github.com/apache/mina-sshd/pull/299 Automatically configure KeyIdentityProviders to use the FilePasswordProvider set on the client if they don't have an explicit password provider already. This simplifies setting up a client to

[GitHub] [mina-sshd] tomaswolf closed issue #294: Memory Leak in SftpFileSystemProvider

2022-12-21 Thread GitBox
tomaswolf closed issue #294: Memory Leak in SftpFileSystemProvider URL: https://github.com/apache/mina-sshd/issues/294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [mina-sshd] tomaswolf merged pull request #295: GH-294: Fix memory leaks in SftpFileSystemProvider

2022-12-21 Thread GitBox
tomaswolf merged PR #295: URL: https://github.com/apache/mina-sshd/pull/295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mina-sshd] tomaswolf closed issue #298: Server side heartbeat not working

2022-12-21 Thread GitBox
tomaswolf closed issue #298: Server side heartbeat not working URL: https://github.com/apache/mina-sshd/issues/298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [mina-sshd] tomaswolf commented on issue #298: Server side heartbeat not working

2022-12-21 Thread GitBox
tomaswolf commented on issue #298: URL: https://github.com/apache/mina-sshd/issues/298#issuecomment-1362479575 Why did you expect any heartbeats to be sent when you set heartbeat type `NONE`? Try `SessionHeartbeatController.HeartbeatType.IGNORE`. -- This is an automated message

[GitHub] [mina-sshd] thevipwan opened a new issue, #298: Server side heartbeat not working

2022-12-21 Thread GitBox
thevipwan opened a new issue, #298: URL: https://github.com/apache/mina-sshd/issues/298 ### Version master ### Bug description dependency: ``` org.apache.sshd sshd-core 2.7.0 ``` Code: ``` SshServer sshd =

[GitHub] [mina-sshd] tomaswolf commented on issue #297: SSHD Client failing on private key file with key password

2022-12-21 Thread GitBox
tomaswolf commented on issue #297: URL: https://github.com/apache/mina-sshd/issues/297#issuecomment-1361969405 If you mean that you added in [SshClientCliSupport, line

[GitHub] [mina-sshd] ascertsimonm opened a new issue, #297: SSHD Client failing on private key file with key password

2022-12-21 Thread GitBox
ascertsimonm opened a new issue, #297: URL: https://github.com/apache/mina-sshd/issues/297 ### Version 2.9.2 ### Bug description When attempting to run the SSH client with that private key file that is protected with a password the Mina SSH client doesn't make the

[GitHub] [mina-sshd] onyas commented on pull request #242: Fix: close session when timeout during connect

2022-12-20 Thread GitBox
onyas commented on PR #242: URL: https://github.com/apache/mina-sshd/pull/242#issuecomment-1360632397 Got it. Thank you for your contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [mina-sshd] tomaswolf commented on issue #296: [Support Request] Read only VirtualFileSystemFactory

2022-12-20 Thread GitBox
tomaswolf commented on issue #296: URL: https://github.com/apache/mina-sshd/issues/296#issuecomment-1360277406 I looked at that a while ago myself in the context of [Gerrit issue 15944](https://bugs.chromium.org/p/gerrit/issues/detail?id=15944). I didn't see immediately how to do that.

[GitHub] [mina-sshd] ThanasisBarekas opened a new issue, #296: [Support Request] Read only VirtualFileSystemFactory

2022-12-20 Thread GitBox
ThanasisBarekas opened a new issue, #296: URL: https://github.com/apache/mina-sshd/issues/296 Hello, Is it possible to create a read only VirtualFileSystemFactory ? if yes can you please share an example ? Thank you, Thanasis -- This is an automated message from the

[GitHub] [mina-sshd] tomaswolf commented on a diff in pull request #295: GH-294: Fix memory leaks in SftpFileSystemProvider

2022-12-20 Thread GitBox
tomaswolf commented on code in PR #295: URL: https://github.com/apache/mina-sshd/pull/295#discussion_r1053561160 ## sshd-sftp/src/test/java/org/apache/sshd/sftp/client/fs/SftpFileSystemTest.java: ## @@ -87,6 +89,7 @@ import org.junit.runners.MethodSorters; import

[GitHub] [mina-sshd] tomaswolf commented on a diff in pull request #295: GH-294: Fix memory leaks in SftpFileSystemProvider

2022-12-20 Thread GitBox
tomaswolf commented on code in PR #295: URL: https://github.com/apache/mina-sshd/pull/295#discussion_r1053192599 ## sshd-sftp/src/test/java/org/apache/sshd/sftp/client/fs/SftpFileSystemTest.java: ## @@ -87,6 +89,7 @@ import org.junit.runners.MethodSorters; import

[GitHub] [mina-sshd] tomaswolf commented on pull request #242: Fix: close session when timeout during connect

2022-12-20 Thread GitBox
tomaswolf commented on PR #242: URL: https://github.com/apache/mina-sshd/pull/242#issuecomment-1359155156 I can't promise anything. All the maintainers in this project are unpaid volunteers doing this in their spare time. I wrote in October I'd be working on this, and I am, but progress

[GitHub] [mina-sshd] onyas commented on pull request #242: Fix: close session when timeout during connect

2022-12-19 Thread GitBox
onyas commented on PR #242: URL: https://github.com/apache/mina-sshd/pull/242#issuecomment-1358715900 Is there any possibility to release it early next year? our customer is eager to get this fixed. If not, can you provide any plan so that we can set the expectation for the customer.

[GitHub] [mina-sshd] tomaswolf commented on issue #294: Memory Leak in SftpFileSystemProvider

2022-12-19 Thread GitBox
tomaswolf commented on issue #294: URL: https://github.com/apache/mina-sshd/issues/294#issuecomment-1358527146 Thanks for pointing out this bug. It should be fixed by the referenced pull request. But personally I'm not convinced using a ThreadLocal to store these wrappers is a good

[GitHub] [mina-sshd] tomaswolf opened a new pull request, #295: GH-294: Fix memory leaks in SftpFileSystemProvider

2022-12-19 Thread GitBox
tomaswolf opened a new pull request, #295: URL: https://github.com/apache/mina-sshd/pull/295 SftpFileSystem.getClient() returns reference-counted wrapper instances that need to be closed to avoid a memory leak via ThreadLocals. Make sure that the streams returned by

[GitHub] [mina-sshd] tomaswolf merged pull request #292: Fix the channel window logic

2022-12-19 Thread GitBox
tomaswolf merged PR #292: URL: https://github.com/apache/mina-sshd/pull/292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mina-sshd] luchenguang commented on issue #294: Memory Leak in SftpFileSystemProvider

2022-12-19 Thread GitBox
luchenguang commented on issue #294: URL: https://github.com/apache/mina-sshd/issues/294#issuecomment-1357686187 Meet the same question when using SftpFileSystem, seems to be caused by SftpFileSystem using a ThreadLocal to cache a sftp client but unable to clear it -- This is an

[GitHub] [mina-sshd] sparkchans opened a new issue, #294: Memory Leak in SftpFileSystemProvider

2022-12-18 Thread GitBox
sparkchans opened a new issue, #294: URL: https://github.com/apache/mina-sshd/issues/294 ### Version master ### Bug description The newInputStream and newOutputStream methods of SftpFileSystemProvider call the SftpFileSystem#getClient() method without call the close()

[GitHub] [mina-sshd] tomaswolf commented on issue #293: Performance problems in tests (NIO2, MINA, ubuntu)

2022-12-17 Thread GitBox
tomaswolf commented on issue #293: URL: https://github.com/apache/mina-sshd/issues/293#issuecomment-1356404731 Partial problem cause: in the **SftpTransferTest**, the problem is the SFTP buffer size of 64kB in `testTransferIntegrityWithBufferLargerThanPacket`. That is 1kB more than the

[GitHub] [mina-sshd] tomaswolf opened a new issue, #293: Performance problems in tests (NIO2, MINA, ubuntu)

2022-12-17 Thread GitBox
tomaswolf opened a new issue, #293: URL: https://github.com/apache/mina-sshd/issues/293 Looking through the GitHub build logs, there seems to be a problem with two tests on Linux, with the NIO2 or MINA transport back-ends. They show very poor performance:

  1   2   3   4   5   6   7   8   9   10   >