RE: SFTP problems

2010-05-10 Thread Frank van der Kleij
Great! and thanks > Date: Mon, 10 May 2010 07:33:45 +0200 > Subject: Re: SFTP problems > From: gno...@gmail.com > To: dev@mina.apache.org > > I think I've actually fixed the issue. The problem is that in version 3, > the reply to SSH_FXP_REALPATH should always

Re: SFTP problems

2010-05-09 Thread Guillaume Nodet
I think I've actually fixed the issue. The problem is that in version 3, the reply to SSH_FXP_REALPATH should always send back dummy attributes. On Sun, May 9, 2010 at 16:15, Frank van der Kleij wrote: > > I was doing some tests and found a problem on uploading. > > When doing the upload REALPA

Re: SFTP problems

2010-05-09 Thread Guillaume Nodet
If you look at sshd-core/src/docs/draf-ietf-secsh-filexfer-13.txt, the SSH_FXP_REALPATH can include a control byte, and the default value is SSH_FXP_REALPATH_NO_CHECK which means that the call must not fail. I guess we should check this flag correctly and default to the right behavior (which would

RE: SFTP problems

2010-05-09 Thread Frank van der Kleij
I was doing some tests and found a problem on uploading. When doing the upload REALPATH is called on the file that is about to be created, but in writeAttrs there is a check whether the file actually exists and an exception is thrown. When I remove the exception throwing in writeAttrs then all

Re: SFTP problems

2010-05-06 Thread Guillaume Nodet
Sorry, i missed that call. Last try ? On Thu, May 6, 2010 at 17:39, Frank van der Kleij wrote: > > > Hi Guillaume, > > I still have the FileNotFoundException when I start in e.g. d:\temp with > > f = new File(normalizedPath); > > For me it works only with f = resolveFile(normalizedPath); > > Wha

RE: SFTP problems

2010-05-06 Thread Frank van der Kleij
Hi Guillaume, I still have the FileNotFoundException when I start in e.g. d:\temp with f = new File(normalizedPath); For me it works only with f = resolveFile(normalizedPath); What are your settings? Do you start in '/' on Mac? Regards

Re: SFTP problems

2010-05-06 Thread Guillaume Nodet
Wanna give it another try ? About adding the SFTP subsystem by default, I have no real opinion. I'm just not sure if people would be willing to give access to the file system by default. On Thu, May 6, 2010 at 15:03, Sai Pullabhotla wrote: > I've setup the root directory for the SFTP subsystem t

Re: SFTP problems

2010-05-06 Thread Sai Pullabhotla
I've setup the root directory for the SFTP subsystem to be "C:\". The login, and cd'ing, listing to subdirectories is working fine. But, I cannot "cd" to C:\ again using "cd ..". So if my working directory is "/dev", doing a "cd .." should put me back in "/" (whose real path is "C:\"). But the dir

Re: SFTP problems

2010-05-06 Thread Guillaume Nodet
Well, the problem i had was when resolving the root dir, i could end with an empty file name, which would cause parsing errors in filezilla when sending the getLongFileName(). We need to always return a name, but maybe there's a better way. On Thu, May 6, 2010 at 13:58, Frank van der Kleij wrote:

RE: SFTP problems

2010-05-06 Thread Frank van der Kleij
I'm testing on Windows in a non-root directory and the folder navigation works but I have errors in the log because of this: line 790: f = new File(normalizedPath); if (f.getName().length() == 0) { f = new File(f, "."); } It causes errors in writeAttrs because the

Re: SFTP problems

2010-05-06 Thread Guillaume Nodet
I've made a few other fixes (including SSHD-86) which helps a lot. Please have a look and i'll cut a release tonight or tomorrow. On Wed, May 5, 2010 at 21:18, Guillaume Nodet wrote: > Thanks for the pointer. The SFTP subsystem is now using that code. > Any more issues ? > > On Wed, May 5, 2010

SFTP problems

2010-05-05 Thread Guillaume Nodet
Thanks for the pointer. The SFTP subsystem is now using that code. Any more issues ? On Wed, May 5, 2010 at 18:43, Sai Pullabhotla wrote: > Okay, I see the fix for the dates, but they are still incorrect when > the client interprets its. Couple of things - > > I believe time should be on a 24 ho