[jira] [Assigned] (MNEMONIC-363) Missing mnemonic-query module in source-assembly.xml

2017-08-31 Thread Wang, Gang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MNEMONIC-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wang, Gang reassigned MNEMONIC-363:
---

Assignee: Wang, Gang

> Missing mnemonic-query module in source-assembly.xml
> 
>
> Key: MNEMONIC-363
> URL: https://issues.apache.org/jira/browse/MNEMONIC-363
> Project: Mnemonic
>  Issue Type: Bug
>  Components: Release
>Affects Versions: 0.9.0-incubating
>Reporter: Wang, Gang
>Assignee: Wang, Gang
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-mnemonic pull request #65: Adding java docs to travis

2017-08-31 Thread bigdata-memory 
Github user bigdata-memory commented on a diff in the pull request:

https://github.com/apache/incubator-mnemonic/pull/65#discussion_r136454730
  
--- Diff: .travis.yml ---
@@ -37,6 +37,6 @@ install:
 
 script:
   - ls -l $TRAVIS_BUILD_DIR
-  - docker run -v $TRAVIS_BUILD_DIR:/ws/incubator-mnemonic --rm -t 
mnemonic/mneci /bin/bash -c "cd /ws/incubator-mnemonic; git log -1 --stat; git 
clean -xdf; mvn clean install"
+  - docker run -v $TRAVIS_BUILD_DIR:/ws/incubator-mnemonic --rm -t 
mnemonic/mneci /bin/bash -c "cd /ws/incubator-mnemonic; git log -1 --stat; git 
clean -xdf; mvn clean install; mvn javadoc:javadoc"
--- End diff --

or use
mvn clean install && mvn javadoc:javadoc



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-mnemonic pull request #65: Adding java docs to travis

2017-08-31 Thread bigdata-memory 
Github user bigdata-memory commented on a diff in the pull request:

https://github.com/apache/incubator-mnemonic/pull/65#discussion_r136454237
  
--- Diff: .travis.yml ---
@@ -37,6 +37,6 @@ install:
 
 script:
   - ls -l $TRAVIS_BUILD_DIR
-  - docker run -v $TRAVIS_BUILD_DIR:/ws/incubator-mnemonic --rm -t 
mnemonic/mneci /bin/bash -c "cd /ws/incubator-mnemonic; git log -1 --stat; git 
clean -xdf; mvn clean install"
+  - docker run -v $TRAVIS_BUILD_DIR:/ws/incubator-mnemonic --rm -t 
mnemonic/mneci /bin/bash -c "cd /ws/incubator-mnemonic; git log -1 --stat; git 
clean -xdf; mvn clean install; mvn javadoc:javadoc"
--- End diff --

How about to use following one maven command instead of two?
mvn clean install javadoc:javadoc


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-mnemonic pull request #64: Fixed MNEMONIC-361: Fails to generate J...

2017-08-31 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-mnemonic/pull/64


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (MNEMONIC-361) Fails to generate Javadocs

2017-08-31 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/MNEMONIC-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149338#comment-16149338
 ] 

ASF GitHub Bot commented on MNEMONIC-361:
-

GitHub user bigdata-memory opened a pull request:

https://github.com/apache/incubator-mnemonic/pull/64

Fixed MNEMONIC-361: Fails to generate Javadocs

Added required comments and removed an unexpected character.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/NonVolatileComputing/incubator-mnemonic master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-mnemonic/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #64


commit 43b57b67ef19dcaf52fbf929efd071ba75a5add3
Author: Wang, Gang(Gary) 
Date:   2017-08-31T17:47:24Z

MNEMONIC-361: Fails to generate Javadocs




> Fails to generate Javadocs
> --
>
> Key: MNEMONIC-361
> URL: https://issues.apache.org/jira/browse/MNEMONIC-361
> Project: Mnemonic
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 0.9.0-incubating
>Reporter: Johnu George
>Assignee: Wang, Gang
> Fix For: 0.9.0-incubating
>
>
> ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:2.10.3:jar (attach-javadocs) on 
> project mnemonic-core: MavenReportException: Error while generating Javadoc:
> [ERROR] Exit code: 1 - 
> /ws/release/incubator-mnemonic/mnemonic-core/src/main/java/org/apache/mnemonic/Allocator.java:36:
>  warning: no @param for addr
> [ERROR] void sync(long addr, long length, boolean autodetect);
> [ERROR] ^
> [ERROR] 
> /ws/release/incubator-mnemonic/mnemonic-core/src/main/java/org/apache/mnemonic/Allocator.java:36:
>  warning: no @param for length
> [ERROR] void sync(long addr, long length, boolean autodetect);
> [ERROR] ^
> [ERROR] 
> /ws/release/incubator-mnemonic/mnemonic-core/src/main/java/org/apache/mnemonic/Allocator.java:36:
>  warning: no @param for autodetect
> [ERROR] void sync(long addr, long length, boolean autodetect);
> [ERROR] ^
> [ERROR] 
> /ws/release/incubator-mnemonic/mnemonic-core/src/main/java/org/apache/mnemonic/NonVolatileMemAllocator.java:613:
>  error: @param name not found
> [ERROR] * @param readOnly
> [ERROR] ^
> [ERROR] 
> /ws/release/incubator-mnemonic/mnemonic-core/src/main/java/org/apache/mnemonic/SysMemAllocator.java:154:
>  warning: no description for @param
> [ERROR] * @param addr
> [ERROR] ^
> [ERROR] 
> /ws/release/incubator-mnemonic/mnemonic-core/src/main/java/org/apache/mnemonic/SysMemAllocator.java:155:
>  warning: no description for @param
> [ERROR] * @param length
> [ERROR] ^
> [ERROR] 
> /ws/release/incubator-mnemonic/mnemonic-core/src/main/java/org/apache/mnemonic/SysMemAllocator.java:156:
>  warning: no description for @param
> [ERROR] * @param autodetect
> [ERROR] ^
> [ERROR] 
> [ERROR] Command line was: 
> /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.141-1.b16.el7_3.x86_64/jre/../bin/javadoc
>  @options @packages
> [ERROR] 
> [ERROR] Refer to the generated Javadoc files in 
> '/ws/release/incubator-mnemonic/mnemonic-core/target/apidocs' dir.
> [ERROR] -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [DISCUSS] Graduation?

2017-08-31 Thread Wen Tong 
+1 support for graduation.

On Thu, Aug 31, 2017 at 5:35 AM, Wei HE  wrote:
> +1 support for graduation.
>
> Wei HE
>
> On Mon, Aug 28, 2017 at 4:40 PM, Gang(Gary) Wang  wrote:
>
>> Yes, I also totally agree this and we will try our best for the readiness
>> for the graduation.
>>
>> For the suggestion that John advised, we have prepared the following
>> comments for your review, Thanks!
>>
>> *CD20 - You have a link in your header called GITHUB that brought me to
>> your source code.  Other projects use hacking guides.  Unless you're on
>> gitbox, the git primary repo should be the ASF hosted repos.*
>>
>> The github link has been removed from CD20 and using
>> http://mnemonic.incubator.apache.org/develop/ as the link of website. we
>> also create ticket MNEMONIC-355 (resolved) to remove Github link from
>> navigator menu on website.
>>
>> *CD30 - The usage of docker is in of itself a violation of this item, from
>> my point of view.  In your case, you're pointing to "centos:latest" which
>> today is C7.2, but in a few months will be C7.3.*
>>
>> Yes, we will fix it through Apache Jira MNEMONIC-353(reviewed) and
>> MNEMONIC-356(WIP)
>>
>> *CD50 - I can't tell if the pull requests to your repo are from committers
>> or from contributors.  If I take
>> https://github.com/apache/incubator-mnemonic/pull/60
>>  as an example, the
>> commit message says nothing about provenance of the source code.*
>>
>> We have requested to revoke all stalled PRs, and all commit messages must
>> contain Apache JIRA number and title.
>>
>> *LC50 - You mention in your response why this is incorrect (the use of
>> *most*)*
>>
>> Yes we will correct it with "The files in the project source repository
>> have appropriate headers", The files under target/ that generated by mvn
>> building process would be excluded and all other project files have been
>> properly licensed and guarded by RAT plugin.
>>
>> *RE10 - You link to http://mnemonic.incubator.apache.org/news/
>>  but that doesn't include any
>> download links.  http://mnemonic.incubator.apache.org/downloads/
>>  does include download
>> links to the proper release mirrors.*
>>
>> That has been corrected by replacing it with the link
>> http://mnemonic.incubator.apache.org/downloads/
>>
>> *RE20 - You mention non-PMC members in the vote (PPMC).*
>>
>> Yes, we started with the community vote for releasing and the result
>> explicitly shows binding and non-binding votes.
>>
>> *RE30 - Again, not using mirror.*
>>
>> Looks no mirror link in this field.
>>
>> *RE40 - Correct answer would be "NO. We do not distribute binary
>> releases."*
>>
>> Yes it is and corrected
>>
>> *RE50 - Your release process neglects deleting old artifacts.*
>>
>> Sorry I forgot it and corrected it by the Apache Jira ticket MNEMONIC-357
>> (resolved) as well as MNEMONIC-358 (resolved)
>>
>> *QU10 - Code quality is more than bug reports.  You may want to use
>> linters, sonar, etc.*
>>
>> Yes, we will investigate this plugin and apply them to project later, as
>> for now, the QU10 has been replaced with "YES. The project records all bugs
>> in the Apache’s JIRA issue tracker. Developer also uses Eclipse or Intellij
>> IDEA to improve their code quality."
>>
>> *QU20 - This is only achievable if you've had a security vulnerability
>> reported.  If you haven't had one reported, there's no way to confirm
>> this.*
>>
>> The QU20 has been replaced with "YES. Security issues would be treated with
>> the highest priority, computing service and memory service are separated
>> from other modules and defined by interfaces, so security concerns could be
>> largely mitigated by introduced this design at first place.", that this
>> emphasize we consider the security aspect from design viewpoint as well.
>>
>> *QU50 - I see that MNEMONIC-203/217 have been open for around 6 months.*
>>
>> We have asked owners to properly handle those tickets
>>
>> *CO10 - Github shows two pull requests open without any commentary or
>> questions from the project's committers.  Why is that?*
>>
>> They are stalled PRs, we have asked the owner to properly revoke them.
>>
>> *The full checklist as follows for you to add comments*
>> https://docs.google.com/document/d/10LKTjPMceV4s4MrSRIA9L8pg7jLFp
>> -ec-TmW96mZbXM/edit?usp=sharing
>>
>> Very truly yours
>> Gary
>>
>>
>>
>>
>>
>> On Mon, Aug 28, 2017 at 2:25 PM, John D. Ament 
>> wrote:
>>
>> > Huge +1 to that.
>> >
>> > On Mon, Aug 28, 2017 at 5:18 PM Henry Saputra 
>> > wrote:
>> >
>> > > The "checklist" suppose to just provide guide for readiness our
>> > > graduation. It was NOT mandatory checklist.
>> > >
>> > > This should be used primarily for self check to make sure we are ready
>> > for
>> > > graduation.
>> > >
>> > >
>> > > - Henry
>> > >
>> > > On