Re: Request for comments - Keras-MXNet as submodule in MXNet

2018-03-23 Thread sandeep krishnamurthy
1. I agree bringing whole keras-mxnet repo as submodule in MXNet is not the right thing to do. I was mainly proposing, a stripped version of keras-mxnet which has keras interface with MXNet backend in to MXNet enabling MXNet users to use Keras interface natively within MXNet (Ex: mx.keras) 2.

Re: MXNet C++ package improvements

2018-03-23 Thread Tianqi Chen
One quote that I really liked and related to this topic “the best design is achieved not when you have nothing to add, but when there is nothing to be taken away”. Most of the stable api decision we put into a project will become a technical debt, and a minimum clean design with equally powerful

Re: MXNet C++ package improvements

2018-03-23 Thread Tianqi Chen
+1 for hour-glass CAPI design. It is there for very good reason. For example, if you are windows user an want to build your app using mingw, current way works. While the raw c++ approach won’t due to the fact cuda is only supported by MSVC. The argument that c++ api itself is more elegant and

Re: Request for comments - Keras-MXNet as submodule in MXNet

2018-03-23 Thread Xingjian SHI
It should at least pass the review process. However, the Keras-MXNet has not passed the review by the keras team. Best, Xingjian From: Naveen Swamy Sent: Saturday, March 24, 2018 3:04 AM To: dev@mxnet.incubator.apache.org Subject: Re:

Re: Request for comments - Keras-MXNet as submodule in MXNet

2018-03-23 Thread Xingjian SHI
-1. We do not need to get the eyeballs this way. Asking users to use features that are not mature enough will only hurt the future development of MXNet. Xingjian From: Naveen Swamy Sent: Saturday, March 24, 2018 2:54 AM To:

Re: Request for comments - Keras-MXNet as submodule in MXNet

2018-03-23 Thread Yuan Tang
-1 I don't think this has significant difference. The adoption from existing Keras users will only come once it's landed in Keras repo. I doubt that many people will use it unless it's more stable and backward compatibility is guaranteed. On Fri, Mar 23, 2018 at 2:54 PM, Naveen Swamy

Re: Request for comments - Keras-MXNet as submodule in MXNet

2018-03-23 Thread Naveen Swamy
The proposal is about bringing a forked version of Keras(that works only with MXNet) into Apache MXNet repo submodule that way MXNet gets more eyeballs from existing Keras users and eventually Gluon, etc., , like Sandeep mentioned Keras has a large user base which MXNet could tap into. On Fri,

Re: Request for comments - Keras-MXNet as submodule in MXNet

2018-03-23 Thread Yao Wang
-1 Creating Keras as submodule of MXNet will provide users a feeling that MXNet depends on Keras. Keras is a frontend library which can be supported by various different backend framework. It would be better to add backend framework as Keras's submodule(Keras depends on MXNet) rather than

Re: Request for comments - Keras-MXNet as submodule in MXNet

2018-03-23 Thread Zhi Zhang
On 2018/03/23 05:49:07, sandeep krishnamurthy wrote: > Hello MXNet Community, > > Along with Lai, Karan and other MXNet contributors, I am working on adding > MXNet backend for Keras. Currently supporting around ~70% of Keras APIs > across CNNs and RNNs. >

Re: MXNet C++ package improvements

2018-03-23 Thread Eric Xie
I see several issues with the design. I've commented in the document but for record here: 1. cpp-package is almost only used for inference. since you are planning a rewrite that's almost certainly non-backward-compatible, we might as well create a new interface that's inference only. 2. The

Re: Request for comments - Keras-MXNet as submodule in MXNet

2018-03-23 Thread Xingjian SHI
-1. I think we should wait until it's merged into keras-team/keras. The repo is still not mature enough. Best, Xingjian From: sandeep krishnamurthy Sent: Friday, March 23, 2018 1:49 PM To: dev@mxnet.incubator.apache.org Subject:

Re: Request for comments - Keras-MXNet as submodule in MXNet

2018-03-23 Thread Eric Xie
-1 If you make MXNet a submodule of keras, then you should PR that to keras. If you want something like mxnet.keras, then you should do a full rewrite that only keeps the keras interface. On 2018/03/23 05:49:07, sandeep krishnamurthy wrote: > Hello MXNet

RE: call for contributions to next MXNet release

2018-03-23 Thread Zhao, Patric
Really thank Marco, Da and other reviewers' help :) I'd like to update the status of MKL-DNN bugs. Feel free to let me know if there're any other issues. There're 8 opened issues (1 discussion thread is not included). 2 issues are WIP and will be completed in next several days. #10189, Race

Re: Request for comments - Keras-MXNet as submodule in MXNet

2018-03-23 Thread Naveen Swamy
+1 > On Mar 22, 2018, at 11:11 PM, Chris Olivier wrote: > > +1 > > On Thu, Mar 22, 2018 at 10:49 PM sandeep krishnamurthy < > sandeep.krishn...@gmail.com> wrote: > >> Hello MXNet Community, >> >> Along with Lai, Karan and other MXNet contributors, I am working on

Re: Request for comments - Keras-MXNet as submodule in MXNet

2018-03-23 Thread Chris Olivier
+1 On Thu, Mar 22, 2018 at 10:49 PM sandeep krishnamurthy < sandeep.krishn...@gmail.com> wrote: > Hello MXNet Community, > > Along with Lai, Karan and other MXNet contributors, I am working on adding > MXNet backend for Keras. Currently supporting around ~70% of Keras APIs > across CNNs and