Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)

2018-06-25 Thread Anirudh
Hi Mu, Thanks for bringing this up and hopefully this should answer Sheng's question. Thomas pointed out something similar in the PR here for the warning message which I didn't notice back then: https://github.com/apache/incubator-mxnet/pull/11127 Not sure about the reasoning to not add it and if

Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)

2018-06-25 Thread Mu Li
Detailed documents should help, but the current warning message that "save_params is deprecated, use save_parameters instead" is not sufficient enough. Some details about the API changes: 1. v1.2 changed the implementation of "save_params", which is explained in the release note. The main benefit

Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)

2018-06-25 Thread Sheng Zha
Wouldn’t this break users who are on 1.2.0 and used our API correctly? Why do we have to revert load_params, given that it’s backward compatible? -sz > On Jun 25, 2018, at 6:30 PM, Anirudh wrote: > > Hi, > > 1.2.1 (load_params) is backward compatible with 1.1.0 not with 1.2.0. > It does not a

Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)

2018-06-25 Thread Sergio Fernández
Well, in the end, I guess, such issues can be always corrected with better documentation. On Mon, Jun 25, 2018, 18:29 Anirudh wrote: > Hi, > > 1.2.1 (load_params) is backward compatible with 1.1.0 not with 1.2.0. > It does not adhere exactly with semver but it had to be made, to quickly > help o

Re: Adding section on how to develop with MXNet to the website

2018-06-25 Thread Hagay Lupesko
Pedro, Anything that helps bring in more contributors is good IMO. But can you please clarify what you mean by "develop MXNet itself"? Hagay On Mon, Jun 25, 2018, 19:33 Markham, Aaron wrote: > More or less... Instructions are in the readme in the docs folder. Focus > on the developer sections.

Re: Adding section on how to develop with MXNet to the website

2018-06-25 Thread Markham, Aaron
More or less... Instructions are in the readme in the docs folder. Focus on the developer sections. Dependencies and other info is provided. Link to your info from the contribute page that's under community. Ping me if you need help. Sent from VMware Boxer On Jun 25, 2018 19:17, Pedro Larroy

Re: Adding section on how to develop with MXNet to the website

2018-06-25 Thread Naveen Swamy
Great idea, I think this will be an ongoing effort, can you try to improve the documentation here instead: https://cwiki.apache.org/confluence/display/MXNET/Development ? On Mon, Jun 25, 2018 at 7:16 PM, Pedro Larroy wrote: > Hi > > I want to add a section on how to develop MXNet itself to attr

Adding section on how to develop with MXNet to the website

2018-06-25 Thread Pedro Larroy
Hi I want to add a section on how to develop MXNet itself to attract contributors. Would this be acceptable for the website? Is there any recommended workflow for this? Any tools? is it going into docs and `make html` or something else? Thanks. Pedro

Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)

2018-06-25 Thread Anirudh
Hi, 1.2.1 (load_params) is backward compatible with 1.1.0 not with 1.2.0. It does not adhere exactly with semver but it had to be made, to quickly help our customers who were using the APIs incorrectly. Anirudh On Mon, Jun 25, 2018 at 5:42 PM, Sheng Zha wrote: > save_parameters didn't exist in

Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)

2018-06-25 Thread Sheng Zha
save_parameters didn't exist in 1.2.0 so its addition usually isn't supposed to happen in a patch release if we stick to semantic versioning. I couldn't find a discussion on this exception. Did it happen? Would people who used 1.2.0 to save models be able to load parameters in 1.2.1 using the reve

Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)

2018-06-25 Thread Anirudh
Hi Mu, The warining currently printed is "save_params is deprecated. Please use save_parameters." Isn't this similar to what you are suggesting ? Anirudh On Mon, Jun 25, 2018 at 3:47 PM, Mu Li wrote: > v1.2.1 will print a deprecating warning message when calling > save_params. We should tell u

Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)

2018-06-25 Thread Mu Li
v1.2.1 will print a deprecating warning message when calling save_params. We should tell users clearly to replace "save_params" with "save_parameters" or something else. On Mon, Jun 18, 2018 at 6:52 PM, Anirudh wrote: > Hi, > > This is the vote to release Apache MXNet (incubating) version 1.2.1.

Re: Abandoned MXNet readthedocs site

2018-06-25 Thread Markham, Aaron
Hi, just bumping this issue again. Can we get a trademark C&D sent to the readthedocs folks, so they'll go ahead and remove the derelict website? It's still the #4 result in Google for "mxnet install". What's Apache's process? Thanks, Aaron On 5/16/18, 8:20 AM, "Hen" wrote: It seems we

Re: Single-Machine Topology-aware Communication

2018-06-25 Thread Carl Yang
I added a few more figures showing how I got the MXNET_KVSTORE_GPUARRAY_BOUND value [Figures 7(b) and 7(c)]. I performed a microbenchmark measuring runtime in seconds vs. message size sent using MXNet's KVStore. Figure 7(b) shows the results of a crossover point around 1M. Beyond this point, multi-

Re: C++ api issue labeling

2018-06-25 Thread Marco de Abreu
+1 to renaming to Backend On Mon, Jun 25, 2018 at 10:13 AM Hagay Lupesko wrote: > Thanks Lin for your feedback. > Bumping again to get more feedback before concluding. > > On Fri, Jun 22, 2018 at 8:53 AM Lin Yuan wrote: > > > I agree with Hagay. Using "Backend" as label makes it much easier to

Re: C++ api issue labeling

2018-06-25 Thread Hagay Lupesko
Thanks Lin for your feedback. Bumping again to get more feedback before concluding. On Fri, Jun 22, 2018 at 8:53 AM Lin Yuan wrote: > I agree with Hagay. Using "Backend" as label makes it much easier to track. > "C++" label only describes the language used in implementation, "Backend" > better

Re: Single-Machine Topology-aware Communication

2018-06-25 Thread Pedro Larroy
Nice design document. From where does it come the default value of MXNET_KVSTORE_GPUARRAY_BOUND of 10M? Do you generate a tree for each GPU? Pedro. On Mon, Jun 18, 2018 at 2:30 PM Carl Yang wrote: > Hi, > > Currently, we have two methods for single-machine communication: > parameter server an