Re: Increase indentation limit from 100 to 120 characters

I read more google codes instead of amazon codes. That's why I used Google for example, not because Google is "our competitor", which term is actually disallowed to say by amazon employees. I think the question is not "there's a good reason *not to* increase", but "why we want to make such a

Re: Increase indentation limit from 100 to 120 characters

I don't think there is a strong argument in either way and an easy thing is to stay things as it is. I think it is just adoption of mindset or social momentum. Tianqi On Mon, Jan 8, 2018 at 11:35 AM, Chris Olivier wrote: > I don't care that much either way (100 or 120)

Re: Increase indentation limit from 100 to 120 characters

I don't care that much either way (100 or 120) because I twist my monitors vertically, so I have a lot of lines of code on the screen compared to most people and I am reasonably used to 100 at this point, but there's a lot of points like "our competitor does it this way" and "we've always done it

Re: Increase indentation limit from 100 to 120 characters

BTW, the current limit is 100 loc instead of 80 loc, which is mostly enough Tianqi On Mon, Jan 8, 2018 at 11:12 AM, Mu Li wrote: > I think this code should be refactored instead of increasing the indent. > Puting the test codes within 7 nested for loops is hard to read.

Re: Increase indentation limit from 100 to 120 characters

I think this code should be refactored instead of increasing the indent. Puting the test codes within 7 nested for loops is hard to read. Maybe we can split it into multiple functions, or create some templates, or try "using mxnet::op::BatchNormV1Prop" In general, I feel 80-column is not a big

Re: Increase indentation limit from 100 to 120 characters

+1 on 80 columns being a legacy standard which makes no sense today On Mon, Jan 8, 2018 at 9:45 AM, Barber, Christopher < christopher.bar...@analog.com> wrote: > For languages like C++ and Java it is hard to stay within 80 columns > without resorting to overly terse naming scheme or awkward

Re: Increase indentation limit from 100 to 120 characters

For languages like C++ and Java it is hard to stay within 80 columns without resorting to overly terse naming scheme or awkward indentation. 120 really makes a lot of sense for C++ and it seems easier to adopt the same standard throughout the codebase since it may be annoying or difficult to

Re: Increase indentation limit from 100 to 120 characters

It's probably good to have an example to help with discussion. Here's one that's been bugging us, and highlights why the current line length limit in C++ leads to hard-to-read code:

Re: Increase indentation limit from 100 to 120 characters

Just a note that I don't think Pedro was suggesting the change for Python or Scala. How would folks feel about changing the limit for just C++? On Sat, Jan 6, 2018 at 6:21 AM, Tianqi Chen wrote: > An argument against such change would be the coding style standard is >

Re: Increase indentation limit from 100 to 120 characters

An argument against such change would be the coding style standard is people already get used to it, and there is less benefit of making the change. PEP and Google C style suggest 80 chars as limit, I usually write with that in mind and try to break multiple arguments into multiple lines when

Re: Increase indentation limit from 100 to 120 characters

wellmax line length as 100 is adopted in many projects (nearly all projects I have been involved or used or looked at, spark/flink/bahir/atlas, etc. companies which using scala intensively also sets it to 100 (e.g. netflix, you can check their atlas project)) one of the reasons is that all

Re: Increase indentation limit from 100 to 120 characters

Why -1? On Fri, Jan 5, 2018 at 11:03 AM, Nan Zhu wrote: > -1 for scala part > > On Fri, Jan 5, 2018 at 9:48 AM, Marco de Abreu < > marco.g.ab...@googlemail.com > > wrote: > > > +1 > > > > Am 05.01.2018 5:49 nachm. schrieb "Chris Olivier" >: > > >

Re: Increase indentation limit from 100 to 120 characters

-1 for scala part On Fri, Jan 5, 2018 at 9:48 AM, Marco de Abreu wrote: > +1 > > Am 05.01.2018 5:49 nachm. schrieb "Chris Olivier" : > > +1 > > On Fri, Jan 5, 2018 at 8:00 AM, Pedro Larroy > > wrote: > > > Hi

Re: Increase indentation limit from 100 to 120 characters

+1 Am 05.01.2018 5:49 nachm. schrieb "Chris Olivier" : +1 On Fri, Jan 5, 2018 at 8:00 AM, Pedro Larroy wrote: > Hi > > Can we please increase the indent limit from 100 to 120? I find 100 > too low for current standards and today's monitors.