Re: Apache MXNet v1.4.0 release status

2019-01-20 Thread kellen sunderland
Hey Steffen, thanks for allowing a little extra time to merge PRs. All my PRs are in. #13905 looks good to me, but we may want someone a little more familiar to MKLDNN / the ndarray.h file review as well. On Sun, Jan 20, 2019 at 11:53 AM Steffen Rochel wrote: > Still waiting for merge of > htt

Re: Apache MXNet v1.4.0 release status

2019-01-20 Thread Steffen Rochel
Still waiting for merge of https://github.com/apache/incubator-mxnet/pull/13905 All other PR are merged and CI tests are passing. Please no more changes on 1.4.x branch beside merge for PR 13905, so we can move forward with 1.4.0 release. Best Regards, Steffen On Fri, Jan 18, 2019 at 9:48 AM Ste

Re: Random data in tests produces unstable test coverage

2019-01-20 Thread Marco de Abreu
That's a great question! Since we record branch-coverage as well, we would now reliably notice these test-gaps and could make targeted tests. Additionally, we could define test-coverage thresholds for certain files to enforce this - e.g. 100% for all operators. While the stochastic approach certai

Re: Random data in tests produces unstable test coverage

2019-01-20 Thread Chris Olivier
wouldn’t abandoning stochastic testing mean that execution paths would no longer be tested and therefore increase issues found in production? On Sun, Jan 20, 2019 at 5:13 AM Marco de Abreu wrote: > Hello everyone, > > a few months ago, I have enabled test coverage recording for the MXNet > repos

Re: [Article] Object Detection with Clojure MXNet

2019-01-20 Thread Carin Meier
Thanks - props for the images belongs to the original Scala article https://medium.com/apache-mxnet/object-detection-with-mxnet-scala-inference-api-9049230c77fd and Kedar - the contributor that ported the object detection feature to Clojure. They are pretty awesome though. On Sat, Jan 19, 2019 a

Random data in tests produces unstable test coverage

2019-01-20 Thread Marco de Abreu
Hello everyone, a few months ago, I have enabled test coverage recording for the MXNet repository [1]. The next step would be to report the coverage changes to pull requests so we can make them part of the review. For this, I've created a pull request here at [2]. Before this feature can be enabl