Re: New PMC member: Dick Carter
Finally! Welcome! On Tue, May 21, 2019 at 6:28 PM Steffen Rochel wrote: > > Congratulation Dick! > > On Tue, May 21, 2019 at 2:43 PM Carin Meier wrote: > > > Congrats and welcome! > > > > On Tue, May 21, 2019 at 4:37 PM Marco de Abreu > > wrote: > > > > > The Project Management Committee (PMC) for Apache MXNet > > > has invited Dick Carter to become a PMC member and we are pleased > > > to announce that he has accepted. > > > > > > Dick has been a great help over the past years to make MXNet as > > > efficient and easy-to-use on GPU as possible, reduce technical debt, > > > improve our testing experience around flaky tests and providing senior > > > guidance within the project. > > > > > > Being a committer enables easier contribution to the > > > project since there is no need to go via the patch > > > submission process. This should enable better productivity. > > > Being a PMC member enables assistance with the management > > > and to guide the direction of the project. > > > > > > Best regards, > > > Marco de Abreu > > > > >
Re: [ANNOUNCEMENT] New Committer: Przemyslaw Tredak (ptrendx)
Welcome! On Tue, May 21, 2019 at 3:55 PM Steffen Rochel wrote: > > Congratulations Przemyslaw! > > On Tue, May 21, 2019 at 3:38 PM Marco de Abreu > wrote: > > > Welcome! > > > > On Tue, May 21, 2019 at 11:48 PM Carin Meier wrote: > > > > > Welcome! > > > > > > On Tue, May 21, 2019 at 5:32 PM Naveen Swamy wrote: > > > > > > > The Project Podling Management Committee (PPMC) for Apache MXNet has > > > > invited Przemyslaw Tredak (ptrendx) based on his contribution to MXNet > > to > > > > become a committer and we are pleased to announce that he has accepted. > > > > > > > > Przemyslaw, thanks a lot for your contribution and continued effort to > > > > support MXNet community. > > > > > > > > Please join me in welcoming Przemyslaw to the project! > > > > > > > > Thanks, Naveen > > > > (on behalf of Apache MXNet PPMC) > > > > > > > > >
Re: DGL crashes in the recent master branch
Yes, I created an issue in MXNet github: https://github.com/apache/incubator-mxnet/issues/15029, which shows a piece of small code that reproduces the bug. The bug should be related to this PR: https://github.com/apache/incubator-mxnet/pull/14570. Another update in the progress is that the DLPack bug has been fixed and merged to MXNet. Best, Da On Tue, May 21, 2019 at 6:48 PM Chris Olivier wrote: > > Might be helpful if you wrote a unit test for this and other behaviors that > DGL depends upon to reduce the likelihood that it happens again. Just a > suggestion. That would show good ownership, imho. > > On Tue, May 21, 2019 at 6:11 PM Chris Olivier wrote: > > > Thanks for clarifying, Da. > > > > On Tue, May 21, 2019 at 5:44 PM Zheng, Da > > wrote: > > > >> DGL is a framework of deep learning on graphs. https://www.dgl.ai/ > >> > >> It's not that MXNet is responsible to be compatible with DGL. The crashes > >> are caused by bugs in MXNet. > >> > >> Best, > >> Da > >> > >> On 5/21/19, 5:39 PM, "Chris Olivier" wrote: > >> > >> Curious what is DGL and what is Apache/MXNet’s responsibility to it to > >> maintain compatibility rather than the other way around? > >> > >> On Tue, May 21, 2019 at 3:39 PM Zheng, Da > >> wrote: > >> > >> > Hello all, > >> > > >> > I recently find that DGL don’t run with the recent MXNet. DGL > >> crashes with > >> > memory errors. > >> > Yesterday we have identified a bug in DLPack and Junru has > >> implemented a > >> > fix: https://github.com/apache/incubator-mxnet/pull/15016 > >> > However, there are some other bugs that causes DGL to crash with a > >> memory > >> > error. I’m still searching among the PRs to identify the one that > >> causes > >> > the issue. I think we should make sure that MXNet 1.5 release works > >> with > >> > DGL correctly. > >> > > >> > Best, > >> > Da > >> > > >> > >> > >>
Re: DGL crashes in the recent master branch
Might be helpful if you wrote a unit test for this and other behaviors that DGL depends upon to reduce the likelihood that it happens again. Just a suggestion. That would show good ownership, imho. On Tue, May 21, 2019 at 6:11 PM Chris Olivier wrote: > Thanks for clarifying, Da. > > On Tue, May 21, 2019 at 5:44 PM Zheng, Da > wrote: > >> DGL is a framework of deep learning on graphs. https://www.dgl.ai/ >> >> It's not that MXNet is responsible to be compatible with DGL. The crashes >> are caused by bugs in MXNet. >> >> Best, >> Da >> >> On 5/21/19, 5:39 PM, "Chris Olivier" wrote: >> >> Curious what is DGL and what is Apache/MXNet’s responsibility to it to >> maintain compatibility rather than the other way around? >> >> On Tue, May 21, 2019 at 3:39 PM Zheng, Da >> wrote: >> >> > Hello all, >> > >> > I recently find that DGL don’t run with the recent MXNet. DGL >> crashes with >> > memory errors. >> > Yesterday we have identified a bug in DLPack and Junru has >> implemented a >> > fix: https://github.com/apache/incubator-mxnet/pull/15016 >> > However, there are some other bugs that causes DGL to crash with a >> memory >> > error. I’m still searching among the PRs to identify the one that >> causes >> > the issue. I think we should make sure that MXNet 1.5 release works >> with >> > DGL correctly. >> > >> > Best, >> > Da >> > >> >> >>
Re: New PMC member: Dick Carter
Congratulation Dick! On Tue, May 21, 2019 at 2:43 PM Carin Meier wrote: > Congrats and welcome! > > On Tue, May 21, 2019 at 4:37 PM Marco de Abreu > wrote: > > > The Project Management Committee (PMC) for Apache MXNet > > has invited Dick Carter to become a PMC member and we are pleased > > to announce that he has accepted. > > > > Dick has been a great help over the past years to make MXNet as > > efficient and easy-to-use on GPU as possible, reduce technical debt, > > improve our testing experience around flaky tests and providing senior > > guidance within the project. > > > > Being a committer enables easier contribution to the > > project since there is no need to go via the patch > > submission process. This should enable better productivity. > > Being a PMC member enables assistance with the management > > and to guide the direction of the project. > > > > Best regards, > > Marco de Abreu > > >
Re: DGL crashes in the recent master branch
Thanks for clarifying, Da. On Tue, May 21, 2019 at 5:44 PM Zheng, Da wrote: > DGL is a framework of deep learning on graphs. https://www.dgl.ai/ > > It's not that MXNet is responsible to be compatible with DGL. The crashes > are caused by bugs in MXNet. > > Best, > Da > > On 5/21/19, 5:39 PM, "Chris Olivier" wrote: > > Curious what is DGL and what is Apache/MXNet’s responsibility to it to > maintain compatibility rather than the other way around? > > On Tue, May 21, 2019 at 3:39 PM Zheng, Da > wrote: > > > Hello all, > > > > I recently find that DGL don’t run with the recent MXNet. DGL > crashes with > > memory errors. > > Yesterday we have identified a bug in DLPack and Junru has > implemented a > > fix: https://github.com/apache/incubator-mxnet/pull/15016 > > However, there are some other bugs that causes DGL to crash with a > memory > > error. I’m still searching among the PRs to identify the one that > causes > > the issue. I think we should make sure that MXNet 1.5 release works > with > > DGL correctly. > > > > Best, > > Da > > > > >
Re: DGL crashes in the recent master branch
DGL is a framework of deep learning on graphs. https://www.dgl.ai/ It's not that MXNet is responsible to be compatible with DGL. The crashes are caused by bugs in MXNet. Best, Da On 5/21/19, 5:39 PM, "Chris Olivier" wrote: Curious what is DGL and what is Apache/MXNet’s responsibility to it to maintain compatibility rather than the other way around? On Tue, May 21, 2019 at 3:39 PM Zheng, Da wrote: > Hello all, > > I recently find that DGL don’t run with the recent MXNet. DGL crashes with > memory errors. > Yesterday we have identified a bug in DLPack and Junru has implemented a > fix: https://github.com/apache/incubator-mxnet/pull/15016 > However, there are some other bugs that causes DGL to crash with a memory > error. I’m still searching among the PRs to identify the one that causes > the issue. I think we should make sure that MXNet 1.5 release works with > DGL correctly. > > Best, > Da >
Re: DGL crashes in the recent master branch
Curious what is DGL and what is Apache/MXNet’s responsibility to it to maintain compatibility rather than the other way around? On Tue, May 21, 2019 at 3:39 PM Zheng, Da wrote: > Hello all, > > I recently find that DGL don’t run with the recent MXNet. DGL crashes with > memory errors. > Yesterday we have identified a bug in DLPack and Junru has implemented a > fix: https://github.com/apache/incubator-mxnet/pull/15016 > However, there are some other bugs that causes DGL to crash with a memory > error. I’m still searching among the PRs to identify the one that causes > the issue. I think we should make sure that MXNet 1.5 release works with > DGL correctly. > > Best, > Da >
Re: [ANNOUNCEMENT] New Committer: Przemyslaw Tredak (ptrendx)
Congratulations Przemyslaw! On Tue, May 21, 2019 at 3:38 PM Marco de Abreu wrote: > Welcome! > > On Tue, May 21, 2019 at 11:48 PM Carin Meier wrote: > > > Welcome! > > > > On Tue, May 21, 2019 at 5:32 PM Naveen Swamy wrote: > > > > > The Project Podling Management Committee (PPMC) for Apache MXNet has > > > invited Przemyslaw Tredak (ptrendx) based on his contribution to MXNet > to > > > become a committer and we are pleased to announce that he has accepted. > > > > > > Przemyslaw, thanks a lot for your contribution and continued effort to > > > support MXNet community. > > > > > > Please join me in welcoming Przemyslaw to the project! > > > > > > Thanks, Naveen > > > (on behalf of Apache MXNet PPMC) > > > > > >
Re: warnings as errors
It would be great to enforce the check for warnings and treat as errors. Some questions I have: - what are the warnings that you think should be ignored? - for the rest of the warning types, can we turn them on one by one? -sz On 2019/05/21 22:33:51, Pedro Larroy wrote: > Hi dev@ > > I try to fix any warning that I see during compilation of MXNet in my > platform and with the build toggles that I care about. These seemingly > trivial and ungrateful efforts, take nonetheless energy on the > contributor side. > > I think overall I submitted myself more than a dozen of PRs fixing > warnings and I would like to call for additional help and > contributions in this area. > > There was a question from Lin about discussing this on the mailing > list, I have the feeling that everybody agrees on moving towards zero > warnings and warnings as errors. I think there are unavoidable > warnings that can be disabled specifically such as the one triggered > by mshadow type switch. > > Some important missing warnings such as warning on missing return > values (ie. forgetting to return on a function returning non-void) > cause bugs, danger and additional time spent bugfixing, which can be > better spent somewhere else. > > Is there a process that we can figure out such as a more expedited > merges of PRs fixing warnings or a specific label? > > Some simple PRs that fixes a warning can take long to merge, and > sometimes trigger too much discussion and make the progress a bit > unfriendly to contributors. > > Any help or constructive ideas on this topic would be appreciated. > > Pedro. >
DGL crashes in the recent master branch
Hello all, I recently find that DGL don’t run with the recent MXNet. DGL crashes with memory errors. Yesterday we have identified a bug in DLPack and Junru has implemented a fix: https://github.com/apache/incubator-mxnet/pull/15016 However, there are some other bugs that causes DGL to crash with a memory error. I’m still searching among the PRs to identify the one that causes the issue. I think we should make sure that MXNet 1.5 release works with DGL correctly. Best, Da
Re: [ANNOUNCEMENT] New Committer: Przemyslaw Tredak (ptrendx)
Welcome! On Tue, May 21, 2019 at 11:48 PM Carin Meier wrote: > Welcome! > > On Tue, May 21, 2019 at 5:32 PM Naveen Swamy wrote: > > > The Project Podling Management Committee (PPMC) for Apache MXNet has > > invited Przemyslaw Tredak (ptrendx) based on his contribution to MXNet to > > become a committer and we are pleased to announce that he has accepted. > > > > Przemyslaw, thanks a lot for your contribution and continued effort to > > support MXNet community. > > > > Please join me in welcoming Przemyslaw to the project! > > > > Thanks, Naveen > > (on behalf of Apache MXNet PPMC) > > >
warnings as errors
Hi dev@ I try to fix any warning that I see during compilation of MXNet in my platform and with the build toggles that I care about. These seemingly trivial and ungrateful efforts, take nonetheless energy on the contributor side. I think overall I submitted myself more than a dozen of PRs fixing warnings and I would like to call for additional help and contributions in this area. There was a question from Lin about discussing this on the mailing list, I have the feeling that everybody agrees on moving towards zero warnings and warnings as errors. I think there are unavoidable warnings that can be disabled specifically such as the one triggered by mshadow type switch. Some important missing warnings such as warning on missing return values (ie. forgetting to return on a function returning non-void) cause bugs, danger and additional time spent bugfixing, which can be better spent somewhere else. Is there a process that we can figure out such as a more expedited merges of PRs fixing warnings or a specific label? Some simple PRs that fixes a warning can take long to merge, and sometimes trigger too much discussion and make the progress a bit unfriendly to contributors. Any help or constructive ideas on this topic would be appreciated. Pedro.
Re: [ANNOUNCEMENT] New Committer: Przemyslaw Tredak (ptrendx)
Welcome! On Tue, May 21, 2019 at 5:32 PM Naveen Swamy wrote: > The Project Podling Management Committee (PPMC) for Apache MXNet has > invited Przemyslaw Tredak (ptrendx) based on his contribution to MXNet to > become a committer and we are pleased to announce that he has accepted. > > Przemyslaw, thanks a lot for your contribution and continued effort to > support MXNet community. > > Please join me in welcoming Przemyslaw to the project! > > Thanks, Naveen > (on behalf of Apache MXNet PPMC) >
Re: New PMC member: Dick Carter
Congrats and welcome! On Tue, May 21, 2019 at 4:37 PM Marco de Abreu wrote: > The Project Management Committee (PMC) for Apache MXNet > has invited Dick Carter to become a PMC member and we are pleased > to announce that he has accepted. > > Dick has been a great help over the past years to make MXNet as > efficient and easy-to-use on GPU as possible, reduce technical debt, > improve our testing experience around flaky tests and providing senior > guidance within the project. > > Being a committer enables easier contribution to the > project since there is no need to go via the patch > submission process. This should enable better productivity. > Being a PMC member enables assistance with the management > and to guide the direction of the project. > > Best regards, > Marco de Abreu >
[ANNOUNCEMENT] New Committer: Przemyslaw Tredak (ptrendx)
The Project Podling Management Committee (PPMC) for Apache MXNet has invited Przemyslaw Tredak (ptrendx) based on his contribution to MXNet to become a committer and we are pleased to announce that he has accepted. Przemyslaw, thanks a lot for your contribution and continued effort to support MXNet community. Please join me in welcoming Przemyslaw to the project! Thanks, Naveen (on behalf of Apache MXNet PPMC)
New PMC member: Dick Carter
The Project Management Committee (PMC) for Apache MXNet has invited Dick Carter to become a PMC member and we are pleased to announce that he has accepted. Dick has been a great help over the past years to make MXNet as efficient and easy-to-use on GPU as possible, reduce technical debt, improve our testing experience around flaky tests and providing senior guidance within the project. Being a committer enables easier contribution to the project since there is no need to go via the patch submission process. This should enable better productivity. Being a PMC member enables assistance with the management and to guide the direction of the project. Best regards, Marco de Abreu
PR failures
Dear MXNet community, An inconsistency made its way into master and making the 'sanity' pipeline fail. This has been fixed. Please rebase your branches off master to retrigger the PR checks. Cheers, Per
