Re: Apache MXNet build failures are mostly valid - verify before merge

Yay! On 10/12/17, 11:27, "Gautam" wrote: Hi All, The master branch is protected now. Please review your PR for merge. Thanks to Infra team for following up on this. Regards, Gautam On Mon, Oct 2, 2017 at 1:19 PM, Gautam

Re: Apache MXNet build failures are mostly valid - verify before merge

Hi All, The master branch is protected now. Please review your PR for merge. Thanks to Infra team for following up on this. Regards, Gautam On Mon, Oct 2, 2017 at 1:19 PM, Gautam wrote: > Thanks All. > > I've created the JIRA to mark the protected branch for master >

Re: Apache MXNet build failures are mostly valid - verify before merge

Hi Hen - we started to document the process - https://cwiki.apache.org/confluence/display/MXNET/Development+Process Contributions are welcome! Steffen On Sun, Oct 8, 2017 at 3:08 AM, Henri Yandell wrote: > A late followup on this. > > Is the "How a committer develops on

Re: Apache MXNet build failures are mostly valid - verify before merge

Thanks All. I've created the JIRA to mark the protected branch for master https://issues.apache.org/jira/browse/INCUBATOR-205. We also need to add all the committers to be code owner as discussed in the slack, I've opened a PR for it https://github.com/apache/incubator-mxnet/pull/8128. Good

Re: Apache MXNet build failures are mostly valid - verify before merge

+1 on protected branch. Best regards, -sz On 9/28/17, 11:48 AM, "Kumar, Gautam" wrote: Hi Guys, Let’s focus on specific issue here. Marking the master branch protected which involves “Only merge if checks has passed, and yes it will run the complete

Re: Apache MXNet build failures are mostly valid - verify before merge

Hi Guys, Let’s focus on specific issue here. Marking the master branch protected which involves “Only merge if checks has passed, and yes it will run the complete build”. We can’t afford to degrade the quality and keep debugging the build failure forever. If it’s slow down the development

Re: Apache MXNet build failures are mostly valid - verify before merge

-1000 on that. :) On Thu, Sep 28, 2017 at 11:33 AM Naveen Swamy wrote: > PR->Sanity test/Linux build/test->reviewer/committer approves the > change->Comment "Build Now" (Or trigger on at least one approval from a > committer other than author)->*Full build-*>*passes

Re: Apache MXNet build failures are mostly valid - verify before merge

I understand the proposal. How to trigger a build in that case? On Thu, Sep 28, 2017 at 10:54 AM Madan Jampani wrote: > Chris, > I don't think Naveen is suggesting that a merge happen without full > verification i.e. all tests across all platforms pass. > If a PR has

Re: Apache MXNet build failures are mostly valid - verify before merge

Chris, I don't think Naveen is suggesting that a merge happen without full verification i.e. all tests across all platforms pass. If a PR has some back and forth and results in multiple revisions (which is arguably more common than a random unit test failing), we simply delay full verification

Re: Apache MXNet build failures are mostly valid - verify before merge

-1 for running only partial tests. Most failing unit tests that get through fail only for certain platforms/configurations. I personally prefer to be assured the build and test is good before merge. Most PR merges aren't in a huge hurry. On Thu, Sep 28, 2017 at 9:54 AM, Naveen Swamy

Re: Apache MXNet build failures are mostly valid - verify before merge

> At a minimum I'd like to see the following two happen: > - Option to merge is disabled until all required checks pass. > - Code is reviewed and given +1 by at least one other committer (no self > review). I like this policy. In fact, Apache Hadoop community works with the policy too. Thanks

Re: Apache MXNet build failures are mostly valid - verify before merge

+1 on that On Wed, Sep 27, 2017 at 11:15 PM Gautam wrote: > Hi Chris, > > Here is > user > document on semantics of protected branch. > In short when a branch is protected following applies to that branch. > >

Re: Apache MXNet build failures are mostly valid - verify before merge

Hi Chris, Here is user document on semantics of protected branch. In short when a branch is protected following applies to that branch. - Can't be force pushed - Can't be deleted - Can't have changes merged into it until

Re: Apache MXNet build failures are mostly valid - verify before merge

What does that mean? "Protected"? Protected from what? On Wed, Sep 27, 2017 at 11:08 PM Gautam wrote: > Hi Chris, > >I mean make "master branch protected" of MXNet. > > -Gautam > > On Wed, Sep 27, 2017 at 11:04 PM, Chris Olivier > wrote: > > >

Re: Apache MXNet build failures are mostly valid - verify before merge

Hi Chris, I mean make "master branch protected" of MXNet. -Gautam On Wed, Sep 27, 2017 at 11:04 PM, Chris Olivier wrote: > What does this mean? "Mx-net branch protected"? > > On Wed, Sep 27, 2017 at 9:59 PM Tsuyoshi OZAWA > wrote: > > >

Re: Apache MXNet build failures are mostly valid - verify before merge

What does this mean? "Mx-net branch protected"? On Wed, Sep 27, 2017 at 9:59 PM Tsuyoshi OZAWA wrote: > +1, > > While I'm checking the recent build failures, and I think the decision > of making the mx-net branch protected is necessary for stable > building. > Thanks

Re: Apache MXNet build failures are mostly valid - verify before merge

+1, While I'm checking the recent build failures, and I think the decision of making the mx-net branch protected is necessary for stable building. Thanks Kumar for resuming important discussion. Best regards - Tsuyoshi On Thu, Sep 28, 2017 at 12:56 PM, Kumar, Gautam wrote: >

Re: Apache MXNet build failures are mostly valid - verify before merge

Reviving the discussion. At this point of time we have couple of stable builds https://builds.apache.org/view/Incubator%20Projects/job/incubator-mxnet/job/master/448/ https://builds.apache.org/view/Incubator%20Projects/job/incubator-mxnet/job/master/449/ Should we have a quick discussion or

Re: Apache MXNet build failures are mostly valid - verify before merge

@madan looking into some failures – you’re right… there’s multiple issues going on, some of them intermittent, and we want to be able to merge fixes in. Agreed that we can wait with setting up protected mode until build stabilizes. On 8/31/17, 11:41, "Madan Jampani"

Re: Apache MXNet build failures are mostly valid - verify before merge

@hagay: we agree on the end state. I'm not too particular about how we get there. If you think enabling it now and fixes regression later is doable, I'm fine with. I see a bit of a chicken and egg problem. We need to get some fixes in even when the status checks are failing. On Thu, Aug 31, 2017

Re: Apache MXNet build failures are mostly valid - verify before merge

@madan – re: getting to a stable CI first: I’m concerned that by not enabling protected branch mode ASAP, we’re just taking in more regressions, which makes a stable build a moving target for us… On 8/31/17, 10:49, "Zha, Sheng" wrote: Just one thing: please don’t

Re: Apache MXNet build failures are mostly valid - verify before merge

Just one thing: please don’t disable more tests or just raise the tolerance thresholds. Best regards, -sz On 8/31/17, 10:45 AM, "Madan Jampani" wrote: +1 Before we can turn protected mode I feel we should first get to a stable CI pipeline. Sandeep is

Re: Apache MXNet build failures are mostly valid - verify before merge

+1 Before we can turn protected mode I feel we should first get to a stable CI pipeline. Sandeep is chasing down known breaking issues. On Thu, Aug 31, 2017 at 10:27 AM, Hagay Lupesko wrote: > Build stability is a major issue, builds have been failing left and right > over

Re: Apache MXNet build failures are mostly valid - verify before merge

Build stability is a major issue, builds have been failing left and right over the last week. Some of it is due to Jenkins slave issues, but some are real regressions. We need to be more strict in the code we're committing. I propose we configure our master to be a protected branch (