Re: [DISCUSS] Remove amalgamation

2019-09-28 Thread Tianqi Chen
malgamation, based on my knowledge on this feature I'm not > aware > > of > > >> > any > > >> > > > difference in the end result, compared to the code-inlining > > approach > > >> > that > > >> &

Re: [DISCUSS] Remove amalgamation

2019-09-28 Thread Chris Olivier
so the original email suggesting to remove was after all > >> self-serving > >> > > :) > >> > > > > > >> > > > > let's encourage if someone wants to maintain and make use of the > >> > > original > &g

Re: [DISCUSS] Remove amalgamation

2019-09-28 Thread Tianqi Chen
>> > > > > >> > > > > let's encourage if someone wants to maintain and make use of the >> > > original >> > > > > work and make it better. >> > > > > >> > > > > -1 to remove at this point >> >

Re: [DISCUSS] Remove amalgamation

2019-09-28 Thread Tianqi Chen
t to do some due diligence before bringing topics up > for > > > > > discussion. > > > > > > > > > > On Wed, Sep 11, 2019 at 8:10 AM Lv, Tao A > > wrote: > > > > > > > > > > > Sorry to chime in. > > > > &

Re: [DISCUSS] Remove amalgamation

2019-09-28 Thread Marco de Abreu
wrote: > > > > > > > > > Sorry to chime in. > > > > > > > > > > There is a PR to fix amalgamation. I was pinged several times to > > merge > > > it > > > > > but I don't think I have enough knowledge to do that. So it woul

Re: [DISCUSS] Remove amalgamation

2019-09-28 Thread Junru Shao
edge to do that. So it would be > > great > > > > if someone from this thread can help to review. > > > > > > > > https://github.com/apache/incubator-mxnet/pull/15303 > > > > > > > > thanks, > > > > -tao > > > >

Re: [DISCUSS] Remove amalgamation

2019-09-27 Thread Tianqi Chen
t; but I don't think I have enough knowledge to do that. So it would be > great > > > if someone from this thread can help to review. > > > > > > https://github.com/apache/incubator-mxnet/pull/15303 > > > > > > thanks, > > > -ta

Re: [DISCUSS] Remove amalgamation

2019-09-27 Thread Sheng Zha
> > -tao > > > > -Original Message- > > From: Marco de Abreu > > Sent: Wednesday, September 11, 2019 9:38 PM > > To: dev@mxnet.incubator.apache.org > > Subject: Re: [DISCUSS] Remove amalgamation > > > > Is Amalgamation only used on An

Re: [DISCUSS] Remove amalgamation

2019-09-12 Thread Naveen Swamy
s://github.com/apache/incubator-mxnet/pull/15303 > > thanks, > -tao > > -Original Message- > From: Marco de Abreu > Sent: Wednesday, September 11, 2019 9:38 PM > To: dev@mxnet.incubator.apache.org > Subject: Re: [DISCUSS] Remove amalgamation > > Is Amalgamatio

RE: [DISCUSS] Remove amalgamation

2019-09-11 Thread Lv, Tao A
-Original Message- From: Marco de Abreu Sent: Wednesday, September 11, 2019 9:38 PM To: dev@mxnet.incubator.apache.org Subject: Re: [DISCUSS] Remove amalgamation Is Amalgamation only used on Android though? Are there any other use cases? -Marco Pedro Larroy schrieb am Mi., 11. Sep. 2019, 11:57

Re: [DISCUSS] Remove amalgamation

2019-09-11 Thread Marco de Abreu
Is Amalgamation only used on Android though? Are there any other use cases? -Marco Pedro Larroy schrieb am Mi., 11. Sep. 2019, 11:57: > Hi Anirudh > > Appreciate your feedback and sorry if my email came across that way to you, > I think you might miss some context. I don't think calling

Re: [DISCUSS] Remove amalgamation

2019-09-10 Thread Skalicky, Sam
Heres some foundation for “hacky” in computer science: Calling a piece of code hacky isn’t the same as saying it’s bad, the code just doesn’t have infrastructure around it. You can probably already piece together why they call hackers hackers, and hackathons hackathons — hacks just need to run

Re: [DISCUSS] Remove amalgamation

2019-09-10 Thread Anirudh Subramanian
Hi Pedro, I don't see anything "destructive" with Chris asking for justification for you calling something "hacky". The only email in this thread where I see ad hominems and disrespectful comments is your email. On Sat, Sep 7, 2019, 10:18 PM Pedro Larroy wrote: > Apache mentors should have a

Re: [DISCUSS] Remove amalgamation

2019-09-07 Thread Pedro Larroy
Apache mentors should have a look at these reincident harassment and destructive behaviors which demotivate contributions and take action. It takes only one bad apple to ruin a community. The mobile solution that is known to work as of know is cross compiling with "ci/build.py -p

Re: [DISCUSS] Remove amalgamation

2019-09-06 Thread Aaron Markham
I went down the path for this and was disuaded by the errors I had and the open issues about the same errors. It's one thing to leave something around that works, but another to leave something around that wastes a lot of time and causes abandonment. The project needs a mobile solution. What's

Re: [DISCUSS] Remove amalgamation

2019-09-06 Thread Naveen Swamy
+1. I have heard this before elsewhere if you don't understand the code, give it a name like "hacky", "does not follow the pattern", "unmaintainable", etc., may all that be true but it does not help making cliched and disrespectful comments about someone else's contributions. the code is not

Re: [DISCUSS] Remove amalgamation

2019-09-06 Thread Marco de Abreu
I can recall that we had quite a few issues where people tried to use amalgamation. Have we identified these use cases so far and documented the alternative. I think the compilation only takes a few seconds and I think we also have some nightly tests for it. So far it seemed very low maintenance,

Re: [DISCUSS] Remove amalgamation

2019-09-06 Thread Chris Olivier
Hi Pedro, While I was not involved with amalgamation or its development in any way, can you please refrain from referring to the work of others as a "hacky solution"? This is derogatory slang and the statement was not supported with any justification for such name-calling. Someone spent a good