Re: [Proposal] New MyFaces Commons module - Agent Detection

2009-09-25 Thread Marius Petoi
Hello, I think we should first have the module into myfaces-commons and I will modify it afterwards. How do I do to send you the patch? On the MyFaces wiki I have found the following procedure: http://wiki.apache.org/myfaces/Contributing_Patches. Is it enough to open a JIRA case and attach the pa

Re: [Proposal] New MyFaces Commons module - Agent Detection

2009-09-24 Thread Udo Schnurpfeil
Hi Marius, I've looked at the code, and I think it will not be a problem to use it. But I've some refactoring suggestions: * What do you think about enums instead of constants for the agentName and platformName * It would be great when the version would be comparable (not lexicographical like S

Re: [Proposal] New MyFaces Commons module - Agent Detection

2009-09-22 Thread Simon Lessard
Hi, I wouldn't mind seeing that part shared. ~ Simon On Tue, Sep 22, 2009 at 5:30 PM, Udo Schnurpfeil wrote: > Hi Marius, > > it sounds very nice for me. Can I take a look to the implementation > anywhere? I would like to check if it fits to Tobago. > > So we can share the code instead of reim

Re: [Proposal] New MyFaces Commons module - Agent Detection

2009-09-22 Thread Udo Schnurpfeil
Hi Marius, it sounds very nice for me. Can I take a look to the implementation anywhere? I would like to check if it fits to Tobago. So we can share the code instead of reimplementing the same stuff twice or more. Regards, Udo Marius Petoi schrieb: Hi everybody, I would like to propose

[Proposal] New MyFaces Commons module - Agent Detection

2009-09-21 Thread Marius Petoi
Hi everybody, I would like to propose the creation of a new module in MyFaces Commons, that will handle agent detection, a feature which I hope you will consider, as such a module would be useful to any component set out there (or at least to the ones in MyFaces). My work is based on what already