Re: external api change OK for myfaces-impl 1.2.1?

2007-11-13 Thread Bernhard Huemer
Hello, Actually, the problem is that you can't take part in the initialization process, i.e. there is no way to add support for additional, non-standard injection annotations. For example, I thought of rewriting Dennis' Guice integration: /// public class GuiceLifecycleProvider implements

Re: external api change OK for myfaces-impl 1.2.1?

2007-11-13 Thread Bernhard Huemer
s/as it doesn't additional complexity/as it doesn't introduce additional complexity Usually, errors don't matter, but I think it's more difficult to understand otherwise. On 11/13/2007 +0100, Bernhard Huemer [EMAIL PROTECTED] wrote: Hello, Actually, the problem is that you can't take part

Re: external api change OK for myfaces-impl 1.2.1?

2007-11-13 Thread Paul McMahan
On Nov 13, 2007, at 3:03 PM, Bernhard Huemer wrote: However, if you really can't live with the seperation of initialization and postconstruction, what about introducing InjectionTasks? The ManagedBeanBuilder, for example, could register an InjectionTask that handles the injection of

Re: external api change OK for myfaces-impl 1.2.1?

2007-11-13 Thread Bernhard Huemer
Hello, Ok, I'll do that on Thursday, if you don't mind. regards, Bernhard On 11/13/2007 +0100, Paul McMahan [EMAIL PROTECTED] wrote: On Nov 13, 2007, at 3:03 PM, Bernhard Huemer wrote: However, if you really can't live with the seperation of initialization and postconstruction, what about

Re: external api change OK for myfaces-impl 1.2.1?

2007-11-13 Thread Paul McMahan
Whenever you have time sounds fine to me. Thanks again for your help on this. Best wishes, Paul On Nov 13, 2007, at 4:09 PM, Bernhard Huemer wrote: Hello, Ok, I'll do that on Thursday, if you don't mind. regards, Bernhard On 11/13/2007 +0100, Paul McMahan [EMAIL PROTECTED] wrote: On

external api change OK for myfaces-impl 1.2.1?

2007-11-12 Thread Paul McMahan
The LifecycleProvider interface was introduced in MyFaces core 1.2.0 as an integration point that allows Java EE containers to handle annotation processing for JSF managed beans. In order to help containers invoke @PostConstruct methods more consistently with the Java EE RI (glassfish) we

Re: external api change OK for myfaces-impl 1.2.1?

2007-11-12 Thread Bruno Aranda
This is an implementation detail so it sounds fine to me. If there was a way to deprecate the existing method instead of just replacing it would be better though. If not, the change is just fine and I don't expect someone using/extending directly the implementation. Cheers, Bruno On 12/11/2007,

Re: external api change OK for myfaces-impl 1.2.1?

2007-11-12 Thread Bernd Bohmann
Hello Paul, what is wrong with Bernhards patch? Instead of handling all of the annotation processing in LifecycleProvider.newInstance(String className) he suggest to add a method LifecycleProvider.postConstruct(Object obj) this method is called after the properties are injected by the

Re: external api change OK for myfaces-impl 1.2.1?

2007-11-12 Thread Paul McMahan
Bernd, My understanding of the JSF 1.2 spec is that annotation processing for managed beans pertains to the injection of JavaEE managed resources. Now Bernhard raises a good point which is that for JSF developers a more practical use of the term injection could also mean the