[GitHub] [myfaces] tandraschko commented on pull request #292: MYFACES-4442: avoid UnsupportedOperationException

2022-08-30 Thread GitBox
tandraschko commented on PR #292: URL: https://github.com/apache/myfaces/pull/292#issuecomment-1231241287 i like this fix but this doesnt solve https://issues.apache.org/jira/browse/TOMEE-2846, which is actually related to the same root problem -- This is an automated message from the

[jira] [Commented] (MYFACES-4445) "No CDI container started" when using PushContext async

2022-08-30 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597607#comment-17597607 ] Thomas Andraschko commented on MYFACES-4445: TBH WebsocketApplicationSessionHolder looks a

[jira] [Created] (MYFACES-4447) UnsupportedOperationException when using org.apache.myfaces.AUTOMATIC_EXTENSIONLESS_MAPPING = true

2022-08-30 Thread Paul Nicolucci (Jira)
Paul Nicolucci created MYFACES-4447: --- Summary: UnsupportedOperationException when using org.apache.myfaces.AUTOMATIC_EXTENSIONLESS_MAPPING = true Key: MYFACES-4447 URL:

[GitHub] [myfaces] pnicolucci commented on pull request #292: MYFACES-4442: avoid UnsupportedOperationException

2022-08-30 Thread GitBox
pnicolucci commented on PR #292: URL: https://github.com/apache/myfaces/pull/292#issuecomment-1231444193 @tandraschko I opened https://issues.apache.org/jira/browse/MYFACES-4447 to address automatic extensionless mapping. This fix at least gets us past the initial initFaces

[GitHub] [myfaces] pnicolucci commented on pull request #292: MYFACES-4442: avoid UnsupportedOperationException

2022-08-30 Thread GitBox
pnicolucci commented on PR #292: URL: https://github.com/apache/myfaces/pull/292#issuecomment-1231446032 So I'll plan to merge this by the end of the day today if no objections to the actual code change here except for we still need to fix it for automatic extensionless mapping which has

[jira] [Commented] (MYFACES-4442) UnsupportedOperationException when calling getServletRegistrations from initFaces

2022-08-30 Thread Paul Nicolucci (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598111#comment-17598111 ] Paul Nicolucci commented on MYFACES-4442: - 2.3-next PR:

[jira] [Commented] (MYFACES-4449) Implementation ClassUtils needs methods added to support OSGI runtimes

2022-08-30 Thread Paul Nicolucci (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598162#comment-17598162 ] Paul Nicolucci commented on MYFACES-4449: - I'll work to get a PR up for review tomorrow. >

[jira] [Resolved] (MYFACES-4448) avoid ClassCastException in TextUnit.compressSpaces

2022-08-30 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4448. Resolution: Fixed > avoid ClassCastException in TextUnit.compressSpaces >

[GitHub] [myfaces] pnicolucci commented on pull request #292: MYFACES-4442: avoid UnsupportedOperationException

2022-08-30 Thread GitBox
pnicolucci commented on PR #292: URL: https://github.com/apache/myfaces/pull/292#issuecomment-1231571453 Opened: to fix extensionless mapping: https://issues.apache.org/jira/browse/MYFACES-4447 -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (MYFACES-4442) UnsupportedOperationException when calling getServletRegistrations from initFaces

2022-08-30 Thread Paul Nicolucci (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597867#comment-17597867 ] Paul Nicolucci commented on MYFACES-4442: - [~tandraschko] do you want me to backport this to

[jira] [Commented] (MYFACES-4447) UnsupportedOperationException when using org.apache.myfaces.AUTOMATIC_EXTENSIONLESS_MAPPING = true

2022-08-30 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597795#comment-17597795 ] Thomas Andraschko commented on MYFACES-4447: in 4.0 its called:

[GitHub] [myfaces] tandraschko merged pull request #296: MYFACES-4448 Fix impossible cast

2022-08-30 Thread GitBox
tandraschko merged PR #296: URL: https://github.com/apache/myfaces/pull/296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces] tandraschko merged pull request #297: MYFACES-4448 Fix impossible cast

2022-08-30 Thread GitBox
tandraschko merged PR #297: URL: https://github.com/apache/myfaces/pull/297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MYFACES-4448) avoid ClassCastException in TextUnit.compressSpaces

2022-08-30 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597801#comment-17597801 ] Thomas Andraschko commented on MYFACES-4448: Thanks - great contribution! > avoid

[GitHub] [myfaces] pnicolucci merged pull request #292: MYFACES-4442: avoid UnsupportedOperationException

2022-08-30 Thread GitBox
pnicolucci merged PR #292: URL: https://github.com/apache/myfaces/pull/292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (MYFACES-4448) avoid ClassCastException in TextUnit.compressSpaces

2022-08-30 Thread Piotr Zygielo (Jira)
Piotr Zygielo created MYFACES-4448: -- Summary: avoid ClassCastException in TextUnit.compressSpaces Key: MYFACES-4448 URL: https://issues.apache.org/jira/browse/MYFACES-4448 Project: MyFaces Core

[GitHub] [myfaces] tandraschko merged pull request #293: MYFACES-4448 Fix impossible cast

2022-08-30 Thread GitBox
tandraschko merged PR #293: URL: https://github.com/apache/myfaces/pull/293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces] tandraschko merged pull request #295: MYFACES-4448 Fix impossible cast

2022-08-30 Thread GitBox
tandraschko merged PR #295: URL: https://github.com/apache/myfaces/pull/295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MYFACES-4442) UnsupportedOperationException when calling getServletRegistrations from initFaces

2022-08-30 Thread Paul Nicolucci (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597805#comment-17597805 ] Paul Nicolucci commented on MYFACES-4442: - We can address the extenionless mapping here

[GitHub] [myfaces] tandraschko commented on pull request #293: Fix impossible cast

2022-08-30 Thread GitBox
tandraschko commented on PR #293: URL: https://github.com/apache/myfaces/pull/293#issuecomment-1231522007 please create a JIRA issue and provide a PR for all active branches (2.3, 2.3-next, 3.0, main) -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [myfaces] tandraschko merged pull request #294: Fix missing spaces in string literals

2022-08-30 Thread GitBox
tandraschko merged PR #294: URL: https://github.com/apache/myfaces/pull/294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MYFACES-4442) UnsupportedOperationException when calling getServletRegistrations from initFaces

2022-08-30 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597871#comment-17597871 ] Thomas Andraschko commented on MYFACES-4442: yes please 2.3-next and 4.0 is the same

[jira] [Created] (MYFACES-4449) Implementation ClassUtils needs methods added to support OSGI runtimes

2022-08-30 Thread Paul Nicolucci (Jira)
Paul Nicolucci created MYFACES-4449: --- Summary: Implementation ClassUtils needs methods added to support OSGI runtimes Key: MYFACES-4449 URL: https://issues.apache.org/jira/browse/MYFACES-4449