[GitHub] [myfaces] werpu commented on pull request #356: Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC3)

2022-11-07 Thread GitBox
werpu commented on PR #356: URL: https://github.com/apache/myfaces/pull/356#issuecomment-1306750505 I have created an issue on my github side: https://github.com/werpu/jsfs_js_ts/issues/26 I will fix the bugs there first and will keep an update on the status. Once everything is

[GitHub] [myfaces] werpu commented on pull request #356: Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC3)

2022-11-07 Thread GitBox
werpu commented on PR #356: URL: https://github.com/apache/myfaces/pull/356#issuecomment-1306315248 Thanks for the reports, I will tackle every single one of those issues tomorrow. the f:param is clearly still an issue in the new form encoding code as for the rest I will have a deeper

[GitHub] [myfaces] volosied commented on pull request #356: Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC3)

2022-11-07 Thread GitBox
volosied commented on PR #356: URL: https://github.com/apache/myfaces/pull/356#issuecomment-1306168003 Another thing I just noticed: The ajax file submissions (single / multiple) doesn't seem to work. https://github.com/jakartaee/faces/tree/master/tck/faces40/inputFile -- This

[GitHub] [myfaces] volosied commented on pull request #356: Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC3)

2022-11-07 Thread GitBox
volosied commented on PR #356: URL: https://github.com/apache/myfaces/pull/356#issuecomment-1306143241 @werpu Wanted to give you a quick update. Most tests are passing, but I see a few issues 1) f:param doesn't to be properly sent. For example: ```

[jira] [Resolved] (MYFACES-4492) NPE when no label is specified on

2022-11-07 Thread Paul Nicolucci (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Nicolucci resolved MYFACES-4492. - Resolution: Fixed > NPE when no label is specified on >

[GitHub] [myfaces] melloware merged pull request #376: MYFACES-4492: don't NPE when no label is set

2022-11-07 Thread GitBox
melloware merged PR #376: URL: https://github.com/apache/myfaces/pull/376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces] pnicolucci opened a new pull request, #376: MYFACES-4492: don't NPE when no label is set

2022-11-07 Thread GitBox
pnicolucci opened a new pull request, #376: URL: https://github.com/apache/myfaces/pull/376 https://issues.apache.org/jira/browse/MYFACES-4492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [myfaces] melloware merged pull request #375: MYFACES-4492: don't NPE when no label is set

2022-11-07 Thread GitBox
melloware merged PR #375: URL: https://github.com/apache/myfaces/pull/375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces] pnicolucci opened a new pull request, #375: MYFACES-4492: don't NPE when no label is set

2022-11-07 Thread GitBox
pnicolucci opened a new pull request, #375: URL: https://github.com/apache/myfaces/pull/375 https://issues.apache.org/jira/browse/MYFACES-4492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [myfaces] melloware merged pull request #374: MYFACES-4492: don't NPE when no label is set

2022-11-07 Thread GitBox
melloware merged PR #374: URL: https://github.com/apache/myfaces/pull/374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces] pnicolucci merged pull request #373: MYFACES-4492: don't NPE when no label is set

2022-11-07 Thread GitBox
pnicolucci merged PR #373: URL: https://github.com/apache/myfaces/pull/373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces] pnicolucci opened a new pull request, #374: MYFACES-4492: don't NPE when no label is set

2022-11-07 Thread GitBox
pnicolucci opened a new pull request, #374: URL: https://github.com/apache/myfaces/pull/374 https://issues.apache.org/jira/browse/MYFACES-4492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [myfaces] werpu commented on pull request #356: Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC3)

2022-11-07 Thread GitBox
werpu commented on PR #356: URL: https://github.com/apache/myfaces/pull/356#issuecomment-1305224968 Btw. theoretically we also could replace the codebase or add the next gen codebase to 2.3 (as second loading option) the codebase can work in both namespaces, via frontend shims) --