Welcome, Kenn!
It's great to have your input!
Looking forward to working with you!
-Gon
On Fri, Dec 14, 2018 at 5:54 PM Kenneth Knowles wrote:
> Hi Nemo (incubating :-) !
>
> I've been following the project since it was Onyx. I love the idea. I was
> very happy to see a Beam runner.
>
> I
wonook commented on issue #180: [NEMO-319] Fix path to beam resources in
examples in README
URL: https://github.com/apache/incubator-nemo/pull/180#issuecomment-447261325
Lovely! It looks good to me. I'll merge after the tests.
wonook edited a comment on issue #182: [NEMO-292] (WIP) Run Beam
ValidatesRunner tests
URL: https://github.com/apache/incubator-nemo/pull/182#issuecomment-447259465
Oh, and I forgot to mention, but making an über jar is the right direction.
I think
kennknowles commented on issue #180: [NEMO-319] Fix path to beam resources in
examples in README
URL: https://github.com/apache/incubator-nemo/pull/180#issuecomment-447259985
OK, all the edits are done, I think.
This is an
wonook commented on issue #182: [NEMO-292] (WIP) Run Beam ValidatesRunner tests
URL: https://github.com/apache/incubator-nemo/pull/182#issuecomment-447259465
Oh, and I forgot to mention, but making an über jar is the right direction.
Hi Nemo (incubating :-) !
I've been following the project since it was Onyx. I love the idea. I was
very happy to see a Beam runner.
I thought it would be fun to try to run Beam's "ValidatesRunner" tests
using Nemo, so I spent my hours at home this evening getting to know the
repository a
wonook edited a comment on issue #182: [NEMO-292] (WIP) Run Beam
ValidatesRunner tests
URL: https://github.com/apache/incubator-nemo/pull/182#issuecomment-447255102
@kennknowles I think referring to our `nemo-examples-beam` package `pom.xml`
could help creating the right deps & bundling &
wonook edited a comment on issue #182: [NEMO-292] (WIP) Run Beam
ValidatesRunner tests
URL: https://github.com/apache/incubator-nemo/pull/182#issuecomment-447255102
@kennknowles I think referring to our `nemo-examples-beam` package `pom.xml`
could help creating the right deps & bundling &
wonook commented on issue #180: [NEMO-319] Fix path to beam resources in
examples in README
URL: https://github.com/apache/incubator-nemo/pull/180#issuecomment-447257364
@kennknowles Thanks for the quick reaction! Just one favor to ask regarding
the PR: in the README, there's an
wonook commented on issue #182: (WIP) Add Beam spec tests
URL: https://github.com/apache/incubator-nemo/pull/182#issuecomment-447255102
@kennknowles I think referring to our `nemo-examples-beam` package `pom.xml`
could help creating the right deps & bundling & distribution. To my
kennknowles commented on a change in pull request #180: [NEMO-319] Fix path to
beam resources in examples in README
URL: https://github.com/apache/incubator-nemo/pull/180#discussion_r241676353
##
File path: README.md
##
@@ -86,7 +86,7 @@ Please refer to the [Contribution
kennknowles commented on a change in pull request #180: [NEMO-319] Fix path to
beam resources in examples in README
URL: https://github.com/apache/incubator-nemo/pull/180#discussion_r241676326
##
File path: README.md
##
@@ -77,7 +77,7 @@ Please refer to the [Contribution
kennknowles commented on a change in pull request #180: [NEMO-319] Fix path to
beam resources in examples in README
URL: https://github.com/apache/incubator-nemo/pull/180#discussion_r241676368
##
File path: README.md
##
@@ -86,7 +86,7 @@ Please refer to the [Contribution
kennknowles commented on a change in pull request #180: [NEMO-319] Fix path to
beam resources in examples in README
URL: https://github.com/apache/incubator-nemo/pull/180#discussion_r241676124
##
File path: README.md
##
@@ -77,7 +77,7 @@ Please refer to the [Contribution
kennknowles commented on a change in pull request #180: [NEMO-319] Fix path to
beam resources in examples in README
URL: https://github.com/apache/incubator-nemo/pull/180#discussion_r241676093
##
File path: README.md
##
@@ -77,7 +77,7 @@ Please refer to the [Contribution
wonook commented on issue #181: [NEMO-159] Nemo Web UI
URL: https://github.com/apache/incubator-nemo/pull/181#issuecomment-447252608
@seojangho I've updated the tests. Please check again!
This is an automated message from the
kennknowles opened a new pull request #182: (WIP) Add Beam spec tests
URL: https://github.com/apache/incubator-nemo/pull/182
Opening this for early feedback. I spent a little while trying to get this
to run, but did not finish it. I hope that some member of the Nemo community
can easily
+1 (binding), but please look into Markus' feedback.
Non-blocking comments:
- Please add instruction header to the KEYS file (see example in Beam)
- Examples parent module should go too?
Great work.
On Thu, Dec 13, 2018 at 6:27 PM Markus Weimer wrote:
> I tried to build on Ubuntu 18.04 to
johnyangk commented on a change in pull request #180: Fix path to beam
resources in examples in README
URL: https://github.com/apache/incubator-nemo/pull/180#discussion_r241665971
##
File path: README.md
##
@@ -77,7 +77,7 @@ Please refer to the [Contribution
johnyangk commented on a change in pull request #180: Fix path to beam
resources in examples in README
URL: https://github.com/apache/incubator-nemo/pull/180#discussion_r241666839
##
File path: README.md
##
@@ -77,7 +77,7 @@ Please refer to the [Contribution
johnyangk commented on a change in pull request #180: Fix path to beam
resources in examples in README
URL: https://github.com/apache/incubator-nemo/pull/180#discussion_r241667063
##
File path: README.md
##
@@ -86,7 +86,7 @@ Please refer to the [Contribution
21 matches
Mail list logo
