On Sat, 15 Apr 2023 at 21:15, Łukasz Bownik wrote:
> Will it get merged or shall I close it?
I believe PRs can still get merged even after the fork is deleted -
see
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-reque
I was hoping this would make the cut for NB 15.
Is there a problem with the PR? Lack of resources? Lack of Interest? The
problem the PR addresses isn't important? Poor presentation?
-ernie
On 7/13/22 10:11 AM, Ernie Rael wrote:
https://github.com/apache/netbeans/pull/4249
This PR introduces
It's only the setup which requires slightly more configuration than usual.
The best practice is keep each PR in it's own branch. It is also
possible that your PR-s are not accepted/merged in that order you are
popping them out, so having them on one branch could be difficult. I
check out the a
a lot what Antonio described is setup work. Once your remote etc is
configured its a very quick process.
1) switch to master and pull from the apache netbeans repo
2) create a fresh branch from that
3) add commits
4) push to your clone, press the create PR button
If you don't use one branch
Gee... it looks like a lot of work every time I submit a little PR to a
module nobody else is working on. How about I continue with my current
private branch until i change a module I work on or get conflists with
master?
On Thu, Apr 14, 2022, 1:28 PM antonio wrote:
> Hi,
>
> So you have forked
Hi,
So you have forked the NetBeans repository at
https://github.com/lbownik/netbeans, and you've cloned it to a directory
in your laptop using "git clone", or something similar.
This means that your clone (in your laptop) has a "remote" pointing to
your repository.
This "remote" is usuall
Hi,
Am Donnerstag, dem 14.04.2022 um 13:15 -0700 schrieb Łukasz Bownik:
> What about branching. May I keep pumping PRs from the same branch?
For the size: Changes should be focused on a problem and driven by it.
If that means the changes becomes bigger so be it. You should keep in
mind, that some
Not sure about that, lets see what others say.
Gj
On Thu, 14 Apr 2022 at 16:15, Łukasz Bownik wrote:
> What about branching. May I keep pumping PRs from the same branch?
>
> On Thu, Apr 14, 2022, 1:08 PM Geertjan Wielenga
> wrote:
>
> > Small is good. :-)
> >
> > Gj
> >
> > On Thu, 14 Apr 2022
What about branching. May I keep pumping PRs from the same branch?
On Thu, Apr 14, 2022, 1:08 PM Geertjan Wielenga
wrote:
> Small is good. :-)
>
> Gj
>
> On Thu, 14 Apr 2022 at 15:59, Łukasz Bownik
> wrote:
>
> > Hello.
> > I got my first PR merged.
> >
> >
> > Can I continue development on my
Small is good. :-)
Gj
On Thu, 14 Apr 2022 at 15:59, Łukasz Bownik wrote:
> Hello.
> I got my first PR merged.
>
>
> Can I continue development on my branch or shall i create new branch for
> each pull request?
>
> Do you guys prefer small or larger PRs?
>
Maybe add a little bit of shading to the white background and/or give the NB
logo a subtle drop shadow? Anything to give it a little bit of depth. You
could even sink the NB logo a little bit into the background (like the compass
in Safari’s icon).
There should be a little bit of drop shadow a
I hope we can rename, was just to tag the next milestone to keep information.
Eric
-Message d'origine-
De : Neil C Smith
Envoyé : mardi 14 septembre 2021 14:58
À : dev
Objet : Re: PR milestone for next version
On Tue, 14 Sep 2021, 13:44 Eric Barboni, wrote:
> Anticipating
On Tue, 14 Sep 2021, 13:44 Eric Barboni, wrote:
> Anticipating for next release but do not forget to tag milestone 12.6 on
> merge to ease the future Release note.
>
I guess we also need to complete that conversation on whether the next next
release will be 12.7, 13.0 or 13? And whether we do an
On 4/8/2020 12:09 PM, Laszlo Kishalmi wrote:
Dear all, Erik,
We have a number of PR-s coming in for 12.0. Please take your time
and review!
There's a couple of approved PR that seem relevant to the stated goals
of NetCAT. (I didn't want to cheerlead for them, and yet here I am: Rah,
rah!)
On Thu, 9 Apr 2020 at 16:39, Ernie Rael wrote:
> On 4/9/2020 7:05 AM, Eric Barboni wrote:
> > I merged some that I find not destructive to NetCAT. (subjective maybe)
> I don't get it. Does this mean that once NetCAT starts no changes can be
> made to any area covered by NetCAT? I guess I don't und
On 4/9/2020 7:05 AM, Eric Barboni wrote:
I merged some that I find not destructive to NetCAT. (subjective maybe)
I don't get it. Does this mean that once NetCAT starts no changes can be
made to any area covered by NetCAT? I guess I don't understand NetCAT. I
would have thought it better to merg
I merged some that I find not destructive to NetCAT. (subjective maybe)
With the stay home + work at home policy in France, I'm a bit too much at work
:p
Some PR have to strong conclusion. I wait until consensus is done.
Best Regards
Eric
-Message d'origine-
De : Laszlo Kishalmi
Envoy
On 2/6/2020 3:41 PM, Eric Barboni wrote:
I'm thinking on doing beta3 preparation on Monday. Maybe can it be vc1 ?
I just did PR #1935 to fix a major bug. It reverts an "experimental"
change done in11.2.
-ernie
-
To unsubsc
On Thu, 6 Feb 2020, 23:41 Eric Barboni, wrote:
> I'm thinking on doing beta3 preparation on Monday. Maybe can it be vc1 ?
>
I definitely think we should have a beta3. One thing we learned and
discussed during 11.1, and did during 11.2, is having vc1 identical to the
last beta.
I do think it's m
Hi Eric,
I have been using the latest 11.3 beta for the past few days without issues.
I'd say +1 to a vc1 next week.
Thanks
Josh Juneau
juneau...@gmail.com
http://jj-blogger.blogspot.com
https://www.apress.com/us/search?query=Juneau
> On Feb 6, 2020, at 5:41 PM, Eric Barboni wrote:
>
> Hi
Sorry for the previous not ready but send mail:/
Would it be possible to review the following:
(missing final review for )
https://github.com/apache/netbeans/pull/1774
(friend addition)
https://github.com/apache/netbeans/pull/1721
Travis build configuration (not reviewed). But seems ok to merge w
://github.com/apache/netbeans/pull/1270
by my perfect git(hub) actions.
Best Regards
Eric
-Message d'origine-
De : Neil C Smith
Envoyé : samedi 23 novembre 2019 11:46
À : dev
Objet : Re: PR-s are Piling up!
On Fri, 22 Nov 2019 at 23:46, Geertjan Wielenga wrote:
> I would do the
On Fri, 22 Nov 2019 at 23:46, Geertjan Wielenga wrote:
> I would do these tasks immediately, I just don't know exactly what needs to
> be done -- I don't know what needs to be done and I really appreciate the
> work you and Eric have done in simplifying and smoothing out the release
> process, but
I would do these tasks immediately, I just don't know exactly what needs to
be done -- I don't know what needs to be done and I really appreciate the
work you and Eric have done in simplifying and smoothing out the release
process, but currently I do not know how it works. For me, best would be
com
On Thu, 21 Nov 2019 at 20:25, Geertjan Wielenga wrote:
> But haven't they been reviewed already? At this point, you can merge them
> and continue with the process you describe of suggesting a signing option.
Theoretically there's an open request for review from Jan on the
nb-javac one, and an ope
But haven't they been reviewed already? At this point, you can merge them
and continue with the process you describe of suggesting a signing option.
Gj
On Thu, Nov 21, 2019 at 8:15 PM Neil C Smith wrote:
> On Wed, 20 Nov 2019 at 16:08, Laszlo Kishalmi
> wrote:
> > Please take some time and rev
On Wed, 20 Nov 2019 at 16:08, Laszlo Kishalmi wrote:
> Please take some time and review PR-s. They are piling up.
As important for 11.3 as that is, it would be even better if we could
prioritize the patch fix PRs for 11.2! There are 2 cherry-pick PRs
that still need reviewing and merging to mast
Thanks for the ping! Will be looking through them. :-)
Gj
On Wed, 20 Nov 2019 at 17:08, Laszlo Kishalmi
wrote:
> Dear all,
>
> Please take some time and review PR-s. They are piling up.
>
> Thank you!
>
>
> -
> To unsubscribe,
El 11/5/19 a las 11:42, Neil C Smith escribió:
On Sat, 11 May 2019 at 09:29, Antonio wrote:
As discussed in the splash screen thread and NETBEANS-2455 [1], I
submitted PR-1245 [2] based on the ASF Identity Guide and the
contributions by J. Gosling and others. Thank you all for the contributi
On Sat, 11 May 2019 at 09:29, Antonio wrote:
> As discussed in the splash screen thread and NETBEANS-2455 [1], I
> submitted PR-1245 [2] based on the ASF Identity Guide and the
> contributions by J. Gosling and others. Thank you all for the contributions!
...
> I've uploaded a new binary with a Tr
30 matches
Mail list logo
