Re: NB11.1 Feature Freeze - master branch closed except for fixes!

2019-06-17 Thread Junichi Yamamoto
Let's just revert it. I think we need the new branch for merging PRs unrelated to NB 11.1 because the current PRs are set 'master' as the base branch. The same thing may happen again. Thanks, Junichi On Tue, Jun 18, 2019 at 4:07 AM Neil C Smith wrote: > > On Mon, 17 Jun 2019 at 19:37, Geertjan

Re: NB11.1 Feature Freeze - master branch closed except for fixes!

2019-06-17 Thread Geertjan Wielenga
Great. It is through practical scenarios like this one that we’ll figure out how and whether our ideas work out. Gj On Mon, 17 Jun 2019 at 21:07, Neil C Smith wrote: > On Mon, 17 Jun 2019 at 19:37, Geertjan Wielenga > wrote: > > > > So where should that PR 1301 go, i.e., I guess, it should no

Re: NB11.1 Feature Freeze - master branch closed except for fixes!

2019-06-17 Thread Neil C Smith
On Mon, 17 Jun 2019 at 19:37, Geertjan Wielenga wrote: > > So where should that PR 1301 go, i.e., I guess, it should not be merged at > all unless it should go into 11.1? Ideally, no, particularly because it's intended for 11.2 anyway. In general, it depends where the urge to merge comes from.

Re: nbm-maven-plugin 4.2 generates one " too many in etc/conf

2019-06-17 Thread Patrik Karlström
Great, happy to hear that! Den mån 17 juni 2019 kl 11:38 skrev Eric Barboni : > It's fixed on the master. (https://github.com/apache/netbeans/pull/1203) > But the nbm-maven plugin is using the RELEASE110 that was wrong. > We have to wait next release. > > Regards > Eric > -Message d'origine--

Re: NB11.1 Feature Freeze - master branch closed except for fixes!

2019-06-17 Thread Geertjan Wielenga
So where should that PR 1301 go, i.e., I guess, it should not be merged at all unless it should go into 11.1? Gj On Mon, 17 Jun 2019 at 18:41, Neil C Smith wrote: > Hi All, > > Just a reminder that the feature freeze deadline for NB 11.1 was on > Saturday. The release branch was made earlier t

NB11.1 Feature Freeze - master branch closed except for fixes!

2019-06-17 Thread Neil C Smith
Hi All, Just a reminder that the feature freeze deadline for NB 11.1 was on Saturday. The release branch was made earlier today, and the branding / config changes made - first beta should be ready tomorrow. The only merges to master between now and release date should be intended for NB11.1 (eve

RE: [DISCUSS] The need for code reviewers

2019-06-17 Thread Eric Barboni
Sounds a good idea. How can we make it "fair" ? (maybe tribe member is not skilled enough, not knowing the better pattern and let the pr to be merged compared to another member that will ask for modification) How can we prevent too many people involved in too many tribe ? (because if an i

Re: Installers for 11.1 release

2019-06-17 Thread Geertjan Wielenga
All the sources for these generated installers are in Apache NetBeans GitHub and the entire generation process is handled by the Apache build process. Hence there should be nothing preventing these installers as being released as convenience binaries as part of the 11.1 release. Gj On Mon, 17 J

Re: Installers for 11.1 release

2019-06-17 Thread reema . taneja
Production signing of Windows installer is one that I haven't tried yet and it is not free. Other is limited testing of installers. Thanks, Reema On 17/06/19 6:25 PM, Geertjan Wielenga wrote: Excellent, many thanks for this! Definitely the most requested feature for Apache NetBeans is insta

Re: Installers for 11.1 release

2019-06-17 Thread Geertjan Wielenga
Excellent, many thanks for this! Definitely the most requested feature for Apache NetBeans is installers, so you have done the most important work for this release in that sense, many many thanks. What are the open items from your point of view here, the possible risks, the factors to be aware of?

[DISCUSS] The need for code reviewers

2019-06-17 Thread Geertjan Wielenga
Hi all, We have a beautiful PR for Payara integration, Java EE 8 integration, and more. But we're not going to be able to include those PRs if no one reviews them. How can we solve this situation? Possibly a tribe concept for reviewing PRs, similar to the tribe concept in NetCAT? I.e., the tribe

Installers for 11.1 release

2019-06-17 Thread reema . taneja
Resending with release number typo corrected.. Hi Geertjan, Neil,    I have created build job [1] for generating installers for Windows and Linux. Mac installer needs to be built locally. This build job currently points to zip generated from a daily build job. But for release build, it shoul

Re: AutoUpdate and Installer hard-coded versions?!

2019-06-17 Thread Neil C Smith
On Fri, 14 Jun 2019 at 17:47, Geertjan Wielenga wrote: > > There's reasons for that. Jirka will explain, I confess I keep > forgetting/not completely understanding this part. Well, I assumed there was. :-) I've made a PR adding 11.0 here - https://github.com/apache/netbeans/pull/1302 It's right

Installers for 11.0 release

2019-06-17 Thread reema . taneja
Hi Geertjan, Neil,    I have created build job [1] for generating installers for Windows and Linux. Mac installer needs to be built locally. This build job currently points to zip generated from a daily build job. But for release build, it should pick up release artifact from release job [2]

RE: nbm-maven-plugin 4.2 generates one " too many in etc/conf

2019-06-17 Thread Eric Barboni
It's fixed on the master. (https://github.com/apache/netbeans/pull/1203) But the nbm-maven plugin is using the RELEASE110 that was wrong. We have to wait next release. Regards Eric -Message d'origine- De : Patrik Karlström Envoyé : dimanche 16 juin 2019 10:45 À : dev@netbeans.apache.org