Re: [DISCUSSION] integrating cleanup PRs

2023-01-26 Thread Antonio
Hi, I'd try to take a look at them during the weekend, as time permits. I've seen tons of "code cleanup" PRs that have very little value and are too granular. - Changing "new Integer(0)" with "0" in three files in a project with > 500k LOC is not worth the effort and does not provide real

Re: Jackpot

2023-01-26 Thread Jan Lahoda
Hi Scott, Thanks for the interest in Jackpot. The Maven plugin basically only calls a standalone command line tool, which is also uploaded on Maven central (org.apache.netbeans.modules.jackpot30:tool:13.0), although that's a bit harder to use without the launchers (launchers are part of the

Re: Jackpot

2023-01-26 Thread Scott Palmer
I haven't been able to get Jackpot to build... (If there is a better place to ask about this, let me know) I followed the instructions in cmdline/README.md Using Ant v 1.10.12 Maven v 3.8.4 With JAVA_HOME set to JDK 8 I ran: ant -DNETBEANS_PLATFORM=/Users/scott/dev/netbeans-13

Re: NB 17-rc2 Gradle "included builds" are missing from class path

2023-01-26 Thread Scott Palmer
Interestingly, while making this test case the issue only appeared after I made the included library modular, and even then I had to restart NB for the issue to show up. So I can't be certain if this wasn't also an issue with 17-rc1, as I may not have restarted NB 17-rc1 after making my actual

Re: NB 17-rc2 Gradle "included builds" are missing from class path

2023-01-26 Thread László Kishalmi
Is this a regression between NB17-rc1 and NB17-rc2 ? If I may ask, could you provide a sample project? On Thu, Jan 26, 2023 at 12:29 PM Scott Palmer wrote: > No, all those details are in the libs.versions.toml file. > > [versions] > fxsvg = "1.0.0" > > [libraries] > fxsvg = { module =

Re: NB 17-rc2 Gradle "included builds" are missing from class path

2023-01-26 Thread Scott Palmer
No, all those details are in the libs.versions.toml file. [versions] fxsvg = "1.0.0" [libraries] fxsvg = { module = "com.analogideas.fxsvg:fxsvg", version.ref = "fxsvg" } On Thu, Jan 26, 2023 at 3:19 PM László Kishalmi wrote: > Shoudn't you use the :[:] reference there? > > On Thu, Jan 26,

Re: NB 17-rc2 Gradle "included builds" are missing from class path

2023-01-26 Thread László Kishalmi
Shoudn't you use the :[:] reference there? On Thu, Jan 26, 2023 at 10:46 AM Scott Palmer wrote: > I have a project that uses another library I am working on. The library is > not deployed to any artifact repository (i.e. not even the maven local > cache), but it does define a group and name.

Re: Jackpot

2023-01-26 Thread Ernie Rael
On 23/01/26 10:25 AM, Scott Palmer wrote: Well, yeah of course.. but is there a documented public API? The maven plugin doesn't actually do refactoring, right? It just identifies hints? At: https://netbeans.apache.org/jackpot/ To apply the changes produced by the declarative hints, run

NB 17-rc2 Gradle "included builds" are missing from class path

2023-01-26 Thread Scott Palmer
I have a project that uses another library I am working on. The library is not deployed to any artifact repository (i.e. not even the maven local cache), but it does define a group and name. I included it in the project that uses it as an "included build" In NB 17-rc1 this project was

Re: Jackpot

2023-01-26 Thread Scott Palmer
Well, yeah of course.. but is there a documented public API? The maven plugin doesn't actually do refactoring, right? It just identifies hints? I was just wondering if there are notes somewhere that go a bit deeper than showing how to use it from the command line or NetBeans. I did find a README

Re: [DISCUSSION] integrating cleanup PRs

2023-01-26 Thread Neil C Smith
On Thu, 26 Jan 2023 at 18:04, Michael Bien wrote: > But since so many PRs piled up by now, I would like to wait till NB > 17rc3 is out, and then after that slowly start merging again. Plan is to > let some time pass between merges so that everyone gets the opportunity > to update the local clones

[DISCUSSION] integrating cleanup PRs

2023-01-26 Thread Michael Bien
Hello devs, we have a large amount of cleanup PRs open in various stages of readiness (some are not even labeled yet so the wrong tests ran most likely). https://github.com/apache/netbeans/pulls?q=is%3Apr+is%3Aopen+label%3A%22Code+cleanup%22 I stopped integrating cleanup PRs when NB 17 got

Re: Jackpot

2023-01-26 Thread Michael Bien
you check how the maven plugin is implemented and adopt it for gradle? -mbien On 26.01.23 17:13, Scott Palmer wrote: I don't use Maven if I can help it. But you misunderstand, I want to call Jackpot from my code to get it to perform some refactoring from control of my program. Getting a list

Re: Jackpot

2023-01-26 Thread Scott Palmer
I don't use Maven if I can help it. But you misunderstand, I want to call Jackpot from my code to get it to perform some refactoring from control of my program. Getting a list of possible hints may happen later. Or perhaps a more general use... What would I do if I wanted to write a Gradle plugin

Re: Better release notes for NB17 - the Highlight label

2023-01-26 Thread Neil C Smith
On Thu, 26 Jan 2023 at 15:37, Eirik Bakke wrote: > > There was a top comment on the "Apache NetBeans 15" HackerNews post some > months ago that seems relevant: > > "None of the blog that is linked here, Netbeans github page, and the official > NetBeans website have a single screenshot of what

Re: Jackpot

2023-01-26 Thread Michael Bien
On 26.01.23 16:01, Scott Palmer wrote: I wanted to experiment with Jackpot for a project I'm working on. How dependent on the NetBeans Platform is the Jackpot code at https://github.com/apache/netbeans-jackpot30 ? Is there such a thing as a jackpot library jar that does not depend on NetBeans

Re: Jackpot

2023-01-26 Thread Ernie Rael
On 23/01/26 7:01 AM, Scott Palmer wrote: I wanted to experiment with Jackpot for a project I'm working on. How dependent on the NetBeans Platform is the Jackpot code at https://github.com/apache/netbeans-jackpot30 ? Is there such a thing as a jackpot library jar that does not depend on NetBeans

RE: Better release notes for NB17 - the Highlight label

2023-01-26 Thread Eirik Bakke
There was a top comment on the "Apache NetBeans 15" HackerNews post some months ago that seems relevant: "None of the blog that is linked here, Netbeans github page, and the official NetBeans website have a single screenshot of what the application looks like. If you compare that to IntelliJ

Jackpot

2023-01-26 Thread Scott Palmer
I wanted to experiment with Jackpot for a project I'm working on. How dependent on the NetBeans Platform is the Jackpot code at https://github.com/apache/netbeans-jackpot30 ? Is there such a thing as a jackpot library jar that does not depend on NetBeans classes? If I wanted to make a standalone