org.openide.filesystems.Repository
Trying to understand a little about how NB finds source files (e.g. "go to declaration") I came across class "org.openide.filesystems.Repository" which seems to be used widely, even though all (?) its public methods are deprecated. The deprecation notice says to use the ClassPath API instead but can't see practically how that would work. For example in "org.netbeans.core.startup.layers.ArchiveURLMapper", function "private static JarFileSystem findJarFileSystemInRepository(File jarFile)", there is the line Enumeration en = Repository.getDefault().getFileSystems(); How could one get FileSystems from the classpath API? Is there any guidance on this? Thanks Peter - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [HELP WANTED] Testing new macOS installer
Just as a follow up I noticed some keys which are in the info.plist of netbeans 18 and not in 20-rc4, specifically NSHighResolutionCapable and NSSupportsAutomaticGraphicsSwitching - I don't know what these do but might they be important? - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [HELP WANTED] Testing new macOS installer
On Tue, 14 Nov 2023 at 18:19, Neil C Smith wrote: > Testing as we wind down towards NB20 release would be appreciated, > including of terminal and profiler support from a signed installer on > aarch64! It installed OK for me on MacOS (see specs below) but it wouldn't run because it said it needed MacOS 12 - however I could run it by executing Contents/MacOS/netbeans directly. So maybe that restriction on OS version is unnecessary? (I appreciate 10.15.7 is pretty long in the tooth now) Pete Product Version: Apache NetBeans IDE 20-rc4 Java: 17.0.5; OpenJDK 64-Bit Server VM 17.0.5+8 Runtime: OpenJDK Runtime Environment 17.0.5+8 System: Mac OS X version 10.15.7 running on x86_64; UTF-8; en_GB (nb) - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: NetBeans 20
On Mon, 16 Oct 2023 at 11:01, Michael Bien wrote: > NB 20 will have initial support for string templates, e.g code completion: > the first release candidate should be out this week so you can test it > yourself if you want. I just tried it on rc2 - seems to work fine, thanks! - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: NetBeans 20
On Mon, 16 Oct 2023 at 11:40, Laszlo Kishalmi wrote: > > The String Template support has been merged for NB20: I missed that one. Thank you Michael and Laszlo! Peter - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
NetBeans 20
Quick question - will NetBeans 20 editor support Java 21, specifically the string templates (which, I know, is only in preview)? I couldn't see anything Java 21-related in the milestone issue list. Thanks Pete - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: x11 resource claim of graph applet in performance toolbar
It would be good if someone could try and reproduce this (I don't use netbeans on Linux) but it seems like it might not be Netbeans to blame? Also can you just clarify - are these X resources returned after a GC or is there some amount which is permanently leaked? On Mon, 4 Sept 2023 at 12:40, Simon IJskes - QCG wrote: > > The rate of GC increments depends on if the performance toolbar is the > last in the toolbars, when i add a custom toolbar at the end, it is down > to 3 per second. When not about 30+ per second. > > Using Metal Laf. > > Gr Simon > > On 9/4/23 13:19, Simon IJskes - QCG wrote: > > > > Thanks, > > > > had a look as well, and nothing looks like a forgotten dispose, in that > > component. > > > > I'm starting to think it is a broader problem. Maybe more a LAF thing, > > if i 'hide' the window (i dont know the proper term, the display manager > > shows a button with windowtitle in [] in the panel), the increment of > > the graphics contexts stops. Also it is probably dependend on the > > netbeans window content. After restarting netbeans it is down to 3 gc > > extra per second. > > > > Gr. Simon > > > > On 9/4/23 11:59, Peter Hull wrote: > >> On Mon, 4 Sept 2023 at 10:01, Simon IJskes - QCG wrote: > >>> The memory graph in the performance toolbar claims a huge amount of X11 > >>> resources. > >>> > >>> To give an idea, it creates 30 X11 graphics contexts per second. > >> > >> For information - this is implemented in > >> https://github.com/apache/netbeans/blob/0322fce7c3f5c9335f2bcb00e5751de81fdb7ffb/platform/openide.actions/src/org/openide/actions/HeapView.java#L62 > >> I had a quick look and I can't see anything jumping out as being the > >> problem, it's quite a simple pure Java class. > >> The auto update is set to trigger every 1500 milliseconds so something > >> else must be causing it to refresh at 30 times per second. > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > >> For additional commands, e-mail: dev-h...@netbeans.apache.org > >> > >> For further information about the NetBeans mailing lists, visit: > >> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > >> > >> > >> > > > > -- > create firmware without programming https://www.bendyroad.com > > > - > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > For additional commands, e-mail: dev-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: x11 resource claim of graph applet in performance toolbar
On Mon, 4 Sept 2023 at 10:01, Simon IJskes - QCG wrote: > The memory graph in the performance toolbar claims a huge amount of X11 > resources. > > To give an idea, it creates 30 X11 graphics contexts per second. For information - this is implemented in https://github.com/apache/netbeans/blob/0322fce7c3f5c9335f2bcb00e5751de81fdb7ffb/platform/openide.actions/src/org/openide/actions/HeapView.java#L62 I had a quick look and I can't see anything jumping out as being the problem, it's quite a simple pure Java class. The auto update is set to trigger every 1500 milliseconds so something else must be causing it to refresh at 30 times per second. - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Windows 11 Issues - Copy/Paste Failure
On Tue, 29 Aug 2023 at 14:59, Scott Palmer wrote: > But when I worked on Windows it happened all the time. It was a weekly > annoyance. > I know how frustrating this must be. I use NetBeans on Windows (currently NB 18 and Windows 11) and I do not see this issue. In the linked bug, there is some code which uses Robot to automate copy/paste to notepad, which was said to be a reliable reproducer. But I still couldn't get it to go wrong, even running it multiple times. The only thing I can say (and I'm sure it's been mentioned before, don't hate me) is that I have previously seen clipboard issues when VirtualBox was running. So I suppose the question is - are those people experiencing it absolutely sure they're not running something else that might be interfering with the clipboard? Pete - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Maven indexing on NB 18
Just to update you, I think my problem was really down to running out of space on the system drive; I have made more space available and over the last 2 weeks it seems to be behaving fine. I didn't try NB19 as I haven't had time. Thanks everyone, Peter - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Maven indexing on NB 18
On Sun, 11 Jun 2023 at 19:05, Tamás Cservenák wrote: > The central index last publish happened on 5th June 2023. Thanks everyone for the comments. I've not been monitoring it specifically but I had the feeling that indexer was running more frequently, that's why I asked if there was a log so I could confirm it (or not!) I believe it was indexing rather than just an update check, because it makes my laptop fans spin up for a few minutes. I have only recently upgraded to NB18 so for example if I had done that on 4th June I would have had an indexer run on that day and again the following day, is that correct? And also, if I had closed NB before the indexing had finished, would it start again from scratch, or does it work incrementally? I'll keep an eye on it and let you know if it seems to be running more frequently than updates to the nexus-maven-repository-index.properties would suggest. Pete - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Maven indexing on NB 18
Hi, It seems to me that the maven indexing is running more often than it used to, and certainly more than 'once per week' which is what I've set it up for. For example, it's run twice today. Is there a log which shows how often it's run and what made it start, then I can confirm what the situation is? There's nothing useful AFAICS in the IDE log. Peter ps I'm running NB 18 with JDK 17 on Windows 11. The maven is the built-in one. - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: PR
On Sat, 15 Apr 2023 at 21:15, Łukasz Bownik wrote: > Will it get merged or shall I close it? I believe PRs can still get merged even after the fork is deleted - see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally#modifying-an-inactive-pull-request-locally However it can potentially make it more cumbersome for the NB developers so I don't see why you would delete it? - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [Lazy Consensus] Minimum JDK build and run policy (dropping JDK 8)
On Wed, 12 Apr 2023 at 09:15, Mark Struberg wrote: > Java11 is not as much used in the industry, it was kind of totally ignored by > some companies and bigger projects. It also imo doesn't bring that much of a > benefit for the code base. Plus the eco system is rather slowly moving. There > are still too many Java 8 projects actively being used and maintained in the > industry. And we still have Android as was mentioned. Can you just clarify - as I understand it we are talking about the JDK needed to build and run Netbeans. I can then use NB to develop a project which needs a different JDK e.g. Java 8. Neil (I think) said the earliest JDK I could use for a project depends on the availability of nb-javac for that platform, is that right? Who is in charge of that decision, is it Apache? I can see why a company deploying an application would want to stick with the Java version they have validated in production but does that also apply to what is running on the developers' own machines? (I have no experience of this in industry) Sorry if this is obvious, I thought I'd got it and then became a little confused with some of the responses here. Peter - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Replacement for deprecated getUserHomeDirectory
On Tue, 7 Mar 2023 at 16:36, Christian Oyarzun wrote: > Looks like you should use getDefaultUserdirRoot(). Great thanks! Although I see that, for example in getSuperId(), it uses getUserHomeDirectory() as a fallback if getDefaultUserdirRoot() doesn't work! - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Replacement for deprecated getUserHomeDirectory
Hi, Does anyone know what is the suggested replacement for org.netbeans.installer.utils#getUserHomeDirectory() in netbeans/nbi/engine/src/org/netbeans/installer/utils/SystemUtils.java:88 Thanks! - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Launching an application
On Thu, 2 Mar 2023 at 10:22, Andrii Cherepkov wrote: > > I just installed NetBeans for coding in PHP. So I try to launch application > and nothing was happened =( Just to be clear, what OS are you using and how did you install Netbeans? (from the zip or from a platform dependent installer?) I know for the Windows installer if it can't find Java it shows a popup window. Peter - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Windows installer build process
On 2023/02/27 22:23:17 Christian Oyarzun wrote: > I believe the stub gets the rest of the installer's binary data appended to > it or vise-versa Thanks Christian, that was helpful. I think maybe it's the shell scripts in "netbeans\nbbuild\installer\infra\build" that assemble the final binary. The stub is padded out to 45 bytes and then the metadata and binary data are appended to that (so the stub knows to start extracting from a fixed offset 45 from the beginning of the file) This means I can recompile the stub and test it just by overwriting the first part of an existing installer, which is simpler/quicker than going through the proper build process.That seems to work so far, hopefully I can proceed this way. - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Windows installer build process
I was wanting to investigate the 'native' windows installer to see if I could fix https://github.com/apache/netbeans/issues/5060 'Difficulty with NB16 Windows installer' but I cannot figure out how the windows stub exe gets incorporated to the final, overall windows installer 'Apache-NetBeans-17-bin-windows-x64.exe' or whatever. Can anyone give me some hints to get started? - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Status of 'allowAmbiguousCommands' and Maven
On Tue, 24 Mar 2020 at 11:09, Neil C Smith wrote: > Incidentally, that fix went into NB 11.2. OK, memory didn't serve. After my first message I actually checked in the bug report and there were references to it being fixed in 11.2 VC so I guessed it was fixed in 11.2. How time flies! Pete - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Status of 'allowAmbiguousCommands' and Maven
On Tue, 24 Mar 2020 at 08:44, Eric Barboni wrote: Thanks Eric, I have updated the StackOverflow. - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Status of 'allowAmbiguousCommands' and Maven
Towards the end of last year there was a problem with Maven projects caused by a new version of the JDK. The workaround was to edit netbeans.conf and add an option to netbeans_default_options. What's the current status of this? If memory serves, the change for netbeans.conf was put into NB 11.3 and there is a patch been committed for NB 12? I ask because I answered a StackOverflow question on this I and I want to edit my answer to make sure it's the correct, up-to-date information. https://stackoverflow.com/questions/58473884/cannot-create-maven-web-project-in-netbeans-8-2/58500289#58500289 Pete - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Cannot build netbeans from the master on Fedora 31
I think there is something unusual about Fedora's ant, which I have
not got to the bottom of. See, for example,
https://issues.apache.org/jira/browse/NETBEANS-239
Can you try downloading ant from Apache and using that, instead of the
one from your distro. https://ant.apache.org/bindownload.cgi
I have build netbeans this way fairly recently (in the last month) and
it was ok.
Pete
On Tue, 17 Mar 2020 at 06:34, Code Zombie wrote:
>
> Hi Geertjan
>
> Ant version:
>
> Apache Ant(TM) version 1.10.5 compiled on May 7 2019
>
> Errors:
>
> : The following error occurred while executing this line:
> /home/johndoe/src/netbeans/nbbuild/build/langtools/make/build.xml:91:
> java.lang.ClassNotFoundException:
> org.apache.bsf.engines.javascript.JavaScriptEngine
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
> at
> java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
> at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
> at org.apache.bsf.BSFManager.loadScriptingEngine(BSFManager.java:696)
> at org.apache.bsf.BSFManager.exec(BSFManager.java:485)
> at
> org.apache.tools.ant.util.optional.ScriptRunner.executeScript(ScriptRunner.java:100)
> at
> org.apache.tools.ant.types.optional.AbstractScriptComponent.executeScript(AbstractScriptComponent.java:142)
> at
> org.apache.tools.ant.types.optional.ScriptMapper.mapFileName(ScriptMapper.java:85)
> at
> org.apache.tools.ant.util.CompositeMapper.lambda$mapFileName$0(CompositeMapper.java:32)
> at
> java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195)
> at
> java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:177)
> at
> java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1654)
> at
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
> at
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
> at
> java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:550)
> at
> java.base/java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260)
> at
> java.base/java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:517)
> at
> org.apache.tools.ant.util.CompositeMapper.mapFileName(CompositeMapper.java:33)
> at org.apache.tools.ant.taskdefs.PathConvert.execute(PathConvert.java:363)
> at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
> at org.apache.tools.ant.Task.perform(Task.java:350)
> at org.apache.tools.ant.Target.execute(Target.java:449)
> at org.apache.tools.ant.helper.ProjectHelper2.parse(ProjectHelper2.java:184)
> at
> org.apache.tools.ant.ProjectHelper.configureProject(ProjectHelper.java:93)
> at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:393)
> at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
> at org.apache.tools.ant.Task.perform(Task.java:350)
> at org.apache.tools.ant.Target.execute(Target.java:449)
> at org.apache.tools.ant.Target.performTasks(Target.java:470)
> at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1388)
> at org.apache.tools.ant.Project.executeTarget(Project.java:1361)
> at
> org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
> at org.apache.tools.ant.Project.executeTargets(Project.java:1251)
> at org.apache.tools.ant.Main.runBuild(Main.java:834)
> at org.apache.tools.ant.Main.startAnt(Main.java:223)
> at org.apache.tools.ant.launch.Launcher.run(Launcher.java:284)
> at org.apache.tools.ant.launch.Launcher.main(Launcher.java:101)
>
> Total time: 11 seconds
>
> And then the mentioned build.xml file contains at line 91:
>
>
>
> fs = project.getProperty("file.separator");
> path = project.getProperty("build.modules");
> mod = source.substr(source.lastIndexOf(fs)+1);
> self.addMappedName(mod + "=\"" + path + fs + mod + "\"");
>
>
>
>
>
>
>
>
>
>
>
>
> On Tue, Mar 17, 2020 at 2:29 AM Geertjan Wielenga
> wrote:
>
> > In what way is it failing, what are the error messages? Often the problem
> > is related to the Ant version used.
> >
> > Gj
> >
> > On Tue, 17 Mar 2020 at 07:22, Code Zombie wrote:
> >
> > > I am trying to build NetBeans
Re: Apache Netbeans 11.3 Press
On Sun, 15 Mar 2020 at 20:44, Eric Bresie wrote: > https://adtmag.com/articles/2020/03/11/apache-netbeans-update.aspx?oly_enc_id=8998A7400878E0S Looks good up to the last paragraph - that stuff about the Swiss army knife doesn't make sense to me. Has the author confused NetCAT with the nc/netcat utility? - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Memory usage text rendering issue
On Fri, 28 Feb 2020 at 10:37, Tim Boudreau wrote: > I happened to be around to chat with the author of that code Thanks for the info; I mentioned above that the code seemed strangely complicated and I could not find any comments or history to explain it. > The reason: GradientPaint's allocate large rasters (large being int[width > * height * 4]) on every repaint. I did not know this. But, the updated widget doesn't use gradient paints any more, just a flat colour filled polyline and some text, so hopefully we won't get that problem. > Most likely the root of the problem is simply > theGraphics.setRenderingHint(RenderingHints.KEY_TEXT_ANTIALIASING, > RenderingHints.VALUE_ANTIALIASING_ON) I believe the ugliness was caused by rendering the text + dropshadow into a buffer created with the 'nominal' pixel dimensions, then causing it to scale up a bit by drawing it on to the HiDPI screen (e.g. a 125% scale, which resulted in blockiness). As mentioned by David Green above it looks OK if the drop shadow effect is turned off. In this case text was drawn straight onto the Graphics2D. If you wouldn't mind running an eye over the code that would be great! Pete - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Pull the plug from Java 8 in 12.1?
I also feel it is a bit too early. Java 8 is still common in production - for example this suggests 64% Java 8, 25% Java 11: https://snyk.io/blog/developers-dont-want-to-leave-java-8-as-64-hold-firm-on-their-preferred-release/ (i know this is not necessarily a representative survey) For people working in commercial environments, is it usual for everything to be using the same JVM, or for example can developers use whatever they want, as long as they target a specific version for the production servers? If everything has to be the same, this could limit uptake of a Java 11 only NB. Pete - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Profiling method calls does not work with JDK newer than 1.8
On Wed, 26 Feb 2020 at 20:00, Matthias Bläsing wrote: > ok - I'll aks the obvious question: Why try to squeze a pointer sized > type into a int sized type? Why not use a jlong? I've been back and forth on this one - I actually implemented it both ways. I went for mapping jmethodID to jint because it didn't need any changes *at all* to the Java code or the wire protocol, and allowed all the old native libraries to work unchanged. Although more processing is needed in the native code, performance seemed OK to me, and it would be offset by not having to double the amount of data sent over the wire. For the 'all 64 bit/jlong' alternative I wasn't 100% confident I had found all places where changes were required. I also looked at a third option of having two wire protocols for 32 and 64-bit and this seemed even more complicated! Having said that, are we close to the point where all JVMs are 64 bit? Should we just get on with it and go for 64-bit? Any comments welcome! Pete ps. I look forward to discussing again in a few decades, when 128-bit pointers are the norm!! - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Profiling method calls does not work with JDK newer than 1.8
On Wed, 26 Feb 2020 at 19:42, Matteo Di Giovinazzo wrote: > I found the whole thread and I see you found a solution: NB 12.0 might be a > good occasion to get this sorted out. Agreed, I have been a bit quiet recently because I was waiting for all the 11.3 stuff to settle down. > I see in one of your last comments > [1] you were stuck on integrating the fix in NetBeans infrastructure build. > I guess I can try to help you. As I understand it, we need to build the native interface (DLL/SO) on every platform we support, zip them up into profiler-external-binaries-8.2.zip (or -12 I guess!) then upload to netbeans.osuosl.org/binaries, and finally update the binaries-list file in the NB source. My specific problems were: * can't build for every platform, especially old ones (HP-UX, for example) - we might need to take a decision to drop some platforms. * I don't know who to ask about uploading to osuosl. Currently I've rebuilt for Win, Mac and Linux, and superficially tested them, enough for a more thorough testing as part of NetCAT. I just need to tidy up my branch and will put in a PR fairly soon. - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Profiling method calls does not work with JDK newer than 1.8
On Wed, 26 Feb 2020 at 18:39, Matteo Di Giovinazzo wrote: > > Profiling method calls does not work with JDK newer than 1.8 > https://issues.apache.org/jira/browse/NETBEANS-3896 It is the same as https://issues.apache.org/jira/browse/NETBEANS-1428 I think. - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Java profiler (again) - supported platforms
Hi all, I think I am right when I say the Profiler still will not work for 64-bit windows, [NETBEANS-1428] (https://issues.apache.org/jira/browse/NETBEANS-1428) There's a quick fix, a replacement DLL, which is referenced in the bug report above. I am still working slowly on the correct fix and I am nearly there. One thing which makes it difficult is the number of platforms which the native shared library is built for. On JDK 1.5: hpux-pa_risc2.0 hpux-pa_risc2.0w linux linux-amd64 mac solaris-amd64 solaris-i386 solaris-sparc solaris-sparcv9 windows windows-amd64 On JDK 1.6: hpux-pa_risc2.0 hpux-pa_risc2.0w linux linux-amd64 linux-arm linux-arm-vfp-hflt mac solaris-amd64 solaris-i386 solaris-sparc solaris-sparcv9 windows windows-amd64 On CVM (an embedded JVM, not even sure?): linux windows Also 'mac' encompasses i386, x64, PPC and PPC64 all bundled together. The logic here is, if I understand correctly, that the JNI interface hasn't changed since JDK 1.6 so there's no need for separate 1.9, 9, 10, 11, ... versions and the server-side code (which runs alongside the profiler target) is written with as low a source level as possible. This should make it possible to profile something on all these platforms, even if NB 11.x itself won't run on these platforms. I think the changes I need to make will not break existing support but I will not have a way to test. So: 1. Is there an official list of supported 'target' platforms? 2. If I finish my work and put in a PR, is anyone likely have time to test it? Especially on different linuxes (and solaris if we're still doing solaris) (we have a decent test-spec as part of NetCAT, it doesn't take long to whiz through it) Pete - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Memory usage text rendering issue
On Mon, 3 Feb 2020 at 21:23, Laszlo Kishalmi wrote: > +1 for make it more simple! > > I have made a PR, https://github.com/apache/netbeans/pull/1918. Images of current / proposed are in the PR. Please let me know if you have any comments and also if you are able to test it on Mac, Linux, different HiDPI settings that would be great. Pete
Re: Memory usage text rendering issue
On Mon, 3 Feb 2020 at 15:43, Eirik Bakke wrote: > You could make it work, but it will be easier to just redo the drawing > code directly. And it can really be something much simpler than what is > there now--no gradients etc, axis marker lines or anything. Just a single > polygon of a solid color (for the chart) with the text drawn on top. This > would look a lot more modern. > > I'll give it a go. Pete
Re: Memory usage text rendering issue
On Mon, 3 Feb 2020 at 15:12, Eirik Bakke wrote: > Do you have HiDPI scaling activated? (Check "Scale and Layout" in the > windows Display control panel.) > > To make things like this work well on HiDPI screens, it's best not to go > through a BufferedImage, but rather draw directly on the supplied > Graphics2D. > Hi Eirik, Sorry if it wasn't clear - this is all about Scott Palmer's issue with the HeapView widget - and the current code *does* go through a BufferedImage. My gist was just confirming that there is a difference in the output of the two methods (and I was hoping someone would know the 'magic' rendering hints which would make them the same!) I've made some mods which do improve things IMO, but these are drawing directly on the Graphics2D. This means the blur effect of the current code, using ConvolveOp, can't be done. If I understand correctly you're saying that there's no easy way to get it to work through BufferedImage? If so I can put in a pull request for my 'direct drawing' code. Let me know what you think as I am not an expert in this. Pete
Re: Memory usage text rendering issue
I made a simple example, https://gist.github.com/pedro-w/b089e23db7aca037266b41cfc9c2ec2f On windows, I see this: [image: Annotation 2020-02-03 142402.jpg] I think the unpleasant rendering in the 'Rendered via Image' sample accounts for what you can see in the Memory usage widget (it's worse for smaller text) I suppose there is some RenderingHints which can fix this, unfortunately I haven't time to google just now! Pete
Re: Memory usage text rendering issue
On Mon, 3 Feb 2020 at 12:38, Scott Palmer wrote: > How is the BufferedImage created? What is the pixel format? > It is BufferedImage.TYPE_INT_ARGB Reference: https://github.com/apache/netbeans/blob/820a688606a3777c673ab6cfb3d6638fe87471cc/platform/openide.actions/src/org/openide/actions/HeapView.java#L663 Pete
Re: Memory usage text rendering issue
On Sun, 2 Feb 2020 at 18:28, Scott Palmer wrote: > Does anyone else see really ugly text in the memory usage widget on the > toolbar? > I had a quick look at this. It's very odd, rendering text into a Graphics2D derived from a BufferedImage (which is what the current dropshadow does) comes out differently from rendering to the Graphics2D supplied to the paintComponent method. Also the current code seems quite complicated and I'm not sure why. e.g. it creates a new Runnable to render the text. I tried using the cheap & cheerful way of drawing the text twice, the first time displaced and in a darker colour. It is more subtle than the current method of using ConvolveOps etc. but looks "not terrible" to my eye. To be honest, not having a drop shadow at all looks fine to me. Let me know what you think of the image below: [image: Annotation 2020-02-03 121418.jpg] The change is just one file, with 13 insertions and 94 deletions, so just a slight reduction in LOC.
Re: Build failing locally
On Tue, 3 Dec 2019 at 01:19, Steven Ingram wrote: > Also I just noticed that the README has changed to say that you can now > build the project with 8 or 11? How'd I miss that? > > Just to check I did a clean checkout and built with JDK11. I needed to add option "-Dpermit.jdk9.builds=true" to the ant command line (it tells you to do this) but it was fine. However, some targets (build-basic and build-platform) already have this set. So I think the message is - make sure not to mix two JDKs otherwise strange things will happen. This means checking the PATH and JAVA_HOME and JDK_HOME and .nbbuild.properties and nbbuild\user.build.properties for consistency. Having said which, I *think* building with JDK 1.8 is still the recommended option (at least that's what the Travis does). Anyway they're all the things I've done wrong so hopefully will be helpful to someone else. Pete
Re: Build failing locally
On Sun, 1 Dec 2019 at 22:15, Steven Ingram wrote: > I tried to build the project today, but I kept hitting errors which led me > to make a new clone of an up-to-date master branch of my fork. I keep > running into compilation errors. See attached truncated output. If i need > to attach the rest I can at request. > > I also saw the same errors (failing to build the applemenu module) just recently. For me it was solved by making sure I was building with JDK 8, and making sure JAVA_HOME was also set correctly. I think applemenu depends on some Desktop classes which were added in JDK9, and there is a compatibility JAR which contains these classes for earlier JDKs. On later ones (I tried JDK11) the classes should be there automatically but for some reason they were not found. I didn't have time to look further. Pete
Re: Error when building from current git
On Wed, 27 Nov 2019 at 14:31, Laszlo Kishalmi wrote: > Actually I've seen that when I added the dark LAF to the build. > > But master builds fine for Travis and for me as well. > > I don't know what caused the problem but I have done an `ant clean` and then `ant build` which was successful. Thanks for your help, Peter
Error when building from current git
Hi all, I have started seeing this error after updating to the latest git master and running `ant` or `ant build-basic`: > ...\netbeans\nbbuild\build.xml:660: Target "all-o.n.swing.laf.dark" does not exist in the project "nbbuild". It is used from target "nbmerge-build-one-cluster". Has anyone else seen this? I'm using Windows & JDK1.8 to build. Pete
Re: [NETBEANS-3346] Upgrade asm to 5.2+
On Thu, 7 Nov 2019 at 22:28, Laszlo Kishalmi wrote: > When you create your PR for 7.2, please close this one in favor of that: > PR#1620 has been merged now, which is great news! Is everyone happy that no changes are needed to the processjsannotations ant task - this was discussed in the comments[1] to the PR but I wasn't clear if the matter had been concluded. Thanks Pete [1]: https://github.com/apache/netbeans/pull/1620#discussion_r345766432
Re: [NETBEANS-3346] Upgrade asm to 5.2+
On Wed, 6 Nov 2019 at 22:24, Jose Ch wrote:
>
> I will test the PR and do as you suggest Pete.
For what it's worth my implementation was a bit different:
private static class CtorDelVisitor extends AnnotationVisitor {
int[] indices;
/**
* Constructs a new {@link AnnotationVisitor}.
*
* @param api the ASM API version implemented by this visitor. Must
be one of {@link
* Opcodes#ASM4}, {@link Opcodes#ASM5}, {@link Opcodes#ASM6} or
{@link Opcodes#ASM7}.
*/
public CtorDelVisitor(int api) {
super(api);
}
@Override
public AnnotationVisitor visitArray(String name) {
if ("delegateParams".equals(name)) { // NOI18N
return new AnnotationVisitor(api) {
List list = new ArrayList<>();
@Override
public void visit(String name, Object value) {
list.add((Integer) value);
}
@Override
public void visitEnd() {
int[] indices = new int[list.size()];
for (int i = 0; i < indices.length; ++i) {
indices[i] = list.get(i);
}
CtorDelVisitor.this.indices = indices;
}
};
} else {
return super.visitArray(name); // Not interested
}
}
}
I guess Svata's will be more efficient.
It's a bit frustrating that the AnnotationNode forces us to visit each
array element in turn when all we need is the complete list, but I think
there's no way around that. Visitor pattern makes my head spin, it always
seems inside-out to me.
Pete
Re: [NETBEANS-3346] Upgrade asm to 5.2+
On Wed, 6 Nov 2019 at 20:38, Svata Dedic wrote: > Yes, that was it. You probably didn't do "ant clean" (neither did I). Right. > The NPE should be fixed by > https://github.com/pepness/incubator-netbeans/pull/2 Right again! I just opened up my mail to post my progress, great to see you'd already solved it! However: 1. Would it be better to jump straight to the latest Asm (7.2) - i.e. put in a PR against Jose's asm72 branch 2. There is a also a commit titled "Add logging" on that branch, and the asm72 branch, which is certainly not wanted. So maybe Jose can pull yours, rebase and then put in a PR against apache/netbeans? Pete - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [NETBEANS-3346] Upgrade asm to 5.2+
On Wed, 6 Nov 2019 at 15:13, Jose Ch wrote: > Could you verify that in the line 300 (Startup Classpath) it is using the asm > version 5.2 or above? For some reason I've got both 7.2 and 5.0.1 on the startup classpath - I will do a clean & rebuild then report back to you. Pete Startup Classpath = D:\Libraries\Documents\NetBeansProjects\netbeans\nbbuild\netbeans\platform\core\asm-7.2.jar;D:\Libraries\Documents\NetBeansProjects\netbeans\nbbuild\netbeans\platform\core\asm-all-5.0.1.jar;D:\Libraries\Documents\NetBeansProjects\netbeans\nbbuild\netbeans\platform\core\asm-tree-7.2.jar;D:\Libraries\Documents\NetBeansProjects\netbeans\nbbuild\netbeans\platform\core\core-base.jar;D:\Libraries\Documents\NetBeansProjects\netbeans\nbbuild\netbeans\platform\core\core.jar;D:\Libraries\Documents\NetBeansProjects\netbeans\nbbuild\netbeans\platform\core\org-netbeans-libs-asm.jar;D:\Libraries\Documents\NetBeansProjects\netbeans\nbbuild\netbeans\platform\core\org-openide-filesystems-compat8.jar;D:\Libraries\Documents\NetBeansProjects\netbeans\nbbuild\netbeans\platform\core\org-openide-filesystems.jar;D:\Libraries\Documents\NetBeansProjects\netbeans\nbbuild\netbeans\nb\core\org-netbeans-upgrader.jar;D:\Libraries\Documents\NetBeansProjects\netbeans\nbbuild\netbeans\nb\core\locale\core_nb.jar - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [NETBEANS-3346] Upgrade asm to 5.2+
On Wed, 6 Nov 2019 at 00:42, Jose Ch wrote: > I tried to upgrade the asm-all-5.0.1 library to the latest version 7.2 and > received a nullPointerException (line 774 of asm-52 & asm-72 files). I > already successfully upgrade it to version 5.1 > (https://issues.apache.org/jira/browse/NETBEANS-3341). I tried to reproduce this but couldn't; I took the current NB source and pulled the asm72 branch of your fork. When I started up the IDE in debug mode I didn't get any null pointer exceptions and in the log I saw something different from your asm-72.log file at the point you mentioned (line 752 in your log). You had > INFO [org.netbeans.core.startup.Asm]: patch(128) AnnotationNode > an.values: [delegateParams, [1, 2, 3]] I got > INFO [org.netbeans.core.startup.Asm]: patch(128) AnnotationNode > an.values: [delegateParams, [I@2fac9730] Have you any more info on how to reproduce? Peter - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Blocker Maven issue just opened?
On Sat, 19 Oct 2019 at 11:32, Neil C Smith wrote: > Searching that system property surprised to see it's quite old - > https://blogs.oracle.com/thejavatutorials/jdk-7u25:-solutions-to-issues-caused-by-changes-to-runtimeexec > > I've opened a linked issue for 11.3 to track fixing it properly > https://issues.apache.org/jira/browse/NETBEANS-3254 I have had a bit of a play with this and might have made some progress. However, in the NB source there are at comments relating to fixing at least 6 different bugs going back a decade so it's obviously a bit of a hairy patch of code. In the linked article above it gives the 'Golden Rule' as creating a process builder with the first 2 string args being "cmd" and "/c", then folding the actual thing you want to call into the third argument, taking care to quote it properly. But it seems to me that with changes to the JDK's command line argument validation it is impossible to tiptoe around the tighter checks with this technique, and furthermore a better approach is to keep all the parts of the arguments separated out, and let Java take care of the escaping. More like you'd do on Linux, in fact. I've had a go at implementing this here: https://github.com/pedro-w/netbeans/tree/NETBEANS-3254 It works for me with JDK11 on Windows and Linux but I only tested simple projects. I'm not a Maven expert* and I don't know what kind of crazy parameters people will use to invoke mvn.cmd with. So, if anyone could have a go and see where they get to I would be grateful. In my branch there is also a commit which just cleans up some warnings in the code, I didn't go all-in on this (e.g. using lambdas where suggested) but I thought if we were changing the file we might as well clear up a few things. Pete .* see what I _didn't_ do there! - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: 20 years of NetBeans!
On Wed, 23 Oct 2019 at 10:49, Geertjan Wielenga wrote: > As stated on Twitter by Jaroslav Tulach: "Exactly twenty years ago Sun > announced it had acquired NetBeans." I had a copy of "Forte for Java" which I requested from Sun and they posted to me on a CD. That was where it started for me (2001-2 ish?) Thanks, all. Pete - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Instructions for getting started
On Mon, 21 Oct 2019 at 10:56, Geertjan Wielenga wrote: > > In nbbuild/netbeans/bin you’ll find the executable, and netbeans.conf in > nbbuild/netbeans/etc. Thanks Geertjan! Unfortunately I don't get the executable when I just run ant (as suggested in README.md). I get errors (https://gist.github.com/pedro-w/22ca3dabb6623d887a58a6c3db7afd7c) However, I think it is because my current JDK, on the path, was JDK 11 and it's not enough just to select JDK8 in user.build.properties, I need to put JDK8 on the path too. Now the build seems to be running OK, we'll see in an hour or so if has worked... Pete - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Instructions for getting started
Can someone point me to the current directions for getting started with Netbeans development? I've cloned the current git master but am unsure how to proceed. This is a bit embarrassing for me because I've done it in the recent past, but from memory all I had to do was 'ant tryme' to get a working IDE. When I do that now, I see the splash screen appear very briefly and that's it. I'm on Windows and JDK8 (selected the JDK in user.build.properties.) Thanks! Peter - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Blocker Maven issue just opened?
Possibly it is the change labelled "Runtime.exec and ProcessBuilder Argument Restrictions" in https://www.oracle.com/technetwork/java/javase/11all-relnotes-5013287.html#R11_0_5 In which case it's not a bug introduced by JDK and the command line for maven needs to change, I think. Pete On Fri, 18 Oct 2019 at 19:27, Geertjan Wielenga wrote: > > And here as well: > > https://netbeans.org/bugzilla/show_bug.cgi?id=228901 > > Can someone on Windows take 11.2 beta 3 and try to reproduce? > > Gj > > On Fri, Oct 18, 2019 at 8:25 PM Geertjan Wielenga > wrote: > > > Similar report: > > > > > > https://stackoverflow.com/questions/58411279/java-with-maven-wouldnt-build-cannot-run-program-cmd-malformed-argument-has/58456347#58456347 > > > > Gj > > > > On Fri, Oct 18, 2019 at 8:21 PM Geertjan Wielenga > > wrote: > > > >> https://twitter.com/lhochet/status/1185217897049841671 > >> > >> Gj > >> > >> On Fri, Oct 18, 2019 at 8:21 PM Geertjan Wielenga > >> wrote: > >> > >>> Maybe it's the same concern as posted here on Twitter: > >>> > >>> > >>> On Fri, Oct 18, 2019 at 7:10 PM Neil C Smith > >>> wrote: > >>> > Hi, > > Just looking at final tasks for triggering the NB 11.2 release vote > and noticed a new "blocker" issue just opened. Anyone, particularly > with Windows 10, want to assess? > > https://issues.apache.org/jira/projects/NETBEANS/issues/NETBEANS-3251 > > Thanks, > > Neil > > - > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > For additional commands, e-mail: dev-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
