[GitHub] incubator-netbeans issue #11: Fixes bug in FileChooserBuilderTest

2017-09-30 Thread emilianbold
Github user emilianbold commented on the issue: https://github.com/apache/incubator-netbeans/pull/11 Committed. ---

[GitHub] incubator-netbeans pull request #11: Fixes bug in FileChooserBuilderTest

2017-09-30 Thread emilianbold
Github user emilianbold closed the pull request at: https://github.com/apache/incubator-netbeans/pull/11 ---

[GitHub] incubator-netbeans pull request #19: [NETBEANS-54] Module Review openide.nod...

2017-09-30 Thread emilianbold
Github user emilianbold closed the pull request at: https://github.com/apache/incubator-netbeans/pull/19 ---

[GitHub] incubator-netbeans issue #19: [NETBEANS-54] Module Review openide.nodes

2017-09-30 Thread emilianbold
Github user emilianbold commented on the issue: https://github.com/apache/incubator-netbeans/pull/19 Committed. ---

Hello

2017-09-30 Thread William Beebe
I'm interested in following this mailing list.

Commit author rules?

2017-09-30 Thread Emilian Bold
Hello, I believe it would be best to use our full name and @apache alias when committing to the main repository. Right now I see a mix of company, personal and .local email addresses as well as complete name or just (local machine) usernames. Actually I don't care about the email address that mu

Notifications in triplicate

2017-09-30 Thread Emilian Bold
Hello, It's annoying how GitHub notifications work. So, if I get a reply on a PR I'm active in, this email gets sent by notificati...@github.com to me and incubator-netbe...@noreply.github.com g...@git.apache.org also sends the same comment in the pull request email thread on dev@ ... and final

[GitHub] incubator-netbeans pull request #25: NETBEANS-73: Autodetect id_rsa and id_d...

2017-09-30 Thread emilianbold
Github user emilianbold commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/25#discussion_r142020102 --- Diff: git/src/org/netbeans/modules/git/ui/repository/remote/RemoteRepository.java --- @@ -686,6 +686,7 @@ public SSHConnectionSettingsType

[GitHub] incubator-netbeans pull request #25: NETBEANS-73: Autodetect id_rsa and id_d...

2017-09-30 Thread lkishalmi
Github user lkishalmi commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/25#discussion_r142020017 --- Diff: git/src/org/netbeans/modules/git/ui/repository/remote/RemoteRepository.java --- @@ -686,6 +686,7 @@ public SSHConnectionSettingsType (

Re: README and Blog

2017-09-30 Thread Tushar Joshi
Done. My Roller username is "tusharjoshi" with regards Tushar

Re: README and Blog

2017-09-30 Thread Wade Chandler
On Sep 30, 2017 5:34 PM, "Geertjan Wielenga" < geertjan.wiele...@googlemail.com> wrote: Login there, i.e., create a user and password, tell me what your user name is and I can give you permission access to https://blogs.apache.org/netbeans Done. My Roller user name is "wadechandler". By the way,

Re: README and Blog

2017-09-30 Thread Wade Chandler
On Sep 30, 2017 12:55 PM, "Emilian Bold" wrote: Yeah, Confluence isn't very mobile friendly. The blogware isn't Confluence. It is Apache Roller; the login page pointed it out for me. I imagine we can learn more here https://roller.apache.org and figure out how to improve the experience. Thanks

Re: License header for package-list

2017-09-30 Thread Junichi Yamamoto
Thank you for the information. I see. I'll just ignore them. Thanks, Junichi 2017-09-30 15:47 GMT+09:00 Emilian Bold : > That's a Javadoc specific file which I don't believe supports comments: > http://docs.oracle.com/javase/8/docs/technotes/tools/windows/javadoc.html#JSWOR663 > > They should be

Re: README and Blog

2017-09-30 Thread Geertjan Wielenga
And everything from blogs.apache.org/netbeans is aggregated at blogs.apache.org, so that all other Apache projects can see what's going on with Apache NetBeans (incubating). Gj On Sat, Sep 30, 2017 at 2:33 PM, Geertjan Wielenga < geertjan.wiele...@googlemail.com> wrote: > It's for everyone to ha

Re: README and Blog

2017-09-30 Thread Geertjan Wielenga
It's for everyone to have access to and blog at: https://blogs.apache.org/ Login there, i.e., create a user and password, tell me what your user name is and I can give you permission access to https://blogs.apache.org/netbeans . Then you can blog there about what you're working on in Apache NetBe

[GitHub] incubator-netbeans pull request #30: [NETBEANS-54] Module Review defaults

2017-09-30 Thread matthiasblaesing
GitHub user matthiasblaesing opened a pull request: https://github.com/apache/incubator-netbeans/pull/30 [NETBEANS-54] Module Review defaults - no external library - checked Rat report; unrecognized license headers manually changed - skimmed through the module, did

[GitHub] incubator-netbeans pull request #29: [NETBEANS-54] Module Review derby

2017-09-30 Thread matthiasblaesing
GitHub user matthiasblaesing opened a pull request: https://github.com/apache/incubator-netbeans/pull/29 [NETBEANS-54] Module Review derby - external binary is binary form of etc/sample.sql (not on maven) - checked Rat report; missing header added to etc/sample.sql, ignored

[Code review] Go to File - folder search

2017-09-30 Thread Emilian Bold
Hello, I'm trying to add to Navigate | Go to File... the options of also searching the file path, not just the file name. This is useful when you know the package and part of the name or when you have the same file in multiple packages and want to quickly filter somehow. There's also an issue ab

Re: [GitHub] incubator-netbeans issue #21: Fixing form files license headers

2017-09-30 Thread Geertjan Wielenga
Everyone agrees form files need licenses, please merge this. Gj On Sat, 30 Sep 2017 at 11:27, jlahoda wrote: > Github user jlahoda commented on the issue: > > https://github.com/apache/incubator-netbeans/pull/21 > > The only blocker I see is that I am not sure how the discussion on dev

[GitHub] incubator-netbeans issue #21: Fixing form files license headers

2017-09-30 Thread jlahoda
Github user jlahoda commented on the issue: https://github.com/apache/incubator-netbeans/pull/21 The only blocker I see is that I am not sure how the discussion on dev on this patch ended up. Otherwise, as far as I can tell, this can be merged. ---

Re: README and Blog

2017-09-30 Thread Emilian Bold
Yeah, Confluence isn't very mobile friendly. What is https://blogs.apache.org/netbeans/ ? Just an aggregator? How do you post there? --emi Pe 30 sept. 2017, la 19:11, Wade Chandler a scris: > On Sep 29, 2017 05:31, "Geertjan Wielenga" > wrote: > > OK, requested a new blog and ...snip > >

Re: README and Blog

2017-09-30 Thread Wade Chandler
On Sep 29, 2017 05:31, "Geertjan Wielenga" wrote: OK, requested a new blog and ...snip The worst part about the Apache blogs IMO is the lack of mobile support when trying to view them on a phone. Undoubtedly the posts will be linked by Twitter and other mobile platforms, and thus, how can we ge

[GitHub] incubator-netbeans issue #15: [NETBEANS-54] Module Review uihandler

2017-09-30 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/15 Merged - thank you! ---

[GitHub] incubator-netbeans pull request #15: [NETBEANS-54] Module Review uihandler

2017-09-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/15 ---

[GitHub] incubator-netbeans issue #15: [NETBEANS-54] Module Review uihandler

2017-09-30 Thread ebarboni
Github user ebarboni commented on the issue: https://github.com/apache/incubator-netbeans/pull/15 Done ---

[GitHub] incubator-netbeans issue #15: [NETBEANS-54] Module Review uihandler

2017-09-30 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/15 @ebarboni thank you, that looks much cleaner. I have one last point: The commit message should reference the tracking bug. You had that in the PR, but that message does not get me

[GitHub] incubator-netbeans issue #15: [NETBEANS-54] Module Review uihandler

2017-09-30 Thread ebarboni
Github user ebarboni commented on the issue: https://github.com/apache/incubator-netbeans/pull/15 @matthiasblaesing thanks a lot for pointer on rebase. Hope its better now. ---

[GitHub] incubator-netbeans pull request #23: [NETBEANS-54] Module Review db.sql.edit...

2017-09-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/23 ---

[GitHub] incubator-netbeans issue #24: [NETBEANS-54] Module Review db.sql.visualedito...

2017-09-30 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/24 When that central decision is made, there is already at least one file that has this change already `db/external/binaries-list`. In any case the header is not wrong. The file is p

[GitHub] incubator-netbeans pull request #23: [NETBEANS-54] Module Review db.sql.edit...

2017-09-30 Thread matthiasblaesing
Github user matthiasblaesing commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/23#discussion_r142003802 --- Diff: db.sql.editor/test/unit/src/org/netbeans/modules/db/sql/editor/completion/SelectCompletionQueryTest.java --- @@ -125,11 +125,1

[GitHub] incubator-netbeans issue #24: [NETBEANS-54] Module Review db.sql.visualedito...

2017-09-30 Thread emilianbold
Github user emilianbold commented on the issue: https://github.com/apache/incubator-netbeans/pull/24 ... unless the central decision will be not to use headers and then your file becomes the only one that has to be manually tweaked back. ---

[GitHub] incubator-netbeans pull request #23: [NETBEANS-54] Module Review db.sql.edit...

2017-09-30 Thread emilianbold
Github user emilianbold commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/23#discussion_r142003704 --- Diff: db.sql.editor/test/unit/src/org/netbeans/modules/db/sql/editor/completion/SelectCompletionQueryTest.java --- @@ -125,11 +125,11 @@

[Code review] Native notifications

2017-09-30 Thread Emilian Bold
Hello, I'm trying to push parts of nbnotify.com into NetBeans proper. The most basic feature would be to show NetBeans notifications via the SystemTray, if available. This will mean native notifications on Windows and some Linux configurations. Here is the branch I'm working on https://github.c

[GitHub] incubator-netbeans issue #28: [NETBEANS-54] Module Review bugtracking

2017-09-30 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/28 Looks good. (there are now two positive reviews on this, as @emilianbold reacted with a thumbs up, which is not converted into a information message) ---

[GitHub] incubator-netbeans issue #26: [NETBEANS-54] Module Review api.debugger

2017-09-30 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/26 Looks good. (there are now two positive reviews on this, as @emilianbold reacted with a thumbs up, which is not converted into a information message) ---

[GitHub] incubator-netbeans issue #27: [NETBEANS-54] Module Review api.xml.ui

2017-09-30 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/27 Looks good. ---

[GitHub] incubator-netbeans issue #15: [NETBEANS-54] Module Review uihandler

2017-09-30 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/15 @ebarboni There are two thinks I'd like to ask you: - Adjust your git settings to include a name and update the existing commits (see here: https://www.git-tower.com/lear

[GitHub] incubator-netbeans issue #12: properties for by module report

2017-09-30 Thread ebarboni
Github user ebarboni commented on the issue: https://github.com/apache/incubator-netbeans/pull/12 I'm enhancing my skill on rebase :p, hope its ok now ---

[GitHub] incubator-netbeans pull request #16: [NETBEANS-54] Module Review db.dataview

2017-09-30 Thread matthiasblaesing
Github user matthiasblaesing commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/16#discussion_r142002680 --- Diff: db.dataview/test/unit/src/org/netbeans/modules/db/dataview/util/TestCaseDataFactory.java --- @@ -39,11 +39,11 @@ publ

[GitHub] incubator-netbeans issue #23: [NETBEANS-54] Module Review db.sql.editor

2017-09-30 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/23 Thanks for looking into this. I let the changed for loop in place and updated the usage of `getResource().openStream()` to `getResourceAsStream`. ---

[GitHub] incubator-netbeans pull request #23: [NETBEANS-54] Module Review db.sql.edit...

2017-09-30 Thread matthiasblaesing
Github user matthiasblaesing commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/23#discussion_r142002449 --- Diff: db.sql.editor/test/unit/src/org/netbeans/modules/db/sql/editor/completion/SelectCompletionQueryTest.java --- @@ -125,11 +125,1

[GitHub] incubator-netbeans issue #24: [NETBEANS-54] Module Review db.sql.visualedito...

2017-09-30 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/24 I had to touch binaries-list to change it to maven coordinates - so adding the license header was a natural reaction. From my POV there is no gain by removing that header again -