[GitHub] borxa opened a new pull request #235: [NETBEANS-54] Module Review html.editor

borxa opened a new pull request #235: [NETBEANS-54] Module Review html.editor URL: https://github.com/apache/incubator-netbeans/pull/235 Files to be solved centrally: html.editor/src/org/netbeans/modules/html/editor/options/ui/formatSample.html

[GitHub] geertjanw commented on issue #227: [NETBEANS-54] adding license headers to various files in nbbuild

geertjanw commented on issue #227: [NETBEANS-54] adding license headers to various files in nbbuild URL: https://github.com/apache/incubator-netbeans/pull/227#issuecomment-341853553 Thanks a lot for the review! This is an

[GitHub] geertjanw commented on issue #234: [NETBEANS-68] Remove SwingX dependency

geertjanw commented on issue #234: [NETBEANS-68] Remove SwingX dependency URL: https://github.com/apache/incubator-netbeans/pull/234#issuecomment-341844411 Wow, nice job. Will review each file and comment more ASAP. This is

[GitHub] geertjanw commented on issue #221: [NETBEANS-54] adding license headers to uml files in openide.windows

geertjanw commented on issue #221: [NETBEANS-54] adding license headers to uml files in openide.windows URL: https://github.com/apache/incubator-netbeans/pull/221#issuecomment-341843893 Thanks for the review! Merging now.

[GitHub] geertjanw closed pull request #221: [NETBEANS-54] adding license headers to uml files in openide.windows

geertjanw closed pull request #221: [NETBEANS-54] adding license headers to uml files in openide.windows URL: https://github.com/apache/incubator-netbeans/pull/221 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] geertjanw closed pull request #226: [NETBEANS-54] adding license headers to UML files in openide.options

geertjanw closed pull request #226: [NETBEANS-54] adding license headers to UML files in openide.options URL: https://github.com/apache/incubator-netbeans/pull/226 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] geertjanw commented on issue #226: [NETBEANS-54] adding license headers to UML files in openide.options

geertjanw commented on issue #226: [NETBEANS-54] adding license headers to UML files in openide.options URL: https://github.com/apache/incubator-netbeans/pull/226#issuecomment-341843803 Thanks for the review! Merging. This

[GitHub] matthiasblaesing closed pull request #233: [NETBEANS-54] Module Review o.eclipse.core.runtime

matthiasblaesing closed pull request #233: [NETBEANS-54] Module Review o.eclipse.core.runtime URL: https://github.com/apache/incubator-netbeans/pull/233 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] matthiasblaesing opened a new pull request #234: [NETBEANS-68] Remove SwingX dependency

matthiasblaesing opened a new pull request #234: [NETBEANS-68] Remove SwingX dependency URL: https://github.com/apache/incubator-netbeans/pull/234 This PR removes the dependency on SwingX. It is not a complete replacement, as the primary component (the DatePicker) was not replaced,

[GitHub] geertjanw commented on issue #218: [NETBEANS-54] Module Review xml.jaxb

geertjanw commented on issue #218: [NETBEANS-54] Module Review xml.jaxb URL: https://github.com/apache/incubator-netbeans/pull/218#issuecomment-341673939 Thanks a lot for the review, makes sense, will do. This is an

Re: CTR vs RTC (was: Current Status & Proposed Plan for Apache NetBeans)

Well, they're often not as trivial as they seem -- sometimes these license changes have impacts that are not foreseen by whoever makes the change. Gj On Fri, Nov 3, 2017 at 10:07 AM, Bertrand Delacretaz wrote: > On Fri, Nov 3, 2017 at 9:45 AM, Geertjan Wielenga >

Re: CTR vs RTC (was: Current Status & Proposed Plan for Apache NetBeans)

On Fri, Nov 3, 2017 at 9:45 AM, Geertjan Wielenga wrote: > ...Not really a decision, just it feels safer to me personally to have someone > looking at them before I merge them Understood. I just wanted to make sure you guys are not going to RTC everything

Re: CTR vs RTC (was: Current Status & Proposed Plan for Apache NetBeans)

Not really a decision, just it feels safer to me personally to have someone looking at them before I merge them. But, sure, if there's another way, that's fine too. Thanks as always Bertrand for your insights and guidance. :-) Gj On Fri, Nov 3, 2017 at 9:35 AM, Bertrand Delacretaz

CTR vs RTC (was: Current Status & Proposed Plan for Apache NetBeans)

Hi, On Fri, Nov 3, 2017 at 1:11 AM, Geertjan Wielenga wrote: > ...Several more pull requests now -- people are needed to review them... I'm curious why you want reviews as opposed to just merging those yourself. I see mostly trivial changes at

[GitHub] geertjanw closed pull request #230: [NETBEANS-54] Module Review ide

geertjanw closed pull request #230: [NETBEANS-54] Module Review ide URL: https://github.com/apache/incubator-netbeans/pull/230 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] geertjanw closed pull request #219: [NETBEANS-54] Module Review websvc.saas.codegen.java

geertjanw closed pull request #219: [NETBEANS-54] Module Review websvc.saas.codegen.java URL: https://github.com/apache/incubator-netbeans/pull/219 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] geertjanw closed pull request #223: [NETBEANS-54] Module Review libs.nbi.ant

geertjanw closed pull request #223: [NETBEANS-54] Module Review libs.nbi.ant URL: https://github.com/apache/incubator-netbeans/pull/223 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] geertjanw closed pull request #229: [NETBEANS-54] Module Review spi.navigator & spi.palette

geertjanw closed pull request #229: [NETBEANS-54] Module Review spi.navigator & spi.palette URL: https://github.com/apache/incubator-netbeans/pull/229 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] geertjanw closed pull request #231: [NETBEANS-54] Module Review jemmy

geertjanw closed pull request #231: [NETBEANS-54] Module Review jemmy URL: https://github.com/apache/incubator-netbeans/pull/231 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] geertjanw closed pull request #222: [NETBEANS-54] Module Review javahelp

geertjanw closed pull request #222: [NETBEANS-54] Module Review javahelp URL: https://github.com/apache/incubator-netbeans/pull/222 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a