[GitHub] incubator-netbeans issue #25: NETBEANS-73: Autodetect id_rsa and id_dsa keys...

[lkishalmi]

Github user lkishalmi commented on the issue:

https://github.com/apache/incubator-netbeans/pull/25
  
I've made a small change to do the detection only when the key auth is 
selected.


---

[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...

[jlahoda]

Github user jlahoda commented on the issue:

https://github.com/apache/incubator-netbeans/pull/33
  
I am no opposed to excluding binaries-list, but I'd add:
-remove existing license headers from binaries-list
-explain the decision at release time if needed

So, are you willing to work on this central problem and resolve it?

Thanks.


---

[GitHub] incubator-netbeans issue #41: [NETBEANS-54] Module Review c.google.guava

[junichi11]

Github user junichi11 commented on the issue:

https://github.com/apache/incubator-netbeans/pull/41
  
@matthiasblaesing Thanks for looking at it :) Fixed. I hope that my 
understanding is correct.


---

[GitHub] incubator-netbeans issue #41: [NETBEANS-54] Module Review c.google.guava

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/41
  
This is nitpicking but as the target is cleanup I hope you understand:
- the license file should match the binary `.zip` should be 
accompanied by `-icense.txt` in this case `guava-15.0-license.jar`
- in the license file the version should be corrected to `15.0`
Thanks :-)


---

[GitHub] incubator-netbeans issue #40: [NETBEANS-54] Module Review c.googlecode.javae...

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/40
  
Looks good.


---

[GitHub] incubator-netbeans issue #22: [NETBEANS-54] Module Review db.mysql

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/22
  
Merged with 1 positive review. Thanks for having a look.


---

[GitHub] incubator-netbeans pull request #22: [NETBEANS-54] Module Review db.mysql

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/22


---

[GitHub] incubator-netbeans pull request #30: [NETBEANS-54] Module Review defaults

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/30


---

[GitHub] incubator-netbeans issue #30: [NETBEANS-54] Module Review defaults

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/30
  
Merged into master with 1 positive review. Thank you for reviewing.


---

[GitHub] incubator-netbeans issue #20: [NETBEANS-54] Module Review db.drivers

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/20
  
Merged with one positive review - thanks for reviewing.


---

[GitHub] incubator-netbeans pull request #20: [NETBEANS-54] Module Review db.drivers

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/20


---

[GitHub] incubator-netbeans issue #38: [NETBEANS-54] Module Review editor.lib2

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/38
  
Merged with 2 positive reviews.


---

[GitHub] incubator-netbeans issue #37: [NETBEANS-54] Module Review editor.lib

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/37
  
Merged with 3 positive reviews - Thank you.


---

[GitHub] incubator-netbeans pull request #37: [NETBEANS-54] Module Review editor.lib

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/37


---

[GitHub] incubator-netbeans pull request #38: [NETBEANS-54] Module Review editor.lib2

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/38


---

[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...

[emilianbold]

Github user emilianbold commented on the issue:

https://github.com/apache/incubator-netbeans/pull/33
  
I don't believe there is much IP value in the binaries-list files and I 
would not add that huge license header in all of them when they generally have 
1-2 lines. The overall project license applies to all the files regardless.

So my solution would be not to add the license header to the binaries-list 
files and just add a RAT exclusion filter.


---

[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...

[jlahoda]

Github user jlahoda commented on the issue:

https://github.com/apache/incubator-netbeans/pull/33
  
Well, I think it would be good to decide if we (really) want to solve the 
binaries-list issue centrally, and if yes solve it. Are you willing to resolve 
that?


---

Re: Wiki page on how to submit PR

[Neil C Smith]

Hi,

On Mon, 2 Oct 2017, 15:16 Eric Barboni,  wrote:

>
>   I started a new page [1] to help people making PR. I'm novice in git and
> nice workflow with GitHub.
>

This is a good start. From experience if this is particularly aimed at
people unused to GitHub, you may want to be more explicit that a reason for
using branches is that the PR is not fixed at the point you create it -
further commits to that branch affects the PR. This seems to confuse people
who've not done it before. I've had a few PR on projects that acquired some
unintended additions!

Best wishes,

Neil

> --
Neil C Smith
Artist & Technologist
www.neilcsmith.net

Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org

goldenfiles (was Re: Testing modules after review & licenses in test files?)

[Antonio]

On 02/10/17 19:59, Matthias Bläsing wrote:

Am Montag, den 02.10.2017, 19:33 +0200 schrieb Antonio Vieiro:

Are you sure the added header causes the test to fail? From the look of
the file I doubt that. If it is indeed the header that causes the


The licenses in headers have nothing to do with unit test failures.

Some golden files have also been modified with a new license ([1]) and 
may cause qa-test failures (this is the editor module, after all,  and 
may use text-specific positions for tests).


I think running qa-tests requires a special setup, right? So I cannot 
qa-test the module. I'll mark it as "needs further testing" after the 
review, or should I add an issue for these failing tests?


Thanks,
Antonio

[1] 
https://github.com/apache/incubator-netbeans/blob/master/editor/test/qa-functional/data/goldenfiles/org/netbeans/test/editor/general/GeneralTypingTest/testJavaEnterBeginAndEnd.pass

Re: Testing modules after review & licenses in test files?

[Jan Lahoda]

On Mon, Oct 2, 2017 at 8:11 PM, Emilian Bold  wrote:

> AnnotationsTest and AnnotationLoadingTest are not failing on my machine.
>
> But PlainDocumentCompatibilityRandomTest.test and
> NbEditorToolBarTest.testActionContextLookupContainsNodeOnlyOnce *do* fail
> on my machine.
>

I see those two failing as well.

I think it is good to run tests with the
-Dtest-unit-sys-prop.ignore.random.failures=true flag (this will/should
ignore tests marked with @RandomlyFails):
ant -Dtest-unit-sys-prop.ignore.random.failures=true test

Overall, I don't think it is a good idea to revert changes to licence
headers because of failing tests - better fix (or ignore/disable) the test.
(In some cases, it might be OK to remove the header altogether, but putting
the old one back does not sound correct.)

Jan


>
> --emi
>
> On Mon, Oct 2, 2017 at 8:58 PM, Antonio Vieiro  wrote:
>
> > I restored the xml test file to the Oracle headers but the tests keep
> > on failing.
> >
> > So the Apache license headers are not the reason of the failure. I'll
> > keep those and keep going.
> >
> > TIA
> > Antonio
> >
>

Re: Wiki page on how to submit PR

[Matthias Bläsing]

Hi Emilian,

Am Montag, den 02.10.2017, 16:36 +0300 schrieb Emilian Bold:
> Most important, before a master commit:
> 
> git checkout feature
> git checkout -b temporary-branch
> git rebase -i master
> # [Clean up the history]
> git checkout master
> git merge temporary-branch

why do you insist on an rebase on master? Ok that allows fast-forward
merges, but apart from that I don't see the benefit.

I never worked with signed PRs, but as rebasing changes history, I
don't see this working together.

The netbeans code base is highly modular, so merge conflicts are not
that likely to occur, so even less need for rebases.

Greetings


Matthias

Re: Editing permissions for making changes to the Wiki.

[Borxa Varela Bouzas]

Hi,

I need permissions too. My confluence id is “borxa”

Thanks

> El 2 oct 2017, a las 12:33, Geertjan Wielenga 
>  escribió:
> 
> Done!
> 
> Gj
> 
> On Monday, October 2, 2017, Antonio Vieiro  wrote:
> 
>> Hi,
>> 
>> Would someone please add my confluence id " vieiro " to the list of
>> people allowed to make changes to the list of modules to review at
>> [1]?
>> 
>> Thanks,
>> Antonio
>> 
>> [1] https://cwiki.apache.org/confluence/display/NETBEANS/
>> List+of+Modules+to+Review
>> 

[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...

[emilianbold]

Github user emilianbold commented on the issue:

https://github.com/apache/incubator-netbeans/pull/33
  
The way I understood it, I will absolutely not touch "Problems to be solved 
centrally" because they will be dealt with entirely at some future moment.

Only reason I would care about those is if I see an Oracle copyright 
header. Not if they have none.

> So I was adding the headers to binaries-lists I was modifying, as that 
should not be wrong either way.

It kinda makes sense since you also modified the file, although not 
substantially (it's still the same dependency) but I would have kept it without 
a header because it's trivial to add them "centrally" afterwards.


---

[GitHub] incubator-netbeans issue #39: [NETBEANS-54] Module Review bugzilla

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/39
  
The change looks good.


---

[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/33
  
My take: If a file needs to be edited, there is no draw back in adding the 
license header also. There is already a mixed set (files with and without 
license header), so the problem would be already there.


---

Re: Testing modules after review & licenses in test files?

[Antonio Vieiro]

I restored the xml test file to the Oracle headers but the tests keep
on failing.

So the Apache license headers are not the reason of the failure. I'll
keep those and keep going.

TIA
Antonio

[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...

[jlahoda]

Github user jlahoda commented on the issue:

https://github.com/apache/incubator-netbeans/pull/33
  
Regarding binaries-list, yes it is listed in the central problems (although 
all that means is that some of us will need to propose and implement a 
solution). Including the header for a single line (typically) file may be 
somewhat silly, but I am not sure if not adding the header is worth the 
discussion that will arise (given that, unlike in e.g. manifests, there is 
basically no issue with the header). Some of these files also already have a 
license header. So I was adding the headers to binaries-lists I was modifying, 
as that should not be wrong either way.


---

Re: Testing modules after review & licenses in test files?

[Emilian Bold]

http://www.apache.org/legal/src-headers.html#faq-exceptions

Other files may make sense to have no license header. Three examples are:
>


Test data for which the addition of a source header would cause the tests
> to fail.



--emi

On Mon, Oct 2, 2017 at 8:33 PM, Antonio Vieiro  wrote:

> Hi all,
>
> A license header has already been included in an xml test file at [1]
> (ide cluster, editor module). If I run tests on this module (cd
> editor; ant test) the tests fail.
>
> My questions:
>
> a) Should I remove the license header from the test file?
> b) If so, the test file would have an Oracle license (see [2]). Is this OK?
> b) Is "(cd editor; ant test)" the proper way to test a module?
>
> Thanks in advance and apologies for so many questions,
> Antonio
>
> [1] https://github.com/apache/incubator-netbeans/blob/
> master/editor/test/unit/src/org/netbeans/modules/editor/
> resources/annotations-test-layer.xml
> [2] https://github.com/apache/incubator-netbeans/commit/
> 6daa72c9819847bb4f71ee6aba6d30d5ffaca41a#diff-
> 4af1caa76a12a7dce3d32c9063306622
>

[GitHub] incubator-netbeans issue #31: [NETBEANS-54] Module Review j2ee.core.utilitie...

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/31
  
@juneau001 please rereview this changeset - now your PR would remove 
headers from .form files. While your at it: rebase your changes onto the 
current HEAD of master and squash the changes together.


---

Testing modules after review & licenses in test files?

[Antonio Vieiro]

Hi all,

A license header has already been included in an xml test file at [1]
(ide cluster, editor module). If I run tests on this module (cd
editor; ant test) the tests fail.

My questions:

a) Should I remove the license header from the test file?
b) If so, the test file would have an Oracle license (see [2]). Is this OK?
b) Is "(cd editor; ant test)" the proper way to test a module?

Thanks in advance and apologies for so many questions,
Antonio

[1] 
https://github.com/apache/incubator-netbeans/blob/master/editor/test/unit/src/org/netbeans/modules/editor/resources/annotations-test-layer.xml
[2] 
https://github.com/apache/incubator-netbeans/commit/6daa72c9819847bb4f71ee6aba6d30d5ffaca41a#diff-4af1caa76a12a7dce3d32c9063306622

[GitHub] incubator-netbeans issue #12: properties for by module report

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/12
  
This change introduces a problem: exclude patterns can't be defined per 
module anymore. @jlahoda introduced the fist such set 
`form/test/unit/data/goldenfiles/*` and I'll need to do the same for `diff` 
module, where the test data needs to be excluded. With this change, the exclude 
won't work. 


---

Re: Licenses for user facing files & readmes?

[Emilian Bold]

> - User facing files (plain text template files such as [1] or [2], for
example) don't require a license, right?

Correct.

> - README files [3] do require a license

I would say no, see
http://www.apache.org/legal/src-headers.html#faq-exceptions although
that README is long.

So perhaps the project demosrc does need some license info/file somewhere?

BTW, does demosrc/ even work nowadays? I know it wasn't as easy to
keep the editor standalone like it was in the 6.5 days or so.


--emi


On Mon, Oct 2, 2017 at 7:58 PM, Antonio Vieiro  wrote:
> Hi all,
>
> Sorry if this has been already answered, but I need some confirmation here:
>
> - User facing files (plain text template files such as [1] or [2], for
> example) don't require a license, right?
> - README files [3] do require a license
>
> Thanks in advance,
> Antonio
>
>
> [1] 
> https://github.com/apache/incubator-netbeans/blob/master/editor/demosrc/base/org/netbeans/editor/example/res/template.html_
> [2] 
> https://github.com/apache/incubator-netbeans/blob/master/editor.plain/src/org/netbeans/modules/editor/plain/resources/PlainTextExample
>
>
> [3] 
> https://github.com/apache/incubator-netbeans/blob/master/editor/demosrc/README

Licenses for user facing files & readmes?

[Antonio Vieiro]

Hi all,

Sorry if this has been already answered, but I need some confirmation here:

- User facing files (plain text template files such as [1] or [2], for
example) don't require a license, right?
- README files [3] do require a license

Thanks in advance,
Antonio


[1] 
https://github.com/apache/incubator-netbeans/blob/master/editor/demosrc/base/org/netbeans/editor/example/res/template.html_
[2] 
https://github.com/apache/incubator-netbeans/blob/master/editor.plain/src/org/netbeans/modules/editor/plain/resources/PlainTextExample


[3] 
https://github.com/apache/incubator-netbeans/blob/master/editor/demosrc/README

[GitHub] incubator-netbeans issue #35: -external library Apache felix. Changed coordi...

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/35
  
Looks good - comment from #33 about the commit message applies here as 
well. 


---

[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...

[emilianbold]

Github user emilianbold commented on the issue:

https://github.com/apache/incubator-netbeans/pull/33
  
So, are we adding license to binaries-list? Isn't is part of the "Problems 
to be solved centrally"?


---

[GitHub] incubator-netbeans issue #34: -external library jna-4.2.2.jar: dual-licensed...

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/34
  
Looks good, I'd adjust the commit message though to contain something like 
"[NETBEANS-54] Module review libs.jna". The first line ise used as summary of 
the commit and now this looks a bit strange. (Same applies to  #33 and #35).


---

[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/33
  
Looks good.


---

Re: Wiki page on how to submit PR

[Emilian Bold]

Lots of useful info here
https://www.atlassian.com/git/tutorials/merging-vs-rebasing

Most important, before a master commit:

git checkout feature
git checkout -b temporary-branch
git rebase -i master
# [Clean up the history]
git checkout master
git merge temporary-branch


--emi


On Mon, Oct 2, 2017 at 4:16 PM, Eric Barboni  wrote:
> Hi,
>
>   I started a new page [1] to help people making PR. I'm novice in git and
> nice workflow with GitHub.
>
>
>
>   Changing name and mail seems to be important but as git by default allow
> committing with local name you may lose a bit of time (:D) .
>
> Many thanks to Matthias and Emilian
>
>  Regards
>
> -Eric
>
>
>
> [1]
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74681408
>

Wiki page on how to submit PR

[Eric Barboni]

Hi, 

  I started a new page [1] to help people making PR. I'm novice in git and
nice workflow with GitHub.

  

  Changing name and mail seems to be important but as git by default allow
committing with local name you may lose a bit of time (:D) .

Many thanks to Matthias and Emilian

 Regards

-Eric

 

[1]
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74681408

Re: Hello

[Geertjan Wielenga]

Hi William,

This is how to participate in Apache NetBeans:
https://cwiki.apache.org/confluence/display/NETBEANS/How+to+Participate

This is the current task we're working on, welcome to get involved:
https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review

Thanks,

Geertjan

On Sun, Oct 1, 2017 at 5:13 PM, Craig Russell  wrote:

> Hi,
>
> You might find this of value: https://netbeans.org/
> community/lists/index.html
>
> Regards,
>
> Craig
>
> > On Sep 30, 2017, at 5:45 PM, William Beebe  wrote:
> >
> > I'm interested in following this mailing list.
>
> Craig L Russell
> c...@apache.org
>
>

[GitHub] incubator-netbeans pull request #39: [NETBEANS-54] Module Review bugzilla

[junichi11]

GitHub user junichi11 opened a pull request:

https://github.com/apache/incubator-netbeans/pull/39

[NETBEANS-54] Module Review bugzilla

- no external library
- checked Rat report: update the license header in BugzillaRepository.java
- skimmed through the module, did not notice additional problems

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/junichi11/incubator-netbeans 
module-review-bugzilla

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/39.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #39


commit 036bda8db4785d873531e7dcfde14b2f80e3d1e9
Author: Junichi Yamamoto 
Date:   2017-10-02T04:44:14Z

[NETBEANS-54] Module Review bugzilla

- no external library
- checked Rat report: update the license header in BugzillaRepository.java
- skimmed through the module, did not notice additional problems




---

[GitHub] incubator-netbeans pull request #38: [NETBEANS-54] Module Review editor.lib2

[vieiro]

GitHub user vieiro opened a pull request:

https://github.com/apache/incubator-netbeans/pull/38

[NETBEANS-54] Module Review editor.lib2

- No external libraries.
- checked Rat report: modified license header in 
src/org/netbeans/api/editor/caret/package.html
- skimmed through the module, did not notice additional problems

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vieiro/incubator-netbeans 
netbeans-54-module-review-editor.lib2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/38.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #38


commit cb443c2efbbd41df528c4166f0b0a629d899cec5
Author: Antonio Vieiro 
Date:   2017-10-02T10:46:40Z

[NETBEANS-54] Module Review editor.lib2

- No external libraries.
- checked Rat report: modified license header in 
src/org/netbeans/api/editor/caret/package.html
- skimmed through the module, did not notice additional problems




---

[GitHub] incubator-netbeans pull request #37: [NETBEANS-54] Module Review editor.lib

[vieiro]

GitHub user vieiro opened a pull request:

https://github.com/apache/incubator-netbeans/pull/37

[NETBEANS-54] Module Review editor.lib

- no external libraries
- checked Rat report: modified license header in 
src/org/netbeans/editor/BaseKit.java
- skimmed through the module, did not notice additional problems

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vieiro/incubator-netbeans 
netbeans-54-module-review-editor.lib

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #37


commit 2993d25f8c12ebf6e2b8ec5bdbe4a1f32e447a0c
Author: Antonio Vieiro 
Date:   2017-10-02T09:47:44Z

[NETBEANS-54] Module Review editor.lib
- no external libraries
- checked Rat report: modified license header in 
src/org/netbeans/editor/BaseKit.java




---

[GitHub] incubator-netbeans issue #12: properties for by module report

[ebarboni]

Github user ebarboni commented on the issue:

https://github.com/apache/incubator-netbeans/pull/12
  
@emilianbold  , I sorry was trying to resync but this PR is on my master 
branch so I go back to a usable state.

 



---

[GitHub] incubator-netbeans issue #12: properties for by module report

[emilianbold]

Github user emilianbold commented on the issue:

https://github.com/apache/incubator-netbeans/pull/12
  
I don't believe you are rebasing correctly. You shouldn't see something 
like:

>jlahoda committed with ebarboni 8 days ago



---

Re: Cannot update list of modules to review (ide/editor.lib, ide/editor.lib2)

[Junichi Yamamoto]

Hello,

Updated.

> I cannot update the list of modules to review

>From How to Participate[1] > Look around:
"Once you have a user account on Confluence, please send a mail to
dev@netbeans.incubator.apache.org to ask for editing permissions for
making changes to the Wiki. "

[1] https://cwiki.apache.org/confluence/display/NETBEANS/How+to+Participate

HTH,
Junichi


2017-10-02 17:02 GMT+09:00 Antonio Vieiro :
> Hi,
>
> I cannot update the list of modules to review at
>
> https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review
>
> Would anyone please be so kind as to add the following entries there?
>
> Cluster (area): ide
> Modules: editor.lib, editor.lib2
> Name: vieiro
>
> Thanks,
> Antonio
>
> P.S.: Note to self: editor.lib/src/org/netbeans/editor/BaseKit.java
> has a wrong license header.

Cannot update list of modules to review (ide/editor.lib, ide/editor.lib2)

[Antonio Vieiro]

Hi,

I cannot update the list of modules to review at

https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review

Would anyone please be so kind as to add the following entries there?

Cluster (area): ide
Modules: editor.lib, editor.lib2
Name: vieiro

Thanks,
Antonio

P.S.: Note to self: editor.lib/src/org/netbeans/editor/BaseKit.java
has a wrong license header.

Re: Introducing myself & stepping forward

[Antonio Vieiro]

Yep, these galicians are everywhere! ;-)

https://en.wikipedia.org/wiki/Galicia_(Spain)

Graciñas,
Antonio

2017-10-02 9:44 GMT+02:00 Borxa Varela Bouzas :
> Hi Antonio,
>
> Other spanish here!
>
> Saludos
>
>> El 2 oct 2017, a las 7:54, Antonio Vieiro  escribió:
>>
>> Thanks, Emilian! Thanks all!
>>
>> Un abrazo,
>> Antonio
>>
>> 2017-10-02 7:52 GMT+02:00 Emilian Bold :
>>> Welcome Antonio! You have been missed!
>>>
>>> --emi
>>>
>>>
 On Mon, Oct 2, 2017 at 7:53 AM, Antonio Vieiro  wrote:
 Great to see you all as well! :-)


> El 2 oct 2017, a las 1:17, Wade Chandler  
> escribió:
>
> Great to see you here Antonio!
>
> Wade
>
>
>> On Oct 1, 2017 2:04 PM, "Antonio Vieiro"  wrote:
>>
>> Hi all,
>>
>> This is Antonio Vieiro, an old time NetBeans enthusiast based in Madrid,
>> Spain.
>>
>> I've been keeping an eye on the NetBeans incubator process for a
>> while. It seems there's a looong list of modules to review at
>>
>> https://cwiki.apache.org/confluence/display/NETBEANS/
>> List+of+Modules+to+Review
>>
>> I was wondering if you need a hand on the review process and, if so,
>> I'd appreciate some further instructions on how I should proceed.
>>
>> Kind regards,
>> Antonio
>>
>> P.S.: Yep, I was a NetBeans Dream Team Member a few years ago.
>>

>>
>

Re: Introducing myself & stepping forward

[Borxa Varela Bouzas]

Hi Antonio,

Other spanish here!

Saludos 

> El 2 oct 2017, a las 7:54, Antonio Vieiro  escribió:
> 
> Thanks, Emilian! Thanks all!
> 
> Un abrazo,
> Antonio
> 
> 2017-10-02 7:52 GMT+02:00 Emilian Bold :
>> Welcome Antonio! You have been missed!
>> 
>> --emi
>> 
>> 
>>> On Mon, Oct 2, 2017 at 7:53 AM, Antonio Vieiro  wrote:
>>> Great to see you all as well! :-)
>>> 
>>> 
 El 2 oct 2017, a las 1:17, Wade Chandler  
 escribió:
 
 Great to see you here Antonio!
 
 Wade
 
 
> On Oct 1, 2017 2:04 PM, "Antonio Vieiro"  wrote:
> 
> Hi all,
> 
> This is Antonio Vieiro, an old time NetBeans enthusiast based in Madrid,
> Spain.
> 
> I've been keeping an eye on the NetBeans incubator process for a
> while. It seems there's a looong list of modules to review at
> 
> https://cwiki.apache.org/confluence/display/NETBEANS/
> List+of+Modules+to+Review
> 
> I was wondering if you need a hand on the review process and, if so,
> I'd appreciate some further instructions on how I should proceed.
> 
> Kind regards,
> Antonio
> 
> P.S.: Yep, I was a NetBeans Dream Team Member a few years ago.
> 
>>> 
> 

Re: Commit author rules?

[Bertrand Delacretaz]

Hi,

On Sun, Oct 1, 2017 at 9:54 AM, Matthias Bläsing
 wrote:
> ...   1. Either the change is deemed small/simple enough not to require an
>   ICLA
>2. The author needs to have an ICLA on file
>
> For the first condition I'll rely on my gut feeling, for the second an
> apache email adresse as the author is a clear indication

Note that filing an Apache iCLA does not provide one with an
@apache.org address - for that you need to be elected committer (on
any Apache project).

-Bertrand

[GitHub] incubator-netbeans issue #7: [NETBEANS-54] Module Review api.annotations.com...

[jlahoda]

Github user jlahoda commented on the issue:

https://github.com/apache/incubator-netbeans/pull/7
  
Description of the current -license.txt processing is here:
http://wiki.netbeans.org/DevFaqExternalLibraries

I think details under Apache are still somewhat unclear, but I think 
maintaining -license.txt and -notice.txt (if needed) in the library wrapper 
near the external library is much more maintainable than trying to have a 
central registry, and that whatever we do will be based on the current 
design/state. So, I think it would be good to have things prepared for 
automatic processing as much as possible.

Thanks.


---