[GitHub] incubator-netbeans issue #131: [NETBEANS-54] Module Review lib.terminalemula...

Github user vieiro commented on the issue: https://github.com/apache/incubator-netbeans/pull/131 Should be ready now. ---

[GitHub] incubator-netbeans issue #117: [NETBEANS-54] Modeule Review j2ee.persistence

Github user junichi11 commented on the issue: https://github.com/apache/incubator-netbeans/pull/117 @matthiasblaesing What should we do about the external binary (https://github.com/apache/incubator-netbeans/tree/master/j2ee.persistence/external)? ---

[GitHub] incubator-netbeans pull request #117: [NETBEANS-54] Modeule Review j2ee.pers...

Github user junichi11 commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/117#discussion_r144731244 --- Diff: j2ee.persistence/test/unit/data/invalid_persistence.xml --- @@ -1,8 +1,27 @@ -http://www.apache.org/licenses/LICENSE-2.0

[GitHub] incubator-netbeans pull request #135: [NETBEANS-54] Module Review dlight.nat...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/135 ---

[GitHub] incubator-netbeans pull request #125: [NETBEANS-54] Module Review javafx2.ed...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/125 ---

[GitHub] incubator-netbeans pull request #151: [NETBEANS-54] Module Review o.eclipse....

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/151 ---

[GitHub] incubator-netbeans pull request #138: [NETBEANS-54] Module Review extexecuti...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/138 ---

[GitHub] incubator-netbeans pull request #123: [NETBEANS-54] Module Review hudson.sub...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/123 ---

[GitHub] incubator-netbeans pull request #115: [NETBEANS-54] Module Review libs.jvyam...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/115 ---

[GitHub] incubator-netbeans pull request #124: [NETBEANS-54] Module Review o.apache.t...

Github user matthiasblaesing commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/124#discussion_r144725205 --- Diff: o.apache.tools.ant.module/src/org/apache/tools/ant/module/resources/Project.xml_ --- @@ -1,4 +1,22 @@

[GitHub] incubator-netbeans pull request #149: [NETBEANS-54] Module Review o.apache.x...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/149 ---

[GitHub] incubator-netbeans issue #150: [NETBEANS-54] Module Review o.eclipse.core.co...

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/150 I squashed the changes together. The binaries differ in the sigining information: https://try.diffoscope.org/verbgtdavxyv.html ---

[GitHub] incubator-netbeans pull request #7: [NETBEANS-54] Module Review api.annotati...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/7 ---

[GitHub] incubator-netbeans issue #7: [NETBEANS-54] Module Review api.annotations.com...

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/7 Merged - thank you! ---

[GitHub] incubator-netbeans pull request #104: [NETBEANS-54] Module Review libs.osgi

Github user matthiasblaesing commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/104#discussion_r144722875 --- Diff: libs.osgi/external/binaries-list --- @@ -14,5 +14,5 @@ # KIND, either express or implied. See the License for the #

Re: Should we use Eclipse Maven Repository too?

> El 15 oct 2017, a las 15:50, Emilian Bold escribió: > > It's part of the Apache IP clearance. We need to know our dependencies. A > binary JAR won't do, specifically because we patch stuff too. We can't just > go through classes and add small license headers when we

[GitHub] incubator-netbeans issue #153: [NETBEANS-54] Module Review maven.osgi

Github user mclay commented on the issue: https://github.com/apache/incubator-netbeans/pull/153 https://github.com/emilianbold/incubator-netbeans/issues/145 ---

[GitHub] incubator-netbeans pull request #104: [NETBEANS-54] Module Review libs.osgi

Github user geertjanw commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/104#discussion_r144721265 --- Diff: libs.osgi/external/binaries-list --- @@ -14,5 +14,5 @@ # KIND, either express or implied. See the License for the #

[GitHub] incubator-netbeans issue #7: [NETBEANS-54] Module Review api.annotations.com...

Github user geertjanw commented on the issue: https://github.com/apache/incubator-netbeans/pull/7 Is anything more needed to be done here or can this one be merged? ---

Re: Should we use Eclipse Maven Repository too?

PS: Using Maven also helps because http://hg.netbeans.org/binaries/ will disappear in the (near) future. --emi On Sun, Oct 15, 2017 at 4:50 PM, Emilian Bold wrote: > >So, what's the point of adding maven coordinates for external binaries? > Is this some requirement of

Re: Should we use Eclipse Maven Repository too?

>So, what's the point of adding maven coordinates for external binaries? Is this some requirement of the code donation? Or is this an effort to try to achieve some kind of "repeteable build" mechanism? (I've arrived late to the party, so I surely missed the thread where this was discussed). It's

[GitHub] incubator-netbeans pull request #145: [NETBEANS-54] Module Review apisupport...

Github user geertjanw commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/145#discussion_r144720315 --- Diff: apisupport.wizards/src/org/netbeans/modules/apisupport/project/ui/wizard/action/actionListener.javx --- @@ -1,41 +1,22 @@ -<#--

Re: Should we use Eclipse Maven Repository too?

I've noticed this in another email: Do note that Eclipse doesn't really use Maven Central but > https://repo.eclipse.org/content/groups/releases/ > Take a look there too. I guess if this repo is the canonical source for those JARs we should use it. We have the hash to make sure it's the

[GitHub] incubator-netbeans pull request #121: [NETBEANS-54] Add l10n.list to Rat exc...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/121 ---

[GitHub] incubator-netbeans issue #122: Netbeans 54 review java.completion

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/122 Merged - I added a commit that fixes the unittests, that were broken by the added license headers. Reason was: In the unittests offsets into the example files were used, and

[GitHub] incubator-netbeans pull request #122: Netbeans 54 review java.completion

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/122 ---

Should we use Eclipse Maven Repository too?

Hi all, Modules "o.eclipse.core.**" contain binaries that are either hard or impossible to find in Maven central. Some times the versions are not exactly equal, and I'm not sure if we should downgrade to a previous version or upgrade to a newest one. We're talking of old binaries (2012/2013

[GitHub] incubator-netbeans pull request #145: [NETBEANS-54] Module Review apisupport...

Github user junichi11 commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/145#discussion_r144712225 --- Diff: apisupport.wizards/src/org/netbeans/modules/apisupport/project/ui/wizard/action/actionListener.javx --- @@ -1,41 +1,22 @@ -<#--