[GitHub] jtulach commented on issue #2: Add Automatic-Module-Name attribute to manifest files

2017-11-10 Thread GitBox
jtulach commented on issue #2: Add Automatic-Module-Name attribute to manifest files URL: https://github.com/apache/incubator-netbeans-html4j/pull/2#issuecomment-343644018 Hello David. You mention JUnit: from there it is just a step to TDD. I believe TDD is a great way to balance ability

Re: Lombok (and perhaps other broken annotation processors) makes Netbeans nuts.

2017-11-10 Thread Emilian Bold
The issue mentions IntelliJ IDEA being also broken so it seems like a general Lombok problem, not something NetBeans specific. Are you using an Ant or a Maven project? Did you disable Compile On Save from the project settings (as I assume this might impact Lombok postprocessing)? --emi

[GitHub] junichi11 commented on issue #264: Check whether line endings are LF with Travis CI

2017-11-10 Thread GitBox
junichi11 commented on issue #264: Check whether line endings are LF with Travis CI URL: https://github.com/apache/incubator-netbeans/pull/264#issuecomment-343635498 @geertjanw Thanks a lot for your review! Jan is working on #269. So I'll fix `.travis.yml` again after Jan's changes

[GitHub] junichi11 commented on issue #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs?

2017-11-10 Thread GitBox
junichi11 commented on issue #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs? URL: https://github.com/apache/incubator-netbeans/pull/269#issuecomment-343635104 > Unfortunately, I don't know how to test the Travis build without having a pull

[GitHub] dschoorl commented on a change in pull request #2: Add Automatic-Module-Name attribute to manifest files

2017-11-10 Thread GitBox
dschoorl commented on a change in pull request #2: Add Automatic-Module-Name attribute to manifest files URL: https://github.com/apache/incubator-netbeans-html4j/pull/2#discussion_r150360512 ## File path: pom.xml ## @@ -327,6 +327,7 @@

[GitHub] jtulach commented on a change in pull request #2: Add Automatic-Module-Name attribute to manifest files

2017-11-10 Thread GitBox
jtulach commented on a change in pull request #2: Add Automatic-Module-Name attribute to manifest files URL: https://github.com/apache/incubator-netbeans-html4j/pull/2#discussion_r150342117 ## File path: pom.xml ## @@ -327,6 +327,7 @@

[GitHub] jlahoda commented on issue #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs?

2017-11-10 Thread GitBox
jlahoda commented on issue #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs? URL: https://github.com/apache/incubator-netbeans/pull/269#issuecomment-343593703 @geertjanw - please don't merge yet, the original failure was intentional, the new

[VOTE] Release Apache NetBeans HTML/Java API version 1.5.1

2017-11-10 Thread Jaroslav Tulach
Dear members of Apache NetBeans community. I've prepared a bugfix release of HTML/Java API. It is available as build #20 at https://builds.apache.org/view/Incubator%20Projects/job/incubator-netbeans-html4j-release/20/ The above URL contains the ZIP file with sources, its MD5 and SHA1 checksum

[GitHub] geertjanw commented on issue #264: Check whether line endings are LF with Travis CI

2017-11-10 Thread GitBox
geertjanw commented on issue #264: Check whether line endings are LF with Travis CI URL: https://github.com/apache/incubator-netbeans/pull/264#issuecomment-343586187 +1 looks good to me. Would be good if someone else reviewed this too.

[GitHub] geertjanw commented on issue #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs?

2017-11-10 Thread GitBox
geertjanw commented on issue #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs? URL: https://github.com/apache/incubator-netbeans/pull/269#issuecomment-343584533 Ironically, the Travis build failed, can I merge this one anyway?

[GitHub] jlahoda opened a new pull request #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs?

2017-11-10 Thread GitBox
jlahoda opened a new pull request #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs? URL: https://github.com/apache/incubator-netbeans/pull/269 ?-and-licenses failures. This is an

Lombok (and perhaps other broken annotation processors) makes Netbeans nuts.

2017-11-10 Thread Victor Williams Stafusa da Silva
I am an user (not a dev) of Lombok, and I'm facing issues with using Lombok in Netbeans. Currently, lombok do not works (at least for me) with Netbeans if using Java 9. It does seem to work when I compile it by using Gradle at the command line. See this:

[GitHub] ebarboni commented on issue #252: NETBEANS-134 wip attempt to get ignore from .gitgnore

2017-11-10 Thread GitBox
ebarboni commented on issue #252: NETBEANS-134 wip attempt to get ignore from .gitgnore URL: https://github.com/apache/incubator-netbeans/pull/252#issuecomment-343466528 connect to NETBEANS-134 This is an automated message

[GitHub] jlahoda commented on issue #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip.

2017-11-10 Thread GitBox
jlahoda commented on issue #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip. URL: https://github.com/apache/incubator-netbeans/pull/267#issuecomment-343462476 Uh, I thought Rat excludes "notices", but apparently is doing so based on filenames

[GitHub] junichi11 commented on issue #248: adding crlf characters for the failing tests in api.templates

2017-11-10 Thread GitBox
junichi11 commented on issue #248: adding crlf characters for the failing tests in api.templates URL: https://github.com/apache/incubator-netbeans/pull/248#issuecomment-343459163 @sarveshkesharwani Great to hear. We can merge your change without problems after you send it.

[GitHub] junichi11 commented on issue #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip.

2017-11-10 Thread GitBox
junichi11 commented on issue #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip. URL: https://github.com/apache/incubator-netbeans/pull/267#issuecomment-343457986 @jlahoda It seems that there is no license header in README-bin.txt and

[GitHub] JaroslavTulach commented on issue #265: [NETBEANS-128] Not adding IDE launchers when building only the platfo?

2017-11-10 Thread GitBox
JaroslavTulach commented on issue #265: [NETBEANS-128] Not adding IDE launchers when building only the platfo? URL: https://github.com/apache/incubator-netbeans/pull/265#issuecomment-343432251 Nicely done. This is an

[GitHub] Chris2011 commented on issue #3: NETBEANS-59 - Document split actions

2017-11-10 Thread GitBox
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-343432026 The shortcut is set here: https://github.com/apache/incubator-netbeans/pull/1/commits/67bdd60109474c543c010d3f818cfb36abb9c0c9#r150193869

[GitHub] JaroslavTulach commented on issue #268: Run verify libs and licenses and rat for platform for pull requests

2017-11-10 Thread GitBox
JaroslavTulach commented on issue #268: Run verify libs and licenses and rat for platform for pull requests URL: https://github.com/apache/incubator-netbeans/pull/268#issuecomment-343430969 Excellent. I believe we shall add more and more tests of the platform once we stabilize them.

[GitHub] Chris2011 commented on a change in pull request #1: Feature/248233 - Shortcuts for document splitting

2017-11-10 Thread GitBox
Chris2011 commented on a change in pull request #1: Feature/248233 - Shortcuts for document splitting URL: https://github.com/apache/incubator-netbeans/pull/1#discussion_r150193869 ## File path:

[GitHub] geertjanw closed pull request #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip.

2017-11-10 Thread GitBox
geertjanw closed pull request #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip. URL: https://github.com/apache/incubator-netbeans/pull/267 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] geertjanw commented on issue #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip.

2017-11-10 Thread GitBox
geertjanw commented on issue #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip. URL: https://github.com/apache/incubator-netbeans/pull/267#issuecomment-343401546 Looks good, merging, will work on the content in the readmes.