[GitHub] nifi pull request: NIFI-1420 Adding Splunk bundle

2016-03-05 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/233#issuecomment-192800737 @JPercivall Pushed up a commit that addresses your comment about Client Auth being required, and I think I also fixed the race condition on the RELP test. If you are good

[GitHub] nifi pull request: Nifi 1516 - AWS DynamoDB Get/Put/Delete Process...

2016-03-05 Thread jvwing
Github user jvwing commented on the pull request: https://github.com/apache/nifi/pull/224#issuecomment-192777256 @mans2singh - Sorry I'm slow getting back to you. I have a few comments about the most recent changes: # Tests * The unit tests are much improved. Your

Re: ExecuteSQL and NiFi 0.5.1 - Error org.apache.avro.SchemaParseException: Empty name

2016-03-05 Thread Matt Burgess
Actually on second thought it's not negative logic, it should be checking against tableNameFromMeta. Sent from my iPhone > On Mar 5, 2016, at 6:57 PM, Bryan Bende wrote: > > I think this a legitimate bug that was introduced in 0.5.0. > > I created this ticket:

Re: ExecuteSQL and NiFi 0.5.1 - Error org.apache.avro.SchemaParseException: Empty name

2016-03-05 Thread Matt Burgess
That's on me, that commit went into 0.5.0 and looks like a negative logic error. I thought I had unit tested it but I guess not :( Sent from my iPhone > On Mar 5, 2016, at 6:57 PM, Bryan Bende wrote: > > I think this a legitimate bug that was introduced in 0.5.0. > > I

Re: ExecuteSQL and NiFi 0.5.1 - Error org.apache.avro.SchemaParseException: Empty name

2016-03-05 Thread Bryan Bende
I think this a legitimate bug that was introduced in 0.5.0. I created this ticket: https://issues.apache.org/jira/browse/NIFI-1596 For those interested, I think the line of code causing the problem is this:

Re: OnStopped annotation

2016-03-05 Thread Oleg Zhurakousky
Piere Congratulations, you’ve hit one of the rarest cases in Java type system especially with this one. Consider buying a lottery ticket ;) The eureka moment was when I executed this code: SetSNMP.class.getMethod("close").getDeclaringClass()); To my surprise the output was: class

Re: OnStopped annotation

2016-03-05 Thread Oleg Zhurakousky
Ok, I do see a problem and no I can’t explain it yet ;) Will figure it tomorrow. Cheers Oleg > On Mar 5, 2016, at 3:04 PM, Pierre Villard > wrote: > > No problem Oleg, I had a lot to do this week as well. > You are correct, this is the issue I have on my side. > >

Re: OnStopped annotation

2016-03-05 Thread Pierre Villard
No problem Oleg, I had a lot to do this week as well. You are correct, this is the issue I have on my side. 2016-03-05 20:46 GMT+01:00 Oleg Zhurakousky : > Pierre > > Sorry, didn’t get a chance earlier. Just checked out your branch and > building to see what’s going

Re: OnStopped annotation

2016-03-05 Thread Oleg Zhurakousky
Pierre Sorry, didn’t get a chance earlier. Just checked out your branch and building to see what’s going on. Just to confirm what I am looking for is @OnStopped is not getting invoked in ‘AbstractSNMPProcessor’ whenever you try to stop the processor. Correct? Cheers Oleg On Mar 5, 2016, at