Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/297#issuecomment-199888509
A very weird error with contrib check I am only getting windows 8, an
unapproved license for:
nifi/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/297#issuecomment-199870316
I am testing on Windows 8.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/284#discussion_r56509790
--- Diff:
nifi-nar-bundles/nifi-kerberos-iaa-providers-bundle/nifi-kerberos-iaa-providers/src/test/resources/nifi.properties
---
@@ -0,0 +1,185
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/284#discussion_r56507643
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/jwt/JwtService.java
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/284#discussion_r56410434
--- Diff:
nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-ui/src/main/java/org/apache/nifi/update/attributes/api/RuleResource.java
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/284#discussion_r56425560
--- Diff:
nifi-nar-bundles/nifi-kerberos-iaa-providers-bundle/nifi-kerberos-iaa-providers/src/main/java/org/apache/nifi/kerberos/KerberosProvider.java
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/284#issuecomment-197944422
+1 (with Gilman's last modifications)
Used Gilman's branch to do a contrib check build, reviewed that comments
were addressed and ran through setting up
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/284#discussion_r56507392
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/jwt/JwtService.java
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/284#issuecomment-197582465
There are multiple "todo" comments. What is the plan for them? It appears
that some are just comments on the code, some can be removed (already done),
and a
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/237#discussion_r56237562
--- Diff:
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/test/java/org/apache/nifi/processors/cassandra
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/237#discussion_r56237303
--- Diff:
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/test/java/org/apache/nifi/processors/cassandra/PutCassandraQLTest.java
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/237#discussion_r56191239
--- Diff:
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/test/java/org/apache/nifi/processors/cassandra/PutCassandraQLTest.java
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/237#discussion_r56187278
--- Diff:
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraQL.java
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/237#discussion_r56178725
--- Diff:
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraQL.java
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/237#discussion_r56175269
--- Diff:
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraQL.java
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-196527092
@mosermw shouldn't you just be able to create a typical SSL controller
service and set the "SSL Context Service" property to point to it? This should
automat
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-195528105
Build is still failing contrib check after the latest patches due to:
[INFO] --- maven-checkstyle-plugin:2.15:check (check-style) @
nifi-jms-cf-service
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-195428868
Why are the docs needed as place holders? It is not a breaking change to
adding additional documentation pages in the future. Details regarding simple
capability
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-195427093
What was the motivation for creating an additional details page for the
Publish/Consume processors that is just a summary and an overview of the
configuration? Both
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-195413029
New commits fail contrib-check for these reasons:
[INFO] --- maven-checkstyle-plugin:2.15:check (check-style) @
nifi-jms-processors ---
[WARNING]
src/main
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/235#issuecomment-195030029
@trkurc what was the result of your review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/227#issuecomment-195028936
@trkurc what was the result of your review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-195006367
Following the pattern for Controller Services and their API in
nifi-standard-services, JMSConnectionFactoryProviderDefinition should be in
it's own package
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-194997331
Reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/233#issuecomment-193459708
Just finished looking over the code and doing a round of tests. Everything
looks good.
+1, Thanks for the contribution Bryan, looks like a very powerful new
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/233#issuecomment-192325813
Should have made this comment on the first commit but can the LogGenerator
be put into a util package on the same path? It makes it more readable to only
have the test
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/233#issuecomment-190970047
Whenever an SSL context is being created (done 4 times in multiple
different classes) "SSLContextService.ClientAuth.REQUIRED" is used. Should we
offer con
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/233#issuecomment-190934511
I observed a couple of interesting interactions when testing the PutSplunk
processor. I'm not sure whether it is a problem with the processor, the Splunk
Java SDK
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/180#discussion_r51482142
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/180#discussion_r51483875
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/180#issuecomment-178198337
There needs to be support added for passing username/password (specifically
for shield integration)
---
If your project is set up for it, you can reply to this email
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/180#discussion_r51490929
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/180#issuecomment-178023848
If the "Identifier Attribute" is being left as the attribute containing the
identifier then the "ATTRIBUTE_KEY_VALIDATOR" sh
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/187#issuecomment-176807151
@rpmiskin
Following the RFC 822 guideline (that the MimeMessage class is based on) it
says this about the "From" header:
4.4.1. FROM / R
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/180#issuecomment-176433804
In the latest commit there is more code coverage but there are still only a
couple tests. Ideally I would like to see tests that work with each of the
configuration
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/183#issuecomment-176540108
When MockProcessSession.rollback(boolean)[1] is called it is, the boolean
is telling the session whether or not the flowfiles should be penalized. In the
event
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/183#issuecomment-176544259
I know this isn't part of the ticket but, there are numerous lines in the
unit tests that say " // getMyFlowFiles();". I believe they're relicts fr
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/187#issuecomment-176558911
There 100% needs to be better unit testing for the PutEmail processor and I
agree that this ticket is outside the scope of that. I've created a new one
here[1
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/183#issuecomment-176533014
I believe flowfiles should be removed from the penalized list when
MockProcessSession.remove() is called:
https://github.com/apache/nifi/blob
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/183#issuecomment-176546233
Did a maven contrib check build and verified the functionality using a test
http server. Once the comments are addressed I can merge in.
---
If your project is set up
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/178#discussion_r50174170
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteSQL.java
---
@@ -164,17
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/178#discussion_r50158533
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteSQL.java
---
@@ -164,17
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/178#discussion_r50213360
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteSQL.java
---
@@ -164,17
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/143#discussion_r47814247
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/test/java/org/apache/nifi/processors/kafka/TestPutKafka.java
---
@@ -474,6 +475,18
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/143#discussion_r47814878
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/test/java/org/apache/nifi/processors/kafka/TestPutKafka.java
---
@@ -474,6 +475,18
301 - 345 of 345 matches
Mail list logo
